Re: [SSSD] [PATCH] add libcmocka in BUILD.txt

2013-04-05 Thread Lukas Slebodnik
On (04/04/13 14:23), Ariel Barria wrote: >Patch for Add libcmocka in the list the dependency to remove warning in the >building sssd. > diff --git a/BUILD.txt b/BUILD.txt index 263129215d6af43869a9d97bbd291436b2cc914d..c5f0cd8dd605d0f5ecef368bd07eefb14831

Re: [SSSD] [PATCH] add libcmocka in BUILD.txt

2013-04-05 Thread Jakub Hrozek
On Fri, Apr 05, 2013 at 09:12:07AM +0200, Lukas Slebodnik wrote: > On (04/04/13 14:23), Ariel Barria wrote: > >Patch for Add libcmocka in the list the dependency to remove warning in the > >building sssd. > > > diff --git a/BUILD.txt b/BUILD.txt > index > 2

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-05 Thread Jakub Hrozek
On Wed, Apr 03, 2013 at 01:26:12PM +0200, Pavel Březina wrote: > >>We can also use it to initialize sdap_id_ctx instead of calling > >>sssm_ipa_id_init from other places. > > Given it more thoughts I don't think we should go this way. I like the > sssm_ipa_init() concept though and we should proba

[SSSD] [PATCH] Check for the correct variables

2013-04-05 Thread Jakub Hrozek
Another Coverity bug.. https://fedorahosted.org/sssd/ticket/1864 >From 5ba13376f1fd79927cd1ac5a5ef6f0bf99802a48 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 4 Apr 2013 20:36:43 +0200 Subject: [PATCH] Check for the correct variables https://fedorahosted.org/sssd/ticket/1864 --- src/pro

Re: [SSSD] [PATCH] Check for the correct variables

2013-04-05 Thread Pavel Březina
On 04/05/2013 12:07 PM, Jakub Hrozek wrote: Another Coverity bug.. https://fedorahosted.org/sssd/ticket/1864 Obvious ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 12:24:05PM -0400, Simo Sorce wrote: > Commit should say it all. > We do not have any security issue (that I know off) with the current > code, but I want to tighten up the privileges more given we do not need > the additional capabilities in the krb5_child anyway. > > Simo.

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Lukas Slebodnik
On (04/04/13 12:24), Simo Sorce wrote: >Commit should say it all. >We do not have any security issue (that I know off) with the current >code, but I want to tighten up the privileges more given we do not need >the additional capabilities in the krb5_child anyway. > >Simo. > >-- >Simo Sorce * Red H

Re: [SSSD] [PATCH] INI: Remove dead code

2013-04-05 Thread Ondrej Kos
On 04/04/2013 11:43 PM, Jakub Hrozek wrote: On Thu, Apr 04, 2013 at 01:11:23PM -0400, Dmitri Pal wrote: On 04/04/2013 06:25 AM, Ondrej Kos wrote: On 04/03/2013 10:39 PM, Dmitri Pal wrote: On 04/03/2013 07:36 AM, Ondrej Kos wrote: Hi, Issue found by coverity, the code itself was inaccessibile

Re: [SSSD] [PATCH] DHASH: Don't use backward jumps

2013-04-05 Thread Lukas Slebodnik
On (02/04/13 17:44), Ondrej Kos wrote: >https://fedorahosted.org/sssd/ticket/1855 > >I couldn't let it this way when I saw the code :) >Patch is attached > >Ondra >-- >Ondrej Kos >Associate Software Engineer >Identity Management >Red Hat Czech > >phone: +420-532-294-558 >cell: +420-736-417-909 >e

Re: [SSSD] [PATCH] DHASH: Don't use backward jumps

2013-04-05 Thread Ondrej Kos
On 04/05/2013 01:52 PM, Lukas Slebodnik wrote: On (02/04/13 17:44), Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1855 I couldn't let it this way when I saw the code :) Patch is attached Ondra -- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech phone: +420-532

Re: [SSSD] [PATCH] DHASH: Don't use backward jumps

2013-04-05 Thread Lukas Slebodnik
On (05/04/13 14:02), Ondrej Kos wrote: >On 04/05/2013 01:52 PM, Lukas Slebodnik wrote: >>On (02/04/13 17:44), Ondrej Kos wrote: >>>https://fedorahosted.org/sssd/ticket/1855 >>> >>>I couldn't let it this way when I saw the code :) >>>Patch is attached >>> >>>Ondra >>>-- >>>Ondrej Kos >>>Associate So

Re: [SSSD] [PATCH] add libcmocka in BUILD.txt

2013-04-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/2013 05:16 AM, Jakub Hrozek wrote: > On Fri, Apr 05, 2013 at 09:12:07AM +0200, Lukas Slebodnik wrote: >> On (04/04/13 14:23), Ariel Barria wrote: >>> Patch for Add libcmocka in the list the dependency to remove >>> warning in the building sss

Re: [SSSD] [PATCH] DHASH: Don't use backward jumps

2013-04-05 Thread Ondrej Kos
On 04/05/2013 02:10 PM, Lukas Slebodnik wrote: On (05/04/13 14:02), Ondrej Kos wrote: On 04/05/2013 01:52 PM, Lukas Slebodnik wrote: On (02/04/13 17:44), Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1855 I couldn't let it this way when I saw the code :) Patch is attached Ondra -- O

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Simo Sorce
On Fri, 2013-04-05 at 12:26 +0200, Lukas Slebodnik wrote: > On (04/04/13 12:24), Simo Sorce wrote: > >Commit should say it all. > >We do not have any security issue (that I know off) with the current > >code, but I want to tighten up the privileges more given we do not need > >the additional capabi

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Lukas Slebodnik
On (05/04/13 08:47), Simo Sorce wrote: >On Fri, 2013-04-05 at 12:26 +0200, Lukas Slebodnik wrote: >> On (04/04/13 12:24), Simo Sorce wrote: >> >Commit should say it all. >> >We do not have any security issue (that I know off) with the current >> >code, but I want to tighten up the privileges more g

Re: [SSSD] SSSD Test Suite Coverage

2013-04-05 Thread Abhishek Singh
Hi Jakub, I have made necessary changes, please review it. thanks, On Fri, Apr 5, 2013 at 4:09 AM, Jakub Hrozek wrote: > On Thu, Apr 04, 2013 at 02:44:47AM +0530, Abhishek Singh wrote: > > Hi Jakub, > > > > I have done requested changes and have attached the patch with this mail. > > Kindly r

Re: [SSSD] [PATCH] add libcmocka in BUILD.txt

2013-04-05 Thread Jakub Hrozek
On Fri, Apr 05, 2013 at 08:13:53AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/05/2013 05:16 AM, Jakub Hrozek wrote: > > On Fri, Apr 05, 2013 at 09:12:07AM +0200, Lukas Slebodnik wrote: > >> On (04/04/13 14:23), Ariel Barria wrote: > >>> Patch for Ad

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Simo Sorce
On Fri, 2013-04-05 at 15:02 +0200, Lukas Slebodnik wrote: > On (05/04/13 08:47), Simo Sorce wrote: > >On Fri, 2013-04-05 at 12:26 +0200, Lukas Slebodnik wrote: > >> On (04/04/13 12:24), Simo Sorce wrote: > >> >Commit should say it all. > >> >We do not have any security issue (that I know off) with

Re: [SSSD] [PATCH] add libcmocka in BUILD.txt

2013-04-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/2013 09:10 AM, Jakub Hrozek wrote: > On Fri, Apr 05, 2013 at 08:13:53AM -0400, Stephen Gallagher wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 04/05/2013 05:16 AM, Jakub Hrozek wrote: >>> On Fri, Apr 05, 2013 at 09:12:07AM

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Lukas Slebodnik
On (05/04/13 09:27), Simo Sorce wrote: >On Fri, 2013-04-05 at 15:02 +0200, Lukas Slebodnik wrote: >> On (05/04/13 08:47), Simo Sorce wrote: >> >On Fri, 2013-04-05 at 12:26 +0200, Lukas Slebodnik wrote: >> >> On (04/04/13 12:24), Simo Sorce wrote: >> >> >Commit should say it all. >> >> >We do not ha

[SSSD] [PATCH] Allocate PAM DP request data on responder context

2013-04-05 Thread Jakub Hrozek
https://fedorahosted.org/sssd/ticket/1869 Currently the private data passed to the PAM request is a structure allocated on the client context. But in the odd case where the back end would be stopped or stuck until the idle timeout hits, the DP callback. This patch introduces a new structure alloc

Re: [SSSD] [PATCH] Thighten up become_user()

2013-04-05 Thread Jakub Hrozek
On Fri, Apr 05, 2013 at 04:19:11PM +0200, Lukas Slebodnik wrote: > On (05/04/13 09:27), Simo Sorce wrote: > >On Fri, 2013-04-05 at 15:02 +0200, Lukas Slebodnik wrote: > >> On (05/04/13 08:47), Simo Sorce wrote: > >> >On Fri, 2013-04-05 at 12:26 +0200, Lukas Slebodnik wrote: > >> >> On (04/04/13 12:

Re: [SSSD] [PATCH] Check for the correct variables

2013-04-05 Thread Jakub Hrozek
On Fri, Apr 05, 2013 at 12:11:12PM +0200, Pavel Březina wrote: > On 04/05/2013 12:07 PM, Jakub Hrozek wrote: > >Another Coverity bug.. > > > >https://fedorahosted.org/sssd/ticket/1864 > > Obvious ack. Pushed to master. ___ sssd-devel mailing list sssd-d

Re: [SSSD] [PATCH 1/2] Check for waitpid failure at wrong place.

2013-04-05 Thread Jakub Hrozek
On Wed, Apr 03, 2013 at 06:12:13PM +0200, Michal Židek wrote: > On 04/03/2013 05:58 PM, Michal Židek wrote: > >The first patch fixes coverity bugs mentioned in ticked > >https://fedorahosted.org/sssd/ticket/1865 > > > >The second fixes wrong condition after waitpid. > > > >Michal > > > > I forgot

Re: [SSSD] [PATCH 1/2] Check for waitpid failure at wrong place.

2013-04-05 Thread Jakub Hrozek
On Fri, Apr 05, 2013 at 05:22:13PM +0200, Jakub Hrozek wrote: > On Wed, Apr 03, 2013 at 06:12:13PM +0200, Michal Židek wrote: > > On 04/03/2013 05:58 PM, Michal Židek wrote: > > >The first patch fixes coverity bugs mentioned in ticked > > >https://fedorahosted.org/sssd/ticket/1865 > > > > > >The se

[SSSD] [PATCH] LDAP: Always fail if a map can't be found

2013-04-05 Thread Jakub Hrozek
Hopefully this is the last real issue that Coverity discovered. >From 4ec51e8f8ccfee414a8ce01a093ca929c0835ea2 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 5 Apr 2013 15:14:34 +0200 Subject: [PATCH] LDAP: Always fail if a map can't be found --- src/providers/ldap/sdap.c | 5 + 1 fi

[SSSD] [PATCH] libiniconfig_devel must require libref_array-devel and libbasicobjects-devel

2013-04-05 Thread Jakub Hrozek
See attached patch. It was possible to install libiniconfig_devel and not have all the proper headers in place. >From 30d760b2888e3d2a55390b1691bbab4ff2d39cf0 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 5 Apr 2013 17:50:37 +0200 Subject: [PATCH] libiniconfig_devel must require libref_ar

Re: [SSSD] [PATCH] libiniconfig_devel must require libref_array-devel and libbasicobjects-devel

2013-04-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri 05 Apr 2013 11:52:50 AM EDT, Jakub Hrozek wrote: > See attached patch. It was possible to install libiniconfig_devel > and not have all the proper headers in place. > Ack -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.13 (GNU/Linux) Comment

Re: [SSSD] [PATCH] libiniconfig_devel must require libref_array-devel and libbasicobjects-devel

2013-04-05 Thread Jakub Hrozek
On Fri, Apr 05, 2013 at 12:03:47PM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Fri 05 Apr 2013 11:52:50 AM EDT, Jakub Hrozek wrote: > > See attached patch. It was possible to install libiniconfig_devel > > and not have all the proper headers in place. >

Re: [SSSD] [PATCH] LDAP: Always fail if a map can't be found

2013-04-05 Thread Lukas Slebodnik
On (05/04/13 17:39), Jakub Hrozek wrote: >Hopefully this is the last real issue that Coverity discovered. >From 4ec51e8f8ccfee414a8ce01a093ca929c0835ea2 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Fri, 5 Apr 2013 15:14:34 +0200 >Subject: [PATCH] LDAP: Always fail if a map can't be found >