Re: [SSSD] [PATCH] Fix krbcc dir creation issue with MIT krb5 1.11

2013-04-12 Thread Lukas Slebodnik
On (12/04/13 18:06), Jakub Hrozek wrote: >On Fri, Apr 12, 2013 at 05:31:33PM +0200, Jakub Hrozek wrote: >> On Thu, Apr 11, 2013 at 12:06:22PM +0200, Lukas Slebodnik wrote: >> > On (11/04/13 10:29), Jakub Hrozek wrote: >> > >On Thu, Apr 11, 2013 at 10:28:01AM +0200, Jakub Hrozek wrote: >> > >> Just

Re: [SSSD] [PATCH] Fix segmentation fault in test_io.

2013-04-12 Thread Abhishek Singh
Please check this patch, previous patch contained extra changes which is not required. On Sat, Apr 13, 2013 at 2:30 AM, Abhishek Singh < abhishekkumarsingh@gmail.com> wrote: > Required changes done. Please check the patch. > > > > On Fri, Apr 12, 2013 at 9:28 PM, Jakub Hrozek wrote: > >> On

Re: [SSSD] [PATCH] Fix segmentation fault in test_io.

2013-04-12 Thread Abhishek Singh
Required changes done. Please check the patch. On Fri, Apr 12, 2013 at 9:28 PM, Jakub Hrozek wrote: > On Thu, Apr 11, 2013 at 01:47:03PM +0200, Lukas Slebodnik wrote: > > On (11/04/13 11:18), Jakub Hrozek wrote: > > >On Thu, Apr 11, 2013 at 11:04:06AM +0200, Lukas Slebodnik wrote: > > >> I wan

[SSSD] [PATCH] sss_cache: Remove annoying messages

2013-04-12 Thread Michal Židek
See patch description. This patch applies on top of the "sss_cache: support for subdomains" patch. Thanks Michal >From 02359f1e33420059ba2d29e038a558fd0734b76b Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Fri, 12 Apr 2013 18:58:39 -0400 Subject: [PATCH] sss_cache: Remove annoying messages

Re: [SSSD] [PATCH] sss_cache: support for subdomains

2013-04-12 Thread Michal Židek
On 04/12/2013 04:57 PM, Jakub Hrozek wrote: On Thu, Apr 11, 2013 at 11:35:52AM +0200, Michal Židek wrote: New patch attached. Thanks Michal +if (IS_SUBDOMAIN(dinfo)) { +name_lower = sss_tc_utf8_str_tolower(tmp_ctx, parsed_name); +domain_lower = sss_tc_utf8_str_t

Re: [SSSD] Tool for querying SSSD database

2013-04-12 Thread Jakub Hrozek
On Fri, Apr 12, 2013 at 06:42:03PM +0200, Lukas Slebodnik wrote: > On (12/04/13 01:31), David Bambušek wrote: > >Since I was really working with two months old version of SSSD, I made > >completely new mirror of the newest SSSD on my github account and made some > >changes in code of my sss_query,

Re: [SSSD] [PATCH] sssd fails with readonly SELinux login files

2013-04-12 Thread Jakub Hrozek
On Fri, Apr 12, 2013 at 07:26:39PM +0200, Jakub Hrozek wrote: > On Thu, Apr 11, 2013 at 05:00:23PM +0200, Michal Židek wrote: > > On 04/11/2013 02:33 PM, Michal Židek wrote: > > >This patch is for 1.9 only. > > > > > >https://fedorahosted.org/sssd/ticket/1868 > > > > > >Thanks > > >Michal > > > > >

Re: [SSSD] [PATCH] sssd fails with readonly SELinux login files

2013-04-12 Thread Jakub Hrozek
On Thu, Apr 11, 2013 at 05:00:23PM +0200, Michal Židek wrote: > On 04/11/2013 02:33 PM, Michal Židek wrote: > >This patch is for 1.9 only. > > > >https://fedorahosted.org/sssd/ticket/1868 > > > >Thanks > >Michal > > > > New version attached. It is better to assume that the SELinux is not > availab

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2013-04-12 Thread Jakub Hrozek
On Fri, Apr 12, 2013 at 04:59:28PM +0200, Jakub Hrozek wrote: > On Tue, Apr 09, 2013 at 11:50:35AM -0500, Ariel Barria wrote: > > > > > Hi Ariel, > > > > > > you don't have to duplicate the case statements in a switch statement if > > > both should yield the same result. Instead of: > > > > > >

Re: [SSSD] Tool for querying SSSD database

2013-04-12 Thread Lukas Slebodnik
On (12/04/13 01:31), David Bambušek wrote: >Since I was really working with two months old version of SSSD, I made >completely new mirror of the newest SSSD on my github account and made some >changes in code of my sss_query, so it is compatible with it now. There >should be no problem with compili

Re: [SSSD] [PATCH] Fix krbcc dir creation issue with MIT krb5 1.11

2013-04-12 Thread Jakub Hrozek
On Fri, Apr 12, 2013 at 05:31:33PM +0200, Jakub Hrozek wrote: > On Thu, Apr 11, 2013 at 12:06:22PM +0200, Lukas Slebodnik wrote: > > On (11/04/13 10:29), Jakub Hrozek wrote: > > >On Thu, Apr 11, 2013 at 10:28:01AM +0200, Jakub Hrozek wrote: > > >> Just one nitpick, can you change this block: > > >>

Re: [SSSD] [PATCH] Fix segmentation fault in test_io.

2013-04-12 Thread Jakub Hrozek
On Thu, Apr 11, 2013 at 01:47:03PM +0200, Lukas Slebodnik wrote: > On (11/04/13 11:18), Jakub Hrozek wrote: > >On Thu, Apr 11, 2013 at 11:04:06AM +0200, Lukas Slebodnik wrote: > >> I wanted to revie som patches, but test failed with unrelated issue to > >> revieved > >> patch. > >> > > > >The test

Re: [SSSD] [PATCH] Removing BUILD.txt content

2013-04-12 Thread Ariel Barria
done. Thank you for comments. > Date: Fri, 12 Apr 2013 16:53:02 +0200 > From: jhro...@redhat.com > To: sssd-devel@lists.fedorahosted.org > Subject: Re: [SSSD] [PATCH] Removing BUILD.txt content > > On Tue, Apr 09, 2013 at 11:15:49AM -0500, Ariel Barria wrote: > > Patch for remove BUILD.txt conten

Re: [SSSD] [PATCH] Fix krbcc dir creation issue with MIT krb5 1.11

2013-04-12 Thread Jakub Hrozek
On Thu, Apr 11, 2013 at 12:06:22PM +0200, Lukas Slebodnik wrote: > On (11/04/13 10:29), Jakub Hrozek wrote: > >On Thu, Apr 11, 2013 at 10:28:01AM +0200, Jakub Hrozek wrote: > >> Just one nitpick, can you change this block: > >> > >> +primary_file = talloc_strdup_append(discard_const_p(char, di

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2013-04-12 Thread Jakub Hrozek
On Tue, Apr 09, 2013 at 11:50:35AM -0500, Ariel Barria wrote: > > > Hi Ariel, > > > > you don't have to duplicate the case statements in a switch statement if > > both should yield the same result. Instead of: > > > > +case EPERM: > > +DEBUG(SSSDBG_CRIT_FAILURE, > > +

Re: [SSSD] [PATCH] sss_cache: support for subdomains

2013-04-12 Thread Jakub Hrozek
On Thu, Apr 11, 2013 at 11:35:52AM +0200, Michal Židek wrote: > New patch attached. > > Thanks > Michal > > +if (IS_SUBDOMAIN(dinfo)) { > +name_lower = sss_tc_utf8_str_tolower(tmp_ctx, parsed_name); > +domain_lower = sss_tc_utf8_str_tolower(tmp_ctx, parsed_domain);

Re: [SSSD] [PATCH] Removing BUILD.txt content

2013-04-12 Thread Jakub Hrozek
On Tue, Apr 09, 2013 at 11:15:49AM -0500, Ariel Barria wrote: > Patch for remove BUILD.txt content. > Thank you, but I think the sentence should be reworded slightly. Instead of "In the following link" I think "On the following page" sounds better. Also we

[SSSD] [PATCH] Do not change attr pointer with realloc

2013-04-12 Thread Jakub Hrozek
https://fedorahosted.org/sssd/ticket/1799 One peculiarity of the sysdb_attrs_get_el interface is that if the attribute does not exist, then the attrs array is reallocated and the element is created. But in case other pointers are already pointing into the array, the realloc might invalidate them.