Re: [SSSD] [PATCH] Fix segmentation fault in test_io.

2013-04-22 Thread Jakub Hrozek
On Tue, Apr 16, 2013 at 07:27:20PM +0530, Abhishek Singh wrote: > Changes done. Please check the patch. > > thanks, > Hi Abishek let's do one last change before I push the patch -- test the strdup output for being non-NULL and then free the duplicate when it's not needed: basec = strdup(ge

Re: [SSSD] [PATCH] tests: Link the simple access tests with -ldl

2013-04-22 Thread Lukas Slebodnik
On (19/04/13 21:24), Lukas Slebodnik wrote: >On (19/04/13 11:30), Jakub Hrozek wrote: >>Timo Aaltonen discovered that on Ubuntu the simple access tests fail >>with a linker error saying that dlopen and dlsym are not available. It >>seems that because we are linking to some files from >>src/provider

Re: [SSSD] [PATCH] New dynamic DNS update options

2013-04-22 Thread Pavel Březina
On 04/17/2013 09:03 PM, Jakub Hrozek wrote: [PATCH 1/5] dyndns: new option dyndns_refresh_interval This new options adds the possibility of updating the DNS entries periodically regardless if they have changed or not. This feature will be useful mainly in AD environments where the Windows clients

[SSSD] [PATCH] sudo client: remove dead code

2013-04-22 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/1889 From 659b7f178ed49a8a37a7917d561107c9bfc6b88c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 22 Apr 2013 11:04:39 +0200 Subject: [PATCH] sudo client: remove dead code https://fedorahosted.org/sssd/ticket/1889 Fixes two minor

Re: [SSSD] [PATCH] sudo client: remove dead code

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 11:11:44AM +0200, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1889 Ack ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] tests: Link the simple access tests with -ldl

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 09:35:10AM +0200, Lukas Slebodnik wrote: > On (19/04/13 21:24), Lukas Slebodnik wrote: > >On (19/04/13 11:30), Jakub Hrozek wrote: > >>Timo Aaltonen discovered that on Ubuntu the simple access tests fail > >>with a linker error saying that dlopen and dlsym are not available.

Re: [SSSD] [PATCH] Do not keep growing event context

2013-04-22 Thread Jakub Hrozek
On Fri, Apr 19, 2013 at 02:14:21PM -0400, Simo Sorce wrote: > > > > > /* Stop monitoring for this child */ > > > > > talloc_free(child_ctx); > > > > > +talloc_free(imm); > > > > > } > > > > > > > > Why not simply make the imm context a child of the child_ctx it is freed > > > > just

[SSSD] [PATCH] Display the last grace warning, too

2013-04-22 Thread Jakub Hrozek
The attached patch fixes displaying of the last grace password warning, iow when grace == 0. I checked that this is what pam_ldap does, too. The patch has been tested by a GSS engineer. >From 9173922c8c4291b93533bddfe9487084b968db2e Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 22 Apr 20

Re: [SSSD] [PATCH] Display the last grace warning, too

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 12:33:11PM +0200, Jakub Hrozek wrote: > The attached patch fixes displaying of the last grace password warning, > iow when grace == 0. I checked that this is what pam_ldap does, too. > > The patch has been tested by a GSS engineer. Sorry, I managed to send a patch that onl

Re: [SSSD] [PATCH] New dynamic DNS update options

2013-04-22 Thread steve
On 22/04/13 10:38, Pavel Březina wrote: On 04/17/2013 09:03 PM, Jakub Hrozek wrote: [PATCH 1/5] dyndns: new option dyndns_refresh_interval This new options adds the possibility of updating the DNS entries periodically regardless if they have changed or not. This feature will be useful mainly in

Re: [SSSD] [PATCH] New dynamic DNS update options

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 01:10:45PM +0200, steve wrote: > On 22/04/13 10:38, Pavel Březina wrote: > >On 04/17/2013 09:03 PM, Jakub Hrozek wrote: > >>[PATCH 1/5] dyndns: new option dyndns_refresh_interval > >>This new options adds the possibility of updating the DNS entries > >>periodically regardles

Re: [SSSD] [PATCH] tests: Link the simple access tests with -ldl

2013-04-22 Thread Lukas Slebodnik
On (22/04/13 12:17), Jakub Hrozek wrote: >On Mon, Apr 22, 2013 at 09:35:10AM +0200, Lukas Slebodnik wrote: >> On (19/04/13 21:24), Lukas Slebodnik wrote: >> >On (19/04/13 11:30), Jakub Hrozek wrote: >> >>Timo Aaltonen discovered that on Ubuntu the simple access tests fail >> >>with a linker error s

Re: [SSSD] [PATCH] Fix segmentation fault in test_io.

2013-04-22 Thread Abhishek Singh
changes done. Please check the patch. On Mon, Apr 22, 2013 at 12:55 PM, Jakub Hrozek wrote: > On Tue, Apr 16, 2013 at 07:27:20PM +0530, Abhishek Singh wrote: > > Changes done. Please check the patch. > > > > thanks, > > > > Hi Abishek > > let's do one last change before I push the patch -- test

Re: [SSSD] [PATCH] New dynamic DNS update options

2013-04-22 Thread steve
On 22/04/13 13:19, Jakub Hrozek wrote: On Mon, Apr 22, 2013 at 01:10:45PM +0200, steve wrote: On 22/04/13 10:38, Pavel Březina wrote: On 04/17/2013 09:03 PM, Jakub Hrozek wrote: [PATCH 1/5] dyndns: new option dyndns_refresh_interval This new options adds the possibility of updating the DNS ent

Re: [SSSD] [PATCH] New dynamic DNS update options

2013-04-22 Thread Pavel Březina
On 04/17/2013 09:03 PM, Jakub Hrozek wrote: Hi, the attached patches implement a couple of new dynamic DNS options. The AD dyndns code will be just a wrapper around these options. [PATCH 1/5] dyndns: new option dyndns_refresh_interval This new options adds the possibility of updating the DNS en

Re: [SSSD] [PATCH] New dynamic DNS update options

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 02:01:08PM +0200, steve wrote: > On 22/04/13 13:19, Jakub Hrozek wrote: > >On Mon, Apr 22, 2013 at 01:10:45PM +0200, steve wrote: > >>On 22/04/13 10:38, Pavel Březina wrote: > >>>On 04/17/2013 09:03 PM, Jakub Hrozek wrote: > [PATCH 1/5] dyndns: new option dyndns_refresh_

Re: [SSSD] [PATCH] Active Directory dynamic DNS updates

2013-04-22 Thread Pavel Březina
On 04/17/2013 09:04 PM, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1504 Implements dynamic DNS updates for the AD provider. By default, the updates also update the reverse zone and run periodically every 24 hours. Hi, I will do more thorough review in next days, but there are two

Re: [SSSD] [PATCH] Active Directory dynamic DNS updates

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 02:20:59PM +0200, Pavel Březina wrote: > On 04/17/2013 09:04 PM, Jakub Hrozek wrote: > >https://fedorahosted.org/sssd/ticket/1504 > > > >Implements dynamic DNS updates for the AD provider. By default, the > >updates also update the reverse zone and run periodically every 24

Re: [SSSD] [PATCH] Allow usage of enterprise principals

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 15, 2013 at 09:05:47AM +0200, Sumit Bose wrote: > On Thu, Apr 11, 2013 at 09:32:53AM -0400, Simo Sorce wrote: > > On Thu, 2013-04-11 at 12:46 +0200, Sumit Bose wrote: > > > Hi, > > > > > > this patch fixes https://fedorahosted.org/sssd/ticket/1842 . The actual > > > functionality is ad

Re: [SSSD] [PATCH] tests: Link the simple access tests with -ldl

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 01:36:46PM +0200, Lukas Slebodnik wrote: > On (22/04/13 12:17), Jakub Hrozek wrote: > >On Mon, Apr 22, 2013 at 09:35:10AM +0200, Lukas Slebodnik wrote: > >> On (19/04/13 21:24), Lukas Slebodnik wrote: > >> >On (19/04/13 11:30), Jakub Hrozek wrote: > >> >>Timo Aaltonen discov

Re: [SSSD] [PATCH] Allow usage of enterprise principals

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 03:33:05PM +0200, Jakub Hrozek wrote: > On Mon, Apr 15, 2013 at 09:05:47AM +0200, Sumit Bose wrote: > > On Thu, Apr 11, 2013 at 09:32:53AM -0400, Simo Sorce wrote: > > > On Thu, 2013-04-11 at 12:46 +0200, Sumit Bose wrote: > > > > Hi, > > > > > > > > this patch fixes https:

Re: [SSSD] [PATCH] Use UPN from Kerberos ticket

2013-04-22 Thread Jakub Hrozek
On Mon, Mar 25, 2013 at 10:46:06AM -0400, Simo Sorce wrote: > On Fri, 2013-03-22 at 15:37 +0100, Sumit Bose wrote: > > Hi, > > > > this patch should fix https://fedorahosted.org/sssd/ticket/1634 and > > eliminates the need to guess the UPN in the PAC responder. > > Nack, > sorry I think that if w

Re: [SSSD] [PATCH] tests: Link the simple access tests with -ldl

2013-04-22 Thread Jakub Hrozek
On Mon, Apr 22, 2013 at 03:35:21PM +0200, Jakub Hrozek wrote: > > >Thank you, this is a really nice explanation. I used it to amend the > > >commit message. A new patch is attached. > > > > Ack > > Pushed to master. Also pushed to sssd-1-9 ___ sssd-dev

Re: [SSSD] Group name lost randomly

2013-04-22 Thread Qing Chang
just for the record. This is considered solved. When migrated from OpenLDAP to IPA, inactive user accounts were left out, but some of the accounts were still in place as secondary group members of a certain group (mri as example). Nonexistent "member" in "cn=groups,cn=accounts" causes the lookup

Re: [SSSD] [PATCH] DB: Switch to new libini_config API

2013-04-22 Thread Ondrej Kos
On 04/19/2013 09:00 PM, Jakub Hrozek wrote: On Fri, Apr 19, 2013 at 04:05:49PM +0200, Ondrej Kos wrote: I know that the transaction logic in this function predates this patch, but I think we should fix it when we are changing the code anyway. Can you take a look at how we use the "in_transacti

Re: [SSSD] Group name lost randomly

2013-04-22 Thread Dmitri Pal
On 04/22/2013 09:59 AM, Qing Chang wrote: > just for the record. This is considered solved. > > When migrated from OpenLDAP to IPA, inactive user accounts were left > out, but > some of the accounts were still in place as secondary group members of > a certain > group (mri as example). Nonexistent

Re: [SSSD] [PATCH] DB: Switch to new libini_config API

2013-04-22 Thread Dmitri Pal
On 04/22/2013 10:09 AM, Ondrej Kos wrote: >> >>> if (ret <= 0 || ret >= 21) { >> >> you can use sizeof(timestr) here in the odd case timestr actually >> changed. > > quoting the reference: > Return Value > The number of characters that would have been written if n had been > sufficiently larg