[SSSD] [PATCH] IPA: Deprecate ipa_hbac_support_srchost option

2013-09-10 Thread Ondrej Kos
Hi, Attached patch resolves issue https://fedorahosted.org/sssd/ticket/1918 This option got already deprecated on the ipa server side. Option is undocumented and warning is printed both to the sssd log files and syslog. Ondra -- Ondrej Kos Associate Software Engineer Identity Management - SSSD

[SSSD] [PATCH] MAN: Remove IPA specific LDAP settings

2013-09-10 Thread Ondrej Kos
Hi, Attached patch resolves the issue https://fedorahosted.org/sssd/ticket/1187 Ondra -- Ondrej Kos Associate Software Engineer Identity Management - SSSD Red Hat Czech From 1fa68c56587947116f7105aff5b27d55b20986d6 Mon Sep 17 00:00:00 2001 From: Ondrej Kos Date: Mon, 9 Sep 2013 16:03:23 +0200 S

[SSSD] [PATCH] AUTOMAKE: Don't build libsss_test_common every time

2013-09-10 Thread Lukas Slebodnik
ehlo, Although static library libsss_test_common was used only in tests, It was also built with command "make all". Simple patch is attached. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listin

Re: [SSSD] [PATCH] AUTOMAKE: Don't build libsss_test_common every time

2013-09-10 Thread Lukas Slebodnik
On (10/09/13 09:48), Lukas Slebodnik wrote: >ehlo, > >Although static library libsss_test_common was used only in tests, >It was also built with command "make all". > >Simple patch is attached. My hands was fast and now with patch > >LS >___ >sssd-devel m

Re: [SSSD] [PATCH] AUTOMAKE: Don't build libsss_test_common every time

2013-09-10 Thread Lukas Slebodnik
On (10/09/13 09:50), Lukas Slebodnik wrote: >On (10/09/13 09:48), Lukas Slebodnik wrote: >>ehlo, >> >>Although static library libsss_test_common was used only in tests, >>It was also built with command "make all". >> >>Simple patch is attached. >My hands was fast and now with patch >> >>LS >>__

[SSSD] [PATCH] krb5: Fix warning sometimes uninitialized

2013-09-10 Thread Lukas Slebodnik
ehlo, clang found a warning in simo's krb5 refactoring patches. src/providers/krb5/krb5_utils.c:850:9: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (kerr) { ^~~~ src/providers/krb5/krb5_utils.c:859:12: note: unini

Re: [SSSD] [PATCH] krb5: Fix warning sometimes uninitialized

2013-09-10 Thread Sumit Bose
On Tue, Sep 10, 2013 at 10:13:10AM +0200, Lukas Slebodnik wrote: > ehlo, > > clang found a warning in simo's krb5 refactoring patches. > > src/providers/krb5/krb5_utils.c:850:9: warning: variable 'ret' is used > uninitialized whenever > 'if' condition is false [-Wsometimes-uninitialized] >

Re: [SSSD] [PATCH] krb5: Fix warning sometimes uninitialized

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 10:37:47AM +0200, Sumit Bose wrote: > On Tue, Sep 10, 2013 at 10:13:10AM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > clang found a warning in simo's krb5 refactoring patches. > > > > src/providers/krb5/krb5_utils.c:850:9: warning: variable 'ret' is used > > uninitiali

[SSSD] Releasing 1.10.2 and branching off 1.12

2013-09-10 Thread Jakub Hrozek
Hi, currently we have quite a few unreleased patches in the sssd-1-10 branch. At the same time, most distributions that I know of (Fedora 19, 20, rawhide, Ubuntu) have moved to 1.11 which is already mostly receiving bugfixes now. In addition, the first 1.12 patches have landed on the list today.

Re: [SSSD] mmap_cache problem

2013-09-10 Thread Lukas Slebodnik
On (09/09/13 09:22), Simo Sorce wrote: >On Mon, 2013-09-09 at 13:37 +0200, Lukas Slebodnik wrote: >> On (07/09/13 13:43), Simo Sorce wrote: >> >On Fri, 2013-09-06 at 18:55 -0400, Simo Sorce wrote: >> >> On Fri, 2013-09-06 at 19:45 +0200, Lukas Slebodnik wrote: >> >> > On (06/09/13 12:48), Simo Sorc

Re: [SSSD] [PATCH] krb5: Fix warning sometimes uninitialized

2013-09-10 Thread Lukas Slebodnik
On (10/09/13 10:37), Sumit Bose wrote: >On Tue, Sep 10, 2013 at 10:13:10AM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> clang found a warning in simo's krb5 refactoring patches. >> >> src/providers/krb5/krb5_utils.c:850:9: warning: variable 'ret' is used >> uninitialized whenever >> 'if' c

Re: [SSSD] [PATCH] DB: Add user/group lookup by SID

2013-09-10 Thread Jakub Hrozek
On Mon, Sep 09, 2013 at 06:12:48PM +0200, Jakub Hrozek wrote: > On Mon, Sep 09, 2013 at 06:04:06PM +0200, Ondrej Kos wrote: > > On 09/09/2013 05:51 PM, Jakub Hrozek wrote: > > >On Mon, Sep 09, 2013 at 02:55:57PM +0200, Ondrej Kos wrote: > > >>On 09/06/2013 02:12 PM, Jakub Hrozek wrote: > > >>>On We

Re: [SSSD] [PATCH] sysdb_search_group_by_gid: obtain gid instead of uid

2013-09-10 Thread Jakub Hrozek
On Mon, Sep 09, 2013 at 06:12:19PM +0200, Jakub Hrozek wrote: > On Fri, Sep 06, 2013 at 01:05:05PM +0200, Pavel Březina wrote: > > This looks like copy and paste error to me. > > > > We could probably skip this attribute, but I'd like to keep the > > returned elements same as in sysdb_search_group

[SSSD] [PATCH] is_dn(): free dn

2013-09-10 Thread Pavel Březina
man ldap_str2dn says: Space for dn will be obtained dynamically and should be freed by the caller using ldap_dnfree(3). From 366ccec67415ea9b1f378b176bc52d353ef447ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 10 Sep 2013 14:09:08 +0200 Subject: [PATCH] is_dn(): fr

Re: [SSSD] mmap_cache problem

2013-09-10 Thread Simo Sorce
On Tue, 2013-09-10 at 12:24 +0200, Lukas Slebodnik wrote: > On (09/09/13 09:22), Simo Sorce wrote: > >On Mon, 2013-09-09 at 13:37 +0200, Lukas Slebodnik wrote: > >> On (07/09/13 13:43), Simo Sorce wrote: > >> >On Fri, 2013-09-06 at 18:55 -0400, Simo Sorce wrote: > >> >> On Fri, 2013-09-06 at 19:45

Re: [SSSD] mmap_cache problem

2013-09-10 Thread Lukas Slebodnik
On (10/09/13 09:18), Simo Sorce wrote: >On Tue, 2013-09-10 at 12:24 +0200, Lukas Slebodnik wrote: >> On (09/09/13 09:22), Simo Sorce wrote: >> >On Mon, 2013-09-09 at 13:37 +0200, Lukas Slebodnik wrote: >> >> On (07/09/13 13:43), Simo Sorce wrote: >> >> >On Fri, 2013-09-06 at 18:55 -0400, Simo Sorce

Re: [SSSD] [PATCHES] simple access provider: support subdomain users and groups

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 03, 2013 at 12:42:21PM +0200, Pavel Březina wrote: > Patch 0001: > I haven't used this one after all, but I still think it is nice to > have. It reduces amount of code duplication. > > Patch 0005: > >+/* Try to get group SID and assign it a domain */ > >+group_sid = ldb_msg_fin

Re: [SSSD] [PATCH] is_dn(): free dn

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 02:10:41PM +0200, Pavel Březina wrote: > man ldap_str2dn says: > Space for dn will be obtained dynamically and should be freed by the > caller using ldap_dnfree(3). ACK ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] krb5: Fix warning sometimes uninitialized

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 12:29:22PM +0200, Lukas Slebodnik wrote: > On (10/09/13 10:37), Sumit Bose wrote: > >On Tue, Sep 10, 2013 at 10:13:10AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> clang found a warning in simo's krb5 refactoring patches. > >> > >> src/providers/krb5/krb5_utils.c:85

Re: [SSSD] Releasing 1.10.2 and branching off 1.12

2013-09-10 Thread Simo Sorce
On Tue, 2013-09-10 at 11:05 +0200, Jakub Hrozek wrote: > Hi, > > currently we have quite a few unreleased patches in the sssd-1-10 branch. At > the same time, most distributions that I know of (Fedora 19, 20, rawhide, > Ubuntu) have moved to 1.11 which is already mostly receiving bugfixes > now. I

Re: [SSSD] [PATCH] MAN: Remove IPA specific LDAP settings

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 09:47:17AM +0200, Ondrej Kos wrote: > Hi, > > Attached patch resolves the issue https://fedorahosted.org/sssd/ticket/1187 I think the man page looks good now. I would like to ACK and push the patch as-is, but I'd like to have kind of a last call if any other developer woul

Re: [SSSD] [PATCHES] Enable printf format string checking

2013-09-10 Thread Jakub Hrozek
On Wed, Sep 04, 2013 at 06:34:52PM +0200, Lukas Slebodnik wrote: > On (03/09/13 00:25), Jakub Hrozek wrote: > >On Wed, Aug 21, 2013 at 03:35:11PM +0200, Lukas Slebodnik wrote: > >> On (21/08/13 13:46), Jakub Hrozek wrote: > >> >Sorry it took so long before we got to another review of the patch. The

Re: [SSSD] [PATCH] IPA: Deprecate ipa_hbac_support_srchost option

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 09:48:02AM +0200, Ondrej Kos wrote: > Hi, > > Attached patch resolves issue https://fedorahosted.org/sssd/ticket/1918 > > This option got already deprecated on the ipa server side. > Option is undocumented and warning is printed both to the sssd log files > and syslog. >

Re: [SSSD] mmap_cache problem

2013-09-10 Thread Michal Židek
On 09/10/2013 03:43 PM, Lukas Slebodnik wrote: On (10/09/13 09:18), Simo Sorce wrote: On Tue, 2013-09-10 at 12:24 +0200, Lukas Slebodnik wrote: On (09/09/13 09:22), Simo Sorce wrote: On Mon, 2013-09-09 at 13:37 +0200, Lukas Slebodnik wrote: On (07/09/13 13:43), Simo Sorce wrote: On Fri, 2013

Re: [SSSD] [PATCH] is_dn(): free dn

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 03:49:30PM +0200, Jakub Hrozek wrote: > On Tue, Sep 10, 2013 at 02:10:41PM +0200, Pavel Březina wrote: > > man ldap_str2dn says: > > Space for dn will be obtained dynamically and should be freed by the > > caller using ldap_dnfree(3). > > ACK Pushed to master, sssd-1-10 an

Re: [SSSD] [PATCH] krb5: Fix warning sometimes uninitialized

2013-09-10 Thread Jakub Hrozek
On Tue, Sep 10, 2013 at 03:59:29PM +0200, Jakub Hrozek wrote: > On Tue, Sep 10, 2013 at 12:29:22PM +0200, Lukas Slebodnik wrote: > > On (10/09/13 10:37), Sumit Bose wrote: > > >On Tue, Sep 10, 2013 at 10:13:10AM +0200, Lukas Slebodnik wrote: > > >> ehlo, > > >> > > >> clang found a warning in simo

Re: [SSSD] mmap_cache problem

2013-09-10 Thread Simo Sorce
On Tue, 2013-09-10 at 15:43 +0200, Lukas Slebodnik wrote: > On (10/09/13 09:18), Simo Sorce wrote: > >On Tue, 2013-09-10 at 12:24 +0200, Lukas Slebodnik wrote: > >> On (09/09/13 09:22), Simo Sorce wrote: > >> >On Mon, 2013-09-09 at 13:37 +0200, Lukas Slebodnik wrote: > >> >> On (07/09/13 13:43), Si

Re: [SSSD] Releasing 1.10.2 and branching off 1.12

2013-09-10 Thread Dmitri Pal
On 09/10/2013 05:05 AM, Jakub Hrozek wrote: > Hi, > > currently we have quite a few unreleased patches in the sssd-1-10 branch. At > the same time, most distributions that I know of (Fedora 19, 20, rawhide, > Ubuntu) have moved to 1.11 which is already mostly receiving bugfixes > now. In addition,

[SSSD] [PATCH] Add journald support

2013-09-10 Thread Jakub Hrozek
Hi, attached are two small patches I wrote when I was checking whether Fedora's move to journald affects us or not. Patch #1 adds a new configure option, that, if enabled, routes logging via journald's API. No change in logging format is present in this patch. You need to have systemd-devel instal