Re: [SSSD] [PATCH] krb5: Use right function to free data

2013-10-21 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 08:24:13AM +0200, Jakub Hrozek wrote: > On Mon, Oct 14, 2013 at 02:22:43PM +0200, Lukas Slebodnik wrote: > > >make sense, but please call krb5_free_cred_contents() before to make > > >sure all cred content is freed as well. > > Nice catch. I didn't realise it. > > > > > > >

Re: [SSSD] [PATCH] krb5: Use right function to free data

2013-10-21 Thread Jakub Hrozek
On Mon, Oct 14, 2013 at 02:22:43PM +0200, Lukas Slebodnik wrote: > >make sense, but please call krb5_free_cred_contents() before to make > >sure all cred content is freed as well. > Nice catch. I didn't realise it. > > > > >bye, > >Sumit > > > >> } else { > >> *_cred = cred; > >>

Re: [SSSD] [PATCH] IPA: Remove unused memory context

2013-10-21 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 05:23:06PM +0200, Lukas Slebodnik wrote: > ehlo, > > While I was working on another isuue I found unused paraeter. > > Simple patch is attached > > LS > From 64c8b6839b6de63f8e3fb9995a16351f82ba96c1 Mon Sep 17 00:00:00 2001 > From: Lukas Slebodnik > Date: Mon, 21 Oct 20

Re: [SSSD] [INI][PATCHES] Allow c-style comments in config files

2013-10-21 Thread Dmitri Pal
On 10/21/2013 12:15 PM, Lukas Slebodnik wrote: > On (19/10/13 01:08), Dmitri Pal wrote: >> On 10/17/2013 10:39 AM, Lukas Slebodnik wrote: >>> On (06/10/13 12:29), Dmitri Pal wrote: Hello The following patch set addresses ticket https://fedorahosted.org/sssd/ticket/2108

Re: [SSSD] SSSD Internals Document published

2013-10-21 Thread Yassir Elley
- Original Message - > On Thu, 2013-10-17 at 17:57 -0400, Yassir Elley wrote: > > The SSSD team has published an SSSD Internals Document, which can be found > > at https://fedorahosted.org/sssd/wiki/InternalsDocs. If there are any > > mistakes in the document, feel free to modify the docume

Re: [SSSD] [INI][PATCHES] Allow c-style comments in config files

2013-10-21 Thread Lukas Slebodnik
On (19/10/13 01:08), Dmitri Pal wrote: >On 10/17/2013 10:39 AM, Lukas Slebodnik wrote: >> On (06/10/13 12:29), Dmitri Pal wrote: >>> Hello >>> >>> The following patch set addresses ticket >>> https://fedorahosted.org/sssd/ticket/2108 >>> >>> Please see commit messages for more details about what ea

Re: [SSSD] [PATCH] NSS: Check allocation result

2013-10-21 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 10:38:19AM -0400, Simo Sorce wrote: > On Mon, 2013-10-21 at 11:03 +0200, Jakub Hrozek wrote: > > Another small bug I found when looking for #1020945 > > > > > > > > > > > > > > > > plain text > > document > > attachment > > (0001-NSS-Check-allocation-result.patch) > >

Re: [SSSD] [PATCH] UTIL: Free log message when using journald

2013-10-21 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 10:35:34AM -0400, Simo Sorce wrote: > On Mon, 2013-10-21 at 11:01 +0200, Jakub Hrozek wrote: > > > > I was exercising sssd with valgrind when looking for #1020945 and > > found > > this leak. > > > > > > > > > > > > > > > > plain text > > document > > attachment > >

[SSSD] [PATCH] IPA: Remove unused memory context

2013-10-21 Thread Lukas Slebodnik
ehlo, While I was working on another isuue I found unused paraeter. Simple patch is attached LS >From 64c8b6839b6de63f8e3fb9995a16351f82ba96c1 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 21 Oct 2013 17:18:27 +0200 Subject: [PATCH] IPA: Remove unused memory context. Parameter mem_

Re: [SSSD] [PATCH] Remove duplicate declaration

2013-10-21 Thread Lukas Slebodnik
On (21/10/13 11:27), Jakub Hrozek wrote: >sss_parse_name() was declared twice for no apparent reason. This patch >removes the duplicate declaration. >From 9634c03d1f755eb6de9f2c3fcd6bd5cb46f1bebe Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Wed, 2 Oct 2013 14:58:30 +0200 >Subject: [PATCH]

Re: [SSSD] [PATCH] NSS: Check allocation result

2013-10-21 Thread Simo Sorce
On Mon, 2013-10-21 at 11:03 +0200, Jakub Hrozek wrote: > Another small bug I found when looking for #1020945 > > > > > > > > plain text > document > attachment > (0001-NSS-Check-allocation-result.patch) > > From b1d04686f085e25f10dde82f1e19c89278883001 Mon Sep 17 00:00:00 2001 > From: Jakub

Re: [SSSD] [PATCH] UTIL: Free log message when using journald

2013-10-21 Thread Simo Sorce
On Mon, 2013-10-21 at 11:01 +0200, Jakub Hrozek wrote: > > I was exercising sssd with valgrind when looking for #1020945 and > found > this leak. > > > > > > > > plain text > document > attachment > (0001-UTIL-Free-log-message-when-using-journald.patch) > > From 3bde2833eca1fc280214da03f06

Re: [SSSD] [PATCH] responder: Access packet header using SAFEALIGN macros

2013-10-21 Thread Lukas Slebodnik
On (24/09/13 22:54), Michal Židek wrote: >Hello, > >the attached patch should uses the SAFEALIGN macros to access data in >the packet header (in sss_packet structure) so that it does not >depend on proper memory alignment (currently the alignment is OK, but >if we add something to the packet header

[SSSD] [PATCH] IPA: add callback to reset subdomain timeouts

2013-10-21 Thread Sumit Bose
Hi, these two patches are the SSSD part to fix https://fedorahosted.org/sssd/ticket/2030 . To reset the timeouts I introduced a new callback type which is always executed if SIGUSR2 (go online immediately) is received in contrast to the default online callback which are only executed if the backen

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-21 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2013 05:28 AM, Jakub Hrozek wrote: > Attached is a style patch. Feel free to ack or nack, it's just a > readability improvement. > Ack. I agree, out-of-tree headers should be using <> A fair number of these are pointing at the ding-libs he

Re: [SSSD] [PATCH] UTIL: Free log message when using journald

2013-10-21 Thread Pavel Březina
On 10/21/2013 11:01 AM, Jakub Hrozek wrote: I was exercising sssd with valgrind when looking for #1020945 and found this leak. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-dev

Re: [SSSD] [PATCH] Remove unused constants

2013-10-21 Thread Pavel Reichl
ACK On Mon, 2013-10-21 at 11:25 +0200, Jakub Hrozek wrote: > I found some unused code when working on the dbus responder. > ___ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel __

Re: [SSSD] [PATCH] PROXY: Fix memory hierarchy when enumerating services

2013-10-21 Thread Pavel Březina
On 10/21/2013 11:00 AM, Jakub Hrozek wrote: Enumerating services with the proxy backend didn't work, a local variable was used as a talloc context.. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mai

Re: [SSSD] [PATCH] NSS: Check allocation result

2013-10-21 Thread Sumit Bose
On Mon, Oct 21, 2013 at 11:03:25AM +0200, Jakub Hrozek wrote: > Another small bug I found when looking for #1020945 > From b1d04686f085e25f10dde82f1e19c89278883001 Mon Sep 17 00:00:00 2001 > From: Jakub Hrozek > Date: Sun, 20 Oct 2013 19:24:04 +0200 > Subject: [PATCH] NSS: Check allocation result

Re: [SSSD] [PATCH] NSS: Check allocation result

2013-10-21 Thread Lukas Slebodnik
On (21/10/13 11:03), Jakub Hrozek wrote: >Another small bug I found when looking for #1020945 >From b1d04686f085e25f10dde82f1e19c89278883001 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Sun, 20 Oct 2013 19:24:04 +0200 >Subject: [PATCH] NSS: Check allocation result > >--- > src/responder/ns

[SSSD] [PATCH] Include external headers with #include

2013-10-21 Thread Jakub Hrozek
Attached is a style patch. Feel free to ack or nack, it's just a readability improvement. >From d25f89e20417db947dc3c692411683b77b4ee7d7 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 2 Oct 2013 11:53:33 +0200 Subject: [PATCH] Include external headers with #include I find it more readabl

[SSSD] [PATCH] Remove duplicate declaration

2013-10-21 Thread Jakub Hrozek
sss_parse_name() was declared twice for no apparent reason. This patch removes the duplicate declaration. >From 9634c03d1f755eb6de9f2c3fcd6bd5cb46f1bebe Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 2 Oct 2013 14:58:30 +0200 Subject: [PATCH] Remove duplicate declaration --- src/responde

[SSSD] [PATCH] Remove unused constants

2013-10-21 Thread Jakub Hrozek
I found some unused code when working on the dbus responder. >From 392699d6c6a305c44c9495bd6a09c3cb7210c61b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 2 Oct 2013 11:44:49 +0200 Subject: [PATCH] Remove unused constants --- src/confdb/confdb.h | 3 --- 1 file changed, 3 deletions(-) d

[SSSD] [PATCH] PROXY: Fix memory hierarchy when enumerating services

2013-10-21 Thread Jakub Hrozek
Enumerating services with the proxy backend didn't work, a local variable was used as a talloc context.. >From af68ae133a9cd695345aafdd2a18cf65d8b45f96 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 17 Oct 2013 19:37:14 +0200 Subject: [PATCH 1/3] PROXY: Fix memory hierarchy when enumeratin

[SSSD] [PATCH] NSS: Check allocation result

2013-10-21 Thread Jakub Hrozek
Another small bug I found when looking for #1020945 >From b1d04686f085e25f10dde82f1e19c89278883001 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Sun, 20 Oct 2013 19:24:04 +0200 Subject: [PATCH] NSS: Check allocation result --- src/responder/nss/nsssrv_cmd.c | 2 ++ 1 file changed, 2 insertio

[SSSD] [PATCH] UTIL: Free log message when using journald

2013-10-21 Thread Jakub Hrozek
I was exercising sssd with valgrind when looking for #1020945 and found this leak. >From 3bde2833eca1fc280214da03f067e3df63040899 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Sun, 20 Oct 2013 16:52:06 +0200 Subject: [PATCH 2/3] UTIL: Free log message when using journald --- src/util/sss_log