Re: [SSSD] [PATCH] PROXY: Fix memory hierarchy when enumerating services

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 12:30:48PM +0200, Pavel Březina wrote: > On 10/21/2013 11:00 AM, Jakub Hrozek wrote: > >Enumerating services with the proxy backend didn't work, a local > >variable was used as a talloc context.. > > Ack. Pushed to master and sssd-1-11 _

Re: [SSSD] [PATCH] IPA: Remove unused memory context

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 10:51:53PM +0200, Jakub Hrozek wrote: > On Mon, Oct 21, 2013 at 05:23:06PM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > While I was working on another isuue I found unused paraeter. > > > > Simple patch is attached > > > > LS > > > From 64c8b6839b6de63f8e3fb9995a16351

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/21/2013 05:28 AM, Jakub Hrozek wrote: > > Attached is a style patch. Feel free to ack or nack, it's just a > > readability improvement. > > > > Ack. I agree, out-of-tre

Re: [SSSD] [PATCH] Remove unused constants

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 12:32:24PM +0200, Pavel Reichl wrote: > ACK > On Mon, 2013-10-21 at 11:25 +0200, Jakub Hrozek wrote: > > I found some unused code when working on the dbus responder. > > ___ > > sssd-devel mailing list > > sssd-devel@lists.fedoraho

Re: [SSSD] [PATCH] IPA: add callback to reset subdomain timeouts

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 02:54:24PM +0200, Sumit Bose wrote: > Hi, > > these two patches are the SSSD part to fix > https://fedorahosted.org/sssd/ticket/2030 . To reset the timeouts I > introduced a new callback type which is always executed if SIGUSR2 (go > online immediately) is received in contr

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Lukas Slebodnik
On (22/10/13 09:17), Jakub Hrozek wrote: >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 10/21/2013 05:28 AM, Jakub Hrozek wrote: >> > Attached is a style patch. Feel free to ack or nack, it's just a >> > readability

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: > On (22/10/13 09:17), Jakub Hrozek wrote: > >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> On 10/21/2013 05:28 AM, Jakub Hrozek wrote: > >> > Att

[SSSD] [PATCH] sdap_get_generic_ext_send: check if we a re still connected

2013-10-22 Thread Sumit Bose
Hi, this patch tries to fix https://fedorahosted.org/sssd/ticket/2126 . Se commit message for details. bye, Sumit From 2e9b617c2b0e08f3f34ea3de44d5f47c758b7f9d Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Fri, 18 Oct 2013 15:54:22 +0200 Subject: [PATCH] sdap_get_generic_ext_send: check if we

Re: [SSSD] [PATCH] IPA: add callback to reset subdomain timeouts

2013-10-22 Thread Sumit Bose
On Tue, Oct 22, 2013 at 10:15:27AM +0200, Jakub Hrozek wrote: > On Mon, Oct 21, 2013 at 02:54:24PM +0200, Sumit Bose wrote: > > Hi, > > > > these two patches are the SSSD part to fix > > https://fedorahosted.org/sssd/ticket/2030 . To reset the timeouts I > > introduced a new callback type which is

Re: [SSSD] [PATCH] sdap_get_generic_ext_send: check if we a re still connected

2013-10-22 Thread Sumit Bose
On Tue, Oct 22, 2013 at 10:46:04AM +0200, Sumit Bose wrote: > Hi, > > this patch tries to fix https://fedorahosted.org/sssd/ticket/2126 . Se > commit message for details. sorry, but the check in the first patch is too strict. When doing a rootDSE lookup as the very first LDAP request sh->connecte

Re: [SSSD] [PATCH] Remove duplicate declaration

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 04:48:16PM +0200, Lukas Slebodnik wrote: > On (21/10/13 11:27), Jakub Hrozek wrote: > >sss_parse_name() was declared twice for no apparent reason. This patch > >removes the duplicate declaration. > > >From 9634c03d1f755eb6de9f2c3fcd6bd5cb46f1bebe Mon Sep 17 00:00:00 2001 >

Re: [SSSD] [PATCH] NSS: Check allocation result

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 05:33:33PM +0200, Jakub Hrozek wrote: > On Mon, Oct 21, 2013 at 10:38:19AM -0400, Simo Sorce wrote: > > On Mon, 2013-10-21 at 11:03 +0200, Jakub Hrozek wrote: > > > Another small bug I found when looking for #1020945 > > > > > > > > > > > > > > > > > > > > > > > > pla

Re: [SSSD] [INI] [PATCH] Fix warning format string is not a string literal.

2013-10-22 Thread Jakub Hrozek
On Thu, Oct 17, 2013 at 01:48:43PM +0200, Jakub Hrozek wrote: > On Thu, Oct 17, 2013 at 11:00:08AM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > I found a warning in ding-libs (ini), while I was testing patches on the > > list. > > > > Simple patch is attached. > > > > LS > > ACK Pushed to

Re: [SSSD] [PATCH] IPA: Do not enable IPA sites in server mode

2013-10-22 Thread Jakub Hrozek
On Fri, Sep 27, 2013 at 12:54:32PM +0200, Pavel Březina wrote: > On 09/26/2013 07:40 PM, Jakub Hrozek wrote: > >On Wed, Sep 25, 2013 at 11:37:37AM +0200, Jakub Hrozek wrote: > >>I realized this might be a nice chance when I was working on #2079. In > > ^^ > >

Re: [SSSD] [PATCH] IPA: add callback to reset subdomain timeouts

2013-10-22 Thread Sumit Bose
On Tue, Oct 22, 2013 at 10:58:57AM +0200, Sumit Bose wrote: > On Tue, Oct 22, 2013 at 10:15:27AM +0200, Jakub Hrozek wrote: > > On Mon, Oct 21, 2013 at 02:54:24PM +0200, Sumit Bose wrote: > > > Hi, > > > > > > these two patches are the SSSD part to fix > > > https://fedorahosted.org/sssd/ticket/20

Re: [SSSD] [PATCH] IPA: Do not enable IPA sites in server mode

2013-10-22 Thread Pavel Březina
On 10/22/2013 12:43 PM, Jakub Hrozek wrote: On Fri, Sep 27, 2013 at 12:54:32PM +0200, Pavel Březina wrote: On 09/26/2013 07:40 PM, Jakub Hrozek wrote: On Wed, Sep 25, 2013 at 11:37:37AM +0200, Jakub Hrozek wrote: I realized this might be a nice chance when I was working on #2079. In

Re: [SSSD] [PATCH] Remove duplicate declaration

2013-10-22 Thread Lukas Slebodnik
On (22/10/13 11:43), Jakub Hrozek wrote: >On Mon, Oct 21, 2013 at 04:48:16PM +0200, Lukas Slebodnik wrote: >> On (21/10/13 11:27), Jakub Hrozek wrote: >> >sss_parse_name() was declared twice for no apparent reason. This patch >> >removes the duplicate declaration. >> >> >From 9634c03d1f755eb6de9f2

Re: [SSSD] [PATCH] responder: Access packet header using SAFEALIGN macros

2013-10-22 Thread Michal Židek
On 10/21/2013 04:16 PM, Lukas Slebodnik wrote: On (24/09/13 22:54), Michal Židek wrote: Hello, the attached patch should uses the SAFEALIGN macros to access data in the packet header (in sss_packet structure) so that it does not depend on proper memory alignment (currently the alignment is OK,

Re: [SSSD] [PATCH] nss: wait for initial subdomains request to finish

2013-10-22 Thread Jakub Hrozek
On Thu, Oct 17, 2013 at 05:42:28PM +0200, Jakub Hrozek wrote: > On Thu, Oct 17, 2013 at 02:15:57PM +0200, Sumit Bose wrote: > > On Thu, Oct 17, 2013 at 01:33:41PM +0200, Jakub Hrozek wrote: > > > On Thu, Oct 17, 2013 at 01:23:02PM +0200, Sumit Bose wrote: > > > > On Thu, Oct 17, 2013 at 10:59:47AM

Re: [SSSD] [PATCH] LDAP: Delete entry by SID if not found

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 15, 2013 at 06:08:18PM +0200, Jakub Hrozek wrote: > On Fri, Oct 11, 2013 at 11:01:32AM +0200, Pavel Březina wrote: > > On 10/10/2013 08:13 PM, Jakub Hrozek wrote: > > >Hi, > > > > > >if an entry is removed from LDAP and searched by SID, the SID lookup > > >code doesn't handle ENOENT and

Re: [SSSD] [PATCH] LDAP: Delete entry by SID if not found

2013-10-22 Thread Jakub Hrozek
On Fri, Oct 11, 2013 at 09:59:17AM +0200, Jakub Hrozek wrote: > On Fri, Oct 11, 2013 at 09:37:54AM +0200, Sumit Bose wrote: > > On Thu, Oct 10, 2013 at 02:49:13PM -0400, Stephen Gallagher wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA1 > > > > > > On 10/10/2013 02:13 PM, Jakub Hro

Re: [SSSD] [PATCH] responder: Access packet header using SAFEALIGN macros

2013-10-22 Thread Lukas Slebodnik
On (22/10/13 14:09), Michal Židek wrote: >On 10/21/2013 04:16 PM, Lukas Slebodnik wrote: >>On (24/09/13 22:54), Michal Židek wrote: >>>Hello, >>> >>>the attached patch should uses the SAFEALIGN macros to access data in >>>the packet header (in sss_packet structure) so that it does not >>>depend on

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Lukas Slebodnik
On (22/10/13 10:41), Jakub Hrozek wrote: >On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: >> On (22/10/13 09:17), Jakub Hrozek wrote: >> >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> >> Hash: SHA1 >> >> >> >> On 10/

Re: [SSSD] [PATCH] Remove duplicate declaration

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 01:53:20PM +0200, Lukas Slebodnik wrote: > On (22/10/13 11:43), Jakub Hrozek wrote: > >On Mon, Oct 21, 2013 at 04:48:16PM +0200, Lukas Slebodnik wrote: > >> On (21/10/13 11:27), Jakub Hrozek wrote: > >> >sss_parse_name() was declared twice for no apparent reason. This patch

Re: [SSSD] [PATCH] IPA: Do not enable IPA sites in server mode

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 01:26:53PM +0200, Pavel Březina wrote: > On 10/22/2013 12:43 PM, Jakub Hrozek wrote: > >On Fri, Sep 27, 2013 at 12:54:32PM +0200, Pavel Březina wrote: > >>On 09/26/2013 07:40 PM, Jakub Hrozek wrote: > >>>On Wed, Sep 25, 2013 at 11:37:37AM +0200, Jakub Hrozek wrote: > I r

[SSSD] [PATCH] subdomains: first destroy ptask than remove sdom

2013-10-22 Thread Pavel Březina
From 5906f84cf340b925ae63d72e9fcec9b3700f9f14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 22 Oct 2013 16:15:16 +0200 Subject: [PATCH 1/2] subdomains: first destroy ptask then remove sdom be_ptask_destroy was unreachable since sdom is not present in the list of sdap

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Pavel Reichl
On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote: > On (22/10/13 10:41), Jakub Hrozek wrote: > >On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: > >> On (22/10/13 09:17), Jakub Hrozek wrote: > >> >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: > >> >> ---

Re: [SSSD] [PATCH] IPA: add callback to reset subdomain timeouts

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 12:51:56PM +0200, Sumit Bose wrote: > On Tue, Oct 22, 2013 at 10:58:57AM +0200, Sumit Bose wrote: > > On Tue, Oct 22, 2013 at 10:15:27AM +0200, Jakub Hrozek wrote: > > > On Mon, Oct 21, 2013 at 02:54:24PM +0200, Sumit Bose wrote: > > > > Hi, > > > > > > > > these two patche

Re: [SSSD] [PATCH] sdap_get_generic_ext_send: check if we a re still connected

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 11:36:16AM +0200, Sumit Bose wrote: > On Tue, Oct 22, 2013 at 10:46:04AM +0200, Sumit Bose wrote: > > Hi, > > > > this patch tries to fix https://fedorahosted.org/sssd/ticket/2126 . Se > > commit message for details. > > sorry, but the check in the first patch is too stric

Re: [SSSD] [PATCH] IPA: add callback to reset subdomain timeouts

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 05:45:36PM +0200, Jakub Hrozek wrote: > On Tue, Oct 22, 2013 at 12:51:56PM +0200, Sumit Bose wrote: > > On Tue, Oct 22, 2013 at 10:58:57AM +0200, Sumit Bose wrote: > > > On Tue, Oct 22, 2013 at 10:15:27AM +0200, Jakub Hrozek wrote: > > > > On Mon, Oct 21, 2013 at 02:54:24PM

Re: [SSSD] [PATCH] sdap_get_generic_ext_send: check if we a re still connected

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 06:53:37PM +0200, Jakub Hrozek wrote: > On Tue, Oct 22, 2013 at 11:36:16AM +0200, Sumit Bose wrote: > > On Tue, Oct 22, 2013 at 10:46:04AM +0200, Sumit Bose wrote: > > > Hi, > > > > > > this patch tries to fix https://fedorahosted.org/sssd/ticket/2126 . Se > > > commit mess