Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Simo Sorce
On Mon, 2013-11-04 at 18:07 +0100, Lukas Slebodnik wrote: > On (04/11/13 11:51), Simo Sorce wrote: > >On Mon, 2013-11-04 at 16:44 +0100, Sumit Bose wrote: > >> On Mon, Nov 04, 2013 at 10:36:56AM -0500, Simo Sorce wrote: > >> > On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote: > >> > > On Mon, No

Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs

2013-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2013 09:47 AM, Lukas Slebodnik wrote: > On (04/11/13 15:40), Jakub Hrozek wrote: >> On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote: >>> On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: https://fedorahosted.org/ss

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Lukas Slebodnik
On (04/11/13 11:51), Simo Sorce wrote: >On Mon, 2013-11-04 at 16:44 +0100, Sumit Bose wrote: >> On Mon, Nov 04, 2013 at 10:36:56AM -0500, Simo Sorce wrote: >> > On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote: >> > > On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote: >> > > > On (

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Simo Sorce
On Mon, 2013-11-04 at 16:44 +0100, Sumit Bose wrote: > On Mon, Nov 04, 2013 at 10:36:56AM -0500, Simo Sorce wrote: > > On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote: > > > On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote: > > > > On (01/11/13 18:41), Sumit Bose wrote: > > > > >

Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs

2013-11-04 Thread Pavel Brezina
- Original Message - > From: "Sumit Bose" > To: sssd-devel@lists.fedorahosted.org > Sent: Monday, November 4, 2013 3:03:04 PM > Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs > > On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > > https://fedorahosted

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Sumit Bose
On Mon, Nov 04, 2013 at 10:36:56AM -0500, Simo Sorce wrote: > On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote: > > On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote: > > > On (01/11/13 18:41), Sumit Bose wrote: > > > >Hi, > > > > > > > >with this patch it is not required anymore t

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Simo Sorce
On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote: > On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote: > > On (01/11/13 18:41), Sumit Bose wrote: > > >Hi, > > > > > >with this patch it is not required anymore to have cifs-utils-devel > > >installed for the default build. > > > > >

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Sumit Bose
On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote: > On (01/11/13 18:41), Sumit Bose wrote: > >Hi, > > > >with this patch it is not required anymore to have cifs-utils-devel > >installed for the default build. > > > >Fixes https://fedorahosted.org/sssd/ticket/2125 > > > >bye, > >Sumit

Re: [SSSD] [PATCH] build: fix ordering of linker flags

2013-11-04 Thread Jakub Hrozek
On Mon, Nov 04, 2013 at 07:54:58AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/04/2013 05:45 AM, Jakub Hrozek wrote: > > On Sat, Nov 02, 2013 at 01:38:53AM +0100, Jan Engelhardt wrote: > >> > >> On Saturday 2013-11-02 01:35, Dmitri Pal wrote: > >>>

Re: [SSSD] [PATCH] Enhance/add unit tests for find_subdomain_by_sid/name

2013-11-04 Thread Jakub Hrozek
On Mon, Nov 04, 2013 at 10:41:01AM +0100, Jakub Hrozek wrote: > On Fri, Nov 01, 2013 at 06:44:30PM +0100, Sumit Bose wrote: > > Hi, > > > > recently I added some unit tests for find_subdomain_by_sid. This patch > > enhances those and adds similar tests for find_subdomain_by_name. > > > > bye, > >

Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs

2013-11-04 Thread Lukas Slebodnik
On (04/11/13 15:40), Jakub Hrozek wrote: >On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote: >> On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: >> > https://fedorahosted.org/sssd/ticket/2133 >> >> Patches are looking good, I wonder why you did not cover binary SIDs, >> i.e.

Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs

2013-11-04 Thread Jakub Hrozek
On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote: > On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > > https://fedorahosted.org/sssd/ticket/2133 > > Patches are looking good, I wonder why you did not cover binary SIDs, > i.e. *_to_bin_sid() calls? > > bye, > Sumit I wou

Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs

2013-11-04 Thread Sumit Bose
On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/2133 Patches are looking good, I wonder why you did not cover binary SIDs, i.e. *_to_bin_sid() calls? bye, Sumit ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] build: fix ordering of linker flags

2013-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2013 05:45 AM, Jakub Hrozek wrote: > On Sat, Nov 02, 2013 at 01:38:53AM +0100, Jan Engelhardt wrote: >> >> On Saturday 2013-11-02 01:35, Dmitri Pal wrote: >>> On 11/01/2013 08:13 PM, Jan Engelhardt wrote: Libraries MUST be specified in L

[SSSD] Sernet Samba 4 packages

2013-11-04 Thread Rowland Penny
Hi, it was reported on the Samba list that if you are running Ubuntu 12.04 and install the Sernet samba4 packages, then install sssd from the ppa that the sernet-samba package is removed. Upon investigation, it turns out that the Sernet package conflicts with libndr-standard0 and libndr0. This

[SSSD] [PATCHES] idmap: add API to free allocated SIDs

2013-11-04 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2133 From 683b8be4f4d54dc9efc2b35de9d993be0dd69c39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Fri, 1 Nov 2013 12:23:23 +0100 Subject: [PATCH 1/5] idmap: add API to free allocated SIDs --- src/lib/idmap/sss_idmap.c | 30

Re: [SSSD] [PATCH] Add ldap_autofs_map_master_name option

2013-11-04 Thread Jakub Hrozek
On Wed, Jul 10, 2013 at 02:51:37PM +0200, Jakub Hrozek wrote: > On Tue, Jun 18, 2013 at 05:00:17PM +0200, Lukas Slebodnik wrote: > > On (18/06/13 11:15), Jakub Hrozek wrote: > > >On Tue, Jun 18, 2013 at 10:29:36AM +0200, Lukas Slebodnik wrote: > > >> On (17/06/13 19:47), Jakub Hrozek wrote: > > >>

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Lukas Slebodnik
On (01/11/13 18:41), Sumit Bose wrote: >Hi, > >with this patch it is not required anymore to have cifs-utils-devel >installed for the default build. > >Fixes https://fedorahosted.org/sssd/ticket/2125 > >bye, >Sumit >From 35f5932946d67a943146411a336afac34a78fb90 Mon Sep 17 00:00:00 2001 >From: Sumi

Re: [SSSD] [PATCH] build: fix ordering of linker flags

2013-11-04 Thread Jakub Hrozek
On Sat, Nov 02, 2013 at 01:38:53AM +0100, Jan Engelhardt wrote: > > On Saturday 2013-11-02 01:35, Dmitri Pal wrote: > >On 11/01/2013 08:13 PM, Jan Engelhardt wrote: > >> Libraries MUST be specified in LDADD/LIBADD, not LDFLAGS, because > >> LDFLAGS appear earlier in the command line and library or

Re: [SSSD] [PATCH] Include external headers with #include

2013-11-04 Thread Jakub Hrozek
On Fri, Nov 01, 2013 at 11:21:38AM +0100, Jakub Hrozek wrote: > On Fri, Nov 01, 2013 at 11:18:47AM +0100, Jakub Hrozek wrote: > > On Fri, Nov 01, 2013 at 11:05:33AM +0100, Pavel Reichl wrote: > > > On Thu, 2013-10-31 at 19:53 +0100, Jakub Hrozek wrote: > > > > On Thu, Oct 31, 2013 at 10:53:40AM +01

Re: [SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

2013-11-04 Thread Jakub Hrozek
On Fri, Nov 01, 2013 at 06:41:20PM +0100, Sumit Bose wrote: > Hi, > > with this patch it is not required anymore to have cifs-utils-devel > installed for the default build. > > Fixes https://fedorahosted.org/sssd/ticket/2125 > > bye, > Sumit Hi, I think it would also be nice to add explicit "w

Re: [SSSD] [PATCH] Enhance/add unit tests for find_subdomain_by_sid/name

2013-11-04 Thread Jakub Hrozek
On Fri, Nov 01, 2013 at 06:44:30PM +0100, Sumit Bose wrote: > Hi, > > recently I added some unit tests for find_subdomain_by_sid. This patch > enhances those and adds similar tests for find_subdomain_by_name. > > bye, > Sumit Builds fine, the tests make sense and pass on F-20 64bit. ACK ___