Re: [SSSD] [Patch] Added null checks to authtok module

On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote: > Hello, > > Please find the attachment below. Kindly review. > I am not really a fan of these null checks, I prefer the code to crash in this case because these functions should never be called with an empty context. Simo. -- Simo Sorce *

Re: [SSSD] Makefile split

On Sat, 2013-11-16 at 13:06 +0100, Lukas Slebodnik wrote: > ehlo, > > We have a very big Makefile.am > bash$ wc -l Makefile.am > 2152 Makefile.am > > And it will be much bigger, because there is initiative to improve code > coverage with unit tests. I have an idea to split current big makefile to

[SSSD] [Patch] Added null checks to authtok module

Hello, Please find the attachment below. Kindly review. Thanks, Pallavi From 05016cb4104d4b4225747599fac614acb376bd87 Mon Sep 17 00:00:00 2001 From: Pallavi Jha Date: Sat, 16 Nov 2013 16:23:01 +0530 Subject: [PATCH] added null checks to authtok module --- src/util/authtok.c | 30 +

[SSSD] Makefile split

ehlo, We have a very big Makefile.am bash$ wc -l Makefile.am 2152 Makefile.am And it will be much bigger, because there is initiative to improve code coverage with unit tests. I have an idea to split current big makefile to smaller ones. If we want to split Makefile it will have pros and cons. B