[SSSD] [PATCHES] Enable sending DEBUG logs to journald

2013-12-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All of these patches require Nikolai's "DEBUG Macro Refactoring v3" patches to be applied first. Patch 0001: Allow debug_fn to process __FILE__ and __LINE__ In preparation for enabling journald support for the DEBUG logs, we will need to be able t

Re: [SSSD] DEBUG macro refactoring v3

2013-12-20 Thread Nikolai Kondrashov
Hi Stephen, Thanks for the review! Replies below. On 12/20/2013 09:31 PM, Stephen Gallagher wrote: I'd rather that 0005 and 0006 be squashed together and that the comment be written as follows: {{{ Make DEBUG macro invocations variadic Use a script to update DEBUG macro invocations to use it

Re: [SSSD] DEBUG macro refactoring v3

2013-12-20 Thread Nikolai Kondrashov
On 12/20/2013 09:43 PM, Stephen Gallagher wrote: Actually, minor Nack on 0008: #define DEBUG(level, format, ...) do { \ - -int __debug_macro_newlevel = debug_get_level(level); \ - -if (DEBUG_IS_SET(__debug_macro_newlevel)) \ - -debug_fn(__FUNCTION__, __debug_macro_newlevel, for

Re: [SSSD] DEBUG macro refactoring v3

2013-12-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2013 02:31 PM, Stephen Gallagher wrote: > On 12/20/2013 11:15 AM, Nikolai Kondrashov wrote: >> Hi everyone, > >> Please find attached the third version of the DEBUG macro >> refactoring patchset. The second version was lost to the >> maillis

Re: [SSSD] DEBUG macro refactoring v3

2013-12-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2013 11:15 AM, Nikolai Kondrashov wrote: > Hi everyone, > > Please find attached the third version of the DEBUG macro > refactoring patchset. The second version was lost to the maillist > message size limit, so I'll list the changes from the

Re: [SSSD] [PATCH] build: add missing Requires to pkgconfig file

2013-12-20 Thread Jakub Hrozek
On Thu, Dec 19, 2013 at 07:42:36PM +0100, Jan Engelhardt wrote: > ini_comment.h uses simplebuffer.h, therefore must Require > basicobjects which provides that. Similarly, ini_valueobj.h uses > ref_array.h and must therefore Require ref_array. > --- > ini/ini_config.pc.in | 3 ++- > 1 file changed,