On Fedora a 20 box got the following linker errors during 'make check'.
* krb5 built from git master
* sssd git master
* Both built with --prefix=/opt/build ...
Attached is a patch which fixes the problem.
Cheers,
Stef
libtool: link: gcc -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith
Reported by Timo Aaltonen.
From ba1782624d8d33a5a8056beae9a69ce58cc23668 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek jhro...@redhat.com
Date: Tue, 7 Jan 2014 10:43:55 +0100
Subject: [PATCH] tests: Remove tests that check creating public directories
The functionality was removed, but we forgot to
On 07.01.2014 11:45, Jakub Hrozek wrote:
Reported by Timo Aaltonen.
thanks, confirmed that it fixed the build.
--
t
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On Fri, Dec 27, 2013 at 10:40:08AM +0100, Lukas Slebodnik wrote:
ACK
LS
Pushed to master.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On Fri, Dec 20, 2013 at 01:20:31PM +0100, Jakub Hrozek wrote:
On Thu, Dec 19, 2013 at 07:42:36PM +0100, Jan Engelhardt wrote:
ini_comment.h uses simplebuffer.h, therefore must Require
basicobjects which provides that. Similarly, ini_valueobj.h uses
ref_array.h and must therefore Require
On Wed, Dec 11, 2013 at 03:47:17PM +0545, Pallavi Jha wrote:
Hello,
Please find the updated patch attached with this mail.
With regards
Pallavi Kumari Jha
Computer Science Engineering
Hi Pallavi,
there are still two compilation warnings in the code. Attached is a
patch with changes I
On Wed, Dec 25, 2013 at 02:10:20AM +0200, Nikolai Kondrashov wrote:
On 12/23/2013 01:42 PM, Jakub Hrozek wrote:
On Sun, Dec 22, 2013 at 11:23:58AM +0200, Nikolai Kondrashov wrote:
1. There are 2273 uses of the old levels, *half* of all DEBUG macro
invocations, so updating them
Hi Jakub,
Thanks a lot for reviewing!
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
I spoke about the same problem with Simo (or Stephen? Sorry, I forgot
over holidays) and it seems my opinion is in minority so I won't block
the patchset over it.
I have some very minor comments about the
Hi,
some of the recent changes to the AD group membership lookups broke
those lookups for the IPA server mode. This patch should fix it.
bye,
Sumit
From 48afb0dd8bff534c1867e7f767e563fe97402db4 Mon Sep 17 00:00:00 2001
From: Sumit Bose sb...@redhat.com
Date: Tue, 7 Jan 2014 13:04:58 +0100
On Tue, Jan 07, 2014 at 03:31:50PM +0200, Nikolai Kondrashov wrote:
Hi Jakub,
Thanks a lot for reviewing!
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
I spoke about the same problem with Simo (or Stephen? Sorry, I forgot
over holidays) and it seems my opinion is in minority so I won't
On 07.01.2014 14:57, Stef Walter wrote:
On 07.01.2014 14:07, Stef Walter wrote:
Anyhow, here's a patch which aims to make the full_name_format printf
handling both correct and safe.
...
I'll be happy to split the patch into two, if desired. One which adds
safe-printf.[ch] + tests, and
On 01/07/2014 04:53 PM, Jakub Hrozek wrote:
On Tue, Jan 07, 2014 at 03:31:50PM +0200, Nikolai Kondrashov wrote:
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
[PATCH 3/8] Remove extra flushing from debug message output
The code is fine, but why is it a separate patch and not part of #2 ? It
seems
On 07.01.2014 19:55, Simo Sorce wrote:
A few notes:
1. style
although we allow things like
if (condition)
statement;
I do not think we accpet for or while loops w/o braces
Nod.
2. the functions are incomplete and lack documentation that states so
in particular the only accepted
On 07.01.2014 20:34, Simo Sorce wrote:
Ok fine, makes sense once explained (need this explanation in the
docs/headers), but then use a different name.
If I see safe_snprintf, I assume the full format capabilities of
snprintf, the name in this case is misleading.
That said I am not sure
On Tue, 2014-01-07 at 21:31 +0100, Stef Walter wrote:
On 07.01.2014 20:34, Simo Sorce wrote:
Ok fine, makes sense once explained (need this explanation in the
docs/headers), but then use a different name.
If I see safe_snprintf, I assume the full format capabilities of
snprintf, the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/07/2014 10:22 AM, Jakub Hrozek wrote:
On Mon, Dec 23, 2013 at 08:01:15AM -0500, Stephen Gallagher wrote:
On Dec 21, 2013, at 1:25 PM, Lukas Slebodnik
lsleb...@redhat.com wrote:
On (20/12/13 17:05), Stephen Gallagher wrote: All of these
Hi,
Thank you for the patch. I checked it and have included the changes in
the patch attached with this mail. Please look into it.
From e235241893cf09fbce5fb2f339841dd27ca0dfde Mon Sep 17 00:00:00 2001
From: Pallavi Jha pallavikumari...@gmail.com
Date: Wed, 8 Jan 2014 12:41:08 +0545
Subject:
Hi,
the attached patch fixes #2191.
From f12c4bb11ff35cdd785026aa571db8f659127763 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek jhro...@redhat.com
Date: Wed, 8 Jan 2014 08:11:46 +0100
Subject: [PATCH] LDAP: Fix typo and use the right attribute map
https://fedorahosted.org/sssd/ticket/2191
There
18 matches
Mail list logo
