[SSSD] [PATCH] sudo: set tm_isdst when converting time attributes

2014-01-29 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2213 From 53c98c297a28cdf9f9dc16db8b8914049a4b28a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Wed, 29 Jan 2014 12:56:08 +0100 Subject: [PATCH] sudo: set tm_isdst when converting time attributes strptime() which

[SSSD] [PATCH] MAN: clarify which shell option takes precedence

2014-01-29 Thread Jakub Hrozek
I think there was a bug in our man pages. They say that default_shell takes precedence over any other shell related options, but according to the code, override_shell is evaluated first. From 3872153e4fd6595c1eb1adb1f0377a223bbf6649 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com

Re: [SSSD] [PATCH] sudo: set tm_isdst when converting time attributes

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 12:58:24PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2213 for (format = formats; *format != NULL; format++) { tret = strptime(str, *format, tm); if (tret != NULL *tret == '\0') { +/* strptime() leaves isdst

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Sumit Bose
On Tue, Jan 28, 2014 at 03:34:52PM +0100, Jakub Hrozek wrote: On Tue, Jan 28, 2014 at 11:17:55AM +0100, Sumit Bose wrote: Thank you for the review. A new set of patches is attached. Patches 1, 2, 3 and 5 are looking good. In patch 4 you add ad_enum_subdom_send() and

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 01:32:45PM +0100, Sumit Bose wrote: On Tue, Jan 28, 2014 at 10:44:30PM +0100, Jakub Hrozek wrote: I think I should bring up one piece of the last patch: +/* Get the list of original DN attributes the group had in AD */ +group_odn_list =

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote: Code looks good and my tests passed, so ACK. bye, Sumit Thank you for the review, pushed to master. There are some conflicts in the 1.11 branch, so I'll send patches separately. ___

Re: [SSSD] [PATCH] MAN: clarify which shell option takes precedence

2014-01-29 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/29/2014 07:25 AM, Jakub Hrozek wrote: I think there was a bug in our man pages. They say that default_shell takes precedence over any other shell related options, but according to the code, override_shell is evaluated first. Ack

Re: [SSSD] [PATCH] sudo: set tm_isdst when converting time attributes

2014-01-29 Thread Pavel Březina
On 01/29/2014 01:29 PM, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 12:58:24PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2213 for (format = formats; *format != NULL; format++) { tret = strptime(str, *format, tm); if (tret != NULL *tret ==

Re: [SSSD] [PATCH] sudo: set tm_isdst when converting time attributes

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 02:45:49PM +0100, Pavel Březina wrote: On 01/29/2014 01:29 PM, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 12:58:24PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2213 for (format = formats; *format != NULL; format++) { tret =

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-29 Thread Michal Židek
On 01/22/2014 07:50 PM, Lukas Slebodnik wrote: This patch needs to be rebased. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Rebased patch attached. Michal From

Re: [SSSD] [PATCH] LDAP: Detect the presence of POSIX attributes

2014-01-29 Thread Pavel Březina
On 01/27/2014 11:33 PM, Jakub Hrozek wrote: Hi, When the schema is set to AD and ID mapping is used, there is a one-time you wanted to say when ID mapping is *not* used check ran when searching for users to detect the presence of POSIX attributes in LDAP. If this check fails, the search

Re: [SSSD] sssd not setting IPA AD trusted user homedir

2014-01-29 Thread Pavel Reichl
Hi Jakub, I did as you wrote:-). New patches are attached. Please note that I changed handling of failure in call of apply_subdomain_homedir from ipa_get_ad_acct_ad_part_done. PR From 4300f985377bfe16c40faf3f373e1875e5f80433 Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date:

Re: [SSSD] [PATCH] LDAP: Detect the presence of POSIX attributes

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 03:39:41PM +0100, Pavel Březina wrote: On 01/27/2014 11:33 PM, Jakub Hrozek wrote: Hi, When the schema is set to AD and ID mapping is used, there is a one-time you wanted to say when ID mapping is *not* used check ran when searching for users to detect the

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 04:03:15PM +0100, Sumit Bose wrote: On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote: Code looks good and my tests passed, so ACK.

Re: [SSSD] [PATCH] LDAP: Detect the presence of POSIX attributes

2014-01-29 Thread Sumit Bose
On Wed, Jan 29, 2014 at 03:39:41PM +0100, Pavel Březina wrote: On 01/27/2014 11:33 PM, Jakub Hrozek wrote: Hi, When the schema is set to AD and ID mapping is used, there is a one-time you wanted to say when ID mapping is *not* used check ran when searching for users to detect the

Re: [SSSD] [PATCH] sudo: set tm_isdst when converting time attributes

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 02:57:09PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 02:45:49PM +0100, Pavel Březina wrote: On 01/29/2014 01:29 PM, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 12:58:24PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2213 for

Re: [SSSD] [PATCHES] LDAP: Fix group handling with AD schema

2014-01-29 Thread Lukas Slebodnik
On (28/01/14 23:10), Jakub Hrozek wrote: On Mon, Jan 27, 2014 at 09:46:26AM +0100, Lukas Slebodnik wrote: ehlo, two patches are attached. The 1st one is almost he same like patch: commit 16b27fcceebcbbaeefaf5b9bdf2dec3065adba4a LDAP: Don't fail if subdomain cannot be found by sid I

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Lukas Slebodnik
On (29/01/14 16:03), Sumit Bose wrote: On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote: Code looks good and my tests passed, so ACK. bye, Sumit

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Sumit Bose
On Wed, Jan 29, 2014 at 05:20:55PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 04:03:15PM +0100, Sumit Bose wrote: On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 01:33:52PM +0100,

Re: [SSSD] [PATCH] MAN: clarify which shell option takes precedence

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 08:31:12AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/29/2014 07:25 AM, Jakub Hrozek wrote: I think there was a bug in our man pages. They say that default_shell takes precedence over any other shell related options, but

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 04:03:15PM +0100, Sumit Bose wrote: On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote: Code looks good and my tests passed, so ACK.

Re: [SSSD] [PATCH] Connect to GC during enumeration

2014-01-29 Thread Sumit Bose
On Wed, Jan 29, 2014 at 05:49:03PM +0100, Lukas Slebodnik wrote: On (29/01/14 16:03), Sumit Bose wrote: On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote: On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote:

Re: [SSSD] [PATCHES] LDAP: Fix group handling with AD schema

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 05:40:56PM +0100, Lukas Slebodnik wrote: On (28/01/14 23:10), Jakub Hrozek wrote: On Mon, Jan 27, 2014 at 09:46:26AM +0100, Lukas Slebodnik wrote: ehlo, two patches are attached. The 1st one is almost he same like patch: commit

[SSSD] Fedora.NEXT Products and the fate of Spins

2014-01-29 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Apologies for the slightly alarmist $SUBJECT, but I want to make sure that this gets read by the appropriate groups. During today's FESCo meeting, there was the start of a discussion on how to approve new Products into the Fedora family. As part of

Re: [SSSD] [PATCHES] LDAP: Fix group handling with AD schema

2014-01-29 Thread Jakub Hrozek
On Wed, Jan 29, 2014 at 08:12:54PM +0100, Jakub Hrozek wrote: This change is sufficient and patch look nicer :-) Updated patches are attached. LS These patches work for me and resolve the issue. Retrieving groups also still works fine with AD backend. So ACK to the code. I still

Re: [SSSD] Fedora.NEXT Products and the fate of Spins

2014-01-29 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sorry, folks. My email client decided to fill in Development of the System Security Services Daemon instead of Development of Fedora. Please disregard. On 01/29/2014 02:53 PM, Stephen Gallagher wrote: Apologies for the slightly alarmist $SUBJECT,