On Mon, 2014-04-07 at 19:20 -0400, Dmitri Pal wrote:
> Hello,
>
> This is the continuation of the discussion of the following design page:
> https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge
>
> I see three controversial items in this design based on the previous
> discussio
Hello,
This is the continuation of the discussion of the following design page:
https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge
I see three controversial items in this design based on the previous
discussion:
a) Merging values
This horse has been beaten in the other thr
On (07/04/14 21:01), Sumit Bose wrote:
>On Mon, Apr 07, 2014 at 08:39:07PM +0200, Jakub Hrozek wrote:
>>
>> Except first patch didn't allocate on NULL? I think that was the meat of
>> Sumit's comments..
>
>yes, just allocate on NULL and free it explicitly in the end to make
>valgrind happy.
It is e
On (07/04/14 22:21), Sumit Bose wrote:
>On Mon, Apr 07, 2014 at 09:20:50PM +0200, Lukas Slebodnik wrote:
>> but there is no difference. You allocate debug_prg_name on NULL and then
>> steal
>> to another talloc context. (like in ldap_child)
>
>Why do you have to steal it? Just allocate on NULL and
On 04/07/2014 02:29 PM, Simo Sorce wrote:
On Mon, 2014-04-07 at 13:55 -0400, Dmitri Pal wrote:
On 04/07/2014 08:37 AM, Simo Sorce wrote:
I disagree with several points here, sorry.
1) I agree that it would have been better if sssd.conf had a different
semantics about the domains. But the situa
On Mon, Apr 07, 2014 at 09:20:50PM +0200, Lukas Slebodnik wrote:
> On (07/04/14 21:01), Sumit Bose wrote:
> >On Mon, Apr 07, 2014 at 08:39:07PM +0200, Jakub Hrozek wrote:
> >> On Mon, Apr 07, 2014 at 08:35:20PM +0200, Lukas Slebodnik wrote:
> >> > On (07/04/14 20:30), Jakub Hrozek wrote:
> >> > >On
On (30/03/14 22:31), Dmitri Pal wrote:
>I ran the tests again, did distcheck and verified valgrind.
>Everything seems OK.
>
>Refined patches attached.
>
>--
>Thank you,
>Dmitri Pal
>
>Sr. Engineering Manager for IdM portfolio
>Red Hat Inc.
>
>
>---
>Looking to carve out
On (07/04/14 14:20), Dmitri Pal wrote:
>On 04/07/2014 05:47 AM, Lukas Slebodnik wrote:
>>On (04/04/14 17:47), Dmitri Pal wrote:
>>>Just a couple minor edits to the language of the doxygen:
>>>
>>>
>>>diff --git a/ini/ini_configobj.h b/ini/ini_configobj.h
>>>index 9a4eb58..4ef98d
On (07/04/14 21:01), Sumit Bose wrote:
>On Mon, Apr 07, 2014 at 08:39:07PM +0200, Jakub Hrozek wrote:
>> On Mon, Apr 07, 2014 at 08:35:20PM +0200, Lukas Slebodnik wrote:
>> > On (07/04/14 20:30), Jakub Hrozek wrote:
>> > >On Mon, Apr 07, 2014 at 08:03:32PM +0200, Lukas Slebodnik wrote:
>> > >> On (
On Mon, Apr 07, 2014 at 08:39:07PM +0200, Jakub Hrozek wrote:
> On Mon, Apr 07, 2014 at 08:35:20PM +0200, Lukas Slebodnik wrote:
> > On (07/04/14 20:30), Jakub Hrozek wrote:
> > >On Mon, Apr 07, 2014 at 08:03:32PM +0200, Lukas Slebodnik wrote:
> > >> On (07/04/14 18:53), Jakub Hrozek wrote:
> > >>
- Original Message -
> On 04/07/2014 02:20 PM, Dmitri Pal wrote:
> > On 04/07/2014 05:47 AM, Lukas Slebodnik wrote:
> >> On (04/04/14 17:47), Dmitri Pal wrote:
> >>> Just a couple minor edits to the language of the doxygen:
> >>>
> >>>
> >>> diff --git a/ini/ini_configobj.
On (07/04/14 20:37), Jakub Hrozek wrote:
>On Mon, Apr 07, 2014 at 08:23:58PM +0200, Lukas Slebodnik wrote:
>> On (04/04/14 19:39), Pavel Reichl wrote:
>> >Hello,
>> >
>> >attached patches implement ticket:
>> >
>> >https://fedorahosted.org/sssd/ticket/2205
>> >
>> >Maybe I split the changes into to
On Mon, Apr 07, 2014 at 02:41:26PM -0400, Stephen Gallagher wrote:
> I'm also fine with getting these patches pushed and the docstrings
> cleaned up in a later patch.
+1, let's get this thread out of the way already :-)
Lukas, if you don't insist, I'll just push the latest version of the
patches.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 04/07/2014 02:20 PM, Dmitri Pal wrote:
> On 04/07/2014 05:47 AM, Lukas Slebodnik wrote:
>> On (04/04/14 17:47), Dmitri Pal wrote:
>>> Just a couple minor edits to the language of the
>>> doxygen:
>>>
>>>
>>> diff --git a/ini/in
On Mon, Apr 07, 2014 at 08:03:32PM +0200, Lukas Slebodnik wrote:
> On (07/04/14 18:53), Jakub Hrozek wrote:
> >On Fri, Apr 04, 2014 at 03:41:38PM +0200, Lukas Slebodnik wrote:
> >> On (04/04/14 15:18), Jakub Hrozek wrote:
> >> >On Thu, Apr 03, 2014 at 07:11:37PM +0200, Jakub Hrozek wrote:
> >> >> O
On Mon, Apr 07, 2014 at 08:35:20PM +0200, Lukas Slebodnik wrote:
> On (07/04/14 20:30), Jakub Hrozek wrote:
> >On Mon, Apr 07, 2014 at 08:03:32PM +0200, Lukas Slebodnik wrote:
> >> On (07/04/14 18:53), Jakub Hrozek wrote:
> >> >On Fri, Apr 04, 2014 at 03:41:38PM +0200, Lukas Slebodnik wrote:
> >> >
On Mon, Apr 07, 2014 at 08:23:58PM +0200, Lukas Slebodnik wrote:
> On (04/04/14 19:39), Pavel Reichl wrote:
> >Hello,
> >
> >attached patches implement ticket:
> >
> >https://fedorahosted.org/sssd/ticket/2205
> >
> >Maybe I split the changes into too many patches, please feel free to
> >suggest squ
On 04/07/2014 02:20 PM, Dmitri Pal wrote:
On 04/07/2014 05:47 AM, Lukas Slebodnik wrote:
On (04/04/14 17:47), Dmitri Pal wrote:
Just a couple minor edits to the language of the doxygen:
diff --git a/ini/ini_configobj.h b/ini/ini_configobj.h
index 9a4eb58..4ef98dc 100644
- --- a/ini/ini_config
On Mon, Apr 07, 2014 at 08:07:45PM +0200, Lukas Slebodnik wrote:
> On (07/04/14 19:18), Jakub Hrozek wrote:
> >On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
> >> On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
> >> > ehlo,
> >> >
> >> > I found a warning "zero-leng
On (07/04/14 20:30), Jakub Hrozek wrote:
>On Mon, Apr 07, 2014 at 08:03:32PM +0200, Lukas Slebodnik wrote:
>> On (07/04/14 18:53), Jakub Hrozek wrote:
>> >On Fri, Apr 04, 2014 at 03:41:38PM +0200, Lukas Slebodnik wrote:
>> >> On (04/04/14 15:18), Jakub Hrozek wrote:
>> >> >On Thu, Apr 03, 2014 at 0
On Mon, 2014-04-07 at 13:55 -0400, Dmitri Pal wrote:
> On 04/07/2014 08:37 AM, Simo Sorce wrote:
> >> I disagree with several points here, sorry.
> >> >
> >> >1) I agree that it would have been better if sssd.conf had a different
> >> >semantics about the domains. But the situation right now is tha
On (04/04/14 19:39), Pavel Reichl wrote:
>Hello,
>
>attached patches implement ticket:
>
>https://fedorahosted.org/sssd/ticket/2205
>
>Maybe I split the changes into too many patches, please feel free to
>suggest squashing them.
>
>Regards,
>
>Pavel Reichl
I think there is a conflict in requireme
On 04/07/2014 05:47 AM, Lukas Slebodnik wrote:
On (04/04/14 17:47), Dmitri Pal wrote:
Just a couple minor edits to the language of the doxygen:
diff --git a/ini/ini_configobj.h b/ini/ini_configobj.h
index 9a4eb58..4ef98dc 100644
- --- a/ini/ini_configobj.h
+++ b/ini/ini_configobj.h
@@ -483,6 +
On (07/04/14 19:18), Jakub Hrozek wrote:
>On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
>> On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
>> > ehlo,
>> >
>> > I found a warning "zero-length gnu_printf format string" when I was testing
>> > patches on ALT linux. It
On (07/04/14 18:53), Jakub Hrozek wrote:
>On Fri, Apr 04, 2014 at 03:41:38PM +0200, Lukas Slebodnik wrote:
>> On (04/04/14 15:18), Jakub Hrozek wrote:
>> >On Thu, Apr 03, 2014 at 07:11:37PM +0200, Jakub Hrozek wrote:
>> >> On Thu, Mar 20, 2014 at 05:53:31PM +0100, Lukas Slebodnik wrote:
>> >> > On
On 04/07/2014 08:37 AM, Simo Sorce wrote:
I disagree with several points here, sorry.
>
>1) I agree that it would have been better if sssd.conf had a different
>semantics about the domains. But the situation right now is that the
>domains are listed. I agree we can go to your model but in reality
On Mon, Feb 24, 2014 at 06:45:02PM +0100, Pavel Reichl wrote:
> On Mon, 2014-02-10 at 16:04 +0100, Pavel Reichl wrote:
> > Hello,
> >
> > please see attached patch.
> >
> > While testing this patch I have noticed a little asymmetry:
> >
> > While SSSD being offline I added SRV record so resolvi
On Mon, Apr 07, 2014 at 07:18:11PM +0200, Jakub Hrozek wrote:
> On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
> > On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > I found a warning "zero-length gnu_printf format string" when I was
> > > test
On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
> On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
> > ehlo,
> >
> > I found a warning "zero-length gnu_printf format string" when I was testing
> > patches on ALT linux. It is in the ifdef section if nsupdate do not hav
On Thu, Feb 27, 2014 at 05:15:00PM +0100, Pavel Reichl wrote:
> On Thu, 2014-02-27 at 11:55 +0100, Pavel Březina wrote:
> [snip]
> > Nack.
> > It is still possible having a netgroup expired if
> > refresh_expired_interval is misconfigured (> entry_cache_timeout). Thus
> > you still need to check
On Mon, Mar 10, 2014 at 10:28:51PM +0100, Lukas Slebodnik wrote:
> On (10/03/14 14:31), Dmitri Pal wrote:
> >On 03/10/2014 02:30 AM, Lukas Slebodnik wrote:
> >>On (08/03/14 02:00), Dmitri Pal wrote:
> >>>On 03/08/2014 01:40 AM, Dmitri Pal wrote:
> On 03/07/2014 12:00 PM, Jakub Hrozek wrote:
> >
On Fri, Apr 04, 2014 at 03:41:38PM +0200, Lukas Slebodnik wrote:
> On (04/04/14 15:18), Jakub Hrozek wrote:
> >On Thu, Apr 03, 2014 at 07:11:37PM +0200, Jakub Hrozek wrote:
> >> On Thu, Mar 20, 2014 at 05:53:31PM +0100, Lukas Slebodnik wrote:
> >> > On (20/03/14 17:21), Jakub Hrozek wrote:
> >> > >
On Mon, Apr 07, 2014 at 02:22:04PM +0200, Pavel Reichl wrote:
> Hello,
>
> I noticed these two warnings in clang.
>
> It would be great if the 2nd patch could be checked by Sumit to make
> sure that the return value wasn't ignored on purpose.
yes, I would prefer to ignore errors here. There migh
On Mon, Apr 07, 2014 at 02:29:29PM +0200, Pavel Reichl wrote:
> On Mon, 2014-04-07 at 13:55 +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > 2 patches attached.
> >
> > LS
> > ___
> > sssd-devel mailing list
> > sssd-devel@lists.fedorahosted.org
> > http
On Mon, Apr 07, 2014 at 05:30:39PM +0200, Jakub Hrozek wrote:
> On Mon, Apr 07, 2014 at 04:51:58PM +0200, Jakub Hrozek wrote:
> > On Fri, Apr 04, 2014 at 08:42:53PM +0200, Michal Židek wrote:
> > > On 04/04/2014 07:26 PM, Lukas Slebodnik wrote:
> > > >On (04/04/14 17:08), Michal Židek wrote:
> > >
On Mon, Apr 07, 2014 at 04:51:58PM +0200, Jakub Hrozek wrote:
> On Fri, Apr 04, 2014 at 08:42:53PM +0200, Michal Židek wrote:
> > On 04/04/2014 07:26 PM, Lukas Slebodnik wrote:
> > >On (04/04/14 17:08), Michal Židek wrote:
> > >>Reported by Clang. See patch description for more info.
> > >>
> > >>P
On Fri, Apr 04, 2014 at 08:42:53PM +0200, Michal Židek wrote:
> On 04/04/2014 07:26 PM, Lukas Slebodnik wrote:
> >On (04/04/14 17:08), Michal Židek wrote:
> >>Reported by Clang. See patch description for more info.
> >>
> >>Patch is in attachment.
> >>
> >>Thanks,
> >>Michal
> >
> >>From a0c94bc4c5
On Sun, 2014-04-06 at 01:00 -0400, Dmitri Pal wrote:
> On 04/06/2014 12:11 AM, Simo Sorce wrote:
> > On Fri, 2014-04-04 at 18:25 -0400, Dmitri Pal wrote:
> >> Ah you mean the two conditions:
> >>
> >> - all files must start with a valid section header, i.e. each file has
> >> to be valid ini fi
On Mon, 2014-04-07 at 13:55 +0200, Lukas Slebodnik wrote:
> ehlo,
>
> 2 patches attached.
>
> LS
> ___
> sssd-devel mailing list
> sssd-devel@lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Patches look OK to me and
Hello,
I noticed these two warnings in clang.
It would be great if the 2nd patch could be checked by Sumit to make
sure that the return value wasn't ignored on purpose.
Thanks,
Pavel Reichl
>From 20257f6b2a3c6842e67ae61511932c08eaf4ded4 Mon Sep 17 00:00:00 2001
From: Pavel Reichl
Date: Fri, 4
ehlo,
2 patches attached.
LS
>From 5ef1608bbd2e9e877cd05adc26e0513f610910c8 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Sat, 5 Apr 2014 11:26:59 +0200
Subject: [PATCH 1/2] krb5_child: Remove unused krb5_context from
set_changepw_options
---
src/providers/krb5/krb5_child.c | 7 +++
On (04/04/14 17:47), Dmitri Pal wrote:
>
>
>Just a couple minor edits to the language of the doxygen:
>
>
>diff --git a/ini/ini_configobj.h b/ini/ini_configobj.h
>index 9a4eb58..4ef98dc 100644
>- --- a/ini/ini_configobj.h
>+++ b/ini/ini_configobj.h
>@@ -483,6 +48
On Fri, Apr 04, 2014 at 05:52:45PM -0400, Dmitri Pal wrote:
> On 04/03/2014 02:04 PM, Jakub Hrozek wrote:
> >Hi,
> >
> >for some reason several low-priority tickets ended up in 1.11.x. In
> >retrospective, I don't think they need to be in the stable branch and
> >I'd like to move them out. See belo
On (07/04/14 10:23), Jakub Hrozek wrote:
>On Fri, Apr 04, 2014 at 06:30:40PM -0400, Pavel Reichl wrote:
>> Or you could write a wrapper function 'diff_string_lists_const' calling
>> original 'diff_string_lists' but at least hiding the nasty discard_const_p.
>
>Do we have the discard_const hack use
On Fri, Apr 04, 2014 at 05:45:43PM +0200, Jakub Hrozek wrote:
> On Fri, Apr 04, 2014 at 03:28:46PM +0200, Lukas Slebodnik wrote:
> > On (04/04/14 14:47), Jakub Hrozek wrote:
> > >On Fri, Apr 04, 2014 at 10:35:59AM +0200, Lukas Slebodnik wrote:
> > >> ehlo,
> > >>
> > >> attached patch resolves #22
On Fri, Apr 04, 2014 at 06:30:40PM -0400, Pavel Reichl wrote:
> Or you could write a wrapper function 'diff_string_lists_const' calling
> original 'diff_string_lists' but at least hiding the nasty discard_const_p.
Do we have the discard_const hack used anywhere else than the AD
provider enumerati
46 matches
Mail list logo
