Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-05-11 Thread Jakub Hrozek
I haven't tested this patch to be honest, but then again, there's not so much to test except compiling and a bit of sanity testing.. I prefer Michal's version of using sss_strerror explicitly instead of the route Simo proposed to #define strerror as sss_strerror simply because I prefer to see what

Re: [SSSD] [PATCH] MONITOR: Fix start up with closed standard input

2014-05-11 Thread Jakub Hrozek
On Wed, 2014-04-23 at 18:08 +0200, Lukas Slebodnik wrote: > I tought it would be problem to monitor closed file descriptor with > tevent_add_fd, but it isn't. > > New version attached. > > LS The patches look good and also work good -- I've been running them over the weekend on my laptop without

Re: [SSSD] [PATCH] IFP: Add a utility function to reply with an object path

2014-05-11 Thread Jakub Hrozek
On Sun, 2014-05-11 at 19:18 +0200, Pavel Březina wrote: > On 05/11/2014 04:40 PM, Jakub Hrozek wrote: > > Hi, > > > > the attached patches add utility functions that allow the InfoPipe > > responder to reply with an object path, escaped if needed. > > > > The ifp_reply_objpath() function was initia

Re: [SSSD] [PATCH][ding-libs] Collection: remove unused code

2014-05-11 Thread Dmitri Pal
On 05/09/2014 05:06 PM, Jakub Hrozek wrote: Hi, see attached patch, just removes unused code. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Interesting. I looked at the code

Re: [SSSD] [PATCH] IFP: Add a utility function to reply with an object path

2014-05-11 Thread Pavel Březina
On 05/11/2014 04:40 PM, Jakub Hrozek wrote: Hi, the attached patches add utility functions that allow the InfoPipe responder to reply with an object path, escaped if needed. The ifp_reply_objpath() function was initially in my tree, but Pavel improved it quite a bit and fixed some bugs, so the

[SSSD] [PATCH] IFP: Add a utility function to reply with an object path

2014-05-11 Thread Jakub Hrozek
Hi, the attached patches add utility functions that allow the InfoPipe responder to reply with an object path, escaped if needed. The ifp_reply_objpath() function was initially in my tree, but Pavel improved it quite a bit and fixed some bugs, so the patch should be attributed to him. I'm also fi