Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-16 Thread Nikolai Kondrashov
On 05/16/2014 11:32 PM, Lukas Slebodnik wrote: On (16/04/14 21:30), Nikolai Kondrashov wrote: In my case there is no beneficial performance difference when running with valgrind. There is about 25% improvement using /dev/shm when running with coverage enabled, but even in a VM it takes less than

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-16 Thread Lukas Slebodnik
On (16/04/14 21:30), Nikolai Kondrashov wrote: >Hi Lukas, > >A slightly more complete answer to your last message. > >On 04/16/2014 05:44 PM, Lukas Slebodnik wrote: >>On (16/04/14 16:21), Nikolai Kondrashov wrote: >>>On 04/16/2014 04:03 PM, Lukas Slebodnik wrote: It works if $TEST_DIR is create

Re: [SSSD] [PATCH] libsss_dbus

2014-05-16 Thread Sumit Bose
On Fri, May 16, 2014 at 03:32:53PM +0200, Jakub Hrozek wrote: > On Fri, May 16, 2014 at 02:54:55PM +0200, Pavel Březina wrote: > > On 05/16/2014 02:04 PM, Jakub Hrozek wrote: > > > > > >* sss_dbus: add shortcuts for common use cases > > >I wonder if the functions specific to an object could

Re: [SSSD] [PATCH] SDAP: augmented logging for group saving

2014-05-16 Thread Lukas Slebodnik
On (29/04/14 18:25), Pavel Reichl wrote: >On Mon, 2014-04-28 at 21:35 +0200, Jakub Hrozek wrote: >> On Mon, Apr 28, 2014 at 01:55:00PM +0200, Pavel Reichl wrote: >> > On Thu, 2014-04-17 at 17:30 +0200, Jakub Hrozek wrote: >> > > On Tue, Apr 15, 2014 at 04:25:50PM +0200, Pavel Reichl wrote: >> > > >

Re: [SSSD] [PATCH] SBUS: Fix warning declaration shadows a global declaration

2014-05-16 Thread Jakub Hrozek
On Fri, May 16, 2014 at 10:59:38AM +0200, Stef Walter wrote: > On 16.05.2014 10:46, Lukas Slebodnik wrote: > > ehlo, > > > > While I was testing some patches on epl6 I found a new warning. > > > > src/sbus/sssd_dbus_meta.c: In function 'sbus_meta_find_signal': > > src/sbus/sssd_dbus_meta.c:43: wa

Re: [SSSD] [PATCH] BUILD: Make samba4 libraries optional

2014-05-16 Thread Jakub Hrozek
On Fri, May 16, 2014 at 02:54:16PM +0200, Michal Židek wrote: > >Thank you for review. > >The patch for master was sent to review few days ago and meantime gpo patch > >was > >pushed to master. > > > >Updated patches are attached. > > > >LS > > > > Patch for 1.11: ACK. > Patch for master: ACK. >

Re: [SSSD] [patches] SDAP: "ldap_group_nesting_level = 0" does not appear to work

2014-05-16 Thread Lukas Slebodnik
On (13/05/14 00:07), Pavel Reichl wrote: >Hello, > >please see attached patches solving: > >https://fedorahosted.org/sssd/ticket/2294 > >Thanks, > >Pavel Reichl >From 17d8d7c4e53da2291daebfdbbf90d3448df9e765 Mon Sep 17 00:00:00 2001 >From: Pavel Reichl >Date: Mon, 12 May 2014 15:00:26 + >Subj

Re: [SSSD] [PATCH] libsss_dbus

2014-05-16 Thread Jakub Hrozek
On Fri, May 16, 2014 at 02:54:55PM +0200, Pavel Březina wrote: > On 05/16/2014 02:04 PM, Jakub Hrozek wrote: > >On Thu, May 15, 2014 at 09:23:46PM +0200, Pavel Březina wrote: > >>On 05/15/2014 09:09 PM, Pavel Březina wrote: > >>>On 05/13/2014 05:43 PM, Pavel Březina wrote: > On 05/13/2014 11:18

Re: [SSSD] [PATCH] BUILD: Make samba4 libraries optional

2014-05-16 Thread Michal Židek
On 05/15/2014 08:51 PM, Lukas Slebodnik wrote: On (15/05/14 18:48), Michal Židek wrote: On 05/15/2014 06:10 PM, Michal Židek wrote: On 05/08/2014 11:12 PM, Lukas Slebodnik wrote: ehlo, Samba 4 libraries are necessary for building {ad, ipa} provider, but samba4 needn't be available on older di

Re: [SSSD] [PATCH] libsss_dbus

2014-05-16 Thread Pavel Březina
On 05/16/2014 02:04 PM, Jakub Hrozek wrote: On Thu, May 15, 2014 at 09:23:46PM +0200, Pavel Březina wrote: On 05/15/2014 09:09 PM, Pavel Březina wrote: On 05/13/2014 05:43 PM, Pavel Březina wrote: On 05/13/2014 11:18 AM, Pavel Březina wrote: On 05/01/2014 05:39 PM, Pavel Březina wrote: https

Re: [SSSD] [PATCH] libsss_dbus

2014-05-16 Thread Jakub Hrozek
On Thu, May 15, 2014 at 09:23:46PM +0200, Pavel Březina wrote: > On 05/15/2014 09:09 PM, Pavel Březina wrote: > >On 05/13/2014 05:43 PM, Pavel Březina wrote: > >>On 05/13/2014 11:18 AM, Pavel Březina wrote: > >>>On 05/01/2014 05:39 PM, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket

Re: [SSSD] [PATCH] Implement type-safe getters for primitive types and their arrays

2014-05-16 Thread Lukas Slebodnik
On (16/05/14 00:48), Jakub Hrozek wrote: >On Tue, May 13, 2014 at 07:04:22PM +0200, Stef Walter wrote: >> On 12.05.2014 23:27, Jakub Hrozek wrote: >> > Hi, >> > >> > the attached patchset implement the >> > org.freedesktop.DBus.Properties.Get() interface for properties of >> > primitive types and

Re: [SSSD] [PATCH] SBUS: Fix warning declaration shadows a global declaration

2014-05-16 Thread Stef Walter
On 16.05.2014 10:46, Lukas Slebodnik wrote: > ehlo, > > While I was testing some patches on epl6 I found a new warning. > > src/sbus/sssd_dbus_meta.c: In function 'sbus_meta_find_signal': > src/sbus/sssd_dbus_meta.c:43: warning: declaration of 'signal' shadows a > global > declaration > /usr/inc

[SSSD] [PATCH] SBUS: Fix warning declaration shadows a global declaration

2014-05-16 Thread Lukas Slebodnik
ehlo, While I was testing some patches on epl6 I found a new warning. src/sbus/sssd_dbus_meta.c: In function 'sbus_meta_find_signal': src/sbus/sssd_dbus_meta.c:43: warning: declaration of 'signal' shadows a global declaration /usr/include/signal.h:101: warning: shadowed declaration is here patch