Re: [SSSD] [PATCH] SDAP: augmented logging for group saving

2014-05-17 Thread Jakub Hrozek
On Sun, 2014-05-18 at 04:51 +0200, Jakub Hrozek wrote: > On Sat, 2014-05-17 at 23:37 +0200, Pavel Reichl wrote: > > On Fri, 2014-05-16 at 16:58 +0200, Lukas Slebodnik wrote: > > [snip] > > > Could you send new version for 1-11 branch? > > > > > > LS > > > > Sure, this is always fun:-). > > Sorry

Re: [SSSD] [PATCH] PAM: Fix problem with missing declaration

2014-05-17 Thread Jakub Hrozek
On Sun, 2014-05-18 at 05:29 +0200, Jakub Hrozek wrote: > On Sat, 2014-05-17 at 19:32 +0200, Lukas Slebodnik wrote: > > ehlo, > > > > The functions strdup and strncmp are used in pam_test_client, > > but header file string.h was not included directly in this file. > > The header file string.h was i

Re: [SSSD] [PATCH] PAM: macro PAM_DATA_REPLACE isn't available in openpam.

2014-05-17 Thread Jakub Hrozek
On Sun, 2014-05-18 at 05:32 +0200, Jakub Hrozek wrote: > On Sat, 2014-05-17 at 19:33 +0200, Lukas Slebodnik wrote: > > ehlo, > > > > macro PAM_DATA_REPLACE isn't available in openpam. > > Are you testing sssd on another OS? If so, do you want any of these > patches to be pushed to 1.11 as well be

Re: [SSSD] [PATCH] CRYPTO: Use unprefixed version of function stpncpy

2014-05-17 Thread Jakub Hrozek
On Sun, 2014-05-18 at 05:38 +0200, Jakub Hrozek wrote: > On Sat, 2014-05-17 at 19:35 +0200, Lukas Slebodnik wrote: > > ehlo, > > > > glibc contains two versions of finction stpncpy > > sh-4.2$ nm --dynamic --defined-only /lib64/libc.so.6 | grep stpncpy > > 003ce1c89b00 i stpncpy > > 003ce1

Re: [SSSD] [PATCH] CONFIGURE: Remove duplicate detection of pam

2014-05-17 Thread Jakub Hrozek
On Sun, 2014-05-18 at 05:40 +0200, Jakub Hrozek wrote: > On Sat, 2014-05-17 at 19:37 +0200, Lukas Slebodnik wrote: > > ehlo, > > > > just a reduction of configure.ac. > > > > The same test is in file src/external/pam.m4 > > > > ...and pam.m4 is unconditionally included in configure.ac, so it's

Re: [SSSD] [PATCH] CONFIGURE: Remove duplicate detection of pam

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 19:37 +0200, Lukas Slebodnik wrote: > ehlo, > > just a reduction of configure.ac. > > The same test is in file src/external/pam.m4 > ...and pam.m4 is unconditionally included in configure.ac, so it's always executed. ACK. ___

Re: [SSSD] [PATCH] CRYPTO: Use unprefixed version of function stpncpy

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 19:35 +0200, Lukas Slebodnik wrote: > ehlo, > > glibc contains two versions of finction stpncpy > sh-4.2$ nm --dynamic --defined-only /lib64/libc.so.6 | grep stpncpy > 003ce1c89b00 i stpncpy > 003ce1c89b00 i __stpncpy > 003ce1d040a0 T __stpncpy_chk > > We should

Re: [SSSD] [PATCH] PAM: macro PAM_DATA_REPLACE isn't available in openpam.

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 19:33 +0200, Lukas Slebodnik wrote: > ehlo, > > macro PAM_DATA_REPLACE isn't available in openpam. Are you testing sssd on another OS? If so, do you want any of these patches to be pushed to 1.11 as well before the 1.11.6 release? > > This part was introduced in commit dba

Re: [SSSD] [PATCH] PAM: Fix problem with missing declaration

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 19:32 +0200, Lukas Slebodnik wrote: > ehlo, > > The functions strdup and strncmp are used in pam_test_client, > but header file string.h was not included directly in this file. > The header file string.h was indirectly included by the header file > security/pam_client.h. > >

Re: [SSSD] Build Fixes

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 19:49 +0200, Lukas Slebodnik wrote: > >From 8b4746d7e2d5c53cbe5d29f1ce984a16aefb5a54 Mon Sep 17 00:00:00 2001 > >From: Lukas Slebodnik > >Date: Tue, 15 Oct 2013 10:27:36 +0200 > >Subject: [PATCH 1/2] BUILD: Explicitly link libsss_ad.so with sasl libs > > > >If openldap is not

Re: [SSSD] [PATCH] resolv: Do not try to free addrinfo in case of error

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 19:38 +0200, Lukas Slebodnik wrote: > ehlo, > > We should call freeaddrinfo only in situation if getaddrinfo succeeds. > It is not specified in RFC2553 the behaviour of calling freeaddrinfo > with the NULL argument. It is more portable to do not rely on undocumented > behavio

Re: [SSSD] [PATCH] SDAP: augmented logging for group saving

2014-05-17 Thread Jakub Hrozek
On Sat, 2014-05-17 at 23:37 +0200, Pavel Reichl wrote: > On Fri, 2014-05-16 at 16:58 +0200, Lukas Slebodnik wrote: > [snip] > > Could you send new version for 1-11 branch? > > > > LS > > Sure, this is always fun:-). Sorry we made you redo the DEBUG messages, I didn't realize this patch was still

Re: [SSSD] [PATCH] SDAP: augmented logging for group saving

2014-05-17 Thread Pavel Reichl
On Fri, 2014-05-16 at 16:58 +0200, Lukas Slebodnik wrote: [snip] > Could you send new version for 1-11 branch? > > LS Sure, this is always fun:-). >From e571ddacd93c93fcf0bf356adb4db2d10134b408 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Mon, 14 Apr 2014 17:27:23 +0100 Subject: [PATCH] S

Re: [SSSD] [patches] SDAP: "ldap_group_nesting_level = 0" does not appear to work

2014-05-17 Thread Pavel Reichl
Hello Lukas, thanks for comments please see replies inline, new patches are attached. On Fri, 2014-05-16 at 15:34 +0200, Lukas Slebodnik wrote: > On (13/05/14 00:07), Pavel Reichl wrote: > >Hello, > > > >please see attached patches solving: > > > >https://fedorahosted.org/sssd/ticket/2294 > > > >T

Re: [SSSD] Build Fixes

2014-05-17 Thread Lukas Slebodnik
On (07/11/13 20:43), Lukas Slebodnik wrote: >On (31/10/13 11:12), Lukas Slebodnik wrote: >>On (15/10/13 15:42), Benjamin Franzke wrote: >>>Hi Lukas, >>> >>> >>>2013/10/15 Lukas Slebodnik >>> On (15/10/13 11:47), Benjamin Franzke wrote: >Hi, > >These two patches add missing CFLA

[SSSD] [PATCH] resolv: Do not try to free addrinfo in case of error

2014-05-17 Thread Lukas Slebodnik
ehlo, We should call freeaddrinfo only in situation if getaddrinfo succeeds. It is not specified in RFC2553 the behaviour of calling freeaddrinfo with the NULL argument. It is more portable to do not rely on undocumented behaviour of glibc. http://www.ietf.org/rfc/rfc2553.txt [Page 28] simple pa

[SSSD] [PATCH] CONFIGURE: Remove duplicate detection of pam

2014-05-17 Thread Lukas Slebodnik
ehlo, just a reduction of configure.ac. The same test is in file src/external/pam.m4 patch is attached. LS >From fec0bb48b0449a0c933882396ffac24f6897006b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 17 May 2014 18:50:00 +0200 Subject: [PATCH 4/5] CONFIGURE: Remove duplicate detect

[SSSD] [PATCH] CRYPTO: Use unprefixed version of function stpncpy

2014-05-17 Thread Lukas Slebodnik
ehlo, glibc contains two versions of finction stpncpy sh-4.2$ nm --dynamic --defined-only /lib64/libc.so.6 | grep stpncpy 003ce1c89b00 i stpncpy 003ce1c89b00 i __stpncpy 003ce1d040a0 T __stpncpy_chk We should use more portable version of stpncpy without prefix with underscores. The f

[SSSD] [PATCH] PAM: macro PAM_DATA_REPLACE isn't available in openpam.

2014-05-17 Thread Lukas Slebodnik
ehlo, macro PAM_DATA_REPLACE isn't available in openpam. This part was introduced in commit dba7903ba7fc04bc331004b0453938c116be3663 "PAM: close socket fd with pam_set_data" simple patch is attached. LS >From d2e9ee6067e5b829f6fac46e8b5489b1d36cfac1 Mon Sep 17 00:00:00 2001 From: Lukas Sle

[SSSD] [PATCH] PAM: Fix problem with missing declaration

2014-05-17 Thread Lukas Slebodnik
ehlo, The functions strdup and strncmp are used in pam_test_client, but header file string.h was not included directly in this file. The header file string.h was indirectly included by the header file security/pam_client.h. sh-4.2$ nm --undefined-only ./pam_test_client | grep -E "strdup|strncmp"