Re: [SSSD] [PATCH] AD: Add ad_gpo unit tests

2014-05-23 Thread Yassir Elley
- Original Message - > On Fri, May 23, 2014 at 03:50:18PM -0400, Yassir Elley wrote: > > > > > > - Original Message - > > > On Fri, May 23, 2014 at 12:29:37PM -0400, Yassir Elley wrote: > > > > > > > > > > > > - Original Message - > > > > > On Tue, May 20, 2014 at 10:3

Re: [SSSD] [PATCH] AD: Add ad_gpo unit tests

2014-05-23 Thread Sumit Bose
On Fri, May 23, 2014 at 03:50:18PM -0400, Yassir Elley wrote: > > > - Original Message - > > On Fri, May 23, 2014 at 12:29:37PM -0400, Yassir Elley wrote: > > > > > > > > > - Original Message - > > > > On Tue, May 20, 2014 at 10:30:15PM -0400, Yassir Elley wrote: > > > > > Hi, >

Re: [SSSD] [PATCH] libsss_dbus

2014-05-23 Thread Pavel Březina
On 05/23/2014 09:13 PM, Sumit Bose wrote: On Fri, May 23, 2014 at 07:09:23PM +0200, Pavel Březina wrote: On 05/23/2014 07:06 PM, Sumit Bose wrote: On Thu, May 22, 2014 at 09:00:49PM +0200, Pavel Březina wrote: On 05/22/2014 11:17 AM, Sumit Bose wrote: On Thu, May 22, 2014 at 11:07:51AM +0200,

Re: [SSSD] [PATCH] AD: Add ad_gpo unit tests

2014-05-23 Thread Yassir Elley
- Original Message - > On Fri, May 23, 2014 at 12:29:37PM -0400, Yassir Elley wrote: > > > > > > - Original Message - > > > On Tue, May 20, 2014 at 10:30:15PM -0400, Yassir Elley wrote: > > > > Hi, > > > > > > > > The attached patch adds unit tests for some of the ad_gpo > > >

Re: [SSSD] [PATCH] AD: Add ad_gpo unit tests

2014-05-23 Thread Sumit Bose
On Fri, May 23, 2014 at 12:29:37PM -0400, Yassir Elley wrote: > > > - Original Message - > > On Tue, May 20, 2014 at 10:30:15PM -0400, Yassir Elley wrote: > > > Hi, > > > > > > The attached patch adds unit tests for some of the ad_gpo functionality. > > > It > > > also fixes some failur

Re: [SSSD] [PATCH] libsss_dbus

2014-05-23 Thread Sumit Bose
On Fri, May 23, 2014 at 07:09:23PM +0200, Pavel Březina wrote: > On 05/23/2014 07:06 PM, Sumit Bose wrote: > >On Thu, May 22, 2014 at 09:00:49PM +0200, Pavel Březina wrote: > >>On 05/22/2014 11:17 AM, Sumit Bose wrote: > >>>On Thu, May 22, 2014 at 11:07:51AM +0200, Sumit Bose wrote: > On Mon, M

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-23 Thread Dmitri Pal
On 05/22/2014 08:40 AM, Simo Sorce wrote: On Wed, 2014-05-21 at 15:31 -0400, Dmitri Pal wrote: On 05/19/2014 01:36 PM, Nikolai Kondrashov wrote: On 05/19/2014 08:28 PM, Jakub Hrozek wrote: On Mon, May 19, 2014 at 05:55:45PM +0300, Nikolai Kondrashov wrote: "ramdisk" is 58x faster then HDD. "r

Re: [SSSD] [PATCH] libsss_dbus

2014-05-23 Thread Pavel Březina
On 05/23/2014 07:06 PM, Sumit Bose wrote: On Thu, May 22, 2014 at 09:00:49PM +0200, Pavel Březina wrote: On 05/22/2014 11:17 AM, Sumit Bose wrote: On Thu, May 22, 2014 at 11:07:51AM +0200, Sumit Bose wrote: On Mon, May 19, 2014 at 10:40:40PM +0200, Pavel Březina wrote: On 05/16/2014 03:32 PM,

Re: [SSSD] [PATCH] libsss_dbus

2014-05-23 Thread Sumit Bose
On Thu, May 22, 2014 at 09:00:49PM +0200, Pavel Březina wrote: > On 05/22/2014 11:17 AM, Sumit Bose wrote: > >On Thu, May 22, 2014 at 11:07:51AM +0200, Sumit Bose wrote: > >>On Mon, May 19, 2014 at 10:40:40PM +0200, Pavel Březina wrote: > >>>On 05/16/2014 03:32 PM, Jakub Hrozek wrote: > On Fri,

Re: [SSSD] [PATCH] AD: Add ad_gpo unit tests

2014-05-23 Thread Yassir Elley
- Original Message - > On Tue, May 20, 2014 at 10:30:15PM -0400, Yassir Elley wrote: > > Hi, > > > > The attached patch adds unit tests for some of the ad_gpo functionality. It > > also fixes some failure mode processing code in ad_gpo.c that was > > uncovered by the unit tests. This pat

Re: [SSSD] [PATCH] SPEC: Drop rhel5 conditions in spec file.

2014-05-23 Thread Lukas Slebodnik
On (23/05/14 17:47), Lukas Slebodnik wrote: >ehlo, > >In theory, it could be possible to build current master without samba >on rhel5, but the spec file would be very complicated. >It is better to simplify spec file. > >Patch is attached. >1 file changed, 43 deletions(-) :-) > >LS The patch lost so

[SSSD] [PATCH] SPEC: Drop rhel5 conditions in spec file.

2014-05-23 Thread Lukas Slebodnik
ehlo, In theory, it could be possible to build current master without samba on rhel5, but the spec file would be very complicated. It is better to simplify spec file. Patch is attached. 1 file changed, 43 deletions(-) :-) LS ___ sssd-devel mailing list

Re: [SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 05:03:35PM +0200, Lukas Slebodnik wrote: > >> Is this preparation for further patches? > > > >Yes. This dependency was introduced in commit: > >commit b1c4a998f8e217b4ba4cd632f5069d479211c22d > >Author: Yassir Elley > >Date: Wed May 21 19:58:52 2014 -0400 > >

Re: [SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

2014-05-23 Thread Lukas Slebodnik
On (23/05/14 16:59), Jakub Hrozek wrote: >On Fri, May 23, 2014 at 03:57:06PM +0200, Lukas Slebodnik wrote: >> On (23/05/14 13:28), Sumit Bose wrote: >> >Hi, >> > >> >I just realized that libsmbclient it not covered by the general >> >samba-devel package. The patch add the needed BuildRequires to th

Re: [SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 03:57:06PM +0200, Lukas Slebodnik wrote: > On (23/05/14 13:28), Sumit Bose wrote: > >Hi, > > > >I just realized that libsmbclient it not covered by the general > >samba-devel package. The patch add the needed BuildRequires to the spec > >file. > > > >bye, > >Sumit > > >From

Re: [SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

2014-05-23 Thread Lukas Slebodnik
On (23/05/14 13:28), Sumit Bose wrote: >Hi, > >I just realized that libsmbclient it not covered by the general >samba-devel package. The patch add the needed BuildRequires to the spec >file. > >bye, >Sumit >From 6508989d0304dbd8c8c463e7adb955806582f0df Mon Sep 17 00:00:00 2001 >From: Sumit Bose >

Re: [SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 01:28:51PM +0200, Sumit Bose wrote: > Hi, > > I just realized that libsmbclient it not covered by the general > samba-devel package. The patch add the needed BuildRequires to the spec > file. > > bye, > Sumit ACK ___ sssd-devel

[SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

2014-05-23 Thread Sumit Bose
Hi, I just realized that libsmbclient it not covered by the general samba-devel package. The patch add the needed BuildRequires to the spec file. bye, Sumit From 6508989d0304dbd8c8c463e7adb955806582f0df Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Fri, 23 May 2014 13:25:32 +0200 Subject: [PAT

Re: [SSSD] [PATCH] AD: Add libsmbclient to makefiles

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 12:43:35PM +0200, Sumit Bose wrote: > On Wed, May 21, 2014 at 08:04:51PM -0400, Yassir Elley wrote: > > Hi, > > > > The attached patch adds libsmbclient to the makefiles, in preparation for > > adding libsmbclient calls to the gpo-smb code. This patch depends on a > > pre

Re: [SSSD] [PATCH] AD: Add libsmbclient to makefiles

2014-05-23 Thread Sumit Bose
On Wed, May 21, 2014 at 08:04:51PM -0400, Yassir Elley wrote: > Hi, > > The attached patch adds libsmbclient to the makefiles, in preparation for > adding libsmbclient calls to the gpo-smb code. This patch depends on a > previously submitted patch ("Add ad_gpo unit test"), which has not yet been

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-23 Thread Nikolai Kondrashov
On 05/23/2014 12:39 PM, Nikolai Kondrashov wrote: On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote: On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote: Yes, I managed not to notice this before, behind other errors, but I get these too. It seems it is reall a Valgrind issue. I.e. it doesn't seem t

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-23 Thread Nikolai Kondrashov
On 05/23/2014 01:00 PM, Nikolai Kondrashov wrote: On 05/23/2014 12:49 PM, Jakub Hrozek wrote: On Fri, May 23, 2014 at 12:39:55PM +0300, Nikolai Kondrashov wrote: On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote: On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote: Yes, I managed not to notice th

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-23 Thread Nikolai Kondrashov
On 05/23/2014 12:49 PM, Jakub Hrozek wrote: On Fri, May 23, 2014 at 12:39:55PM +0300, Nikolai Kondrashov wrote: On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote: On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote: Yes, I managed not to notice this before, behind other errors, but I get these too

Re: [SSSD] [PATCH] IFP: Support multiple interfaces on sysbus

2014-05-23 Thread Jakub Hrozek
On Thu, May 22, 2014 at 07:52:39PM +0200, Pavel Březina wrote: > On 05/21/2014 10:57 PM, Jakub Hrozek wrote: > >The InfoPipe code in master only supports a single interface per > >responder, which obviously doesn't play well with our grand plans. > > > >Pavel, I know you have different plans with m

Re: [SSSD] [PATCH] Implement org.freedesktop.DBus.Properties.GetAll for primitive types

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 08:31:49AM +0200, Lukas Slebodnik wrote: > On (21/05/14 22:53), Jakub Hrozek wrote: > >Hi, > > > >the attached patches implement the > >org.freedesktop.DBus.Properties.GetAll method for retrieving primitive > >types and their arrays. > > > >The patchset build on the previous

Re: [SSSD] [PATCH] AD: Remove GPO dependency on libsamba-security

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 11:28:13AM +0200, Sumit Bose wrote: > On Thu, May 22, 2014 at 08:09:26PM -0400, Yassir Elley wrote: > > > > > > - Original Message - > > > On Wed, May 14, 2014 at 05:03:20PM -0400, Yassir Elley wrote: > > > > > > > > > > > > - Original Message - > > > > >

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-23 Thread Jakub Hrozek
On Fri, May 23, 2014 at 12:39:55PM +0300, Nikolai Kondrashov wrote: > On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote: > >On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote: > >>Yes, I managed not to notice this before, behind other errors, but I get > >>these > >>too. It seems it is reall a Valgri

Re: [SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

2014-05-23 Thread Nikolai Kondrashov
On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote: On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote: Yes, I managed not to notice this before, behind other errors, but I get these too. It seems it is reall a Valgrind issue. I.e. it doesn't seem to make sense to apply "--error-exitcode" to child p

Re: [SSSD] [PATCH] AD: Add ad_gpo unit tests

2014-05-23 Thread Sumit Bose
On Tue, May 20, 2014 at 10:30:15PM -0400, Yassir Elley wrote: > Hi, > > The attached patch adds unit tests for some of the ad_gpo functionality. It > also fixes some failure mode processing code in ad_gpo.c that was uncovered > by the unit tests. This patch depends on a previously submitted patc

Re: [SSSD] [PATCH] AD: Remove GPO dependency on libsamba-security

2014-05-23 Thread Sumit Bose
On Thu, May 22, 2014 at 08:09:26PM -0400, Yassir Elley wrote: > > > - Original Message - > > On Wed, May 14, 2014 at 05:03:20PM -0400, Yassir Elley wrote: > > > > > > > > > - Original Message - > > > > Hi, ... > > I am using code from samba's ndr_security.c, but I only took t

[SSSD] [PATCH] TEST: fix warning in sbus_codegen_tests

2014-05-23 Thread Pavel Reichl
Hello, I found this warning, ../src/tests/sbus_codegen_tests.c: In function ‘test_vtable’: ../src/tests/sbus_codegen_tests.c:182:5: error: missing initializer for field ‘com_planetexpress_Ship_get_Color’ of ‘struct com_planetexpress_Ship’ [-Werror=missing-field-initializers] Attached pa

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-05-23 Thread Lukas Slebodnik
On (22/05/14 17:08), Pavel Reichl wrote: >Sorry Lukas, but the patches do not apply to master. > rebased patches are attached. LS >From 39b216012c4bc8d17bb15802c240cc02ec8c06d9 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 28 Feb 2014 23:42:19 +0100 Subject: [PATCH 1/3] UTIL: Add func

Re: [SSSD] [PATCH] Implement org.freedesktop.DBus.Properties.GetAll for primitive types

2014-05-23 Thread Lukas Slebodnik
On (23/05/14 08:31), Lukas Slebodnik wrote: >On (21/05/14 22:53), Jakub Hrozek wrote: >>Hi, >> >>the attached patches implement the >>org.freedesktop.DBus.Properties.GetAll method for retrieving primitive >>types and their arrays. >> >>The patchset build on the previous set (currently still on revi