Re: [SSSD] [PATCH] Cherry-pick the InfoPipe patches to sssd-1-11

2014-06-02 Thread Jakub Hrozek
On Tue, Jun 03, 2014 at 08:40:11AM +0200, Lukas Slebodnik wrote: > On (02/06/14 18:36), Jakub Hrozek wrote: > >Hi, > > > >another cherry-pick mail, this time with the IFP responder. Only the > >first patch had to be amended in the conf_macros.m4 and confdb.h files. > > > > > You forgot to cherry-pi

Re: [SSSD] [PATCH] Cherry-pick the InfoPipe patches to sssd-1-11

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 18:36), Jakub Hrozek wrote: >Hi, > >another cherry-pick mail, this time with the IFP responder. Only the >first patch had to be amended in the conf_macros.m4 and confdb.h files. > > You forgot to cherry-pick patch commit 03fb48fdaa7ed95ecb38ecc43a6d221ff2cfd950 Author: Jakub Hrozek D

[SSSD] [PATCH] Amend a DEBUG message

2014-06-02 Thread Jakub Hrozek
Hi, the DEBUG message was confusing, we attempt to always store the SID, not only when ID-mapping. >From 450453eb541ca44ac7d6f67051457e5769c80b74 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 10 Mar 2014 11:08:41 +0100 Subject: [PATCH] LDAP: Fix DEBUG message --- src/providers/ldap/lda

[SSSD] [PATCH] MAN: Document that each provider type uses its own set of options

2014-06-02 Thread Jakub Hrozek
Please see the attached man page patch that addresses: https://fedorahosted.org/sssd/ticket/2281 >From 2e2253eca96b86db06bc93d3f63a6f6332372756 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Tue, 3 Jun 2014 08:14:12 +0200 Subject: [PATCH] MAN: Document that each provider type uses its own set o

Re: [SSSD] [PATCHES] CONFIGURE: Enhance detection of pam

2014-06-02 Thread Jakub Hrozek
On Tue, Jun 03, 2014 at 08:15:36AM +0200, Lukas Slebodnik wrote: > On (02/06/14 23:19), Sumit Bose wrote: > >On Sat, May 31, 2014 at 04:59:44PM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> I think that the attached patches are self descriptive. > >> > >> LS > > > >Patches apply and build fi

Re: [SSSD] [PATCHES] CONFIGURE: Enhance detection of pam

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 23:19), Sumit Bose wrote: >On Sat, May 31, 2014 at 04:59:44PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> I think that the attached patches are self descriptive. >> >> LS > >Patches apply and build fine. I've run build on a few platforms without >any issue, but I had none with openp

Re: [SSSD] New version of the libini_config section merge design

2014-06-02 Thread Dmitri Pal
On 06/02/2014 09:37 AM, Nikolai Kondrashov wrote: On 05/31/2014 04:45 AM, Dmitri Pal wrote: I reworked the design based on the feedback provided. It is a completely rewritten version. Please take a look. https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge I'm likely awfully

Re: [SSSD] [PATCHES] CONFIGURE: Enhance detection of pam

2014-06-02 Thread Sumit Bose
On Sat, May 31, 2014 at 04:59:44PM +0200, Lukas Slebodnik wrote: > ehlo, > > I think that the attached patches are self descriptive. > > LS Patches apply and build fine. I've run build on a few platforms without any issue, but I had none with openpam at hand. I only have one comment on the last

[SSSD] Please holler if you like your patch pushed to 1.11.6

2014-06-02 Thread Jakub Hrozek
Hi, I've sent the patches that I want to be included in 1.11.6 /and/ they need changes to the list already - that's the IFP cherry-pick and LDAP extension rebase. On top of those, the remaining patches we need for the IFP responder's functionality can be cleanly applied. The resulting branch is he

[SSSD] [PATCH] Backport extending the LDAP maps to 1.11

2014-06-02 Thread Jakub Hrozek
Hi, this time it's not a straight cherry-pick but a rebase, because starting with 1.10 the LDAP provider files were split bit differently. But the code itself is the same, just moved elsewhere. The attached patches also include fixes we found after we pushed the original patches. >From 7b9ad4d28e

[SSSD] [PATCH] Cherry-pick the sss_parse_inp request to sssd-1-11

2014-06-02 Thread Jakub Hrozek
Hi, this is another prerequisite to having the IFP responder in sssd-1-11. Only Makefile.am had to be changed. >From ae989d7793117078fa63e67c68eaade71ca38ad6 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 18 Apr 2014 14:58:57 +0200 Subject: [PATCH 1/3] TESTS: Create a default sss_names_ct

Re: [SSSD] [PATCH] TEST: Some macros aren't defined in older version of check.

2014-06-02 Thread Jakub Hrozek
On Fri, Apr 25, 2014 at 10:34:21AM +0200, Jakub Hrozek wrote: > On Thu, Apr 24, 2014 at 01:48:19PM +0200, Michal Židek wrote: > > On 04/24/2014 09:37 AM, Lukas Slebodnik wrote: > > >On (23/04/14 23:38), Michal Židek wrote: > > >>On 04/22/2014 09:55 AM, Lukas Slebodnik wrote: > > >>>ehlo, > > >>> >

Re: [SSSD] [sssd][pathces] MAN: nested group membership

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 11:49:59AM -0400, Stephen Gallagher wrote: > Ack Thanks for the review, pushed to master: 9fd8065663084acaf88e7fe10a52c60e9a2a5411 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/ma

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 06:42:05PM +0200, Jakub Hrozek wrote: > On Mon, Jun 02, 2014 at 05:16:05PM +0200, Lukas Slebodnik wrote: > > On (02/06/14 10:01), Jakub Hrozek wrote: > > >On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: > > >> On (01/06/14 19:23), Jakub Hrozek wrote: > > >>

Re: [SSSD] [PATCH] Cherry-pick Stef's sbus_request patches to sssd-1-11

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 06:27:53PM +0200, Lukas Slebodnik wrote: > On (02/06/14 17:39), Jakub Hrozek wrote: > >Hi, > > > >the attached patchset cherry-picks the sbus_request patches to > >sssd-1-11. As with the previous set I sent, I left the conflict messages > >in the commit headers. There were o

Re: [SSSD] [patches] SDAP: "ldap_group_nesting_level = 0" does not appear to work

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 03:15:33PM +0200, Jakub Hrozek wrote: > On Fri, May 30, 2014 at 02:52:50PM +0200, Pavel Reichl wrote: > > Thank you Jakub for comments. I proposed new version of text to man > > pages. I updated 2nd patch and generally speaking returned to solution > > which I proposed in 1s

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 05:16:05PM +0200, Lukas Slebodnik wrote: > On (02/06/14 10:01), Jakub Hrozek wrote: > >On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: > >> On (01/06/14 19:23), Jakub Hrozek wrote: > >> >On Wed, May 28, 2014 at 06:22:05PM +0200, Lukas Slebodnik wrote: > >> >

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 06:26:54PM +0200, Lukas Slebodnik wrote: > On (02/06/14 12:18), Simo Sorce wrote: > >On Mon, 2014-06-02 at 18:15 +0200, Jakub Hrozek wrote: > >> On Mon, Jun 02, 2014 at 12:01:14PM -0400, Simo Sorce wrote: > >> > > We have a ZERO_STRUCT call precisely for this reason. > >> >

[SSSD] [PATCH] Cherry-pick the InfoPipe patches to sssd-1-11

2014-06-02 Thread Jakub Hrozek
Hi, another cherry-pick mail, this time with the IFP responder. Only the first patch had to be amended in the conf_macros.m4 and confdb.h files. >From 1f5aef524fe51e572b882c744cb8b483b4aed38b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 2 Oct 2013 14:59:35 +0200 Subject: [PATCH 1/3] I

Re: [SSSD] [PATCH] Cherry-pick Stef's sbus_codegen to sssd-1-11

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 06:03:45PM +0200, Lukas Slebodnik wrote: > On (02/06/14 17:35), Jakub Hrozek wrote: > >Hi, > > > >attached are cherry-picked patches that implement Stef's sbus_codegen. > > > >Only the first patch in the series had to be rebased in a very trivial > >way: > > > >diff --cc Mak

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 18:27), Jakub Hrozek wrote: >On Mon, Jun 02, 2014 at 12:18:02PM -0400, Simo Sorce wrote: >> On Mon, 2014-06-02 at 18:15 +0200, Jakub Hrozek wrote: >> > On Mon, Jun 02, 2014 at 12:01:14PM -0400, Simo Sorce wrote: >> > > > We have a ZERO_STRUCT call precisely for this reason. >> > > >>

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 12:18:02PM -0400, Simo Sorce wrote: > On Mon, 2014-06-02 at 18:15 +0200, Jakub Hrozek wrote: > > On Mon, Jun 02, 2014 at 12:01:14PM -0400, Simo Sorce wrote: > > > > We have a ZERO_STRUCT call precisely for this reason. > > > > > > If it is on the stack, we can simply declar

Re: [SSSD] [PATCH] Cherry-pick Stef's sbus_request patches to sssd-1-11

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 17:39), Jakub Hrozek wrote: >Hi, > >the attached patchset cherry-picks the sbus_request patches to >sssd-1-11. As with the previous set I sent, I left the conflict messages >in the commit headers. There were only two conflicts, one in the >Makefile (tests again) and one trivial in #inc

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 12:18), Simo Sorce wrote: >On Mon, 2014-06-02 at 18:15 +0200, Jakub Hrozek wrote: >> On Mon, Jun 02, 2014 at 12:01:14PM -0400, Simo Sorce wrote: >> > > We have a ZERO_STRUCT call precisely for this reason. >> > >> > If it is on the stack, we can simply declare it with a C99 initialize

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Simo Sorce
On Mon, 2014-06-02 at 18:15 +0200, Jakub Hrozek wrote: > On Mon, Jun 02, 2014 at 12:01:14PM -0400, Simo Sorce wrote: > > > We have a ZERO_STRUCT call precisely for this reason. > > > > If it is on the stack, we can simply declare it with a C99 initializer > > of 0 ? > > Or is this structure reused

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 12:01:14PM -0400, Simo Sorce wrote: > > We have a ZERO_STRUCT call precisely for this reason. > > If it is on the stack, we can simply declare it with a C99 initializer > of 0 ? > Or is this structure reused (hence needs resetting) more than once ? > > Simo. btw both clan

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Simo Sorce
On Mon, 2014-06-02 at 18:06 +0200, Lukas Slebodnik wrote: > On (02/06/14 12:01), Simo Sorce wrote: > >On Mon, 2014-06-02 at 10:01 +0200, Jakub Hrozek wrote: > >> On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: > >> > On (01/06/14 19:23), Jakub Hrozek wrote: > >> > >On Wed, May 28,

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 12:01), Simo Sorce wrote: >On Mon, 2014-06-02 at 10:01 +0200, Jakub Hrozek wrote: >> On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: >> > On (01/06/14 19:23), Jakub Hrozek wrote: >> > >On Wed, May 28, 2014 at 06:22:05PM +0200, Lukas Slebodnik wrote: >> > >> On (27/05/1

Re: [SSSD] [PATCH] Cherry-pick Stef's sbus_codegen to sssd-1-11

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 17:35), Jakub Hrozek wrote: >Hi, > >attached are cherry-picked patches that implement Stef's sbus_codegen. > >Only the first patch in the series had to be rebased in a very trivial >way: > >diff --cc Makefile.am >index 8d92326,d7e6243..000 >--- a/Makefile.am >+++ b/Makefile.am >@@@

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Simo Sorce
On Mon, 2014-06-02 at 10:01 +0200, Jakub Hrozek wrote: > On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: > > On (01/06/14 19:23), Jakub Hrozek wrote: > > >On Wed, May 28, 2014 at 06:22:05PM +0200, Lukas Slebodnik wrote: > > >> On (27/05/14 16:32), Jakub Hrozek wrote: > > >> >On Tue

Re: [SSSD] [sssd][pathces] MAN: nested group membership

2014-06-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon 02 Jun 2014 09:13:32 AM EDT, Jakub Hrozek wrote: > On Mon, Jun 02, 2014 at 08:22:14AM -0400, Stephen Gallagher wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 06/01/2014 04:09 PM, Jakub Hrozek wrote: >>> On Fri, May 30, 2014

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 10:01), Jakub Hrozek wrote: >On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: >> On (01/06/14 19:23), Jakub Hrozek wrote: >> >On Wed, May 28, 2014 at 06:22:05PM +0200, Lukas Slebodnik wrote: >> >> On (27/05/14 16:32), Jakub Hrozek wrote: >> >> >On Tue, May 27, 2014 at 0

Re: [SSSD] RFC: Backporting the SBUS changes to 1.11

2014-06-02 Thread Jakub Hrozek
On Mon, May 12, 2014 at 10:24:22AM +0200, Jakub Hrozek wrote: > Hi, > > As you might have noticed already, we're pushing 1.11 and its AD related > improvements to older releases as well, including RHEL-6. These > platforms are supposed to be /stable/. > > I've been thinking about how exactly shou

Re: [SSSD] New version of the libini_config section merge design

2014-06-02 Thread Nikolai Kondrashov
On 05/31/2014 04:45 AM, Dmitri Pal wrote: I reworked the design based on the feedback provided. It is a completely rewritten version. Please take a look. https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge I'm likely awfully under-informed (I haven't seen any prior discussion

Re: [SSSD] [patches] SDAP: "ldap_group_nesting_level = 0" does not appear to work

2014-06-02 Thread Jakub Hrozek
On Fri, May 30, 2014 at 02:52:50PM +0200, Pavel Reichl wrote: > Thank you Jakub for comments. I proposed new version of text to man > pages. I updated 2nd patch and generally speaking returned to solution > which I proposed in 1st or 2nd iteration of this patches. But this time > I traded off code

Re: [SSSD] [sssd][pathces] MAN: nested group membership

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 08:22:14AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/01/2014 04:09 PM, Jakub Hrozek wrote: > > On Fri, May 30, 2014 at 06:04:01PM +0200, Pavel Reichl wrote: > >> OK, please see updated patch. PR > > > > Thank you, from cont

Re: [SSSD] [sssd][pathces] MAN: nested group membership

2014-06-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/01/2014 04:09 PM, Jakub Hrozek wrote: > On Fri, May 30, 2014 at 06:04:01PM +0200, Pavel Reichl wrote: >> OK, please see updated patch. PR > > Thank you, from content point of view, this looks correct to me. > > Can you please ping some native E

Re: [SSSD] [PATCH] TESTS: fgetc returns int, not char

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 12:27:34PM +0200, Lukas Slebodnik wrote: > On (02/06/14 11:03), Jakub Hrozek wrote: > >Hi, > > > >see attached patch. The bug was preventing SSSD from being built on ARM > >(reproduced on a Raspberri Pi, for example). > > >From 86f9acd3579c36fe4b198b8ec63b364620eee6e2 Mon S

Re: [SSSD] [PATCH] TESTS: fgetc returns int, not char

2014-06-02 Thread Lukas Slebodnik
On (02/06/14 11:03), Jakub Hrozek wrote: >Hi, > >see attached patch. The bug was preventing SSSD from being built on ARM >(reproduced on a Raspberri Pi, for example). >From 86f9acd3579c36fe4b198b8ec63b364620eee6e2 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 2 Jun 2014 10:59:46 +0200

Re: [SSSD] [PATCH] SDAP: bugfix - find primary group by GID

2014-06-02 Thread Jakub Hrozek
On Sun, Jun 01, 2014 at 09:41:51PM +0200, Jakub Hrozek wrote: > On Thu, May 29, 2014 at 01:47:10PM +0200, Pavel Reichl wrote: > > Hello, > > > > please see attached patch solving > > https://fedorahosted.org/sssd/ticket/2334 > > > > Patch applies to both master and 1.11. > > > > PR > > ACK. >

Re: [SSSD] [DESIGN] Allow Kerberos Principals in getpwnam() calls

2014-06-02 Thread Sumit Bose
On Mon, Jun 02, 2014 at 10:10:20AM +0200, Jakub Hrozek wrote: > On Fri, May 30, 2014 at 06:09:13PM +0200, Sumit Bose wrote: > > Hi, > > > > I have summarized a thread on this list and added some additional > > information on > > https://fedorahosted.org/sssd/wiki/DesignDocs/NSSWithKerberosPrincipa

[SSSD] [PATCH] TESTS: fgetc returns int, not char

2014-06-02 Thread Jakub Hrozek
Hi, see attached patch. The bug was preventing SSSD from being built on ARM (reproduced on a Raspberri Pi, for example). >From 86f9acd3579c36fe4b198b8ec63b364620eee6e2 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 2 Jun 2014 10:59:46 +0200 Subject: [PATCH] TESTS: fgetc returns int, not c

Re: [SSSD] [DESIGN] Allow Kerberos Principals in getpwnam() calls

2014-06-02 Thread Jakub Hrozek
On Fri, May 30, 2014 at 06:09:13PM +0200, Sumit Bose wrote: > Hi, > > I have summarized a thread on this list and added some additional > information on > https://fedorahosted.org/sssd/wiki/DesignDocs/NSSWithKerberosPrincipal > > For your convenience the text can be found below as well. Comments

Re: [SSSD] NSS: Add config option to expand homedir template format

2014-06-02 Thread Jakub Hrozek
On Mon, Jun 02, 2014 at 07:26:49AM +0200, Lukas Slebodnik wrote: > On (01/06/14 19:23), Jakub Hrozek wrote: > >On Wed, May 28, 2014 at 06:22:05PM +0200, Lukas Slebodnik wrote: > >> On (27/05/14 16:32), Jakub Hrozek wrote: > >> >On Tue, May 27, 2014 at 01:03:42PM +0200, Pavel Reichl wrote: > >> >> O