Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-14 Thread Noam Meltzer
On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek wrote: > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote: > > --- > > contrib/sssd.spec.in | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in > > index b5e7903..8d2f2be 10064

Re: [SSSD] [PATCH v3 1/4] NEW CLIENT: plugin for NFSv4 rpc.idmapd

2014-07-14 Thread Noam Meltzer
On Mon, Jul 14, 2014 at 7:25 PM, Jakub Hrozek wrote: > On Fri, Jun 27, 2014 at 09:44:35AM +0300, Noam Meltzer wrote: > > Implementation of design document: > > https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin > > I've got just one style nitpick and one question, I can fix it befo

Re: [SSSD] [PATCH v3 0/4] NFSv4 rpc.idmapd plugin

2014-07-14 Thread Noam Meltzer
On Mon, Jul 14, 2014 at 7:21 PM, Jakub Hrozek wrote: > On Fri, Jun 27, 2014 at 09:44:34AM +0300, Noam Meltzer wrote: > > Follow patches are the code implementing design document: > > https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin > > > > Changes compared to v2 of this patch: >

Re: [SSSD] [PATCH v3 3/4] NFSv4 client: add to build system

2014-07-14 Thread Jakub Hrozek
On Fri, Jun 27, 2014 at 09:44:37AM +0300, Noam Meltzer wrote: > --- > Makefile.am | 24 > configure.ac| 10 ++ > src/conf_macros.m4 | 30 ++ > src/external/libnfsidmap.m4 | 17 + >

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-14 Thread Jakub Hrozek
On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote: > --- > contrib/sssd.spec.in | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in > index b5e7903..8d2f2be 100644 > --- a/contrib/sssd.spec.in > +++ b/contrib/sssd.spec.in > @@ -13

Re: [SSSD] [PATCH v3 1/4] NEW CLIENT: plugin for NFSv4 rpc.idmapd

2014-07-14 Thread Jakub Hrozek
On Fri, Jun 27, 2014 at 09:44:35AM +0300, Noam Meltzer wrote: > Implementation of design document: > https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin I've got just one style nitpick and one question, I can fix it before pushing.. > --- > src/sss_client/nfs/sss_nfs_client.c | 571

Re: [SSSD] [PATCH v3 2/4] NFSv4 client: (private) headers from libnfsidmap

2014-07-14 Thread Jakub Hrozek
On Fri, Jun 27, 2014 at 09:44:36AM +0300, Noam Meltzer wrote: > The private headers are needed in order to: > nfsidmap_internal.h: > * definition of struct trans_func > * prototype for logger function > cfg.h + queue.h: > * prototype(s) for accessing rpc.idmpad configuration file ACK although I wi

Re: [SSSD] [PATCH v3 0/4] NFSv4 rpc.idmapd plugin

2014-07-14 Thread Jakub Hrozek
On Fri, Jun 27, 2014 at 09:44:34AM +0300, Noam Meltzer wrote: > Follow patches are the code implementing design document: > https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin > > Changes compared to v2 of this patch: > * rebase over rev. 8ca18752 (current master) > * remove man pa

Re: [SSSD] [PATCH] SDAP: augmented logging for group saving

2014-07-14 Thread Pavel Reichl
On Mon, 2014-04-28 at 13:55 +0200, Pavel Reichl wrote: > On Thu, 2014-04-17 at 17:30 +0200, Jakub Hrozek wrote: > > On Tue, Apr 15, 2014 at 04:25:50PM +0200, Pavel Reichl wrote: > > > Hello, > > > > > > some more generally useful logging messages are needed for that > > > bugzilla. > > > > > > Pa

Re: [SSSD] [PATCH] MAN: Document that each provider type uses its own set of options

2014-07-14 Thread Jakub Hrozek
On Wed, Jun 04, 2014 at 11:07:45AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/03/2014 02:21 AM, Jakub Hrozek wrote: > > Please see the attached man page patch that addresses: > > https://fedorahosted.org/sssd/ticket/2281 > > > > Looks good to me.

Re: [SSSD] [PATCH] MAN: local auth_provider is not documented in sssd.conf

2014-07-14 Thread Jakub Hrozek
On Mon, Jun 30, 2014 at 10:48:46AM +0200, Pavel Březina wrote: > On 06/27/2014 03:25 PM, Jakub Hrozek wrote: > >On Fri, Jun 27, 2014 at 03:17:11PM +0200, Pavel Reichl wrote: > >>On Fri, 2014-06-27 at 10:00 +0200, Jakub Hrozek wrote: > >>>Hi, > >>> > >>>attached is a simple man page patch, reported

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Jakub Hrozek
On Mon, Jul 14, 2014 at 02:16:13PM +0200, Pavel Reichl wrote: > Thanks, ACK to all three patches. Pushed to master: * 2be2220f15b2a819a80b07c8881822ef87053c69 * da6ee4b16f57d24f63c09efa74ead7f7cf315a55 * cb8c79278d23a5b1deb66ea4af37feebc7137fd0 ___ s

[SSSD] [PATCH] sudo: fetch sudoRunAs attribute

2014-07-14 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2212 From ed3093d513e54c377fcaf3234bc54e5143027da0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 14 Jul 2014 14:23:50 +0200 Subject: [PATCH] sudo: fetch sudoRunAs attribute This attribute was used in pre 1.7 versions of sudo and i

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Reichl
On Mon, 2014-07-14 at 12:15 +0200, Pavel Březina wrote: > On 07/14/2014 12:08 PM, Pavel Reichl wrote: > > On Mon, 2014-07-14 at 11:49 +0200, Pavel Březina wrote: > >> On 07/14/2014 11:40 AM, Pavel Reichl wrote: > >>> On Mon, 2014-07-14 at 10:59 +0200, Pavel Březina wrote: > On 07/14/2014 10:42

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Březina
On 07/14/2014 12:08 PM, Pavel Reichl wrote: On Mon, 2014-07-14 at 11:49 +0200, Pavel Březina wrote: On 07/14/2014 11:40 AM, Pavel Reichl wrote: On Mon, 2014-07-14 at 10:59 +0200, Pavel Březina wrote: On 07/14/2014 10:42 AM, Pavel Reichl wrote: On Thu, 2014-07-10 at 13:39 +0200, Pavel Březina

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Reichl
On Mon, 2014-07-14 at 11:49 +0200, Pavel Březina wrote: > On 07/14/2014 11:40 AM, Pavel Reichl wrote: > > On Mon, 2014-07-14 at 10:59 +0200, Pavel Březina wrote: > >> On 07/14/2014 10:42 AM, Pavel Reichl wrote: > >>> On Thu, 2014-07-10 at 13:39 +0200, Pavel Březina wrote: > >>> > >>> Hi, > >>> > >>

Re: [SSSD] [PATCH] Retry system bus connection once messagebus is up

2014-07-14 Thread Jakub Hrozek
On Tue, Jul 08, 2014 at 08:42:43PM +0200, Jakub Hrozek wrote: > The 1.11 version will be sent out separately. Here are the 1.11 patches. There are no functional differences, just some minor rebasing. >From 9a7d6addc4d735113f03fb508776d9e0e83ca828 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date:

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Březina
On 07/14/2014 11:40 AM, Pavel Reichl wrote: On Mon, 2014-07-14 at 10:59 +0200, Pavel Březina wrote: On 07/14/2014 10:42 AM, Pavel Reichl wrote: On Thu, 2014-07-10 at 13:39 +0200, Pavel Březina wrote: Hi, thanks for the unit test. Would you consider braking test into smaller part to make it p

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Reichl
On Mon, 2014-07-14 at 10:59 +0200, Pavel Březina wrote: > On 07/14/2014 10:42 AM, Pavel Reichl wrote: > > On Thu, 2014-07-10 at 13:39 +0200, Pavel Březina wrote: > > > > Hi, > > > > thanks for the unit test. > > > > Would you consider braking test into smaller part to make it possible to > > run it

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Březina
On 07/14/2014 10:42 AM, Pavel Reichl wrote: On Thu, 2014-07-10 at 13:39 +0200, Pavel Březina wrote: Hi, thanks for the unit test. Would you consider braking test into smaller part to make it possible to run it over different sets of test data? Different set of data is not necessary for this

Re: [SSSD] [PATCH] resolv: fix server sort by weight

2014-07-14 Thread Pavel Reichl
On Thu, 2014-07-10 at 13:39 +0200, Pavel Březina wrote: Hi, thanks for the unit test. Would you consider braking test into smaller part to make it possible to run it over different sets of test data? Please see comments inline. Thanks, Pavel R > +START_TEST(test_resolv_sort_srv_reply_zero_we