[SSSD] [PATCH] KRB5: add missing debug-to-stderr option to krb5_child

2014-07-18 Thread Sumit Bose
Hi, I just realized that krb5_child and gpo_child do not run in interactive mode anymore. These two patches should fix it. bye, Sumit From d7985be8725e4b580e2315f4744ed963e708ad81 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Fri, 18 Jul 2014 22:34:23 +0200 Subject: [PATCH 1/2] KRB5: add mis

[SSSD] [PATCH] UTIL: rename find_subdomain_by_sid

2014-07-18 Thread Pavel Reichl
Hello, please see attached patch which is result of discussion in thread: LDAP: tokengroups do not work with id_provider=ldap [snip] Anyhow, find_subdomain_by_sid is misnamed, we routinely use the function to find the primary domain. I think find_subdomain_by_sid() does what the name says and

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-18 Thread Lukas Slebodnik
On (18/07/14 16:34), Jakub Hrozek wrote: >On Thu, Jul 17, 2014 at 04:35:31PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> There is problem with OpenLDAP server and dereferencing of attributes >> that is not in the schema of the server? >> >> sh-4.2$ ldapsearch -x -LLL -h openldap.server.test -b

Re: [SSSD] [patch] Python 3 support for sssd

2014-07-18 Thread Bohuslav Kabrda
- Original Message - > On Fri, Jul 18, 2014 at 10:34:00AM -0400, Bohuslav Kabrda wrote: > > I'd highly appreciate if you could do the build changes yourself, I > > probably won't be able to get to any coding next week or two and I think > > it's better to get this merged and tested sooner t

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-18 Thread Lukas Slebodnik
On (18/07/14 17:07), Jakub Hrozek wrote: >On Fri, Jul 18, 2014 at 05:02:33PM +0200, Lukas Slebodnik wrote: >> On (15/07/14 17:28), Jakub Hrozek wrote: >> >On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote: >> >> On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek wrote: >> >> >> >> > On Fri,

Re: [SSSD] [PATCH] LDAP: tokengroups do not work with id_provider=ldap

2014-07-18 Thread Jakub Hrozek
On Thu, Jul 17, 2014 at 05:41:23PM +0200, Pavel Reichl wrote: > On Thu, 2014-07-17 at 07:59 +0200, Jakub Hrozek wrote: > > On 10 Jul 2014, at 16:38, Pavel Reichl wrote: > > > > > Hello, > > > > > > please see attached patches. > > > > > > I found out that if we go with approach introduced in p

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-18 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 05:02:33PM +0200, Lukas Slebodnik wrote: > On (15/07/14 17:28), Jakub Hrozek wrote: > >On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote: > >> On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek wrote: > >> > >> > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-18 Thread Lukas Slebodnik
On (15/07/14 17:28), Jakub Hrozek wrote: >On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote: >> On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek wrote: >> >> > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote: >> > > --- >> > > contrib/sssd.spec.in | 7 +++ >> > > 1 file

Re: [SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-18 Thread Lukas Slebodnik
On (18/07/14 16:23), Jakub Hrozek wrote: >On Fri, Jul 18, 2014 at 04:14:58PM +0200, Lukas Slebodnik wrote: >> On (18/07/14 15:52), Jakub Hrozek wrote: >> >Hi, >> > >> >I was trying to help a user who had problems with the AD provider and >> >realized I had hard time following what exact server are

Re: [SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-18 Thread Pavel Reichl
On 07/18/2014 04:23 PM, Jakub Hrozek wrote: Hi, I think it's always good to add more logs. Code LGTM so ACK++ + +ret = getnameinfo((struct sockaddr *) &ss, ss_len, + ip, sizeof(ip), NULL, 0, NI_NUMERICHOST); +ip[NI_MAXHOST-1] = '\0'; I was just wondering why to

Re: [SSSD] [patch] Python 3 support for sssd

2014-07-18 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 10:34:00AM -0400, Bohuslav Kabrda wrote: > - Original Message - > > On Fri, Jul 18, 2014 at 10:22:07AM -0400, Bohuslav Kabrda wrote: > > > - Original Message - > > > > One more question -- why do you see as preferable to select the python > > > > version we a

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-18 Thread Jakub Hrozek
On Thu, Jul 17, 2014 at 04:35:31PM +0200, Lukas Slebodnik wrote: > ehlo, > > There is problem with OpenLDAP server and dereferencing of attributes > that is not in the schema of the server? > > sh-4.2$ ldapsearch -x -LLL -h openldap.server.test -b 'dc=example,dc=com' \ >-E 'd

Re: [SSSD] [patch] Python 3 support for sssd

2014-07-18 Thread Bohuslav Kabrda
- Original Message - > On Fri, Jul 18, 2014 at 10:22:07AM -0400, Bohuslav Kabrda wrote: > > - Original Message - > > > One more question -- why do you see as preferable to select the python > > > version we are building for? With your patch, the code would run equally > > > well wit

Re: [SSSD] [patch] Python 3 support for sssd

2014-07-18 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 10:22:07AM -0400, Bohuslav Kabrda wrote: > - Original Message - > > On Wed, Jul 09, 2014 at 08:43:27AM -0400, Bohuslav Kabrda wrote: > > > So, there are basically two different approaches to this and I don't think > > > any of them is "the best". I do admit I prefer

Re: [SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-18 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 04:14:58PM +0200, Lukas Slebodnik wrote: > On (18/07/14 15:52), Jakub Hrozek wrote: > >Hi, > > > >I was trying to help a user who had problems with the AD provider and > >realized I had hard time following what exact server are we searching at > >the time and, because we hit

Re: [SSSD] [patch] Python 3 support for sssd

2014-07-18 Thread Bohuslav Kabrda
- Original Message - > On Wed, Jul 09, 2014 at 08:43:27AM -0400, Bohuslav Kabrda wrote: > > So, there are basically two different approaches to this and I don't think > > any of them is "the best". I do admit I prefer the second one though: > > 1) configure can be modified to accept an argu

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-18 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 05:11:31PM +0300, Noam Meltzer wrote: > > Actually, I think we should also add: > > Requires: libnfsidmap > > to the spec file. > > > > I agree. Can you do it while merging the code, or do you want me to send > PATCHv4? No need, I can do the change, this is a trivial f

Re: [SSSD] sss_client: thread safe initialisation of sss_nss_mc_get_ctx

2014-07-18 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 01:10:24PM +0200, Sumit Bose wrote: > ACK to 0001 and 0002. > > bye, > Sumit Thank you for the review! I agree with Lukas that client code should be checked thoroughly, so I'd like to ask Simo to take a look too, since he wrote most of this code. _

[SSSD] Fwd: [PATCH v3 0/4] NFSv4 rpc.idmapd plugin

2014-07-18 Thread Noam Meltzer
Sorry for the delay in reply. Had a few busy days. On Tue, Jul 15, 2014 at 7:15 PM, Jakub Hrozek wrote: > On Mon, Jul 14, 2014 at 09:58:11PM +0300, Noam Meltzer wrote: > > On Mon, Jul 14, 2014 at 7:21 PM, Jakub Hrozek > wrote: > > > > > On Fri, Jun 27, 2014 at 09:44:34AM +0300, Noam Meltzer wr

Re: [SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-18 Thread Lukas Slebodnik
On (18/07/14 15:52), Jakub Hrozek wrote: >Hi, > >I was trying to help a user who had problems with the AD provider and >realized I had hard time following what exact server are we searching at >the time and, because we hit a referral, where the referral pointed to. > >I wrote the two attached patch

Re: [SSSD] [PATCH v3 1/4] NEW CLIENT: plugin for NFSv4 rpc.idmapd

2014-07-18 Thread Noam Meltzer
On Tue, Jul 15, 2014 at 6:17 PM, Jakub Hrozek wrote: > On Mon, Jul 14, 2014 at 10:04:50PM +0300, Noam Meltzer wrote: > > On Mon, Jul 14, 2014 at 7:25 PM, Jakub Hrozek > wrote: > > > > > On Fri, Jun 27, 2014 at 09:44:35AM +0300, Noam Meltzer wrote: > > > > Implementation of design document: > > >

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-18 Thread Noam Meltzer
On Tue, Jul 15, 2014 at 6:28 PM, Jakub Hrozek wrote: > On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote: > > On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek > wrote: > > > > > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote: > > > > --- > > > > contrib/sssd.spec.in | 7 ++

Re: [SSSD] [PATCH v3 0/4] NFSv4 rpc.idmapd plugin

2014-07-18 Thread Noam Meltzer
On Tue, Jul 15, 2014 at 8:21 PM, Jakub Hrozek wrote: > On Tue, Jul 15, 2014 at 06:15:43PM +0200, Jakub Hrozek wrote: > > > How to test: > > > libnfsidmap.git comes with a small C code named "libtest.c" which > allows > > > you to directly test the various function from 'struct trans_func'. > > >

Re: [SSSD] [patch] Python 3 support for sssd

2014-07-18 Thread Jakub Hrozek
On Wed, Jul 09, 2014 at 08:43:27AM -0400, Bohuslav Kabrda wrote: > - Original Message - > > On Tue, Jul 08, 2014 at 10:38:00AM -0400, Bohuslav Kabrda wrote: > > > Some comments: > > > - The patch tries to maintain backward compatibility for Python 2.6 and > > > 2.7 > > > - I admit I only t

[SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-18 Thread Jakub Hrozek
Hi, I was trying to help a user who had problems with the AD provider and realized I had hard time following what exact server are we searching at the time and, because we hit a referral, where the referral pointed to. I wrote the two attached patches. I'm OK with keeping them in my local tree, b

Re: [SSSD] [PATCHES] sss_case = preserving

2014-07-18 Thread Pavel Reichl
Thanks for the quick update, I have some more concerns and questions about the patches. 1st patch: +int confdb_set_string(struct confdb_ctx *cdb, + const char *section, + const char *attribute, + char *val) +{ [snip] +lret =

[SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-18 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2385 From e0b3434fa61802610e7649596ea35463018258bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Thu, 3 Jul 2014 12:45:43 +0200 Subject: [PATCH 1/2] ad: continue on ENOENT when id mapping is disabled When ID mapping is disabled and tok

Re: [SSSD] sss_client: thread safe initialisation of sss_nss_mc_get_ctx

2014-07-18 Thread Sumit Bose
On Wed, Jul 16, 2014 at 03:56:52PM +0200, Lukas Slebodnik wrote: > On (16/07/14 14:02), Sumit Bose wrote: > >On Wed, Jul 16, 2014 at 11:32:53AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> attached patches fix problems with mmap cache in client code. > >> The 1st patch is at least 5th versio

Re: [SSSD] [PATCH] AD-GPO: Store policy settings in local files

2014-07-18 Thread Sumit Bose
On Sun, Jul 06, 2014 at 06:15:28AM -0400, Yassir Elley wrote: > Hi, > > The attached patch implements a workflow change in which policy settings > retrieved by the gpo_child are stored in local files under the > /var/lib/sss/gpo_cache directory (where the full path is based on the gpo's > modif