Re: [SSSD] [PATCH] SDAP: remove duplicated code

2014-07-21 Thread Pavel Reichl
On 07/21/2014 11:57 PM, Lukas Slebodnik wrote: On (21/07/14 22:13), Pavel Reichl wrote: Hello, please see attached trivial patch. Thanks, Pavel Reichl >From 649762a6433066464ae22fe8a3399f0fe4b0d24c Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Mon, 21 Jul 2014 21:01:56 +0100 Subject:

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread William
> >William, can you help us test the patch? I have tested this patch version now, and can confirm that it works as expected. -- William ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/s

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread William
On Mon, 2014-07-21 at 17:15 +0200, Jakub Hrozek wrote: > On Mon, Jul 21, 2014 at 11:35:31PM +0930, William wrote: > > > > > > > On 21 Jul 2014, at 21:42, Lukas Slebodnik wrote: > > > > > >> On (21/07/14 14:08), Jakub Hrozek wrote: > > >>> On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta w

Re: [SSSD] [PATCH] SDAP: remove duplicated code

2014-07-21 Thread Lukas Slebodnik
On (21/07/14 22:13), Pavel Reichl wrote: >Hello, > >please see attached trivial patch. > >Thanks, > >Pavel Reichl >From 649762a6433066464ae22fe8a3399f0fe4b0d24c Mon Sep 17 00:00:00 2001 >From: Pavel Reichl >Date: Mon, 21 Jul 2014 21:01:56 +0100 >Subject: [PATCH] SDAP: remove duplicated code > >Bo

[SSSD] [PATCH] SDAP: remove duplicated code

2014-07-21 Thread Pavel Reichl
Hello, please see attached trivial patch. Thanks, Pavel Reichl >From 649762a6433066464ae22fe8a3399f0fe4b0d24c Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Mon, 21 Jul 2014 21:01:56 +0100 Subject: [PATCH] SDAP: remove duplicated code Body of functions sdap_x_deref_search_done(), sdap_asq_

Re: [SSSD] [PATCH] AD: Cache gpo version; only download policy files if version changes

2014-07-21 Thread Jakub Hrozek
On Sun, Jul 20, 2014 at 05:48:45PM -0400, Yassir Elley wrote: > Hi, > > The attached patch adds support for gpo version checking and for conditional > downloading of policy files. In order to get that to work, this patch also > replaces the deprecated smb functions (e.g. smbc_open, smbc_read, et

Re: [SSSD] [PATCHES] sss_case = preserving

2014-07-21 Thread Michal Židek
On 07/21/2014 05:54 PM, Michal Židek wrote: On 07/18/2014 03:41 PM, Pavel Reichl wrote: Thanks for the quick update, I have some more concerns and questions about the patches. 1st patch: +int confdb_set_string(struct confdb_ctx *cdb, + const char *section, +

Re: [SSSD] [PATCHES] sss_case = preserving

2014-07-21 Thread Michal Židek
On 07/18/2014 03:41 PM, Pavel Reichl wrote: Thanks for the quick update, I have some more concerns and questions about the patches. 1st patch: +int confdb_set_string(struct confdb_ctx *cdb, + const char *section, + const char *attribute, +

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 11:10:02AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/20/2014 03:20 PM, Jakub Hrozek wrote: > > On Fri, Jul 18, 2014 at 05:32:09PM +0200, Lukas Slebodnik wrote: > >> On (18/07/14 16:34), Jakub Hrozek wrote: > >>> On Thu, Jul

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 11:35:31PM +0930, William wrote: > > > > On 21 Jul 2014, at 21:42, Lukas Slebodnik wrote: > > > >> On (21/07/14 14:08), Jakub Hrozek wrote: > >>> On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: > On 18.7.2014 06:41, William wrote: > > >> Igno

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-21 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/20/2014 03:20 PM, Jakub Hrozek wrote: > On Fri, Jul 18, 2014 at 05:32:09PM +0200, Lukas Slebodnik wrote: >> On (18/07/14 16:34), Jakub Hrozek wrote: >>> On Thu, Jul 17, 2014 at 04:35:31PM +0200, Lukas Slebodnik >>> wrote: ehlo, Th

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread William
> On 21 Jul 2014, at 21:42, Lukas Slebodnik wrote: > >> On (21/07/14 14:08), Jakub Hrozek wrote: >>> On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: >> Ignore that last patch, I messed up and didn't include a .h file. Here >> i

Re: [SSSD] [PATCH] UTIL: rename find_subdomain_by_sid

2014-07-21 Thread Pavel Reichl
On 07/21/2014 12:03 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 09:30:06AM +0200, Pavel Reichl wrote: On 07/20/2014 10:06 PM, Jakub Hrozek wrote: On Sun, Jul 20, 2014 at 09:49:46PM +0200, Jakub Hrozek wrote: ACK I take the ack back :-) Can you rebase on top of the tokengroups fix patche

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Lukas Slebodnik
On (21/07/14 14:08), Jakub Hrozek wrote: >On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: >> On 18.7.2014 06:41, William wrote: >> > >> >>>Ignore that last patch, I messed up and didn't include a .h file. Here >> >>>is the fixed patch. >> >> >> >>This new patch seems to be based on so

Re: [SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-21 Thread Pavel Březina
On 07/21/2014 12:07 PM, Jakub Hrozek wrote: On Fri, Jul 18, 2014 at 01:15:25PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2385 The code looks good, but needs to be rebased on top of PavelR's patches I just pushed (sorry, first comes, first served..) The problem is that

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: > On 18.7.2014 06:41, William wrote: > > > >>>Ignore that last patch, I messed up and didn't include a .h file. Here > >>>is the fixed patch. > >> > >>This new patch seems to be based on some older version of the patch, it > >>uses wrong

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Jan Cholasta
On 18.7.2014 06:41, William wrote: Ignore that last patch, I messed up and didn't include a .h file. Here is the fixed patch. This new patch seems to be based on some older version of the patch, it uses wrong option name, sysdb_update_ssh_host still has the confdb argument, etc. Fixed, and

Re: [SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 10:42:05AM +0200, Pavel Březina wrote: > >>+if (!(debug_level & SSSDBG_TRACE_INTERNAL)) { > >^ > >type of this expression is integer and not boolean :-) > > We have DEBUG_IS_SET macro for this type of tests. OK, I

Re: [SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-21 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 01:15:25PM +0200, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/2385 The code looks good, but needs to be rebased on top of PavelR's patches I just pushed (sorry, first comes, first served..) ___ sssd-devel mailing l

Re: [SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

2014-07-21 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 05:20:31PM +0200, Lukas Slebodnik wrote: > On (18/07/14 17:07), Jakub Hrozek wrote: > >On Fri, Jul 18, 2014 at 05:02:33PM +0200, Lukas Slebodnik wrote: > >> On (15/07/14 17:28), Jakub Hrozek wrote: > >> >On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote: > >> >> O

Re: [SSSD] [PATCH] UTIL: rename find_subdomain_by_sid

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 09:30:06AM +0200, Pavel Reichl wrote: > > On 07/20/2014 10:06 PM, Jakub Hrozek wrote: > >On Sun, Jul 20, 2014 at 09:49:46PM +0200, Jakub Hrozek wrote: > >>ACK > >I take the ack back :-) > > > >Can you rebase on top of the tokengroups fix patches? > > Sure, and I also added

Re: [SSSD] [PATCH] ad_handle_acct_info_step: fix typo

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 11:23:43AM +0200, Jakub Hrozek wrote: > On Mon, Jul 21, 2014 at 11:18:07AM +0200, Pavel Březina wrote: > > Hi, > > small patch that fixes an issue I found while debugging something else. > > ACK * master: 594b76cd86e32164a22172e054750fe18d09b0d6 ___

Re: [SSSD] [PATCH] LDAP: tokengroups do not work with id_provider=ldap

2014-07-21 Thread Jakub Hrozek
On Fri, Jul 18, 2014 at 05:10:53PM +0200, Jakub Hrozek wrote: > > Sure, attached patches address your and Lukas' comments. > > They indeed do, ACK master: * 1614e1b25a98ff2f03648c4bf61d750fb688285a * b12e2500237f33c44807d7e5b377ec06007c7252 sssd-1-11: * 5001bab712149a27ab37697d487b3f5

Re: [SSSD] [PATCH] ad_handle_acct_info_step: fix typo

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 11:18:07AM +0200, Pavel Březina wrote: > Hi, > small patch that fixes an issue I found while debugging something else. ACK ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listin

[SSSD] [PATCH] ad_handle_acct_info_step: fix typo

2014-07-21 Thread Pavel Březina
Hi, small patch that fixes an issue I found while debugging something else. From e55fc01a51586211511534c1ea227272f69e85ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 21 Jul 2014 11:09:48 +0200 Subject: [PATCH] ad_handle_acct_info_step: fix typo --- src/providers/a

Re: [SSSD] [PATCH] Two patches with more debugging for the LDAP provider

2014-07-21 Thread Pavel Březina
On 07/18/2014 04:52 PM, Lukas Slebodnik wrote: On (18/07/14 16:23), Jakub Hrozek wrote: On Fri, Jul 18, 2014 at 04:14:58PM +0200, Lukas Slebodnik wrote: On (18/07/14 15:52), Jakub Hrozek wrote: Hi, I was trying to help a user who had problems with the AD provider and realized I had hard time

Re: [SSSD] [PATCH] UTIL: rename find_subdomain_by_sid

2014-07-21 Thread Pavel Reichl
On 07/20/2014 10:06 PM, Jakub Hrozek wrote: On Sun, Jul 20, 2014 at 09:49:46PM +0200, Jakub Hrozek wrote: ACK I take the ack back :-) Can you rebase on top of the tokengroups fix patches? Sure, and I also added patch for renaming find_subdomain_by_name as I think same reasons for renaming