Re: [SSSD] [PATCH] AD: Increment som_index when advancing to the next GPO

2014-07-25 Thread Yassir Elley
- Original Message - > Hi, > > I found this small GPO bug when testing Yassir's patches. > > ___ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > Looks good to me.

Re: [SSSD] [PATCH] NSS: replace with space with specified character in names.

2014-07-25 Thread Michal Židek
On 07/25/2014 04:58 PM, Lukas Slebodnik wrote: On (25/07/14 15:15), Michal Židek wrote: On 07/25/2014 01:42 PM, Lukas Slebodnik wrote: On (24/07/14 17:53), Michal Židek wrote: On 07/24/2014 11:28 AM, Lukas Slebodnik wrote: ehlo, This patch add possibility to replace whitespace in user and gr

Re: [SSSD] [PATCH] AD: Check return value of ad_gpo_evaluate_dacl

2014-07-25 Thread Pavel Reichl
ACK On 07/25/2014 05:57 PM, Jakub Hrozek wrote: Another small GPO-related patch. This time, it's mostly cosmetic, because ad_gpo_evaluate_dacl() can currently only return EOK, but we should be future-proof. ___ sssd-devel mailing list sssd-devel@list

[SSSD] [PATCH] AD: Check return value of ad_gpo_evaluate_dacl

2014-07-25 Thread Jakub Hrozek
Another small GPO-related patch. This time, it's mostly cosmetic, because ad_gpo_evaluate_dacl() can currently only return EOK, but we should be future-proof. >From 4954d897c916e0c81ee0cf31fe969ee0dd85dc99 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 25 Jul 2014 17:55:33 +0200 Subject: [

[SSSD] [PATCH] AD: Increment som_index when advancing to the next GPO

2014-07-25 Thread Jakub Hrozek
Hi, I found this small GPO bug when testing Yassir's patches. >From f40acbdf00eeb6a7e06b589cbe43be5e6af0de10 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 25 Jul 2014 17:39:54 +0200 Subject: [PATCH] AD: Increment som_index when advancing to the next GPO When the GPO processing tried to

Re: [SSSD] [PATCH] NSS: replace with space with specified character in names.

2014-07-25 Thread Lukas Slebodnik
On (25/07/14 15:15), Michal Židek wrote: >On 07/25/2014 01:42 PM, Lukas Slebodnik wrote: >>On (24/07/14 17:53), Michal Židek wrote: >>>On 07/24/2014 11:28 AM, Lukas Slebodnik wrote: ehlo, This patch add possibility to replace whitespace in user and group names with a specified

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-25 Thread Jakub Hrozek
On Fri, Jul 25, 2014 at 02:55:51PM +0200, Jakub Hrozek wrote: > ACK to these three. > > We can also push the IPA patches on top of these but it's OK to do it > after you're back from vacation, those patches do just cleanup, these > three fix a bug. * master: dfb2960ab251f609466fa660449703835c

Re: [SSSD] [PATCH] NSS: replace with space with specified character in names.

2014-07-25 Thread Michal Židek
On 07/25/2014 01:42 PM, Lukas Slebodnik wrote: On (24/07/14 17:53), Michal Židek wrote: On 07/24/2014 11:28 AM, Lukas Slebodnik wrote: ehlo, This patch add possibility to replace whitespace in user and group names with a specified string. With string "-", sssd will return the same result as wi

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-25 Thread Jakub Hrozek
On Fri, Jul 25, 2014 at 02:33:24PM +0200, Lukas Slebodnik wrote: > On (25/07/14 10:40), Jakub Hrozek wrote: > >On Tue, Jul 22, 2014 at 01:28:17PM +0200, Lukas Slebodnik wrote: > >> On (21/07/14 11:10), Stephen Gallagher wrote: > >> >On 07/20/2014 03:20 PM, Jakub Hrozek wrote: > >> >> On Fri, Jul 18

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-25 Thread Lukas Slebodnik
On (25/07/14 10:40), Jakub Hrozek wrote: >On Tue, Jul 22, 2014 at 01:28:17PM +0200, Lukas Slebodnik wrote: >> On (21/07/14 11:10), Stephen Gallagher wrote: >> >On 07/20/2014 03:20 PM, Jakub Hrozek wrote: >> >> On Fri, Jul 18, 2014 at 05:32:09PM +0200, Lukas Slebodnik wrote: >> >>> On (18/07/14 16:3

Re: [SSSD] [PATCH] NSS: replace with space with specified character in names.

2014-07-25 Thread Lukas Slebodnik
On (24/07/14 17:53), Michal Židek wrote: >On 07/24/2014 11:28 AM, Lukas Slebodnik wrote: >>ehlo, >> >>This patch add possibility to replace whitespace in user and group names with >>a specified string. With string "-", sssd will return the same result as >>winbind enabled option "winbind normalize

Re: [SSSD] [PATCH] NSS: replace with space with specified character in names.

2014-07-25 Thread Jakub Hrozek
On Fri, Jul 25, 2014 at 10:51:27AM +0200, Pavel Reichl wrote: > >>+tmp_ctx = talloc_new(mem_ctx); > Is there any difference in creation of tmp_ctx on NULL and on mem_ctx int > this case? I guess as long as you steal result from tmp_ctx and then free > tmp_ctx it doesn't really matter, right?

Re: [SSSD] [PATCH] NSS: replace with space with specified character in names.

2014-07-25 Thread Pavel Reichl
Just a few more questions. On 07/25/2014 08:40 AM, Pavel Reichl wrote: Hello Lukas, just some nitpicks. Please see inline. Thanks! On 07/24/2014 11:28 AM, Lukas Slebodnik wrote: ehlo, This patch add possibility to replace whitespace in user and group names with a specified string. With strin

Re: [SSSD] [PATCH] ldap_opts: Get rid on 389ds specific values in rfc2307bis schema

2014-07-25 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 01:28:17PM +0200, Lukas Slebodnik wrote: > On (21/07/14 11:10), Stephen Gallagher wrote: > >On 07/20/2014 03:20 PM, Jakub Hrozek wrote: > >> On Fri, Jul 18, 2014 at 05:32:09PM +0200, Lukas Slebodnik wrote: > >>> On (18/07/14 16:34), Jakub Hrozek wrote: > On Thu, Jul 17,