Re: [SSSD] should ad-gpo support additional logon rights?

2014-08-26 Thread Yassir Elley
- Original Message - > > > - Original Message - > > > > > > - Original Message - > > > On Mon, Aug 11, 2014 at 04:17:51PM -0400, Yassir Elley wrote: > > > > > > > > > > > > - Original Message - > > > > > On Mon, Aug 11, 2014 at 03:44:34PM -0400, Simo Sorce wr

Re: [SSSD] should ad-gpo support additional logon rights?

2014-08-26 Thread Yassir Elley
- Original Message - > > > - Original Message - > > On Mon, Aug 11, 2014 at 04:17:51PM -0400, Yassir Elley wrote: > > > > > > > > > - Original Message - > > > > On Mon, Aug 11, 2014 at 03:44:34PM -0400, Simo Sorce wrote: > > > > > On Mon, 2014-08-11 at 21:06 +0200, Jak

Re: [SSSD] [PATCHES] check return value

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 05:43:16PM +0200, Pavel Reichl wrote: > >>>If you have time to convert the debug messages, then by all means, send > >>>a patch. Maybe this could be a nice intern task? :-) > >What about this patch? > > > >LS > Your patch definitely fixes clang warning. I studied the patch a

Re: [SSSD] [PATCH] SDAP: Update groups for user just once.

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 05:19:02PM +0200, Jakub Hrozek wrote: > On Tue, Aug 26, 2014 at 04:43:17PM +0200, Lukas Slebodnik wrote: > > On (26/08/14 15:35), Jakub Hrozek wrote: > > >On Mon, Aug 25, 2014 at 06:21:22PM +0200, Lukas Slebodnik wrote: > > >> ehlo, > > >> > > >> attached two patches should

Re: [SSSD] [PATCHES] check return value

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 05:43:16PM +0200, Pavel Reichl wrote: > Your patch definitely fixes clang warning. I studied the patch and nearby > code and it seems to me that we are not breaking anything. > > It would be great to refactor this function soon as I personally find it > really hard to under

Re: [SSSD] [PATCH] Replace space: add some checks

2014-08-26 Thread Sumit Bose
On Tue, Aug 26, 2014 at 03:56:50PM +0200, Jakub Hrozek wrote: > On Mon, Aug 25, 2014 at 06:27:01PM +0200, Sumit Bose wrote: > > Hi, > > > > this patch adds some additional checks to the logic or replacing space > > with a different character. The idea is to not replace the space if we > > might ru

[SSSD] [PATCH] sss_log: fix handling of variable argument lists

2014-08-26 Thread Sumit Bose
Hi, this patch fixes a issue with sss_log() which was introduced recently and I think is only in master. So far I only tested it with syslog, if would be nice if someone can test the journald code path as well. bye, Sumit From cb4a1788cc8d4fd4251de2ee83ff760b740a68d6 Mon Sep 17 00:00:00 2001 From

Re: [SSSD] [PATCHES] check return value

2014-08-26 Thread Pavel Reichl
On 08/26/2014 01:41 PM, Lukas Slebodnik wrote: On (10/04/14 15:05), Lukas Slebodnik wrote: On (10/04/14 14:10), Jakub Hrozek wrote: On Thu, Apr 10, 2014 at 01:44:08PM +0200, Lukas Slebodnik wrote: On (10/04/14 12:11), Pavel Reichl wrote: On Thu, 2014-04-10 at 11:11 +0200, Sumit Bose wrote:

Re: [SSSD] [PATCHES] check return value

2014-08-26 Thread Lukas Slebodnik
On (26/08/14 13:41), Lukas Slebodnik wrote: >On (10/04/14 15:05), Lukas Slebodnik wrote: >>On (10/04/14 14:10), Jakub Hrozek wrote: >>>On Thu, Apr 10, 2014 at 01:44:08PM +0200, Lukas Slebodnik wrote: On (10/04/14 12:11), Pavel Reichl wrote: >On Thu, 2014-04-10 at 11:11 +0200, Sumit Bose w

Re: [SSSD] [PATCH] SDAP: Update groups for user just once.

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 04:43:17PM +0200, Lukas Slebodnik wrote: > On (26/08/14 15:35), Jakub Hrozek wrote: > >On Mon, Aug 25, 2014 at 06:21:22PM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> attached two patches should fix problem with resolving groups > >> from AD child domain. https://fedo

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 03:28:02PM +0200, Sumit Bose wrote: > On Tue, Aug 26, 2014 at 02:50:20PM +0200, Jakub Hrozek wrote: > > On Tue, Aug 26, 2014 at 02:21:00PM +0200, Sumit Bose wrote: > > > > > This is working as expected, but using krb5_cc_new_unique() and > > > > > krb5_cc_get_name() from lib

Re: [SSSD] [PATCH] SDAP: Update groups for user just once.

2014-08-26 Thread Lukas Slebodnik
On (26/08/14 15:35), Jakub Hrozek wrote: >On Mon, Aug 25, 2014 at 06:21:22PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> attached two patches should fix problem with resolving groups >> from AD child domain. https://fedorahosted.org/sssd/ticket/2407 >> It was caused by change in commit 983983dd16

Re: [SSSD] [PATCH] LDAP: Don't add a user member twice when adding a primary group

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 03:20:01PM +0200, Pavel Reichl wrote: > ACK, thanks. * master: 5e195ddf368b705f674ece2faf64261f66e20c23 bb755dcacd126adad8c60e8cbea11566de67affe * sssd-1-11: 25ff0ec25c40c967e4df7a2b2b3e8ad930218cb5 2d1e4d2bb90c40dd16c68b71c69c9e46f428a3f6 __

Re: [SSSD] [PATCH] Replace space: add some checks

2014-08-26 Thread Jakub Hrozek
On Mon, Aug 25, 2014 at 06:27:01PM +0200, Sumit Bose wrote: > Hi, > > this patch adds some additional checks to the logic or replacing space > with a different character. The idea is to not replace the space if we > might run into trouble with the modified name and log an error. > > As mentioned

Re: [SSSD] [PATCH] SDAP: Update groups for user just once.

2014-08-26 Thread Jakub Hrozek
On Mon, Aug 25, 2014 at 06:21:22PM +0200, Lukas Slebodnik wrote: > ehlo, > > attached two patches should fix problem with resolving groups > from AD child domain. https://fedorahosted.org/sssd/ticket/2407 > It was caused by change in commit 983983dd1629ab33eab340a40d9ee83965a339c6 > > LS > From

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Sumit Bose
On Tue, Aug 26, 2014 at 02:50:20PM +0200, Jakub Hrozek wrote: > On Tue, Aug 26, 2014 at 02:21:00PM +0200, Sumit Bose wrote: > > > > This is working as expected, but using krb5_cc_new_unique() and > > > > krb5_cc_get_name() from libkrb5 might even result in more simple code? > > > > > > In theory y

Re: [SSSD] [PATCH] LDAP: Don't add a user member twice when adding a primary group

2014-08-26 Thread Pavel Reichl
ACK, thanks. On 08/26/2014 02:54 PM, Jakub Hrozek wrote: On Tue, Aug 26, 2014 at 02:01:07PM +0200, Pavel Reichl wrote: On 08/26/2014 11:37 AM, Jakub Hrozek wrote: On Mon, Aug 25, 2014 at 08:18:15PM +0200, Pavel Reichl wrote: On 08/25/2014 06:21 PM, Jakub Hrozek wrote: On Mon, Aug 25, 2014 at

Re: [SSSD] [PATCH] LDAP: Don't add a user member twice when adding a primary group

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 02:01:07PM +0200, Pavel Reichl wrote: > > On 08/26/2014 11:37 AM, Jakub Hrozek wrote: > >On Mon, Aug 25, 2014 at 08:18:15PM +0200, Pavel Reichl wrote: > >>On 08/25/2014 06:21 PM, Jakub Hrozek wrote: > >>>On Mon, Aug 25, 2014 at 05:23:44PM +0200, Pavel Reichl wrote: > He

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 02:21:00PM +0200, Sumit Bose wrote: > > > This is working as expected, but using krb5_cc_new_unique() and > > > krb5_cc_get_name() from libkrb5 might even result in more simple code? > > > > In theory yes, I have a patch that I tested already: > > > > https://fedorapeo

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Sumit Bose
On Tue, Aug 26, 2014 at 01:45:11PM +0200, Jakub Hrozek wrote: > On Tue, Aug 26, 2014 at 12:06:53PM +0200, Sumit Bose wrote: > > On Tue, Aug 26, 2014 at 10:46:59AM +0200, Jakub Hrozek wrote: > > > On Fri, Aug 22, 2014 at 05:24:46PM +0200, Jakub Hrozek wrote: > > > > On Fri, Aug 22, 2014 at 05:21:11P

Re: [SSSD] Atomic |rename()| ... / was: Re: [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 07:05:17AM -0400, Roland Mainz wrote: > > I like your approach better and do not expect any issues since rename() > > is expected to be atomic. > > > > Please find comments below. > > Erm... |rename(src, dest)| with |src| and |dest| in the same directory can be > consider

Re: [SSSD] [PATCH] LDAP: Don't add a user member twice when adding a primary group

2014-08-26 Thread Pavel Reichl
On 08/26/2014 11:37 AM, Jakub Hrozek wrote: On Mon, Aug 25, 2014 at 08:18:15PM +0200, Pavel Reichl wrote: On 08/25/2014 06:21 PM, Jakub Hrozek wrote: On Mon, Aug 25, 2014 at 05:23:44PM +0200, Pavel Reichl wrote: Hello, I tested the patch and it fixes the problem described in the ticket. I p

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Jakub Hrozek
On Tue, Aug 26, 2014 at 12:06:53PM +0200, Sumit Bose wrote: > On Tue, Aug 26, 2014 at 10:46:59AM +0200, Jakub Hrozek wrote: > > On Fri, Aug 22, 2014 at 05:24:46PM +0200, Jakub Hrozek wrote: > > > On Fri, Aug 22, 2014 at 05:21:11PM +0200, Pavel Březina wrote: > > > > 2) the ccache name is stored in

Re: [SSSD] [PATCHES] check return value

2014-08-26 Thread Lukas Slebodnik
On (10/04/14 15:05), Lukas Slebodnik wrote: >On (10/04/14 14:10), Jakub Hrozek wrote: >>On Thu, Apr 10, 2014 at 01:44:08PM +0200, Lukas Slebodnik wrote: >>> On (10/04/14 12:11), Pavel Reichl wrote: >>> >On Thu, 2014-04-10 at 11:11 +0200, Sumit Bose wrote: >>> >> On Thu, Apr 10, 2014 at 10:34:10AM +

[SSSD] Atomic |rename()| ... / was: Re: [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Roland Mainz
- Original Message - > From: "Sumit Bose" > To: sssd-devel@lists.fedorahosted.org > Sent: Tuesday, August 26, 2014 12:06:53 PM > Subject: Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410 > > On Tue, Aug 26, 2014 at 10:46:59AM +0200, Jakub Hrozek wrote: > > On Fri, Aug 22, 20

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Sumit Bose
On Tue, Aug 26, 2014 at 10:46:59AM +0200, Jakub Hrozek wrote: > On Fri, Aug 22, 2014 at 05:24:46PM +0200, Jakub Hrozek wrote: > > On Fri, Aug 22, 2014 at 05:21:11PM +0200, Pavel Březina wrote: > > > 2) the ccache name is stored in KRB5CCACHE (or something like that) > > > environment variable so ac

Re: [SSSD] [PATCH] LDAP: Don't add a user member twice when adding a primary group

2014-08-26 Thread Jakub Hrozek
On Mon, Aug 25, 2014 at 08:18:15PM +0200, Pavel Reichl wrote: > > On 08/25/2014 06:21 PM, Jakub Hrozek wrote: > >On Mon, Aug 25, 2014 at 05:23:44PM +0200, Pavel Reichl wrote: > >>Hello, > >> > >>I tested the patch and it fixes the problem described in the ticket. > >> > >>I personally dislike the

Re: [SSSD] [PATCHES] PAM, NSS: allow UPN login names

2014-08-26 Thread Sumit Bose
On Thu, Jul 24, 2014 at 03:42:38PM +0200, Pavel Březina wrote: > On 07/22/2014 09:47 PM, Sumit Bose wrote: > >On Tue, Jul 22, 2014 at 05:55:21PM +0200, Pavel Březina wrote: > >>On 07/22/2014 01:27 PM, Sumit Bose wrote: > >>>Hi, > >>> > >>>this series of patches should solve > >>>https://fedorahoste

Re: [SSSD] [PATCH] https://fedorahosted.org/sssd/ticket/2410

2014-08-26 Thread Jakub Hrozek
On Fri, Aug 22, 2014 at 05:24:46PM +0200, Jakub Hrozek wrote: > On Fri, Aug 22, 2014 at 05:21:11PM +0200, Pavel Březina wrote: > > 2) the ccache name is stored in KRB5CCACHE (or something like that) > > environment variable so actually only one ccache may be used. Possible > > solution would be to