Re: [SSSD] Patch to fix incorrect PAM return code when user enters invalid credentials

2014-09-03 Thread Stephen Gallagher
On 09/03/2014 07:59 PM, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/28/2014 10:00 PM, John Koelndorfer wrote: > > Hey folks, > > > > Some quick background on this small patch I prepared. I run sssd on > > my desktop (and servers) to authenticate against a Sa

Re: [SSSD] Patch to fix incorrect PAM return code when user enters invalid credentials

2014-09-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/28/2014 10:00 PM, John Koelndorfer wrote: > Hey folks, > > Some quick background on this small patch I prepared. I run sssd on > my desktop (and servers) to authenticate against a Samba 4 DC. I > found that when I attempted to log in via KDM and

Re: [SSSD] [PATCH] CI: Consider libcmocka-devel always present

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 06:08 PM, Michal Židek wrote: On 09/03/2014 05:03 PM, Nikolai Kondrashov wrote: This patch fixes incorrect assumption of cmocka missing from RHEL6 by CI and correspondingly enables coverage percentage check there. It requires "CI: Allow disabling distro-(in)dependent tests" as it

Re: [SSSD] [PATCH] CI: Consider libcmocka-devel always present

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 06:03 PM, Nikolai Kondrashov wrote: Hi everyone, This patch fixes incorrect assumption of cmocka missing from RHEL6 by CI and correspondingly enables coverage percentage check there. It requires "CI: Allow disabling distro-(in)dependent tests" as it is, but can be rebased, if nece

Re: [SSSD] [PATCH] CI: Consider libcmocka-devel always present

2014-09-03 Thread Michal Židek
On 09/03/2014 05:03 PM, Nikolai Kondrashov wrote: Hi everyone, This patch fixes incorrect assumption of cmocka missing from RHEL6 by CI and correspondingly enables coverage percentage check there. It requires "CI: Allow disabling distro-(in)dependent tests" as it is, but can be rebased, if nece

[SSSD] [PATCH] CI: Consider libcmocka-devel always present

2014-09-03 Thread Nikolai Kondrashov
Hi everyone, This patch fixes incorrect assumption of cmocka missing from RHEL6 by CI and correspondingly enables coverage percentage check there. It requires "CI: Allow disabling distro-(in)dependent tests" as it is, but can be rebased, if necessary. Nick >From 2e9cf207219a19b94da7c88604e1afbe

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-03 Thread Pavel Reichl
On 09/03/2014 02:40 PM, Jan Cholasta wrote: Dne 2.9.2014 v 16:37 Lukas Slebodnik napsal(a): On (02/09/14 16:21), Pavel Reichl wrote: On 09/01/2014 02:27 PM, Pavel Reichl wrote: On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 P

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 05:48 PM, Lukas Slebodnik wrote: On (03/09/14 17:31), Nikolai Kondrashov wrote: On 09/03/2014 05:25 PM, Lukas Slebodnik wrote: On (03/09/14 17:06), Nikolai Kondrashov wrote: On 09/03/2014 04:58 PM, Lukas Slebodnik wrote: On (03/09/14 11:36), Nikolai Kondrashov wrote: conf_

Re: [SSSD] [PATCH] SPEC: Drop rhel5 conditions in spec file.

2014-09-03 Thread Lukas Slebodnik
On (04/08/14 11:52), Pavel Březina wrote: >Hi, >I'm sorry for the delay, the patch does no longer apply. Can you rebase it >please? > Rebased patch is attached. LS >From 740ed50b0bc3cafd57bfb76129ab580a6cbc32f5 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Thu, 12 Jun 2014 15:44:26 +0200 S

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 17:31), Nikolai Kondrashov wrote: >On 09/03/2014 05:25 PM, Lukas Slebodnik wrote: >>On (03/09/14 17:06), Nikolai Kondrashov wrote: >>>On 09/03/2014 04:58 PM, Lukas Slebodnik wrote: On (03/09/14 11:36), Nikolai Kondrashov wrote: > conf_dir=`mktemp --tmpdir --directory mock-c

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 05:25 PM, Lukas Slebodnik wrote: On (03/09/14 17:06), Nikolai Kondrashov wrote: On 09/03/2014 04:58 PM, Lukas Slebodnik wrote: On (03/09/14 11:36), Nikolai Kondrashov wrote: conf_dir=`mktemp --tmpdir --directory mock-config.` trap 'trap - RETURN; rm -R "$conf_di

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 17:06), Nikolai Kondrashov wrote: >On 09/03/2014 04:58 PM, Lukas Slebodnik wrote: >>On (03/09/14 11:36), Nikolai Kondrashov wrote: >>> conf_dir=`mktemp --tmpdir --directory mock-config.` >>> trap 'trap - RETURN; rm -R "$conf_dir";' RETURN >>>-cp -r /etc/mock/* "$con

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 04:58 PM, Lukas Slebodnik wrote: On (03/09/14 11:36), Nikolai Kondrashov wrote: conf_dir=`mktemp --tmpdir --directory mock-config.` trap 'trap - RETURN; rm -R "$conf_dir";' RETURN -cp -r /etc/mock/* "$conf_dir"/ If you agree with my comment from pdifferent th

Re: [SSSD] [PATCH] CI: Allow disabling distro-(in)dependent tests

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 04:40 PM, Lukas Slebodnik wrote: On (03/09/14 16:06), Nikolai Kondrashov wrote: It does sometimes. Take a look at this: http://sssd-ci.duckdns.org/logs/job/0/19/rhel7/ci.html http://sssd-ci.duckdns.org/logs/job/0/21/rhel7/ci.html I am not sure what is wrong. I have 4 CPUs on my

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 11:36), Nikolai Kondrashov wrote: >Hi everyone, > >This patch adds preserving of mock configuration timestamps, so mock root >cache is not rebuilt unnecessarily, shaving off about a minute of CI run time. > >Nick >From 0451699b7b7fb7a92151c00867f4036fc8feca8b Mon Sep 17 00:00:00 2001

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 04:15 PM, Lukas Slebodnik wrote: On (03/09/14 16:09), Nikolai Kondrashov wrote: On 09/03/2014 03:40 PM, Lukas Slebodnik wrote: On (03/09/14 11:39), Nikolai Kondrashov wrote: On 09/03/2014 11:36 AM, Nikolai Kondrashov wrote: This patch adds preserving of mock configuration timest

Re: [SSSD] [PATCH] NSS: Use right domain for group members with fq names

2014-09-03 Thread Pavel Reichl
On 09/03/2014 02:57 PM, Lukas Slebodnik wrote: On (03/09/14 11:15), Pavel Reichl wrote: On 09/02/2014 07:46 PM, Lukas Slebodnik wrote: -nlen = sss_fqname(NULL, 0, dom->names, dom, name.str); +nlen = sss_fqname(NULL, 0, dom->names, member_dom, name.str);

Re: [SSSD] [PATCH] CI: Allow disabling distro-(in)dependent tests

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 16:06), Nikolai Kondrashov wrote: >On 09/03/2014 03:19 PM, Lukas Slebodnik wrote: >>On (03/09/14 07:55), Nikolai Kondrashov wrote: >>>Hi everyone, >>> >>>As CI mock builds are taking a god-awful long time sometimes and Clang >>>doesn't >>mock build does not take "god-awful long". > >

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 16:09), Nikolai Kondrashov wrote: >On 09/03/2014 03:40 PM, Lukas Slebodnik wrote: >>On (03/09/14 11:39), Nikolai Kondrashov wrote: >>>On 09/03/2014 11:36 AM, Nikolai Kondrashov wrote: This patch adds preserving of mock configuration timestamps, so mock root cache is not rebuilt

Re: [SSSD] [sssd][patch] SYSDB: sysdb_getnetgr returns ENOENT

2014-09-03 Thread Lukas Slebodnik
On (01/09/14 11:20), Pavel Reichl wrote: > >On 08/29/2014 10:14 AM, Lukas Slebodnik wrote: >>On (28/08/14 18:44), Pavel Reichl wrote: >>>On 08/28/2014 06:19 PM, Jakub Hrozek wrote: On Thu, Aug 28, 2014 at 11:49:38AM +0200, Pavel Reichl wrote: >>>Hello, >>> >>>sorry for late reply. I

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 03:40 PM, Lukas Slebodnik wrote: On (03/09/14 11:39), Nikolai Kondrashov wrote: On 09/03/2014 11:36 AM, Nikolai Kondrashov wrote: This patch adds preserving of mock configuration timestamps, so mock root cache is not rebuilt unnecessarily, shaving off about a minute of CI run time

Re: [SSSD] [PATCH] CI: Allow disabling distro-(in)dependent tests

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 03:19 PM, Lukas Slebodnik wrote: On (03/09/14 07:55), Nikolai Kondrashov wrote: Hi everyone, As CI mock builds are taking a god-awful long time sometimes and Clang doesn't mock build does not take "god-awful long". It does sometimes. Take a look at this: http://sssd-ci.duckdn

Re: [SSSD] [PATCH] NSS: Use right domain for group members with fq names

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 11:15), Pavel Reichl wrote: > >On 09/02/2014 07:46 PM, Lukas Slebodnik wrote: >>-nlen = sss_fqname(NULL, 0, dom->names, dom, name.str); >>+nlen = sss_fqname(NULL, 0, dom->names, member_dom, name.str); >

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 11:39), Nikolai Kondrashov wrote: >On 09/03/2014 11:36 AM, Nikolai Kondrashov wrote: >>This patch adds preserving of mock configuration timestamps, so mock root >>cache is not rebuilt unnecessarily, shaving off about a minute of CI run time. > >Here is a job verifying this commit with

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-03 Thread Jan Cholasta
Dne 2.9.2014 v 16:37 Lukas Slebodnik napsal(a): On (02/09/14 16:21), Pavel Reichl wrote: On 09/01/2014 02:27 PM, Pavel Reichl wrote: On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 P

Re: [SSSD] [PATCH] CI: Allow disabling distro-(in)dependent tests

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 07:55), Nikolai Kondrashov wrote: >Hi everyone, > >As CI mock builds are taking a god-awful long time sometimes and Clang doesn't mock build does not take "god-awful long". The londest part is downloading rpms to cache on firs time or after modification of mock config. I have few tip

Re: [SSSD] [PATCH v2 1/2] NFSv4 client: man page

2014-09-03 Thread Lukas Slebodnik
On (03/09/14 00:30), Noam Meltzer wrote: >--- > src/man/Makefile.am | 4 +- > src/man/include/seealso.xml | 4 ++ > src/man/sss_rpcidmapd.5.xml | 132 > 3 files changed, 139 insertions(+), 1 deletion(-) > create mode 100644 src/man/sss_rpcidmapd

Re: [SSSD] [PATCH] CI: Do not try to find memory leaks with valgrind

2014-09-03 Thread Lukas Slebodnik
On (02/09/14 20:29), Nikolai Kondrashov wrote: >On 09/02/2014 04:38 PM, Lukas Slebodnik wrote: >>On (02/09/14 14:23), Nikolai Kondrashov wrote: >>>On 09/02/2014 02:13 PM, Lukas Slebodnik wrote: On (02/09/14 13:27), Nikolai Kondrashov wrote: >On 09/02/2014 01:02 PM, Lukas Slebodnik wrote: >>

Re: [SSSD] [PATCH v2 2/2] NFSv4 client: man page - add to RPM spec

2014-09-03 Thread Roland Mainz
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 6e9d969..9b25cbc 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -666,6 +666,7 @@ rm -rf $RPM_BUILD_ROOT %{_mandir}/man5/sssd.conf.5* %{_mandir}/man5/sssd-simple.5* %{_mandir}/man5/sssd-sudo.5* +%{_mandir}/man5/sss_rp

Re: [SSSD] [PATCH v2 1/2] NFSv4 client: man page

2014-09-03 Thread Roland Mainz
diff --git a/src/man/Makefile.am b/src/man/Makefile.am index 546e0ad..a92ac0d 100644 --- a/src/man/Makefile.am +++ b/src/man/Makefile.am @@ -45,7 +45,9 @@ man_MANS = \ sssd.8 sssd.conf.5 sssd-ldap.5 \ sssd-krb5.5 sssd-simple.5 \ sssd_krb5_locator_plugin.8 sss_groupshow.8 \ -pam_s

Re: [SSSD] [PATCH] NSS: Use right domain for group members with fq names

2014-09-03 Thread Pavel Reichl
On 09/02/2014 07:46 PM, Lukas Slebodnik wrote: -nlen = sss_fqname(NULL, 0, dom->names, dom, name.str); +nlen = sss_fqname(NULL, 0, dom->names, member_dom, name.str); ^ s/dom->names/member_dom->names/ Should

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
On 09/03/2014 11:36 AM, Nikolai Kondrashov wrote: This patch adds preserving of mock configuration timestamps, so mock root cache is not rebuilt unnecessarily, shaving off about a minute of CI run time. Here is a job verifying this commit with distro-independent tests separate: http://sssd-ci.d

[SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-03 Thread Nikolai Kondrashov
Hi everyone, This patch adds preserving of mock configuration timestamps, so mock root cache is not rebuilt unnecessarily, shaving off about a minute of CI run time. Nick >From 0451699b7b7fb7a92151c00867f4036fc8feca8b Mon Sep 17 00:00:00 2001 From: Nikolai Kondrashov Date: Wed, 3 Sep 2014 11:18