Re: [SSSD] [PATCH] AD: conflicting gpo policy settings not being resolved correctly

2014-09-11 Thread Yassir Elley
- Original Message - > > > - Original Message - > > Hi, > > > > The attached patch fixes ticket #2437 (conflicting gpo policy settings not > > being resolved correctly) > > > > https://fedorahosted.org/sssd/ticket/2437 > > > > Regards, > > Yassir. > > > > ___

Re: [SSSD] [PATCH] CI: Improve usability of ci script

2014-09-11 Thread Roland Mainz
- Original Message - > From: "Nikolai Kondrashov" > To: "Development of the System Security Services Daemon" > > Sent: Thursday, September 11, 2014 10:22:45 PM > Subject: Re: [SSSD] [PATCH] CI: Improve usability of ci script > > On 09/11/2014 08:42 PM, Roland Mainz wrote: > > Some (mi

Re: [SSSD] [PATCH v2] CI: Allow disabling distro-(in)dependent tests

2014-09-11 Thread Nikolai Kondrashov
On 09/11/2014 07:06 PM, Michal Židek wrote: On 09/11/2014 02:44 PM, Nikolai Kondrashov wrote: On 09/11/2014 01:42 PM, Michal Židek wrote: On 09/04/2014 11:40 AM, Nikolai Kondrashov wrote: This version removes the disabling of Valgrind memory leak check, which got into the first version acciden

Re: [SSSD] [PATCH] CI: Improve usability of ci script

2014-09-11 Thread Nikolai Kondrashov
On 09/11/2014 08:42 PM, Roland Mainz wrote: Some (minor) nits (not needed for now): 1. Please use "source", not ".", e.g. turn... -- snip -- . shared_variables.sh -- snip -- ... into ... -- snip -- source shared_variables.sh -- snip -- The reason is that "source" is more readable and is an alias

Re: [SSSD] [PATCH] CI: Improve usability of ci script

2014-09-11 Thread Nikolai Kondrashov
On 09/11/2014 09:16 PM, Lukas Slebodnik wrote: On (11/09/14 13:42), Roland Mainz wrote: BTW: i would log all files to the one directory, but I didn't want break backword compatibility. It could break other Nikolai's scrips. Thank you for considering that. Indeed, the Jenkins job archival config

Re: [SSSD] [PATCH] CI: Improve usability of ci script

2014-09-11 Thread Lukas Slebodnik
On (11/09/14 13:42), Roland Mainz wrote: >- Original Message - >> From: "Lukas Slebodnik" >> To: "Development of the System Security Services Daemon" >> >> Sent: Thursday, September 11, 2014 10:36:23 AM >> Subject: Re: [SSSD] [PATCH] CI: Improve usability of ci script >> >> On (05/09/14

Re: [SSSD] [PATCH] CI: Preserve mock config timestamps

2014-09-11 Thread Michal Židek
On 09/03/2014 10:36 AM, Nikolai Kondrashov wrote: Hi everyone, This patch adds preserving of mock configuration timestamps, so mock root cache is not rebuilt unnecessarily, shaving off about a minute of CI run time. Nick Patch works for me. On testing VM I get: real42m19.002s user32m

Re: [SSSD] [PATCH] CI: Add missing debian dependency

2014-09-11 Thread Michal Židek
On 09/08/2014 10:15 AM, Nikolai Kondrashov wrote: On 09/08/2014 10:42 AM, Lukas Slebodnik wrote: Fix for one problem is attached. (missing dependency: make) I don't have a freshly-installed Debian handy to verify this properly, but it works fine on a weathered installation. Nick Patches fix

Re: [SSSD] [PATCH] CI: Improve usability of ci script

2014-09-11 Thread Roland Mainz
- Original Message - > From: "Lukas Slebodnik" > To: "Development of the System Security Services Daemon" > > Sent: Thursday, September 11, 2014 10:36:23 AM > Subject: Re: [SSSD] [PATCH] CI: Improve usability of ci script > > On (05/09/14 18:58), Michal Židek wrote: > >On 09/05/2014 0

Re: [SSSD] [PATCH v2] CI: Allow disabling distro-(in)dependent tests

2014-09-11 Thread Michal Židek
On 09/11/2014 02:44 PM, Nikolai Kondrashov wrote: On 09/11/2014 01:42 PM, Michal Židek wrote: On 09/04/2014 11:40 AM, Nikolai Kondrashov wrote: This version removes the disabling of Valgrind memory leak check, which got into the first version accidentally and should be (and is) a separate patch

Re: [SSSD] [PATCHES] Alternative objectClass for group maps

2014-09-11 Thread Jakub Hrozek
On Thu, Sep 11, 2014 at 12:24:45PM +0200, Michal Židek wrote: > The function is there to replace long "if" conditions. There > were 2 in the code. One used strncasecmp and one strcasecmp. > ^ > Where no length is needed to be specified, you can pass 0 > to this funct

Re: [SSSD] [PATCH] SUDO: Support the IPA schema

2014-09-11 Thread Jakub Hrozek
On Thu, Sep 11, 2014 at 02:47:33PM +0200, Šrubař Michal wrote: > Cituji Pavel Březina : > > >On 09/08/2014 03:47 PM, Jakub Hrozek wrote: > >>On Wed, Aug 20, 2014 at 01:40:45PM +0200, Šrubař Michal wrote: > >>>Hi guys, I spent some time working at this ticket > >>>https://fedorahosted.org/sssd/tick

Re: [SSSD] [PATCH v2] CI: Allow disabling distro-(in)dependent tests

2014-09-11 Thread Nikolai Kondrashov
On 09/11/2014 03:44 PM, Nikolai Kondrashov wrote: On 09/11/2014 01:42 PM, Michal Židek wrote: On 09/04/2014 11:40 AM, Nikolai Kondrashov wrote: This version removes the disabling of Valgrind memory leak check, which got into the first version accidentally and should be (and is) a separate patch

Re: [SSSD] [PATCH] SUDO: Support the IPA schema

2014-09-11 Thread Šrubař Michal
Cituji Pavel Březina : On 09/08/2014 03:47 PM, Jakub Hrozek wrote: On Wed, Aug 20, 2014 at 01:40:45PM +0200, Šrubař Michal wrote: Hi guys, I spent some time working at this ticket https://fedorahosted.org/sssd/ticket/1108 and I think it's finally ready to be reviewed by others. Description of

Re: [SSSD] [PATCH v2] CI: Allow disabling distro-(in)dependent tests

2014-09-11 Thread Nikolai Kondrashov
On 09/11/2014 01:42 PM, Michal Židek wrote: On 09/04/2014 11:40 AM, Nikolai Kondrashov wrote: This version removes the disabling of Valgrind memory leak check, which got into the first version accidentally and should be (and is) a separate patch. This patch no longer applies on master. Please

Re: [SSSD] [PATCH v2] CI: Allow disabling distro-(in)dependent tests

2014-09-11 Thread Michal Židek
On 09/04/2014 11:40 AM, Nikolai Kondrashov wrote: Hi everyone, This version removes the disabling of Valgrind memory leak check, which got into the first version accidentally and should be (and is) a separate patch. Nick This patch no longer applies on master. Please rebase. Michal ___

Re: [SSSD] [PATCHES] Alternative objectClass for group maps

2014-09-11 Thread Michal Židek
On 09/11/2014 11:43 AM, Jakub Hrozek wrote: On Wed, Sep 10, 2014 at 09:59:35PM +0200, Michal Židek wrote: On 09/10/2014 06:13 PM, Michal Židek wrote: On 09/10/2014 06:00 PM, Michal Židek wrote: On 09/10/2014 02:49 PM, Jakub Hrozek wrote: On Wed, Sep 10, 2014 at 01:23:15PM +0200, Michal Židek

Re: [SSSD] [PATCHES] Alternative objectClass for group maps

2014-09-11 Thread Pavel Reichl
Hi Michal, code LGTM, I'll test it later today, I have noticed just a minor nitpick. On 09/10/2014 09:59 PM, Michal Židek wrote: 0001-Add-alternative-objectClass-to-group-attribute-maps.patch From 58b3750bbbcda0dafe0c73b8eae69264d1eb2c7e Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Wed

Re: [SSSD] [PATCHES] Alternative objectClass for group maps

2014-09-11 Thread Jakub Hrozek
On Wed, Sep 10, 2014 at 09:59:35PM +0200, Michal Židek wrote: > On 09/10/2014 06:13 PM, Michal Židek wrote: > >On 09/10/2014 06:00 PM, Michal Židek wrote: > >>On 09/10/2014 02:49 PM, Jakub Hrozek wrote: > >>>On Wed, Sep 10, 2014 at 01:23:15PM +0200, Michal Židek wrote: > --- a/src/providers/lda

Re: [SSSD] [PATCH] LDAP: Don't reuse a single tevent callback for multiple requests

2014-09-11 Thread Jakub Hrozek
On Wed, Sep 10, 2014 at 02:37:14PM +0200, Michal Židek wrote: > On 09/10/2014 12:17 PM, Jakub Hrozek wrote: > >On Wed, Sep 10, 2014 at 11:59:55AM +0200, Jakub Hrozek wrote: > >>On Fri, Sep 05, 2014 at 04:28:00PM +0200, Jakub Hrozek wrote: > >>>I will prepare a 1.11 version separately (sadly, the bu

Re: [SSSD] [PATCH] LDAP: Check return value

2014-09-11 Thread Jakub Hrozek
On Tue, Sep 09, 2014 at 02:14:58PM -0400, Simo Sorce wrote: > > > Not a big deal but we used to talloc_zfree() as the first thing, before > > > checking (and eventually failing) the return error. > > > > > > Simo. > > > > Thank you. I think in the pre-release frenzy we didn't follow the best > >

Re: [SSSD] [PATCH] CI: Improve usability of ci script

2014-09-11 Thread Lukas Slebodnik
On (05/09/14 18:58), Michal Židek wrote: >On 09/05/2014 04:18 PM, Lukas Slebodnik wrote: >>On (05/09/14 16:11), Michal Židek wrote: >>>On 09/05/2014 11:37 AM, Lukas Slebodnik wrote: ehlo, CI scrip can be now executed from different directory than sssd git root. [build@host ci_