Re: [SSSD] [PATCH] IPA: add support for new extdom plugin version

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 04:50:15PM +0200, Sumit Bose wrote: > On Fri, Sep 26, 2014 at 04:06:13PM +0200, Sumit Bose wrote: > > On Thu, Sep 25, 2014 at 05:09:42PM +0200, Sumit Bose wrote: > > > On Wed, Sep 24, 2014 at 12:23:20PM +0200, Jakub Hrozek wrote: > ... > > > > > This new version contain s

Re: [SSSD] Design Discussion: Restricting domains per PAM service

2014-09-29 Thread Simo Sorce
On Mon, 29 Sep 2014 15:28:28 +0200 Jan Pazdziora wrote: > On Tue, Sep 23, 2014 at 10:03:36AM -0400, Simo Sorce wrote: > > > > I would defer this to when we have actual requests for it. > > I am not necessarily opposed but it will be confusing. You see a > > list of domains (or even 'none') and t

Re: [SSSD] [PATCHES] Add backend part of user views

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 03:00:44PM +0200, Sumit Bose wrote: > > Hi, > > I'm sending two more trivial debug patches to squash in. Otherwise its an > > code wise ack. I'm running some tests now. > > > > Thank you. Jakub, in case there are no other issues, can you add them > when committing the patc

Re: [SSSD] [PATCH] LDAP: Do not require a dereference control to be retuned in a reply

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 03:20:57PM +0200, Pavel Reichl wrote: > ACK > > On 09/29/2014 01:16 PM, Jakub Hrozek wrote: > >Ludwig suggested that we should be more permissive when parsing replies > >from a server. > > > > > >___ > >sssd-devel mailing list > >

Re: [SSSD] [PATCH] PAM: new option pam_trusted_users

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 06:24:11PM +0200, Lukas Slebodnik wrote: > >From 2d80e4913453a2c76ff698765765bf3881ecc4e7 Mon Sep 17 00:00:00 2001 > >From: Pavel Reichl > >Date: Thu, 25 Sep 2014 14:52:31 +0100 > >Subject: [PATCH 1/2] PAM: new options pam_trusted_users & pam_public_domains > > > >pam_publi

Re: [SSSD] [PATCH] some typos in debug messages

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 01:48:37PM +0200, Lukas Slebodnik wrote: > On (27/09/14 13:13), Pavel Reichl wrote: > >Please see attached trivial patch. > > > >Thanks! > > >From d1376ef4f5c6c88c7a3f4e101462d942265547c1 Mon Sep 17 00:00:00 2001 > >From: Pavel Reichl > >Date: Sat, 27 Sep 2014 12:06:44 +01

Re: [SSSD] [PATCH] PAM: new option pam_trusted_users

2014-09-29 Thread Lukas Slebodnik
On (29/09/14 18:07), Pavel Reichl wrote: > >On 09/29/2014 05:18 PM, Lukas Slebodnik wrote: >>On (27/09/14 12:39), Pavel Reichl wrote: >>>Attached patch now contains both options. >>> >>>Thanks. >>> >>> >>>On 09/25/2014 03:57 PM, Pavel Reichl wrote: Hello, please see attached patch whic

Re: [SSSD] [PATCH] AD GPO: Fix incorrect sAMAccountName selection

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 01:37:31PM +0200, Jakub Hrozek wrote: > ACK. I checked out the code in gdb: > > (gdb) n > 1489req = tevent_req_callback_data(subreq, struct tevent_req); > (gdb) > 1490state = tevent_req_data(req, struct ad_gpo_access_state); > (gdb) > 1492ret = sda

Re: [SSSD] [PATCH] AD: Add a missing break statement to the GPO code

2014-09-29 Thread Jakub Hrozek
On Mon, Sep 29, 2014 at 01:28:24PM +0200, Pavel Reichl wrote: > > On 09/29/2014 01:17 PM, Jakub Hrozek wrote: > >Found by Coverity. Moreover, I think the DEBUG message shouldn't be so > >loud. > > > > > >___ > >sssd-devel mailing list > >sssd-devel@lists

Re: [SSSD] [PATCH] PAM: new option pam_trusted_users

2014-09-29 Thread Pavel Reichl
On 09/29/2014 05:18 PM, Lukas Slebodnik wrote: On (27/09/14 12:39), Pavel Reichl wrote: Attached patch now contains both options. Thanks. On 09/25/2014 03:57 PM, Pavel Reichl wrote: Hello, please see attached patch which adds first of two options proposed in https://fedorahosted.org/sssd/w

[SSSD] [PATCH] LDAP: Change defaults for ldap_user/group_objectsid

2014-09-29 Thread Michal Židek
Hi, this patch solves the ticket: https://fedorahosted.org/sssd/ticket/2361 From the discussion on bugzilla and the ticket comments, it looks like Jakub and Lukas were for changes in documentation only (+ maybe warning/error if user misconfigured SSSD). I do not want look like I ignore the opin

Re: [SSSD] [PATCH] PAM: new option pam_trusted_users

2014-09-29 Thread Lukas Slebodnik
On (29/09/14 11:10), Pavel Reichl wrote: >Hello, > >please see attached patch, which is amended Daniel Gollubs' patch from thread > >[SSSD] [PATCH] PAM: Add domains= option to pam_sss >(https://lists.fedorahosted.org/pipermail/sssd-devel/2014-July/020867.html). > >I have just fixed nitpick found b

Re: [SSSD] [PATCH] PAM: new option pam_trusted_users

2014-09-29 Thread Lukas Slebodnik
On (27/09/14 12:39), Pavel Reichl wrote: >Attached patch now contains both options. > >Thanks. > > >On 09/25/2014 03:57 PM, Pavel Reichl wrote: >>Hello, >> >>please see attached patch which adds first of two options proposed in >>https://fedorahosted.org/sssd/wiki/DesignDocs/RestrictDomainsInPAM >>

Re: [SSSD] [PATCH] IPA: add support for new extdom plugin version

2014-09-29 Thread Sumit Bose
On Fri, Sep 26, 2014 at 04:06:13PM +0200, Sumit Bose wrote: > On Thu, Sep 25, 2014 at 05:09:42PM +0200, Sumit Bose wrote: > > On Wed, Sep 24, 2014 at 12:23:20PM +0200, Jakub Hrozek wrote: ... > > This new version contain some additional fixes. > > bye, > Sumit Hi, Pavel and Jakub discovered a

Re: [SSSD] Design Discussion: Restricting domains per PAM service

2014-09-29 Thread Jan Pazdziora
On Tue, Sep 23, 2014 at 10:03:36AM -0400, Simo Sorce wrote: > > I would defer this to when we have actual requests for it. > I am not necessarily opposed but it will be confusing. You see a list > of domains (or even 'none') and then you have to (at least > mentally) parse all the code snippets to

Re: [SSSD] [PATCH] LDAP: Do not require a dereference control to be retuned in a reply

2014-09-29 Thread Pavel Reichl
ACK On 09/29/2014 01:16 PM, Jakub Hrozek wrote: Ludwig suggested that we should be more permissive when parsing replies from a server. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-

Re: [SSSD] [PATCHES] Add backend part of user views

2014-09-29 Thread Sumit Bose
On Mon, Sep 29, 2014 at 02:52:10PM +0200, Pavel Březina wrote: > On 09/29/2014 01:01 PM, Sumit Bose wrote: > >On Mon, Sep 29, 2014 at 11:52:52AM +0200, Pavel Březina wrote: > >>On 09/26/2014 04:36 PM, Sumit Bose wrote: > >>>On Fri, Sep 26, 2014 at 01:41:39PM +0200, Pavel Březina wrote: > On 09/

Re: [SSSD] [PATCHES] Add backend part of user views

2014-09-29 Thread Pavel Březina
On 09/29/2014 01:01 PM, Sumit Bose wrote: On Mon, Sep 29, 2014 at 11:52:52AM +0200, Pavel Březina wrote: On 09/26/2014 04:36 PM, Sumit Bose wrote: On Fri, Sep 26, 2014 at 01:41:39PM +0200, Pavel Březina wrote: On 09/26/2014 01:38 PM, Pavel Březina wrote: On Wed, Sep 24, 2014 at 10:25:22AM +02

Re: [SSSD] [PATCH] some typos in debug messages

2014-09-29 Thread Lukas Slebodnik
On (27/09/14 13:13), Pavel Reichl wrote: >Please see attached trivial patch. > >Thanks! >From d1376ef4f5c6c88c7a3f4e101462d942265547c1 Mon Sep 17 00:00:00 2001 >From: Pavel Reichl >Date: Sat, 27 Sep 2014 12:06:44 +0100 >Subject: [PATCH] Fix debug messages - trailing '.' > >Fix debug messages wher

Re: [SSSD] [PATCHES] Merging INI snippets

2014-09-29 Thread Dmitri Pal
On 09/10/2014 11:31 PM, Dmitri Pal wrote: Hello, Extensive travel in recent months allowed me to finish this code. Here is the updated design: https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge Patches: 0001 - Fix in case the Ref array is empty and we need to print/debug it

Re: [SSSD] [PATCH] AD GPO: Fix incorrect sAMAccountName selection

2014-09-29 Thread Jakub Hrozek
On Thu, Sep 25, 2014 at 03:41:22PM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/25/2014 03:40 PM, Stephen Gallagher wrote: > > On 09/25/2014 04:56 AM, Jakub Hrozek wrote: > >> On Wed, Sep 24, 2014 at 11:10:00AM -0400, Stephen Gallagher > >> wrote: We

Re: [SSSD] [PATCH] AD: Add a missing break statement to the GPO code

2014-09-29 Thread Pavel Reichl
On 09/29/2014 01:17 PM, Jakub Hrozek wrote: Found by Coverity. Moreover, I think the DEBUG message shouldn't be so loud. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel ACK ___

[SSSD] [PATCH] AD: Add a missing break statement to the GPO code

2014-09-29 Thread Jakub Hrozek
Found by Coverity. Moreover, I think the DEBUG message shouldn't be so loud. >From fd56898b90db4f6c8149418df10309650f3188e2 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 24 Sep 2014 16:44:15 +0200 Subject: [PATCH] AD: Add a missing break statement to the GPO code --- src/providers/ad/ad

[SSSD] [PATCH] UTIL: Always write capath

2014-09-29 Thread Jakub Hrozek
I had this patch in my branch for a couple of days already so why not send it out.. In a remote session with a customer we discovered that it's beneficial for some scenarios to generate the capaths even on clients. The attached patch does exactly this. >From dfd0c40db796db05d72bb94acd5fb2cf1eafe72

[SSSD] [PATCH] LDAP: Do not require a dereference control to be retuned in a reply

2014-09-29 Thread Jakub Hrozek
Ludwig suggested that we should be more permissive when parsing replies from a server. >From d4c67d0c7636ecc90c929b9b1b85c985a3b4b809 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 24 Sep 2014 16:43:48 +0200 Subject: [PATCH] LDAP: Do not require a dereference control to be retuned in a re

Re: [SSSD] SDAP: check that connection is open before BIND is perfomed

2014-09-29 Thread Pavel Reichl
On 09/23/2014 11:01 PM, Jakub Hrozek wrote: On Thu, Sep 18, 2014 at 10:22:31AM +0200, Pavel Reichl wrote: Hello, please see attached patches and read commit messages for more details. As I do not have a Tivoli server handy, customer was so nice that he verified that patches are fixing the pro

Re: [SSSD] [PATCHES] Add backend part of user views

2014-09-29 Thread Sumit Bose
On Mon, Sep 29, 2014 at 11:52:52AM +0200, Pavel Březina wrote: > On 09/26/2014 04:36 PM, Sumit Bose wrote: > >On Fri, Sep 26, 2014 at 01:41:39PM +0200, Pavel Březina wrote: > >>On 09/26/2014 01:38 PM, Pavel Březina wrote: > >>>On Wed, Sep 24, 2014 at 10:25:22AM +0200, Sumit Bose wrote: > Hi, >

Re: [SSSD] [PATCHES] Add backend part of user views

2014-09-29 Thread Pavel Březina
On 09/29/2014 11:52 AM, Pavel Březina wrote: On 09/26/2014 04:36 PM, Sumit Bose wrote: On Fri, Sep 26, 2014 at 01:41:39PM +0200, Pavel Březina wrote: On 09/26/2014 01:38 PM, Pavel Březina wrote: On Wed, Sep 24, 2014 at 10:25:22AM +0200, Sumit Bose wrote: Hi, this patches contain the IPA prov

Re: [SSSD] [PATCHES] Add backend part of user views

2014-09-29 Thread Pavel Březina
On 09/26/2014 04:36 PM, Sumit Bose wrote: On Fri, Sep 26, 2014 at 01:41:39PM +0200, Pavel Březina wrote: On 09/26/2014 01:38 PM, Pavel Březina wrote: On Wed, Sep 24, 2014 at 10:25:22AM +0200, Sumit Bose wrote: Hi, this patches contain the IPA provider part of https://fedorahosted.org/sssd/tic

Re: [SSSD] [PATCH] PAM: new option pam_trusted_users

2014-09-29 Thread Pavel Reichl
Hello, please see attached patch, which is amended Daniel Gollubs' patch from thread [SSSD] [PATCH] PAM: Add domains= option to pam_sss (https://lists.fedorahosted.org/pipermail/sssd-devel/2014-July/020867.html). I have just fixed nitpick found by Jakub and rebased it on top of previous pat