Re: [SSSD] [PATCH] responder: new interface for cache request

2014-11-20 Thread Michal Židek
On 11/20/2014 01:31 PM, Pavel Březina wrote: On 11/19/2014 05:24 PM, Michal Židek wrote: On 11/06/2014 05:45 PM, Pavel Březina wrote: Hi, this patch set is based on Jakub's original code. The goal was to reduce code duplication among responders - the part that iterates over domains and perfo

[SSSD] [PATCH] be_ptask: Use first/enabled_delay with backoff feature

2014-11-20 Thread Michal Židek
Hi, it is probably not very intuitive to choose the 'period' parameter as the initial interval in the backoff feature (ptask). The first_delay and enabled_delay are more suitable for this. See the attached patch. Michal >From 8bc0e912d6db8ae868915bf5d0c06c2a398a8532 Mon Sep 17 00:00:00 2001 Fro

Re: [SSSD] [PATCH] Hint about removing sysdb if initializing ID map fails

2014-11-20 Thread Pavel Reichl
On 11/20/2014 01:41 PM, Jakub Hrozek wrote: --- a/src/providers/ipa/ipa_init.c +++ b/src/providers/ipa/ipa_init.c @@ -225,7 +225,13 @@ int sssm_ipa_id_init(struct be_ctx *bectx, /* Set up the ID mapping object */ ret = ipa_idmap_init(sdap_ctx, sdap_ctx, &sdap_ctx->opts->idmap_ctx

Re: [SSSD] [PATCH] tests: be_ptask

2014-11-20 Thread Michal Židek
On 11/20/2014 06:04 PM, Lukas Slebodnik wrote: On (20/11/14 17:41), Pavel Březina wrote: All above issues where addressed. Very nice unit test. Thank you. It would be good to add few more tests with corner cases. There aren't test for failed functions (_send, _recv) (Attached is diff with

Re: [SSSD] [PATCH] MAN: Clarify usage of groups search base with tokengroups

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 20, 2014 at 01:55:48PM +0100, Jakub Hrozek wrote: > On Thu, Nov 20, 2014 at 11:46:57AM +0100, Lukas Slebodnik wrote: > > On (19/11/14 23:43), Jakub Hrozek wrote: > > >On Thu, Nov 13, 2014 at 07:41:00PM +0100, Jakub Hrozek wrote: > > >> On Wed, Nov 12, 2014 at 03:35:43PM +0100, Lukas Sle

Re: [SSSD] [PATCH] tests: be_ptask

2014-11-20 Thread Lukas Slebodnik
On (20/11/14 17:41), Pavel Březina wrote: >All above issues where addressed. > >>>Very nice unit test. > >Thank you. > >>>It would be good to add few more tests with corner cases. >>>There aren't test for failed functions (_send, _recv) >>>(Attached is diff with test for error occured in be_ptask_s

Re: [SSSD] [PATCH] tests: be_ptask

2014-11-20 Thread Pavel Březina
On 11/18/2014 06:32 PM, Lukas Slebodnik wrote: On (18/11/14 18:26), Lukas Slebodnik wrote: On (10/11/14 14:29), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1939 >From 8eb7a424bccfcbb6140fc2d6eed91759d765c1a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date:

Re: [SSSD] [PATCH] nss-srv-tests: Add regression test for option re_expression

2014-11-20 Thread Jakub Hrozek
On Tue, Nov 18, 2014 at 11:23:47AM +0100, Lukas Slebodnik wrote: > ehlo, > > Attached patches are unit test for ticket > https://fedorahosted.org/sssd/ticket/2487 > > The ./nss-srv-tests passed with sssd-1.12.1. > > LS > From ee8a9a9d65f1ca71d945c95eb664d1ff7f04cfc5 Mon Sep 17 00:00:00 2001 > F

Re: [SSSD] [PATCH] MAN: Clarify usage of groups search base with tokengroups

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 20, 2014 at 11:46:57AM +0100, Lukas Slebodnik wrote: > On (19/11/14 23:43), Jakub Hrozek wrote: > >On Thu, Nov 13, 2014 at 07:41:00PM +0100, Jakub Hrozek wrote: > >> On Wed, Nov 12, 2014 at 03:35:43PM +0100, Lukas Slebodnik wrote: > >> > On (11/11/14 16:05), Dan Lavu wrote: > >> > >I th

[SSSD] [PATCH] Hint about removing sysdb if initializing ID map fails

2014-11-20 Thread Jakub Hrozek
Hi, if there are other places that would benefit from the same debug message, please let me know...but I think IPA with the external mapping is the best candidate. >From f3c863cca5263c38a33bde3322882e612cf1bf4e Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 20 Nov 2014 13:39:09 +0100 Subj

Re: [SSSD] [PATCH] responder: new interface for cache request

2014-11-20 Thread Pavel Březina
On 11/19/2014 05:24 PM, Michal Židek wrote: On 11/06/2014 05:45 PM, Pavel Březina wrote: Hi, this patch set is based on Jakub's original code. The goal was to reduce code duplication among responders - the part that iterates over domains and performs a cache lookup and data provider communicatio

Re: [SSSD] [PATCH] MAN: Clarify usage of groups search base with tokengroups

2014-11-20 Thread Lukas Slebodnik
On (19/11/14 23:43), Jakub Hrozek wrote: >On Thu, Nov 13, 2014 at 07:41:00PM +0100, Jakub Hrozek wrote: >> On Wed, Nov 12, 2014 at 03:35:43PM +0100, Lukas Slebodnik wrote: >> > On (11/11/14 16:05), Dan Lavu wrote: >> > >I think this explains the feature better. >> > > >> > >From 0504e88c570f1f5a395

Re: [SSSD] [PATCH] Man: debug_timestamps and debug_microseconds

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 20, 2014 at 11:32:19AM +0100, Jakub Hrozek wrote: > On Thu, Nov 13, 2014 at 05:54:30PM +0100, Michal Židek wrote: > > Hi, > > > > man page update. > > > > Michal > > ACK * master: cbbe63ded9d628ffb2494132ca1e5ebe90e2d5f8 ___ sssd-devel mai

Re: [SSSD] [PATCH] Man: debug_timestamps and debug_microseconds

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 13, 2014 at 05:54:30PM +0100, Michal Židek wrote: > Hi, > > man page update. > > Michal ACK ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] MAN: Update case_sensitive=Preserving in man pages.

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 20, 2014 at 11:25:16AM +0100, Jakub Hrozek wrote: > ACK * master: a40897fce90abf48882ea74f923711df7333fecf ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] TESTS: Add test for mmap cache client crash

2014-11-20 Thread Lukas Slebodnik
ehlo, I was not able to mock functions with linker flang -wrap when they was called indirectly by another function from dynamic library. (It works with dirrect invocation of function) mc_client_tests_LDFLAGS = \ -Wl,-wrap,sss_nss_check_header \ -Wl,-wrap,sss_open_cloexec \ $(NULL) Th

Re: [SSSD] [PATCH] MAN: Update case_sensitive=Preserving in man pages.

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 13, 2014 at 08:34:08PM +0100, Michal Židek wrote: > On 11/13/2014 07:43 PM, Jakub Hrozek wrote: > >On Wed, Nov 12, 2014 at 04:14:21PM +0100, Michal Židek wrote: > >>Hello, > >> > >>some man page fixes. > >> > >>https://fedorahosted.org/sssd/ticket/2462 > >> > >>Michal > > > >> From 77a4

Re: [SSSD] [PATCHES] IPA: check overrrides for IPA users as well

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 20, 2014 at 10:32:59AM +0100, Jakub Hrozek wrote: > Thanks, ACK to all. * master: b114bcc370c8d78b5e9f43963cfa91213901c3be acebf94a16c91b17c7c082538ab3083ee26aa992 f1436acde39da5f1400a51153cf7fd370682a4c8 1c82a31a254c2fca6dfa3e3b52986b75221d8742 933326b4180b72636af8

Re: [SSSD] [PATCH] sysdb: add sysdb_search_object_by_uuid()

2014-11-20 Thread Jakub Hrozek
On Thu, Nov 13, 2014 at 07:25:34PM +0100, Lukas Slebodnik wrote: > On (13/11/14 19:06), Pavel Reichl wrote: > > > >On 11/13/2014 06:57 PM, Jakub Hrozek wrote: > >>On Thu, Nov 06, 2014 at 12:26:41PM +0100, Sumit Bose wrote: > >>>Hi, > >>> > >>>this patch adds a new sysdb call which is needed to supp

Re: [SSSD] [PATCHES] IPA: check overrrides for IPA users as well

2014-11-20 Thread Jakub Hrozek
On Wed, Nov 19, 2014 at 10:52:46AM +0100, Sumit Bose wrote: > On Fri, Nov 14, 2014 at 05:27:29PM +0100, Jakub Hrozek wrote: > > On Thu, Nov 13, 2014 at 11:58:13AM +0100, Sumit Bose wrote: > > > > Hi, > > > > Coverity run was clean, CI run succeeded and testing against a recent > > IPA server went