Re: [SSSD] Design Discussion: Domains, users and groups over D-Bus

2015-01-12 Thread Dmitri Pal
On 01/12/2015 03:18 PM, Jakub Hrozek wrote: On Mon, Jan 12, 2015 at 02:17:46PM -0500, Dmitri Pal wrote: On 01/12/2015 09:51 AM, Pavel Březina wrote: On 12/16/2014 02:26 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/wiki/DesignDocs/DBusResponder I created a new design page to reduce s

Re: [SSSD] [PATCHES] AD: support for AD site override

2015-01-12 Thread Jakub Hrozek
On Fri, Jan 09, 2015 at 04:56:46PM +0100, Pavel Reichl wrote: > > On 01/08/2015 08:36 PM, Pavel Březina wrote: > >On 01/07/2015 03:28 PM, Pavel Reichl wrote: > >>Please see attached patches. > >> > >>Thanks. > > > >Hi, > > > >I know there is a design page I did not comment on but seeing the patch

Re: [SSSD] Design Discussion: Domains, users and groups over D-Bus

2015-01-12 Thread Jakub Hrozek
On Mon, Jan 12, 2015 at 02:17:46PM -0500, Dmitri Pal wrote: > On 01/12/2015 09:51 AM, Pavel Březina wrote: > >On 12/16/2014 02:26 PM, Pavel Březina wrote: > >>https://fedorahosted.org/sssd/wiki/DesignDocs/DBusResponder > > > >I created a new design page to reduce size and increase readability in th

Re: [SSSD] Design Discussion: Domains, users and groups over D-Bus

2015-01-12 Thread Dmitri Pal
On 01/12/2015 09:51 AM, Pavel Březina wrote: On 12/16/2014 02:26 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/wiki/DesignDocs/DBusResponder I created a new design page to reduce size and increase readability in the original one. I would like to keep DBusResponder page mainly as a c

Re: [SSSD] [PATCHES] Sig handlers cleanups

2015-01-12 Thread Jakub Hrozek
On Mon, Jan 12, 2015 at 04:34:03PM +0100, Pavel Reichl wrote: > > On 01/08/2015 10:24 AM, Jakub Hrozek wrote: > >pushed to sssd-1-11 btw: > > fea2d8c6aef70f1ba6f7528c261606eac4fcea1c > I'm sorry, but I am a little confused here. The patch doesn't seem to be > pushed in 1.11, if you pushed it w

Re: [SSSD] [PATCH] GPO: Extract server hostname after connecting

2015-01-12 Thread Jakub Hrozek
On Wed, Jan 07, 2015 at 11:47:49AM +0100, Jakub Hrozek wrote: > Hi, > > the attached patch is related to GPO offline functionality, please check > the commit message. > > To reproduce, set up an AD client with GPOs, make sure credential > caching is enabled. Log in as a permitted user to cache th

Re: [SSSD] [PATCH] GPO: Don't use stdout for output in gpo_child

2015-01-12 Thread Jakub Hrozek
On Wed, Jan 07, 2015 at 11:56:24AM +0100, Jakub Hrozek wrote: > Hi, > > the attached patches work around the Samba bug > https://bugzilla.samba.org/show_bug.cgi?id=11036 > > To reproduce, set a high "log level" in smb.conf and attempt to log in. > At least with RHEL-7.1's Samba version, the gpo_c

Re: [SSSD] [PATCHES] Various view related improvements

2015-01-12 Thread Jakub Hrozek
On Mon, Jan 12, 2015 at 05:54:43PM +0100, Sumit Bose wrote: > > Thank you for the review. This should happen if your AD domain name (not > > the real name) contains upper-case characters. This spelling is kept in > > sysdb but get lower-cased e.g. in the getgrnam() output. I've add a 8th > > patch

Re: [SSSD] [PATCHES] Various view related improvements

2015-01-12 Thread Sumit Bose
On Mon, Jan 12, 2015 at 12:31:48PM +0100, Sumit Bose wrote: > On Fri, Jan 09, 2015 at 02:46:27PM +0100, Jakub Hrozek wrote: > > On Wed, Dec 17, 2014 at 11:47:59AM +0100, Sumit Bose wrote: > > > On Wed, Dec 17, 2014 at 09:33:32AM +0100, Lukas Slebodnik wrote: > > > > On (17/12/14 09:31), Lukas Slebo

Re: [SSSD] [PATCHES] Sig handlers cleanups

2015-01-12 Thread Pavel Reichl
On 01/08/2015 10:24 AM, Jakub Hrozek wrote: pushed to sssd-1-11 btw: fea2d8c6aef70f1ba6f7528c261606eac4fcea1c I'm sorry, but I am a little confused here. The patch doesn't seem to be pushed in 1.11, if you pushed it where did you pushed it to? Thanks! _

Re: [SSSD] Design Discussion: Domains, users and groups over D-Bus

2015-01-12 Thread Pavel Březina
On 12/16/2014 02:26 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/wiki/DesignDocs/DBusResponder I created a new design page to reduce size and increase readability in the original one. I would like to keep DBusResponder page mainly as a crossroad with links to other pages in the futu

Re: [SSSD] [PATCH] LDAP: retain external members

2015-01-12 Thread Pavel Reichl
On 01/06/2015 09:12 AM, Jakub Hrozek wrote: On Mon, Jan 05, 2015 at 07:18:13PM +0100, Pavel Reichl wrote: On 01/05/2015 04:55 PM, Jakub Hrozek wrote: On Mon, Dec 15, 2014 at 04:36:46PM +0100, Sumit Bose wrote: On Sat, Dec 13, 2014 at 10:25:55PM +0100, Jakub Hrozek wrote: On Sat, Dec 13, 2014

Re: [SSSD] [PATCH] Fix usage of talloc_steal

2015-01-12 Thread Lukas Slebodnik
On (12/01/15 13:27), Pavel Březina wrote: >On 01/10/2015 06:12 PM, Lukas Slebodnik wrote: >>ehlo, >> >>talloc_steal is a macro around function _talloc_steal_loc >>and returns the pointer that you pass it. It does not have any failure modes. >> >>If the output value is ignored there are compiler war

Re: [SSSD] [PATCH] Fix usage of talloc_steal

2015-01-12 Thread Pavel Březina
On 01/10/2015 06:12 PM, Lukas Slebodnik wrote: ehlo, talloc_steal is a macro around function _talloc_steal_loc and returns the pointer that you pass it. It does not have any failure modes. If the output value is ignored there are compiler warnings. Example of warning src/util/util.c:503:164: w

Re: [SSSD] [PATCH] Fix warning: for loop has empty body

2015-01-12 Thread Pavel Březina
On 01/10/2015 06:08 PM, Lukas Slebodnik wrote: ehlo, The attached patch fixes clang warning -Wempty-body. The other alternative is to put put the semicolon on a separate line to silence this warning as it was suggested by compiler. LS If we are going to fix this warning, I would prefer this w

Re: [SSSD] [PATCHES] Various view related improvements

2015-01-12 Thread Sumit Bose
On Fri, Jan 09, 2015 at 02:46:27PM +0100, Jakub Hrozek wrote: > On Wed, Dec 17, 2014 at 11:47:59AM +0100, Sumit Bose wrote: > > On Wed, Dec 17, 2014 at 09:33:32AM +0100, Lukas Slebodnik wrote: > > > On (17/12/14 09:31), Lukas Slebodnik wrote: > > > >On (11/12/14 11:10), Sumit Bose wrote: > > > >>Hi