Re: [SSSD] [PATCHES] cache_req improvements

2015-02-11 Thread Jakub Hrozek
On Fri, Jan 30, 2015 at 05:04:09PM +0100, Pavel Březina wrote: > On 01/27/2015 02:19 PM, Pavel Březina wrote: > >Hi, > >these patches were created as part of my dbus work however they do not > >depend on it. Those patches can be applied on top of current master and > >review separately. > > > >Rece

Re: [SSSD] [PATCH] Fix warning: equality comparison with extraneous parentheses

2015-02-11 Thread Jakub Hrozek
On Fri, Jan 30, 2015 at 06:12:53PM +0100, Michal Židek wrote: > On 01/28/2015 09:22 AM, Lukas Slebodnik wrote: > >On (23/01/15 18:07), Michal Židek wrote: > >>On 01/10/2015 06:10 PM, Lukas Slebodnik wrote: > >>>ehlo, > >>> > >>>The attached patch fixes clang warning -Wparentheses-equality > >>> > >

Re: [SSSD] [PATCH] ipa_s2n_save_objects: properly handle fully-qualified group

2015-02-11 Thread Jakub Hrozek
On Wed, Jan 28, 2015 at 03:42:38PM +0100, Jakub Hrozek wrote: > On Wed, Jan 28, 2015 at 02:57:19PM +0100, Sumit Bose wrote: > > Hi, > > > > this issue was found be Steeve during testing, sorry I do not have a good > > reproducer atm. > > > > bye, > > Sumit > > The patch seems to work fine in my

Re: [SSSD] [PATCHES] few improvements to sbus and ifp

2015-02-11 Thread Jakub Hrozek
On Wed, Jan 21, 2015 at 02:08:54PM +0100, Pavel Březina wrote: > 2/3 of previous sbus changes are acked so I'm sending few more patches from > my tree. > > Commit messages should be sufficient to justify the changes. Simply put, I > wanted to standardize and shorten names of generated and hard cod

Re: [SSSD] [PATCH] PAM: do not reject abruptly

2015-02-11 Thread Jakub Hrozek
On Wed, Feb 11, 2015 at 05:50:50PM +0100, Sumit Bose wrote: > On Wed, Feb 11, 2015 at 04:56:48PM +0100, Pavel Reichl wrote: > > Hello, > > > > please see attached patch. I'm not sure whether using pam_strerror() is the > > right thing to do. It might be better to use our own string? > > I'm also n

Re: [SSSD] [PATCH] PAM: do not reject abruptly

2015-02-11 Thread Sumit Bose
On Wed, Feb 11, 2015 at 04:56:48PM +0100, Pavel Reichl wrote: > Hello, > > please see attached patch. I'm not sure whether using pam_strerror() is the > right thing to do. It might be better to use our own string? > I'm also not sure about using _(STRING) macro on the output of > pam_strerror().

[SSSD] [PATCH] PAM: do not reject abruptly

2015-02-11 Thread Pavel Reichl
Hello, please see attached patch. I'm not sure whether using pam_strerror() is the right thing to do. It might be better to use our own string? I'm also not sure about using _(STRING) macro on the output of pam_strerror(). I attached output of sequence of commands to show differences. 1) Thi

Re: [SSSD] [PATCH] sbus: use hard coded getters instead of generated

2015-02-11 Thread Jakub Hrozek
On Thu, Jan 22, 2015 at 12:19:52PM +0100, Pavel Březina wrote: > On 01/21/2015 10:42 PM, Jakub Hrozek wrote: > >On Wed, Jan 21, 2015 at 04:31:24PM -0500, Pavel Brezina wrote: > >> > >> > >>- Original Message - > >>>From: "Jakub Hrozek" > >>>To: sssd-devel@lists.fedorahosted.org > >>>Sent:

Re: [SSSD] [PATCH] RESOLV: Remove obsolete in-tree implementation of SRV and TXT

2015-02-11 Thread Jakub Hrozek
On Thu, Jan 15, 2015 at 12:02:46PM +0100, Pavel Březina wrote: > On 01/14/2015 04:22 PM, Jakub Hrozek wrote: > >On Tue, Jan 06, 2015 at 12:50:26PM +0100, Pavel Březina wrote: > >>On 12/15/2014 03:10 AM, Jakub Hrozek wrote: > >>>Hi, > >>> > >>>kindly see the attached patch and the commit message. I'

Re: [SSSD] [PATCH] RESOLV: Add an internal function to read TTL from a DNS packet

2015-02-11 Thread Jakub Hrozek
On Tue, Jan 27, 2015 at 11:24:48AM +0100, Pavel Březina wrote: > On 01/21/2015 05:30 PM, Jakub Hrozek wrote: > >>It looks good otherwise. I got the following compilation error though: > >> > >> CC src/tests/cmocka/ifp_tests-common_mock_resp.o > >>In file included from /home/pbrezina/workspace

Re: [SSSD] [PATCH] AD: use GC for SID requests as well

2015-02-11 Thread Jakub Hrozek
On Fri, Jan 30, 2015 at 03:15:46PM +0100, Jakub Hrozek wrote: > On Fri, Jan 30, 2015 at 02:24:34PM +0100, Sumit Bose wrote: > > On Fri, Jan 30, 2015 at 02:23:43PM +0100, Sumit Bose wrote: > > > On Fri, Jan 30, 2015 at 01:27:34PM +0100, Jakub Hrozek wrote: > > > > On Wed, Jan 28, 2015 at 08:18:04PM

Re: [SSSD] [PATCH] fill_id() fix LE/BE issue with wrong data type

2015-02-11 Thread Jakub Hrozek
On Fri, Jan 30, 2015 at 03:36:39PM +0100, Jakub Hrozek wrote: > On Thu, Jan 29, 2015 at 09:17:28PM +0100, Sumit Bose wrote: > > Hi, > > > > we try to squeeze a 64bit type into a 32bit one which kind of works on > > little-endian because we checked that the value is not larger then > > UINT32_MAX b