[SSSD] [PATCH] PAC: Fix memory leak

ehlo, attached is simple fix and a html report from scan-build. LS >From cdbb6637425a094ffa96e22c9e851f458c50812b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 6 Mar 2015 19:27:38 +0100 Subject: [PATCH] PAC: Fix memory leak Reported by clang static analyser. --- src/sss_client/sssd

Re: [SSSD] [PATCH] Use FQDN if default domain was set

On 03/06/2015 05:47 PM, Lukas Slebodnik wrote: On (03/03/15 22:45), Michal Židek wrote: New patches are attached. SSSD loudly complains to logs and fails to start if default_domain_suffix is used and use_fully_qualified_names is set to False (as Stephen suggested). Also the change of defaults v

Re: [SSSD] [PATCH] Use FQDN if default domain was set

On (03/03/15 22:45), Michal Židek wrote: >New patches are attached. > >SSSD loudly complains to logs and fails to start if >default_domain_suffix is used and use_fully_qualified_names >is set to False (as Stephen suggested). Also the change >of defaults value for use_fully_quallified_names is logge

Re: [SSSD] [PATCHES] SDAP: Lock out ssh keys when account naturally expires

On Fri, Mar 06, 2015 at 12:50:28PM +0100, Pavel Reichl wrote: > On 03/06/2015 10:27 AM, Pavel Reichl wrote: > > > > > >On 03/06/2015 10:24 AM, Jakub Hrozek wrote: > >>On Thu, Mar 05, 2015 at 02:34:15PM +0100, Pavel Reichl wrote: > +case PWP_SENTINEL: > +default: > +DEBUG

Re: [SSSD] [PATCH] ldap_child: initialized ccname_file_dummy

On Fri, Mar 06, 2015 at 12:16:02PM +0100, Jakub Hrozek wrote: > On Fri, Mar 06, 2015 at 11:51:39AM +0100, Jakub Hrozek wrote: > > On Fri, Mar 06, 2015 at 11:41:25AM +0100, Sumit Bose wrote: > > > Hi, > > > > > > this patch should fix the following compiler warning: > > > > > > CC src/provi

Re: [SSSD] [PATCHES] SDAP: Lock out ssh keys when account naturally expires

On 03/06/2015 10:27 AM, Pavel Reichl wrote: On 03/06/2015 10:24 AM, Jakub Hrozek wrote: On Thu, Mar 05, 2015 at 02:34:15PM +0100, Pavel Reichl wrote: +case PWP_SENTINEL: +default: +DEBUG(SSSDBG_MINOR_FAILURE, + "Unexpected value of password policy mode: %d.\n", p

Re: [SSSD] [PATCH] ldap_child: initialized ccname_file_dummy

On Fri, Mar 06, 2015 at 11:51:39AM +0100, Jakub Hrozek wrote: > On Fri, Mar 06, 2015 at 11:41:25AM +0100, Sumit Bose wrote: > > Hi, > > > > this patch should fix the following compiler warning: > > > > CC src/providers/ldap/ldap_child-ldap_child.o > > ../src/providers/ldap/ldap_child.c: In

Re: [SSSD] [PATCH] ldap_child: initialized ccname_file_dummy

On Fri, Mar 06, 2015 at 11:41:25AM +0100, Sumit Bose wrote: > Hi, > > this patch should fix the following compiler warning: > > CC src/providers/ldap/ldap_child-ldap_child.o > ../src/providers/ldap/ldap_child.c: In Funktion »main«: > ../src/providers/ldap/ldap_child.c:503:160: Warnung: »cc

[SSSD] [PATCH] ldap_child: initialized ccname_file_dummy

Hi, this patch should fix the following compiler warning: CC src/providers/ldap/ldap_child-ldap_child.o ../src/providers/ldap/ldap_child.c: In Funktion »main«: ../src/providers/ldap/ldap_child.c:503:160: Warnung: »ccname_file_dummy« könnte in dieser Funktion uninitialisiert verwendet werde

Re: [SSSD] [PATCHES] SDAP: Lock out ssh keys when account naturally expires

On 03/06/2015 10:24 AM, Jakub Hrozek wrote: On Thu, Mar 05, 2015 at 02:34:15PM +0100, Pavel Reichl wrote: +case PWP_SENTINEL: +default: +DEBUG(SSSDBG_MINOR_FAILURE, + "Unexpected value of password policy mode: %d.\n", pwpol_mode); I guess it would be better to set

Re: [SSSD] [PATCHES] SDAP: Lock out ssh keys when account naturally expires

On Thu, Mar 05, 2015 at 02:34:15PM +0100, Pavel Reichl wrote: > >+case PWP_SENTINEL: > >+default: > >+DEBUG(SSSDBG_MINOR_FAILURE, > >+ "Unexpected value of password policy mode: %d.\n", > >pwpol_mode); > I guess it would be better to set 'ret = EINVAL;' here Oops, yes