Re: [SSSD] [PATCH] Add integration tests

2015-03-17 Thread Michal Židek
On 03/10/2015 11:21 AM, Nikolai Kondrashov wrote: On 02/27/2015 07:13 PM, Nikolai Kondrashov wrote: Hi everyone, This is my attempt to add basic integration tests. There are almost no tests there at the moment and this is mostly about the infrastructure and the way we might do it. I will be gl

Re: [SSSD] sssd caching hosts ?

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 02:46:32PM -0400, Dmitri Pal wrote: > On 03/17/2015 12:56 PM, Lukas Slebodnik wrote: > >On (17/03/15 17:26), Olivier wrote: > >>Hi everyone, > >> > >>I was wondering if host requests caching is still part of sssd plans : > >>https://fedorahosted.org/sssd/ticket/359 > >> > >T

Re: [SSSD] sssd caching hosts ?

2015-03-17 Thread Dmitri Pal
On 03/17/2015 12:56 PM, Lukas Slebodnik wrote: On (17/03/15 17:26), Olivier wrote: Hi everyone, I was wondering if host requests caching is still part of sssd plans : https://fedorahosted.org/sssd/ticket/359 This ticket is in deferred section which means that we do not plan to implement it in

Re: [SSSD] sssd caching hosts ?

2015-03-17 Thread Lukas Slebodnik
On (17/03/15 17:26), Olivier wrote: >Hi everyone, > >I was wondering if host requests caching is still part of sssd plans : >https://fedorahosted.org/sssd/ticket/359 > This ticket is in deferred section which means that we do not plan to implement it in near future. But contribution is welcomed ev

[SSSD] sssd caching hosts ?

2015-03-17 Thread Olivier
Hi everyone, I was wondering if host requests caching is still part of sssd plans : https://fedorahosted.org/sssd/ticket/359 Thanks, -- Olivier ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinf

Re: [SSSD] [PATCH] sdap: properly handle binary objectGuid attribute

2015-03-17 Thread Sumit Bose
On Tue, Mar 10, 2015 at 12:31:59PM +0100, Sumit Bose wrote: > On Mon, Mar 09, 2015 at 10:06:26AM +0100, Sumit Bose wrote: > > On Tue, Feb 17, 2015 at 05:05:37PM +0100, Sumit Bose wrote: > > > Hi, > > > > > > this patch tries to resolve https://fedorahosted.org/sssd/ticket/2588 by > > > properly ha

[SSSD] [PATCH] Handle malformed HBAC rules, deprecate and/or remove the ipa_hbac_treat_deny_as option

2015-03-17 Thread Jakub Hrozek
Hi, In some cases, like broken replication, we might encounter malformed objects in the cache when evaluating HBAC rules. Unless deny rules are in effect, we can skip those -- as implemented in the first three patches. The fourth patch is meant for the 1-12 branch to signal the ipa_hbac_treat_den

Re: [SSSD] [PATCH] Add missing new lines to debug messages

2015-03-17 Thread Lukas Slebodnik
On (17/03/15 14:46), Jakub Hrozek wrote: >On Tue, Mar 17, 2015 at 02:38:27PM +0100, Jakub Hrozek wrote: >> On Tue, Mar 17, 2015 at 12:59:53PM +0100, Lukas Slebodnik wrote: >> > On (13/03/15 13:35), Lukas Slebodnik wrote: >> > >On (18/02/15 16:18), Jakub Hrozek wrote: >> > >>On Wed, Feb 18, 2015 at

Re: [SSSD] [PATCH] selinux: Handle setup with empty default and no configured rules

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 03:12:50PM +0100, Michal Židek wrote: > On 03/16/2015 03:23 PM, Jakub Hrozek wrote: > >On Fri, Mar 13, 2015 at 04:26:10PM +0100, Michal Židek wrote: > >>On 03/13/2015 09:00 AM, Jakub Hrozek wrote: > >>>On Thu, Mar 12, 2015 at 10:35:14PM +0100, Michal Židek wrote: > On 03

Re: [SSSD] [PATCH] IPA idviews: check if view name is set

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 03:10:25PM +0100, Jakub Hrozek wrote: > On Tue, Mar 17, 2015 at 01:18:22PM +0100, Sumit Bose wrote: > > Hi, > > > > this patch should fix a segfault in the new view related code. > > > > bye, > > Sumit > > Because I don't have an old server around, I cheated a bit and set

Re: [SSSD] [PATCH] selinux: Handle setup with empty default and no configured rules

2015-03-17 Thread Michal Židek
On 03/16/2015 03:23 PM, Jakub Hrozek wrote: On Fri, Mar 13, 2015 at 04:26:10PM +0100, Michal Židek wrote: On 03/13/2015 09:00 AM, Jakub Hrozek wrote: On Thu, Mar 12, 2015 at 10:35:14PM +0100, Michal Židek wrote: On 03/12/2015 04:34 PM, Jakub Hrozek wrote: To reproduce, set the default context

Re: [SSSD] [PATCH] IPA idviews: check if view name is set

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 01:18:22PM +0100, Sumit Bose wrote: > Hi, > > this patch should fix a segfault in the new view related code. > > bye, > Sumit Because I don't have an old server around, I cheated a bit and set the view name to NULL. The lookup still worked. CI passed: http://sssd-ci.duck

Re: [SSSD] [PATCH] Add missing new lines to debug messages

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 02:38:27PM +0100, Jakub Hrozek wrote: > On Tue, Mar 17, 2015 at 12:59:53PM +0100, Lukas Slebodnik wrote: > > On (13/03/15 13:35), Lukas Slebodnik wrote: > > >On (18/02/15 16:18), Jakub Hrozek wrote: > > >>On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote: > > >>>

Re: [SSSD] [PATCH] Add missing new lines to debug messages

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 12:59:53PM +0100, Lukas Slebodnik wrote: > On (13/03/15 13:35), Lukas Slebodnik wrote: > >On (18/02/15 16:18), Jakub Hrozek wrote: > >>On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote: > >>> ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html > >> > >>

Re: [SSSD] [PATCH] MAN: Clarify debug_level a bit

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 01:09:49PM +0100, Lukas Slebodnik wrote: > On (17/03/15 13:03), Jakub Hrozek wrote: > >Hi, > > > >see the attached man page patch. > > >From 51a1175eaa278365eba4e78cbeeedb62001498f9 Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek > >Date: Tue, 17 Mar 2015 13:02:09 +0100 > >

[SSSD] [PATCH] IPA idviews: check if view name is set

2015-03-17 Thread Sumit Bose
Hi, this patch should fix a segfault in the new view related code. bye, Sumit From b00e00cd2e46583ed1434bc8271eba30cc2b375c Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Tue, 17 Mar 2015 11:08:05 +0100 Subject: [PATCH] IPA idviews: check if view name is set When working with older FreeIPA rel

Re: [SSSD] [PATCH] MAN: Clarify debug_level a bit

2015-03-17 Thread Lukas Slebodnik
On (17/03/15 13:03), Jakub Hrozek wrote: >Hi, > >see the attached man page patch. >From 51a1175eaa278365eba4e78cbeeedb62001498f9 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Tue, 17 Mar 2015 13:02:09 +0100 >Subject: [PATCH] MAN: Clarify debug_level a bit > >Some users are confused about pl

[SSSD] [PATCH] MAN: Clarify debug_level a bit

2015-03-17 Thread Jakub Hrozek
Hi, see the attached man page patch. >From 51a1175eaa278365eba4e78cbeeedb62001498f9 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Tue, 17 Mar 2015 13:02:09 +0100 Subject: [PATCH] MAN: Clarify debug_level a bit Some users are confused about placement of the debug_level directive or the locati

Re: [SSSD] [PATCH] Add missing new lines to debug messages

2015-03-17 Thread Lukas Slebodnik
On (13/03/15 13:35), Lukas Slebodnik wrote: >On (18/02/15 16:18), Jakub Hrozek wrote: >>On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote: >>> ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html >> >>I fixed the space-before-newline mentioned in the other mail and pushed >>the

Re: [SSSD] [PATCH] LDAP/AD: do not resolve group members during tokenGroups request

2015-03-17 Thread Jakub Hrozek
On Mon, Mar 16, 2015 at 03:07:44PM +0100, Jakub Hrozek wrote: > On Tue, Mar 10, 2015 at 03:43:41PM +0100, Sumit Bose wrote: > > Hi, > > > > with this patch I hope to improve the initgroup-request performance > > especially is the user is a member of many nested groups. Currently all > > groups the

Re: [SSSD] [PATCHES] ipa_selinux: Fix warning may be used uninitialized

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 11:47:32AM +0100, Jakub Hrozek wrote: > On Mon, Mar 16, 2015 at 03:09:59PM +0100, Jakub Hrozek wrote: > > On Fri, Mar 13, 2015 at 12:53:23PM +0100, Lukas Slebodnik wrote: > > > ehlo, > > > > > > There are warnings with gcc-5.0 and enabled optimisation. > > > > > > Patch1:

Re: [SSSD] [PATCHES] ipa_selinux: Fix warning may be used uninitialized

2015-03-17 Thread Jakub Hrozek
On Mon, Mar 16, 2015 at 03:09:59PM +0100, Jakub Hrozek wrote: > On Fri, Mar 13, 2015 at 12:53:23PM +0100, Lukas Slebodnik wrote: > > ehlo, > > > > There are warnings with gcc-5.0 and enabled optimisation. > > > > Patch1: > > You can see warning also in koji > > https://kojipkgs.fedoraproject.org/

Re: [SSSD] [PATCH] cache_req: fix ret may be uninitialized

2015-03-17 Thread Lukas Slebodnik
On (17/03/15 11:27), Pavel Březina wrote: >This warning somehow slipped in. >From fc6afcfe73a2a2fe3f2be7ac4a49c5bf56a18a09 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Pavel=20B=C5=99ezina?= >Date: Tue, 17 Mar 2015 11:26:41 +0100 >Subject: [PATCH] cache_req: fix ret may be uninitialized > >--- > src

Re: [SSSD] [PATCH] cache_req: fix ret may be uninitialized

2015-03-17 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 11:27:46AM +0100, Pavel Březina wrote: > This warning somehow slipped in. Lukas already fixed it, I just need to push the patches (sorry, haven't gotten to upstream today..) ___ sssd-devel mailing list sssd-devel@lists.fedorahoste

[SSSD] [PATCH] cache_req: fix ret may be uninitialized

2015-03-17 Thread Pavel Březina
This warning somehow slipped in. From fc6afcfe73a2a2fe3f2be7ac4a49c5bf56a18a09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 17 Mar 2015 11:26:41 +0100 Subject: [PATCH] cache_req: fix ret may be uninitialized --- src/responder/common/responder_cache_req.c | 2 +- 1

[SSSD] [PATCH] memberof: Do not create request with 0 attribute values

2015-03-17 Thread Lukas Slebodnik
ehlo, at first I thought it is related to ticket "#2576" but after simplification of reproducer I found out it just looks bad in log file. ldb failed to add attribute with 0 values to ldb entry, but it would not have any effect. BTW The best would be to immediately skip request. I'm not sure how