Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Jakub Hrozek
On Mon, Mar 23, 2015 at 05:03:03PM +0200, Nikolai Kondrashov wrote: > On 03/23/2015 03:59 PM, Lukas Slebodnik wrote: > >On (23/03/15 14:47), Pavel Reichl wrote: > >> > >> > >>On 03/23/2015 02:43 PM, Lukas Slebodnik wrote: > >>>On (23/03/15 14:18), Jakub Hrozek wrote: > On Mon, Mar 23, 2015 at 0

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Nikolai Kondrashov
On 03/23/2015 03:59 PM, Lukas Slebodnik wrote: On (23/03/15 14:47), Pavel Reichl wrote: On 03/23/2015 02:43 PM, Lukas Slebodnik wrote: On (23/03/15 14:18), Jakub Hrozek wrote: On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS Hm, the defa

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Pavel Reichl
On 03/23/2015 02:59 PM, Lukas Slebodnik wrote: On (23/03/15 14:47), Pavel Reichl wrote: On 03/23/2015 02:43 PM, Lukas Slebodnik wrote: On (23/03/15 14:18), Jakub Hrozek wrote: On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS Hm, the def

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Lukas Slebodnik
On (23/03/15 14:47), Pavel Reichl wrote: > > >On 03/23/2015 02:43 PM, Lukas Slebodnik wrote: >>On (23/03/15 14:18), Jakub Hrozek wrote: >>>On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS >>>Hm, the default CI test doesn't run

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Pavel Reichl
On 03/23/2015 02:43 PM, Lukas Slebodnik wrote: On (23/03/15 14:18), Jakub Hrozek wrote: On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS Hm, the default CI test doesn't run distcheck? I admit I haven't ran distcheck myself, but was relyin

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Lukas Slebodnik
On (23/03/15 14:18), Jakub Hrozek wrote: >On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> simple patch is attached. >> >> LS > >Hm, the default CI test doesn't run distcheck? > >I admit I haven't ran distcheck myself, but was relying on the CI link >Pavel sent.. T

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Jakub Hrozek
On Mon, Mar 23, 2015 at 02:18:40PM +0100, Jakub Hrozek wrote: > On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: > > ehlo, > > > > simple patch is attached. > > > > LS > > Hm, the default CI test doesn't run distcheck? > > I admit I haven't ran distcheck myself, but was relying

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Jakub Hrozek
On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote: > ehlo, > > simple patch is attached. > > LS Hm, the default CI test doesn't run distcheck? I admit I haven't ran distcheck myself, but was relying on the CI link Pavel sent.. ___ sssd-d

[SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-23 Thread Lukas Slebodnik
ehlo, simple patch is attached. LS >From c6a4f4d9707aac3401f602c6042c1620ef2d961a Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 23 Mar 2015 14:04:28 +0100 Subject: [PATCH] BUILD: Add missing header file to tarball make distcheck failed due to missing header file. ../src/tests/cmo

Re: [SSSD] [PATCHES] ldap: refactor - reuse sss_utc_to_time_t()

2015-03-23 Thread Jakub Hrozek
On Mon, Mar 23, 2015 at 12:06:12PM +0100, Jakub Hrozek wrote: > On Mon, Mar 23, 2015 at 10:48:59AM +0100, Pavel Reichl wrote: > > >> From 4236caecdc9981d10f777e90a65aa60cd92445df Mon Sep 17 00:00:00 2001 > > >>From: Pavel Reichl > > >>Date: Fri, 6 Mar 2015 04:29:24 -0500 > > >>Subject: [PATCH 1/3]

Re: [SSSD] [PATCHES] ldap: refactor - reuse sss_utc_to_time_t()

2015-03-23 Thread Jakub Hrozek
On Mon, Mar 23, 2015 at 10:48:59AM +0100, Pavel Reichl wrote: > >> From 4236caecdc9981d10f777e90a65aa60cd92445df Mon Sep 17 00:00:00 2001 > >>From: Pavel Reichl > >>Date: Fri, 6 Mar 2015 04:29:24 -0500 > >>Subject: [PATCH 1/3] TESTS: test expiration > >Sorry, more nitpicks. I should have sent them

Re: [SSSD] [PATCH] Add integration tests

2015-03-23 Thread Nikolai Kondrashov
On 03/23/2015 11:12 AM, Jakub Hrozek wrote: On Fri, Feb 27, 2015 at 07:13:37PM +0200, Nikolai Kondrashov wrote: Hi everyone, This is my attempt to add basic integration tests. There are almost no tests there at the moment and this is mostly about the infrastructure and the way we might do it.

Re: [SSSD] [PATCHES] ldap: refactor - reuse sss_utc_to_time_t()

2015-03-23 Thread Pavel Reichl
ci passed: http://sssd-ci.duckdns.org/logs/job/11/40/summary.html ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] ldap: refactor - reuse sss_utc_to_time_t()

2015-03-23 Thread Pavel Reichl
On 03/20/2015 06:44 PM, Jakub Hrozek wrote: On Fri, Mar 20, 2015 at 04:58:38PM +0100, Pavel Reichl wrote: On 03/20/2015 03:26 PM, Jakub Hrozek wrote: On Fri, Mar 20, 2015 at 01:13:35PM +0100, Pavel Reichl wrote: I wonder why didn't you create a single pwexpire test instead? The file names are

Re: [SSSD] [PATCH] memberof: Do not create request with 0 attribute values

2015-03-23 Thread Jakub Hrozek
On Mon, Mar 23, 2015 at 09:52:29AM +0100, Jakub Hrozek wrote: > I will just fix this comment before pushing. Otherwise ACK. > > > +msg->num_elements = 0; > > +} > > + > > mod_ctx->igh->mod_msg = msg; > > mod_ctx->igh->el = el; > > > > -- > > 2.3.2 > > * master: 999c87114

Re: [SSSD] [PATCH] Add integration tests

2015-03-23 Thread Jakub Hrozek
On Fri, Feb 27, 2015 at 07:13:37PM +0200, Nikolai Kondrashov wrote: > Hi everyone, > > This is my attempt to add basic integration tests. There are almost no tests > there at the moment and this is mostly about the infrastructure and the way we > might do it. > > I will be glad to answer any ques

Re: [SSSD] [PATCH] memberof: Do not create request with 0 attribute values

2015-03-23 Thread Jakub Hrozek
On Tue, Mar 17, 2015 at 09:59:03AM +0100, Lukas Slebodnik wrote: > ehlo, > > at first I thought it is related to ticket "#2576" > but after simplification of reproducer I found out it just looks > bad in log file. > > ldb failed to add attribute with 0 values to ldb entry, but it would not have >

Re: [SSSD] [PATCH] Make several LDAP operation timeouts configurable

2015-03-23 Thread Jakub Hrozek
On Fri, Mar 20, 2015 at 03:03:14PM +0100, Pavel Reichl wrote: > On 03/10/2015 02:50 PM, Jakub Hrozek wrote: > >On Tue, Mar 10, 2015 at 02:16:52PM +0100, Jakub Hrozek wrote: > >>Hi, > >> > >>the attached patches resolve https://fedorahosted.org/sssd/ticket/1501 > >> > >>They were confirmed to work b

Re: [SSSD] [PATCH] LDAP: remove unused code

2015-03-23 Thread Jakub Hrozek
On Fri, Mar 20, 2015 at 06:54:32PM +0100, Jakub Hrozek wrote: > On Fri, Mar 20, 2015 at 11:38:40AM +0100, Pavel Reichl wrote: > > >sssd-devel mailing list > > >sssd-devel@lists.fedorahosted.org > > >https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > > ci passed: > > > > http://sssd-ci.du

Re: [SSSD] [PATCH] GPO: error out instead of leaving array element uninitialized

2015-03-23 Thread Jakub Hrozek
On Fri, Mar 20, 2015 at 07:48:34PM +0100, Sumit Bose wrote: > On Fri, Mar 20, 2015 at 06:52:17PM +0100, Jakub Hrozek wrote: > > On Fri, Mar 20, 2015 at 06:47:09PM +0100, Sumit Bose wrote: > > > Hi, > > > > > > this patch should fix a segfault which was recently found in the GPO > > > code. > > >