[SSSD] More upstream CI tests

2015-08-19 Thread Jakub Hrozek
Hi, as we're stabilizing the 1.13 branch and before we plan what we want to work on during the 1.14 development, we should use that time to write some more tests! Here are some areas where we could add tests. Please discuss or add your ideas, I would like to turn this list into tickets we can sta

Re: [SSSD] [PATCH] NSS: Fix use after free

2015-08-19 Thread Jakub Hrozek
On Thu, Aug 13, 2015 at 07:41:02AM +0200, Lukas Slebodnik wrote: > On (12/08/15 14:17), Jakub Hrozek wrote: > >On Mon, Aug 10, 2015 at 06:38:29AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> Use after free can happed if there are two domains and user is not found > >> in the first one. > >>

Re: [SSSD] [PATCH] sss_override: support domains that requires fqname

2015-08-19 Thread Jakub Hrozek
On Wed, Aug 19, 2015 at 01:52:10PM +0200, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/2757 > > I wrote it on top of my previous override patches, but I think it will apply > on master. ACK (but please fix the ordering issue with the other patches) ___

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-19 Thread Jakub Hrozek
On Wed, Aug 19, 2015 at 12:46:23PM +0200, Pavel Březina wrote: > On 08/18/2015 05:24 PM, Pavel Březina wrote: > >On 08/16/2015 05:59 PM, Pavel Březina wrote: > >>https://fedorahosted.org/sssd/ticket/2737 > >> > >>Hi, it should work... :-) However, I wanted to make import as > >>transaction so no ch

[SSSD] [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-19 Thread Michal Židek
Hi! This is another patch to avoid failing tests in the CI (make-check-valgrind). This time the ldap_id_cleanup tests. Looks like the one second cache timeout was too short and the tests sometimes failed because they expected the entries to be still valid for a short while after they were added

Re: [SSSD] [PATCH] SYSDB: Index the objectSIDString attribute

2015-08-19 Thread Jakub Hrozek
On Tue, Aug 18, 2015 at 05:31:43PM +0200, Michal Židek wrote: > On 08/17/2015 10:35 PM, Jakub Hrozek wrote: > >Hi, > > > >the attached patch was confirmed to work, so the code review should be > >easy. But because it adds an index to objectSID, which all AD objects > >have, there are two catches: >

Re: [SSSD] [PATCH] sdap_async: Use specific errmsg when available

2015-08-19 Thread Jakub Hrozek
On Wed, Aug 19, 2015 at 03:40:48PM +0200, Pavel Reichl wrote: > > > On 08/19/2015 01:02 PM, Michal Židek wrote: > >On 08/19/2015 10:12 AM, Jakub Hrozek wrote: > >>On Tue, Aug 18, 2015 at 09:34:09PM +0200, Michal Židek wrote: > >>>Hi! > >>> > >>>The attached change was requested by: > >>>https://b

Re: [SSSD] [PATCH] UTIL: Alternative way for debug message initialisation

2015-08-19 Thread Michal Židek
On 08/12/2015 01:11 PM, Lukas Slebodnik wrote: ehlo, attached patch shoul avoid situation as in commit 7c69221077c780e62f6c536e78675f2dc1c131bc The comments does not guarantee anything. Author: Michal Zidek Date: Tue Mar 10 17:30:48 2015 +0100 DEBUG: Add missing strings for error mess

Re: [SSSD] [PATCH] sdap_async: Use specific errmsg when available

2015-08-19 Thread Pavel Reichl
On 08/19/2015 01:02 PM, Michal Židek wrote: On 08/19/2015 10:12 AM, Jakub Hrozek wrote: On Tue, Aug 18, 2015 at 09:34:09PM +0200, Michal Židek wrote: Hi! The attached change was requested by: https://bugzilla.redhat.com/show_bug.cgi?id=1254723 Thanks, Michal Thanks for the patch. Can you

[SSSD] [PATCH] sss_override: support domains that requires fqname

2015-08-19 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2757 I wrote it on top of my previous override patches, but I think it will apply on master. >From 8b44829f117e8078a65f0d167f2ad44ecc467497 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 19 Aug 2015 12:28:21 +0200 Subject: [PATCH]

Re: [SSSD] [PATCH] sdap_async: Use specific errmsg when available

2015-08-19 Thread Michal Židek
On 08/19/2015 10:12 AM, Jakub Hrozek wrote: On Tue, Aug 18, 2015 at 09:34:09PM +0200, Michal Židek wrote: Hi! The attached change was requested by: https://bugzilla.redhat.com/show_bug.cgi?id=1254723 Thanks, Michal Thanks for the patch. Can you please resubmit wit the ticket URL in the comm

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-19 Thread Pavel Březina
On 08/18/2015 05:24 PM, Pavel Březina wrote: On 08/16/2015 05:59 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with it so I gave up

Re: [SSSD] [PATCH] sdap_async: Use specific errmsg when available

2015-08-19 Thread Jakub Hrozek
On Tue, Aug 18, 2015 at 09:34:09PM +0200, Michal Židek wrote: > Hi! > > The attached change was requested by: > https://bugzilla.redhat.com/show_bug.cgi?id=1254723 > > Thanks, > > Michal Thanks for the patch. Can you please resubmit wit the ticket URL in the commit message and build a test RPM