Re: [SSSD] [PATCH] LDAP: Do not impose sizelimit=1 for single-entry searches

2015-09-21 Thread Lukas Slebodnik
On (21/09/15 16:50), Jakub Hrozek wrote: >On Mon, Sep 21, 2015 at 03:29:20PM +0200, Lukas Slebodnik wrote: >> On (17/09/15 09:38), Jakub Hrozek wrote: >> >On Thu, Sep 17, 2015 at 09:35:11AM +0200, Jakub Hrozek wrote: >> >> > After just only a month since the nack, attached are updated patches. I >>

Re: [SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

2015-09-21 Thread Lukas Slebodnik
On (21/09/15 17:00), Jakub Hrozek wrote: >On Fri, Sep 18, 2015 at 03:39:50PM +0200, Pavel Březina wrote: >> On 09/01/2015 11:06 AM, Lukas Slebodnik wrote: >> >ehlo, >> > >> >attached is alternative version for ticket 2744. >> >The unit test passed but there is a performance improvement. >> > >> >If

Re: [SSSD] [PATCHES] DYDNDS: update quality of input for nsupdate

2015-09-21 Thread Jakub Hrozek
On Mon, Sep 21, 2015 at 01:03:13PM +0200, Pavel Reichl wrote: > > > On 09/21/2015 10:52 AM, Pavel Březina wrote: > >On 08/28/2015 11:05 AM, Pavel Reichl wrote: > >>On 08/14/2015 04:12 PM, Jakub Hrozek wrote: > > >>Test failed because of missing patch [PATCH 6/9] DYNDNS: use realm and > >>server

Re: [SSSD] [PATCH] DDNS: execute nsupdate for single update of PTR rec

2015-09-21 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 05:51:47PM +0200, Pavel Reichl wrote: > > > On 09/18/2015 02:22 PM, Jakub Hrozek wrote: > > > >I would just like to squash these style changes: > > > > > > diff --git a/src/providers/ldap/sdap_dyndns.c > > b/src/providers/ldap/sdap_dyndns.c > > index c80a468..673f

Re: [SSSD] [PATCH] sss_override: remove -d from manpage

2015-09-21 Thread Jakub Hrozek
On Sun, Sep 20, 2015 at 05:21:03PM +0200, Pavel Reichl wrote: > > > On 09/18/2015 03:56 PM, Pavel Březina wrote: > >Even though Lukas caught -d in command line help, I kinda managed to keep it > >in manual page. > > ack * master: 8ca1a503cf82fe2c9ed6af9d5903a158496be122 ___

Re: [SSSD] [PATCH] Temporarily mark subdomain as inactive instead marking the whole back end offline

2015-09-21 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 03:11:28PM +0200, Pavel Březina wrote: > On 09/18/2015 03:03 PM, Jakub Hrozek wrote: > >On Fri, Sep 18, 2015 at 11:04:36AM +0200, Jakub Hrozek wrote: > >>On Thu, Sep 17, 2015 at 10:41:07PM +0200, Pavel Březina wrote: > >>>On 09/04/2015 02:35 PM, Jakub Hrozek wrote: > Hi,

Re: [SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

2015-09-21 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 03:39:50PM +0200, Pavel Březina wrote: > On 09/01/2015 11:06 AM, Lukas Slebodnik wrote: > >ehlo, > > > >attached is alternative version for ticket 2744. > >The unit test passed but there is a performance improvement. > > > >If we compare 3rd patch to current master than > >t

Re: [SSSD] [PATCH] LDAP: Do not impose sizelimit=1 for single-entry searches

2015-09-21 Thread Jakub Hrozek
On Mon, Sep 21, 2015 at 03:29:20PM +0200, Lukas Slebodnik wrote: > On (17/09/15 09:38), Jakub Hrozek wrote: > >On Thu, Sep 17, 2015 at 09:35:11AM +0200, Jakub Hrozek wrote: > >> > After just only a month since the nack, attached are updated patches. I > >> > would prefer to only apply the first one

Re: [SSSD] [PATCH] PAM: Add pam environment variable AUTH_DOMAIN to pam reply

2015-09-21 Thread Jakub Hrozek
On Mon, Sep 21, 2015 at 04:34:33PM +0200, Michal Židek wrote: > On 09/13/2015 11:30 AM, Jakub Hrozek wrote: > >On Wed, Jun 10, 2015 at 03:36:04PM +0200, Michal Židek wrote: > >>Hi! > >> > >>See the attached patch that adds the AUTH_DOMAIN variable > >>to pam reply. > >> > >>Ticket: > >>https://fedo

Re: [SSSD] [PATCH] PAM: Add pam environment variable AUTH_DOMAIN to pam reply

2015-09-21 Thread Michal Židek
On 09/13/2015 11:30 AM, Jakub Hrozek wrote: On Wed, Jun 10, 2015 at 03:36:04PM +0200, Michal Židek wrote: Hi! See the attached patch that adds the AUTH_DOMAIN variable to pam reply. Ticket: https://fedorahosted.org/sssd/ticket/2476 Thanks, Michal There are some issues with PAM srv test afte

[SSSD] [PATCH] confdb: warn if memcache_timeout > than entry_cache

2015-09-21 Thread Pavel Reichl
Hello, please see simple patch attached. >From 36e31732dd759c8c6b302c75d050a11fe1ea594a Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Mon, 21 Sep 2015 10:26:20 -0400 Subject: [PATCH] confdb: warn if memcache_timeout > than entry_cache Only group and user records are cached in memory cache so

Re: [SSSD] [PATCH] LDAP: Do not impose sizelimit=1 for single-entry searches

2015-09-21 Thread Lukas Slebodnik
On (17/09/15 09:38), Jakub Hrozek wrote: >On Thu, Sep 17, 2015 at 09:35:11AM +0200, Jakub Hrozek wrote: >> > After just only a month since the nack, attached are updated patches. I >> > would prefer to only apply the first one to downstream, since the others >> > are just optimizations and tests. >

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-21 Thread Petr Cech
On 09/21/2015 01:27 PM, Sumit Bose wrote: Hello Sumit, > >there is next version of patch addresing your comments. > >I didn't use statement like ># state->ipa_opts->id->user_map[SDAP_AT_USER_MEMBEROF].sys_name >because we don't have any for originalMemberOf. I'm not sure if I added we have, sta

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-21 Thread Pavel Reichl
Unless other reviewers oppose I think we can ACK the patch. Code LGTM. CI passed: http://sssd-ci.duckdns.org/logs/job/26/94/summary.html ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-d

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-21 Thread Sumit Bose
On Fri, Sep 18, 2015 at 02:33:03PM +0200, Petr Cech wrote: > On 09/14/2015 01:53 PM, Sumit Bose wrote: > >Hi Petr, > > > >thank you for your patience. Both versions of your patches work as > >expected and fixes the issues with group and nested group memberships. > > > >After testing a reading the c

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-21 Thread Michal Židek
On 09/20/2015 05:07 PM, Pavel Reichl wrote: On 09/18/2015 05:07 PM, Michal Židek wrote: +static errno_t check_cert(struct cli_ctx *cctx, + struct pam_ctx *pctx, + struct tevent_req *req, What's the point of parameter *req? You are not reading

Re: [SSSD] [PATCHES] DYDNDS: update quality of input for nsupdate

2015-09-21 Thread Pavel Reichl
On 09/21/2015 10:52 AM, Pavel Březina wrote: On 08/28/2015 11:05 AM, Pavel Reichl wrote: On 08/14/2015 04:12 PM, Jakub Hrozek wrote: Test failed because of missing patch [PATCH 6/9] DYNDNS: use realm and server commands only as fallback I must have skipped it while respinning the patch se

Re: [SSSD] [PATCHES] fix minor memory leaks

2015-09-21 Thread Lukas Slebodnik
On (21/09/15 10:59), Pavel Březina wrote: >On 09/21/2015 10:58 AM, Lukas Slebodnik wrote: >>On (21/09/15 10:40), Pavel Březina wrote: >>>On 09/20/2015 07:58 PM, Pavel Reichl wrote: On 09/04/2015 01:56 PM, Jakub Hrozek wrote: >On Fri, Sep 04, 2015 at 01:09:36PM +0200, Pavel Reichl

Re: [SSSD] [PATCHES] fix minor memory leaks

2015-09-21 Thread Pavel Březina
On 09/21/2015 10:58 AM, Lukas Slebodnik wrote: On (21/09/15 10:40), Pavel Březina wrote: On 09/20/2015 07:58 PM, Pavel Reichl wrote: On 09/04/2015 01:56 PM, Jakub Hrozek wrote: On Fri, Sep 04, 2015 at 01:09:36PM +0200, Pavel Reichl wrote: Hello, please see simple patch set fixing minor mem

Re: [SSSD] [PATCHES] fix minor memory leaks

2015-09-21 Thread Lukas Slebodnik
On (21/09/15 10:40), Pavel Březina wrote: >On 09/20/2015 07:58 PM, Pavel Reichl wrote: >> >> >>On 09/04/2015 01:56 PM, Jakub Hrozek wrote: >>>On Fri, Sep 04, 2015 at 01:09:36PM +0200, Pavel Reichl wrote: Hello, please see simple patch set fixing minor memory leaks of providers. I'm

Re: [SSSD] [PATCHES] DYDNDS: update quality of input for nsupdate

2015-09-21 Thread Pavel Březina
On 08/28/2015 11:05 AM, Pavel Reichl wrote: On 08/14/2015 04:12 PM, Jakub Hrozek wrote: On Thu, Aug 13, 2015 at 05:31:07PM +0200, Pavel Reichl wrote: On 08/13/2015 02:12 PM, Pavel Reichl wrote: Sorry, this time with correct patches! ___ sssd-devel

Re: [SSSD] [PATCHES] fix minor memory leaks

2015-09-21 Thread Pavel Březina
On 09/20/2015 07:58 PM, Pavel Reichl wrote: On 09/04/2015 01:56 PM, Jakub Hrozek wrote: On Fri, Sep 04, 2015 at 01:09:36PM +0200, Pavel Reichl wrote: Hello, please see simple patch set fixing minor memory leaks of providers. I'm not aware of any user hitting those currently. Thanks! Fro