On Wed, Sep 23, 2015 at 04:48:51PM +0200, Sumit Bose wrote:
> Hi,
>
> the attached patch was provided by the reporter of
> https://fedorahosted.org/sssd/ticket/2803 . I'm sending it here for
> completeness.
>
> I verified with valgrind that it fixes the memory leak and CI passes
> http://sssd-ci.
On Wed, Sep 23, 2015 at 09:26:53PM +0200, Pavel Březina wrote:
> On 09/22/2015 03:03 PM, Pavel Reichl wrote:
> >Hello,
> >
> >please see attached patch.
> >
> >Thanks!
>
> Hi,
>
> >-state->filter = talloc_asprintf(state, "(|(%s=*)(%s=*))",
> >+state->filter = talloc_asprintf(state,
> >+
Yes, you are missing the rest of the patch :-)
errno = 0;
strtouint32(vals[0]->bv_val, &endptr, 10);
if (errno || *endptr || (vals[0]->bv_val == endptr)) {
-DEBUG(SSSDBG_OP_FAILURE,
+DEBUG(SSSDBG_MINOR_FAILURE,
"POSIX attribute is not a number: %s\n",
On 09/22/2015 03:03 PM, Pavel Reichl wrote:
Hello,
please see attached patch.
Thanks!
Hi,
-state->filter = talloc_asprintf(state, "(|(%s=*)(%s=*))",
+state->filter = talloc_asprintf(state,
+"(|(&(%s=*)(objectclass=%s))(&(%s=*)(objectclass=%s)))",
On Wed, Sep 23, 2015 at 09:00:04PM +0200, Pavel Březina wrote:
> On 09/23/2015 01:29 PM, Lukas Slebodnik wrote:
> >ehlo,
> >
> >simple patch is attached.
> >
> >LS
>
> >-if (errno != 0) {
> >-ret = errno;
> >+ret = errno;
> >+if (ret != 0) {
> > goto done;
> > }
>
On 09/23/2015 01:29 PM, Lukas Slebodnik wrote:
ehlo,
simple patch is attached.
LS
-if (errno != 0) {
-ret = errno;
+ret = errno;
+if (ret != 0) {
goto done;
}
Hi,
if we are checking ret, it may be nicer to test against EOK since that
is what we usually do
On 09/23/2015 01:08 PM, Pavel Reichl wrote:
On 09/22/2015 11:09 PM, Jakub Hrozek wrote:
On Tue, Sep 22, 2015 at 04:50:02PM -0400, Pavel Brezina wrote:
- Original Message -
From: "Pavel Reichl"
To: sssd-devel@lists.fedorahosted.org
Sent: Tuesday, September 22, 2015 1:31:45 PM
Subje
On Wed, Sep 23, 2015 at 03:01:42PM +0200, Jakub Hrozek wrote:
> On Wed, Sep 23, 2015 at 10:09:40AM +0200, Jakub Hrozek wrote:
> > Hi,
> >
> > the attached patches fix https://fedorahosted.org/sssd/ticket/2639
> >
> > The first patches always retry fetching the keytab on lookup failure.
> >
> > F
On Wed, Jul 29, 2015 at 06:44:08PM +0200, Jakub Hrozek wrote:
> * master: b0ee27fd94f1d20d9c220754ae008a3189752287
Also pushed to sssd-1-12 as f230eda50faaf95b5aaac7f4ec5ad6ab338930b1
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://
On Tue, Sep 22, 2015 at 10:35:09AM +0200, Pavel Březina wrote:
> >LS
>
> Ack.
CI on sssd-1-12 passed:
http://sssd-ci.duckdns.org/logs/job/27/63/summary.html
(Debian test failure is unrelated, we only fixed the dyndns test in
master)
Pushed to sssd-1-12 as:
28dff998717b8bc70e28f39a8c7e3720c0
Hi,
the attached patch was provided by the reporter of
https://fedorahosted.org/sssd/ticket/2803 . I'm sending it here for
completeness.
I verified with valgrind that it fixes the memory leak and CI passes
http://sssd-ci.duckdns.org/logs/job/27/57/summary.html, so I gave ACK
and pushed it to
ma
On (23/09/15 06:40), Lukas Slebodnik wrote:
>On (22/09/15 13:42), Jakub Hrozek wrote:
>>On Tue, Sep 22, 2015 at 11:21:33AM +0200, Pavel Březina wrote:
>>> On 09/22/2015 10:36 AM, Jakub Hrozek wrote:
>>> >Hi,
>>> >
>>> >one of my recent patches broke test builds on Debian. The attached patch
>>> >fi
On Wed, Sep 23, 2015 at 02:09:22PM +0200, Pavel Reichl wrote:
> On 09/23/2015 02:01 PM, Lukas Slebodnik wrote:
> >ehlo,
> >
> >another patch which should fix warning
> >reported by static analyzers.
> >
> >LS
>
> ack
* master: 75889713afc99ea52f4ff13b40672a12b28bdd41
_
On Wed, Sep 23, 2015 at 10:09:40AM +0200, Jakub Hrozek wrote:
> Hi,
>
> the attached patches fix https://fedorahosted.org/sssd/ticket/2639
>
> The first patches always retry fetching the keytab on lookup failure.
>
> For the last two patches, I used Sumit's idea to check the last connection
> ti
Hi everyone,
I'm working on adding more LDAP integration tests upstream and here are some
first results: basic user/group/membership addition/removal tests.
Admittedly they're very basic, although needed some research first.
What I'd like to get is some feedback and also a solution to one issue
On 09/23/2015 02:01 PM, Lukas Slebodnik wrote:
ehlo,
another patch which should fix warning
reported by static analyzers.
LS
ack
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-
ehlo,
another patch which should fix warning
reported by static analyzers.
LS
>From ed143ebfbf69b1e383ba6c6276eb160d0743b9c7 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Wed, 23 Sep 2015 13:50:22 +0200
Subject: [PATCH] DYNDNS: Return right error code in case of failure
The variable will
ehlo,
simple patch is attached.
LS
>From 5d572ec0e499c43416b791cf4c92ca49ca88f924 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Wed, 23 Sep 2015 13:24:53 +0200
Subject: [PATCH] IFP: Suppress warning from static analyzer
It seems that clang expected that errno can change to 0
in case of e
On 09/22/2015 11:09 PM, Jakub Hrozek wrote:
On Tue, Sep 22, 2015 at 04:50:02PM -0400, Pavel Brezina wrote:
- Original Message -
From: "Pavel Reichl"
To: sssd-devel@lists.fedorahosted.org
Sent: Tuesday, September 22, 2015 1:31:45 PM
Subject: Re: [SSSD] [PATCH] confdb: warn if memcac
On (23/09/15 06:40), Lukas Slebodnik wrote:
>On (22/09/15 13:42), Jakub Hrozek wrote:
>>On Tue, Sep 22, 2015 at 11:21:33AM +0200, Pavel Březina wrote:
>>> On 09/22/2015 10:36 AM, Jakub Hrozek wrote:
>>> >Hi,
>>> >
>>> >one of my recent patches broke test builds on Debian. The attached patch
>>> >fi
Hi,
the attached patches fix https://fedorahosted.org/sssd/ticket/2639
The first patches always retry fetching the keytab on lookup failure.
For the last two patches, I used Sumit's idea to check the last connection
time of the AD LDAP connection and compare it with the TDO modifyTimestamp
to on
21 matches
Mail list logo
