Re: [SSSD] [PATCH] LDAP: Fix leak of file descriptors

On (04/11/15 20:39), Jakub Hrozek wrote: >On Wed, Nov 04, 2015 at 03:22:20PM +0100, Lukas Slebodnik wrote: >> >Do you think it would be safer to initialize state->sd to -1 after the >> >state is created and only close state->sd if it's > 1? I think if the >> >socket() call would fail, then state->s

Re: [SSSD] [PATCH] LDAP: Fix leak of file descriptors

On Wed, Nov 04, 2015 at 03:22:20PM +0100, Lukas Slebodnik wrote: > >Do you think it would be safer to initialize state->sd to -1 after the > >state is created and only close state->sd if it's > 1? I think if the > >socket() call would fail, then state->sd was 0 (because tevent uses > >talloc_zero t

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 06:41 PM, Sumit Bose wrote: On Wed, Nov 04, 2015 at 06:00:34PM +0100, Pavel Reichl wrote: On 11/04/2015 03:02 PM, Lukas Slebodnik wrote: On (04/11/15 14:40), Pavel Reichl wrote: Also one of few not yet tested corners of pam_reply() - 'Printing account expiration warning fo

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On Wed, Nov 04, 2015 at 06:00:34PM +0100, Pavel Reichl wrote: > > > On 11/04/2015 03:02 PM, Lukas Slebodnik wrote: > >On (04/11/15 14:40), Pavel Reichl wrote: > > >> > >>Also one of few not yet tested corners of pam_reply() - 'Printing account > >>expiration warning for sshd' requires pam_servic

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 03:02 PM, Lukas Slebodnik wrote: On (04/11/15 14:40), Pavel Reichl wrote: Also one of few not yet tested corners of pam_reply() - 'Printing account expiration warning for sshd' requires pam_service to be sshd, but I can change when I will write another test (it might happen so

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 01:42 PM, Lukas Slebodnik wrote: From fa082a04387ed83f1b12316d388b63a08ba1305d Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Tue, 20 Oct 2015 09:10:30 -0400 Subject: [PATCH 2/3] TESTS: extend PAM responder unit test Extend PAM responder unit test to check 'online' cached auth

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

On 11/04/2015 04:25 PM, Michal Židek wrote: On 11/03/2015 06:30 PM, Nikolai Kondrashov wrote: Now, I think I got confused here. I'm not actually testing negative cache, but only the fact that the changes to LDAP don't appear before the caches expire. Since the negative cache timeout equals the t

Re: [SSSD] [PATCH] BUILD: Fix doc directory for sss_simpleifp

On (04/11/15 12:59), Jakub Hrozek wrote: >On Thu, Oct 29, 2015 at 12:01:39PM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> make all docs && make install DESTDIR=`pwd`/_instdir >> will not install doxygen generated files for sss_simpleifp >> because directory was wrong. >> >> Simple patch is attach

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

On 11/03/2015 06:30 PM, Nikolai Kondrashov wrote: On 10/29/2015 04:52 PM, Michal Židek wrote: On 10/27/2015 04:10 PM, Nikolai Kondrashov wrote: On 10/23/2015 02:54 PM, Michal Židek wrote: +def format_interactive_conf(ldap_conn, schema): +"""Format an SSSD configuration with all caches refr

Re: [SSSD] [PATCH] LDAP: Fix leak of file descriptors

On (04/11/15 11:17), Jakub Hrozek wrote: >On Thu, Oct 22, 2015 at 01:47:18PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> Details are in commit message. BTW it would be good to have at least two >> reviews. >> >> Reproducer which I used for https://fedorahosted.org/sssd/ticket/2792: >> >> Setup:

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On (04/11/15 14:40), Pavel Reichl wrote: > > >On 11/04/2015 02:23 PM, Sumit Bose wrote: >>On Wed, Nov 04, 2015 at 01:58:51PM +0100, Pavel Reichl wrote: >>> >>> >>>On 11/04/2015 01:19 PM, Lukas Slebodnik wrote: On (04/11/15 13:14), Pavel Reichl wrote: > > >On 11/04/2015 12:53 PM, Jak

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 02:23 PM, Sumit Bose wrote: On Wed, Nov 04, 2015 at 01:58:51PM +0100, Pavel Reichl wrote: On 11/04/2015 01:19 PM, Lukas Slebodnik wrote: On (04/11/15 13:14), Pavel Reichl wrote: On 11/04/2015 12:53 PM, Jakub Hrozek wrote: From f9b5adc160d6c18c429cc4e12276896ccc6f7a6d Mo

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On Wed, Nov 04, 2015 at 01:58:51PM +0100, Pavel Reichl wrote: > > > On 11/04/2015 01:19 PM, Lukas Slebodnik wrote: > >On (04/11/15 13:14), Pavel Reichl wrote: > >> > >> > >>On 11/04/2015 12:53 PM, Jakub Hrozek wrote: > >>> > From f9b5adc160d6c18c429cc4e12276896ccc6f7a6d Mon Sep 17 00:00:00 2

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 01:45 PM, Lukas Slebodnik wrote: Subject: [PATCH 2/3] TESTS: extend PAM responder unit test and maybe title of commit message could be changed as well. Becuase many changes to unit tests mean extending unit test. BTW. prefix "TEST:" usually means that tou adding new test or you

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 01:19 PM, Lukas Slebodnik wrote: On (04/11/15 13:14), Pavel Reichl wrote: On 11/04/2015 12:53 PM, Jakub Hrozek wrote: From f9b5adc160d6c18c429cc4e12276896ccc6f7a6d Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Tue, 20 Oct 2015 09:13:53 -0400 Subject: [PATCH 3/3] TESTS:

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On (04/11/15 13:42), Lukas Slebodnik wrote: >On (20/10/15 15:21), Pavel Reichl wrote: >>Hello, >> >>please see first iteration of extended PAM responder unit tests. > >>From 7cd365de5c306cb42901e510ff14df1b76c6bddb Mon Sep 17 00:00:00 2001 >>From: Pavel Reichl >>Date: Tue, 20 Oct 2015 08:07:02 -04

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On (20/10/15 15:21), Pavel Reichl wrote: >Hello, > >please see first iteration of extended PAM responder unit tests. >From 7cd365de5c306cb42901e510ff14df1b76c6bddb Mon Sep 17 00:00:00 2001 >From: Pavel Reichl >Date: Tue, 20 Oct 2015 08:07:02 -0400 >Subject: [PATCH 1/3] TESTS: split pam_test_setup

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On (04/11/15 13:14), Pavel Reichl wrote: > > >On 11/04/2015 12:53 PM, Jakub Hrozek wrote: >> >>> From f9b5adc160d6c18c429cc4e12276896ccc6f7a6d Mon Sep 17 00:00:00 2001 >>>From: Pavel Reichl >>>Date: Tue, 20 Oct 2015 09:13:53 -0400 >>>Subject: [PATCH 3/3] TESTS: fix typo in PAM service name >> >>Wh

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On 11/04/2015 12:53 PM, Jakub Hrozek wrote: From f9b5adc160d6c18c429cc4e12276896ccc6f7a6d Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Tue, 20 Oct 2015 09:13:53 -0400 Subject: [PATCH 3/3] TESTS: fix typo in PAM service name What is the purpose of this patch? Just to match the service

Re: [SSSD] [PATCH] BUILD: Fix doc directory for sss_simpleifp

On Thu, Oct 29, 2015 at 12:01:39PM +0100, Lukas Slebodnik wrote: > ehlo, > > make all docs && make install DESTDIR=`pwd`/_instdir > will not install doxygen generated files for sss_simpleifp > because directory was wrong. > > Simple patch is attached. > > LS ACK CI: http://sssd-ci.duckdns.org/

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

On Tue, Oct 20, 2015 at 03:21:50PM +0200, Pavel Reichl wrote: > Hello, > > please see first iteration of extended PAM responder unit tests. > From 7cd365de5c306cb42901e510ff14df1b76c6bddb Mon Sep 17 00:00:00 2001 > From: Pavel Reichl > Date: Tue, 20 Oct 2015 08:07:02 -0400 > Subject: [PATCH 1/3]

[SSSD] [PATCH] SSSD: Add a new command diag_cmd

Hi, I created this patch to try to diagnose an issue where sssd would randomly restart on any of machines in a VM cluster without giving too much advise why. I think it might be useful to merge in general. >From cf1f9d56b85387885f6211434b827fdbb9e5f4c3 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek

Re: [SSSD] [PATCH] LDAP: Fix leak of file descriptors

On Thu, Oct 22, 2015 at 01:47:18PM +0200, Lukas Slebodnik wrote: > ehlo, > > Details are in commit message. BTW it would be good to have at least two > reviews. > > Reproducer which I used for https://fedorahosted.org/sssd/ticket/2792: > > Setup: > * two active directories with sites; so sometim

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

On Tue, Oct 27, 2015 at 09:42:20AM +0100, Petr Cech wrote: > On 10/23/2015 12:57 PM, Jakub Hrozek wrote: > >Thank you, I think your approach is correct. Your test essentially tests > >that testuser2 was on the server but was removed, so only testuser1 is > >returned. > > > >It's correct, but becaus

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

On 11/03/2015 07:30 PM, Nikolai Kondrashov wrote: All in all, setting memcache_timeout to zero and commenting-out memcache file removal was enough to make *all* tests work fine. FWIW, I left it running repeatedly overnight and it got 250 successful runs and is still going. Nick ___

Re: [SSSD] [PATCH] NSS: fix a use-after-free issue

On (04/11/15 09:36), Lukas Slebodnik wrote: >On (03/11/15 12:38), Sumit Bose wrote: >>On Tue, Nov 03, 2015 at 11:46:42AM +0100, Lukas Slebodnik wrote: >>> On (02/11/15 13:51), Sumit Bose wrote: >>> >On Mon, Nov 02, 2015 at 10:30:51AM +0100, Lukas Slebodnik wrote: >>> >> On (02/11/15 10:05), Sumit B

Re: [SSSD] [PATCH] NSS: fix a use-after-free issue

On (03/11/15 12:38), Sumit Bose wrote: >On Tue, Nov 03, 2015 at 11:46:42AM +0100, Lukas Slebodnik wrote: >> On (02/11/15 13:51), Sumit Bose wrote: >> >On Mon, Nov 02, 2015 at 10:30:51AM +0100, Lukas Slebodnik wrote: >> >> On (02/11/15 10:05), Sumit Bose wrote: >> >> >On Mon, Nov 02, 2015 at 09:42:5

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On (04/11/15 09:06), Lukas Slebodnik wrote: >On (03/11/15 14:48), Michal Židek wrote: >>On 11/03/2015 12:25 PM, Lukas Slebodnik wrote: >>>On (30/10/15 16:06), Michal Židek wrote: On 10/30/2015 09:37 AM, Lukas Slebodnik wrote: >>From a84b7cfc766e1125399a100f28f7565a532c3863 Mon Sep 17 00:00:

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On (03/11/15 14:48), Michal Židek wrote: >On 11/03/2015 12:25 PM, Lukas Slebodnik wrote: >>On (30/10/15 16:06), Michal Židek wrote: >>>On 10/30/2015 09:37 AM, Lukas Slebodnik wrote: >From a84b7cfc766e1125399a100f28f7565a532c3863 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Michal=20=C5=BDidek?