[SSSD]Re: [PATCH] ldap_test.py: Modify enum cache timeouts

2015-12-02 Thread Lukas Slebodnik
On (02/12/15 17:10), Michal Židek wrote: >Hi! > >I saw some integration tests failures recently, >and I think there is a race condition between the >enumeration refresh timeout and the sleeps >after some operations that wait for this timeout. >SSSD fails to populate changes from LDAP in time >and s

[SSSD][PATCH] ldap_test.py: Modify enum cache timeouts

2015-12-02 Thread Michal Židek
Hi! I saw some integration tests failures recently, and I think there is a race condition between the enumeration refresh timeout and the sleeps after some operations that wait for this timeout. SSSD fails to populate changes from LDAP in time and some asserts can fail because of this. So far I

[SSSD]Re: [PATCH] CONTRIB: Add clang-format support

2015-12-02 Thread Michal Židek
On 12/01/2015 10:16 AM, Petr Cech wrote: On 12/01/2015 09:44 AM, Lukas Slebodnik wrote: On (30/11/15 14:55), Petr Cech wrote: Hi, there is little patch which adds clang-format support. More info is in header of patch. My previous patch set [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_col

[SSSD][DESIGN] ID mapping - Automatically assign new slices for any AD domain

2015-12-02 Thread Pavel Reichl
Hello, I decided to share this design document although it still a work in progress. Attached patches are just prove of concept and are very much work in progress. So far patches also defers from design in order in which secondary slices are generated. Thanks for feedback on this early state

[SSSD]Re: [PATCHES] sudo provider improvements

2015-12-02 Thread Lukas Slebodnik
On (02/12/15 14:06), Lukas Slebodnik wrote: >On (02/12/15 11:05), Pavel Březina wrote: >>On 12/01/2015 02:02 PM, Lukas Slebodnik wrote: >>>On (24/11/15 13:23), Pavel Březina wrote: Hi, I'm sending some sudo provider patches. I wanted to fix/improve things in the ldap sudo provider

[SSSD]Re: [PATCHES] sudo provider improvements

2015-12-02 Thread Lukas Slebodnik
On (02/12/15 11:05), Pavel Březina wrote: >On 12/01/2015 02:02 PM, Lukas Slebodnik wrote: >>On (24/11/15 13:23), Pavel Březina wrote: >>>Hi, >>>I'm sending some sudo provider patches. I wanted to fix/improve things in the >>>ldap sudo provider prior my work on ipa provider so I get familiar with it

[SSSD][PATCH] make globals in *_opts.h extern

2015-12-02 Thread Pavel Březina
This solves situation where you want to use those globals on other place than in *_common.c. I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch. From 1b0fcd570b206cac3d35fd048cba01d8

[SSSD]Re: [PATCHES] sudo provider improvements

2015-12-02 Thread Pavel Březina
On 12/01/2015 02:19 PM, Lukas Slebodnik wrote: On (01/12/15 14:02), Lukas Slebodnik wrote: On (24/11/15 13:23), Pavel Březina wrote: Hi, I'm sending some sudo provider patches. I wanted to fix/improve things in the ldap sudo provider prior my work on ipa provider so I get familiar with it again

[SSSD]Re: [PATCHES] sudo provider improvements

2015-12-02 Thread Pavel Březina
On 12/01/2015 02:02 PM, Lukas Slebodnik wrote: On (24/11/15 13:23), Pavel Březina wrote: Hi, I'm sending some sudo provider patches. I wanted to fix/improve things in the ldap sudo provider prior my work on ipa provider so I get familiar with it again and avoid making the same mistakes. It fixe

[SSSD]Re: [PATCH] KRB5: Handle KRB5_REALM_UNKNOWN as ERR_NETWORK_IO

2015-12-02 Thread Jakub Hrozek
On Wed, Dec 02, 2015 at 10:57:55AM +0100, Pavel Březina wrote: > On 11/30/2015 05:44 PM, Jakub Hrozek wrote: > >Hi, > > > >in some cases when an IPA-AD trust client is offline, the libkrb5 > >functions in krb5_child would error out with KRB5_REALM_UNKNOWN, because > >the client is completely autoco

[SSSD]Re: [PATCH] KRB5: Handle preauth request timeout more gracefully

2015-12-02 Thread Pavel Březina
On 11/30/2015 05:46 PM, Jakub Hrozek wrote: Hi, this is more or less a cosmetic issue, but it can be irritating nonetheless. If the krb5_child process times out during preauth, we would print an EINVAL error message. I think the error should be more graceful (and I don't insist on PAM_CRED_UNAVA

[SSSD]Re: [PATCH] KRB5: Handle KRB5_REALM_UNKNOWN as ERR_NETWORK_IO

2015-12-02 Thread Pavel Březina
On 11/30/2015 05:44 PM, Jakub Hrozek wrote: Hi, in some cases when an IPA-AD trust client is offline, the libkrb5 functions in krb5_child would error out with KRB5_REALM_UNKNOWN, because the client is completely autoconfigured. Sounds reasonable, ack. I think we should handle this error code