[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Jakub Hrozek
On Fri, Jan 29, 2016 at 08:24:00PM +0100, Lukas Slebodnik wrote: > On (29/01/16 18:50), Jakub Hrozek wrote: > >On Fri, Jan 29, 2016 at 03:25:56PM +0100, Lukas Slebodnik wrote: > >> On (29/01/16 13:51), Pavel Reichl wrote: > >> > > >> > > >> >On 01/29/2016 01:41 PM, Lukas Slebodnik wrote: > >> >>htt

[SSSD] Re: [PATCH] fix account lockout reporting with the krb5 provider

2016-01-29 Thread Lukas Slebodnik
On (29/01/16 18:48), Jakub Hrozek wrote: >On Fri, Jan 29, 2016 at 03:22:23PM +0100, Lukas Slebodnik wrote: >> On (14/01/16 18:38), Jakub Hrozek wrote: >> >On Thu, Jan 14, 2016 at 12:09:12PM -0500, Simo Sorce wrote: >> >> > OK to push now? >> >> >> >> Yes please :-) >> >> >> >> Simo >> > >> >* mas

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Lukas Slebodnik
On (29/01/16 18:50), Jakub Hrozek wrote: >On Fri, Jan 29, 2016 at 03:25:56PM +0100, Lukas Slebodnik wrote: >> On (29/01/16 13:51), Pavel Reichl wrote: >> > >> > >> >On 01/29/2016 01:41 PM, Lukas Slebodnik wrote: >> >>https://fedorahosted.org/sssd/ticket/2931 >> >>--- >> >> src/providers/krb5/krb5_

[SSSD] Re: [PATCH] SDAP: Add error code to debug message

2016-01-29 Thread Michal Židek
On 01/28/2016 04:48 PM, Pavel Reichl wrote: Hello, please see trivial patch attached. Thanks ACK. CI link: http://sssd-ci.duckdns.org/logs/job/36/90/summary.html Michal ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fed

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Jakub Hrozek
On Fri, Jan 29, 2016 at 03:25:56PM +0100, Lukas Slebodnik wrote: > On (29/01/16 13:51), Pavel Reichl wrote: > > > > > >On 01/29/2016 01:41 PM, Lukas Slebodnik wrote: > >>https://fedorahosted.org/sssd/ticket/2931 > >>--- > >> src/providers/krb5/krb5_child.c | 17 + > >> 1 file chang

[SSSD] Re: [PATCH] fix account lockout reporting with the krb5 provider

2016-01-29 Thread Jakub Hrozek
On Fri, Jan 29, 2016 at 03:22:23PM +0100, Lukas Slebodnik wrote: > On (14/01/16 18:38), Jakub Hrozek wrote: > >On Thu, Jan 14, 2016 at 12:09:12PM -0500, Simo Sorce wrote: > >> > OK to push now? > >> > >> Yes please :-) > >> > >> Simo > > > >* master: 19e44537c28f6d5f011cd7ac885c74c1e892605f > I h

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Lukas Slebodnik
On (29/01/16 13:51), Pavel Reichl wrote: > > >On 01/29/2016 01:41 PM, Lukas Slebodnik wrote: >>https://fedorahosted.org/sssd/ticket/2931 >>--- >> src/providers/krb5/krb5_child.c | 17 + >> 1 file changed, 17 insertions(+) >> >>diff --git a/src/providers/krb5/krb5_child.c b/src/prov

[SSSD] Re: [PATCH] fix account lockout reporting with the krb5 provider

2016-01-29 Thread Lukas Slebodnik
On (14/01/16 18:38), Jakub Hrozek wrote: >On Thu, Jan 14, 2016 at 12:09:12PM -0500, Simo Sorce wrote: >> > OK to push now? >> >> Yes please :-) >> >> Simo > >* master: 19e44537c28f6d5f011cd7ac885c74c1e892605f I have a question about this patch. I can see some inconsistencies for expired/disabled

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-01-29 Thread Lukas Slebodnik
On (29/01/16 14:15), Lukas Slebodnik wrote: >On (06/01/16 13:47), Petr Cech wrote: >//snip >>Lukas, thanks for careful review. >> >>There are fixed patches attached. I hope that I check memory leaks in proper >>way. >>I am little confused if we need "struct test_colondb_ctx" because it is empty >>n

[SSSD] [PATCH] PAM: Clarify man page for domains option

2016-01-29 Thread Pavel Reichl
Hello, please see trivial patch attached. Thanks. >From 6d5f6b71c2d2f891470dc1c9f08ae67f5b6c02f5 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 29 Jan 2016 08:27:01 -0500 Subject: [PATCH] PAM: Clarify man page for domains option Resolves: https://fedorahosted.org/sssd/ticket/2946 --- sr

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-01-29 Thread Lukas Slebodnik
On (06/01/16 13:47), Petr Cech wrote: //snip >Lukas, thanks for careful review. > >There are fixed patches attached. I hope that I check memory leaks in proper >way. >I am little confused if we need "struct test_colondb_ctx" because it is empty >now. > >Regards > >-- >Petr^4 Cech >From 435b1c44f7

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Pavel Reichl
Could we use access() instead of open()? ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Pavel Reichl
On 01/29/2016 01:41 PM, Lukas Slebodnik wrote: https://fedorahosted.org/sssd/ticket/2931 --- src/providers/krb5/krb5_child.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c index 12eb9e2093d2bdd7d67e8d0

[SSSD] [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-01-29 Thread Lukas Slebodnik
ehlo, attached patch should resolve #2931 LS >From abd5a45572e0ab1ae73c237384eada28598f00fc Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 29 Jan 2016 13:30:49 +0100 Subject: [PATCH] krb5_child: Warn if user cannot read krb5.conf Attached patch should siplify troubleshoting of issues

[SSSD] Re: Configuring tlog from SSSD

2016-01-29 Thread Nikolai Kondrashov
On 01/29/2016 10:41 AM, Lukas Slebodnik wrote: On (28/01/16 20:29), Nikolai Kondrashov wrote: On 01/28/2016 12:24 PM, Lukas Slebodnik wrote: On (27/01/16 16:30), Nikolai Kondrashov wrote: On 01/27/2016 04:17 PM, Lukas Slebodnik wrote: You mention many options which could be possibly passed to

[SSSD] Re: [PATCH v2] intg: Add more LDAP tests

2016-01-29 Thread Nikolai Kondrashov
On 01/29/2016 11:22 AM, Jakub Hrozek wrote: On Thu, Jan 21, 2016 at 03:53:19PM +0200, Nikolai Kondrashov wrote: Hi Jakub, Michal, everyone, On 11/11/2015 07:03 PM, Michal Židek wrote: I modified the "squashing" patch to remove the workaround for failing memcache. SQUASH THESE 2 ATTACHED PATCH

[SSSD] Re: [PATCH] NSS: Fix memory leak netgroup

2016-01-29 Thread Pavel Reichl
On 01/28/2016 12:28 PM, Jakub Hrozek wrote: On Mon, Jan 25, 2016 at 08:54:53PM +0100, Jakub Hrozek wrote: On Mon, Jan 25, 2016 at 05:16:37PM +0100, Pavel Reichl wrote: Hello, attached patch does not seem to suffer from these errors any more. Shall I ask user who reported the bug If he is wi

[SSSD] Re: [PATCH v2] intg: Add more LDAP tests

2016-01-29 Thread Lukas Slebodnik
On (29/01/16 10:22), Jakub Hrozek wrote: >On Thu, Jan 21, 2016 at 03:53:19PM +0200, Nikolai Kondrashov wrote: >> Hi Jakub, Michal, everyone, >> >> On 11/11/2015 07:03 PM, Michal Židek wrote: >> >I modified the "squashing" patch to remove the >> >workaround for failing memcache. >> > >> >SQUASH THE

[SSSD] Re: [PATCH v2] intg: Add more LDAP tests

2016-01-29 Thread Jakub Hrozek
On Thu, Jan 21, 2016 at 03:53:19PM +0200, Nikolai Kondrashov wrote: > Hi Jakub, Michal, everyone, > > On 11/11/2015 07:03 PM, Michal Židek wrote: > >I modified the "squashing" patch to remove the > >workaround for failing memcache. > > > >SQUASH THESE 2 ATTACHED PATCHES BEFORE PUSHING > >and use t

[SSSD] Re: Configuring tlog from SSSD

2016-01-29 Thread Lukas Slebodnik
On (28/01/16 20:29), Nikolai Kondrashov wrote: >On 01/28/2016 12:24 PM, Lukas Slebodnik wrote: >>On (27/01/16 16:30), Nikolai Kondrashov wrote: >>>On 01/27/2016 04:17 PM, Lukas Slebodnik wrote: You mention many options which could be possibly passed to tlog. e.g. TLOG_REC_CONF='{ >

[SSSD] Re: [PATCHES] Fix warnings Wsign-compare

2016-01-29 Thread Lukas Slebodnik
On (28/01/16 21:54), Jakub Hrozek wrote: >On Tue, Jan 12, 2016 at 03:21:30PM +0100, Lukas Slebodnik wrote: >> python-3.5 is also in debian-sid and migh be in debian-testing >> within 10 days. First 3 patches can be reviwed and meanwhile >> I will need to figure out solution for 4th patch (but it's