[SSSD] Re: Configuring tlog from SSSD

2016-02-05 Thread Nikolai Kondrashov
On 02/04/2016 09:45 AM, Simo Sorce wrote: On Thu, 2016-01-28 at 11:24 +0100, Lukas Slebodnik wrote: On (27/01/16 16:30), Nikolai Kondrashov wrote: On 01/27/2016 04:17 PM, Lukas Slebodnik wrote: You mention many options which could be possibly passed to tlog. e.g. TLOG_REC_CONF='{

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Lukas Slebodnik
On (05/02/16 19:34), Michal Židek wrote: >On 02/05/2016 06:32 PM, Lukas Slebodnik wrote: >>On (05/02/16 17:30), Michal Židek wrote: >>>On 02/05/2016 05:13 PM, Lukas Slebodnik wrote: On (05/02/16 16:56), Pavel Reichl wrote: >Hopefully the last one. >From 58b06b8fee18c4242e301ecf71f9

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Michal Židek
On 02/05/2016 06:32 PM, Lukas Slebodnik wrote: On (05/02/16 17:30), Michal Židek wrote: On 02/05/2016 05:13 PM, Lukas Slebodnik wrote: On (05/02/16 16:56), Pavel Reichl wrote: Hopefully the last one. >From 58b06b8fee18c4242e301ecf71f92a77f6ba6e7b Mon Sep 17 00:00:00 2001 From: Pavel Reichl

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Pavel Reichl
On 02/05/2016 03:37 PM, Dan Lavu wrote: Pavel, I found the wording to be strange, this is shorter and more concise description of the parameter. I also took the liberty of editing the description of 'pam_account_expired_message' as well. I don't think the comment about ssh keys is necessary

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Lukas Slebodnik
On (05/02/16 17:30), Michal Židek wrote: >On 02/05/2016 05:13 PM, Lukas Slebodnik wrote: >>On (05/02/16 16:56), Pavel Reichl wrote: >>>Hopefully the last one. >> >>>From 58b06b8fee18c4242e301ecf71f92a77f6ba6e7b Mon Sep 17 00:00:00 2001 >>>From: Pavel Reichl >>>Date: Fri, 22 Jan 2016 08:34:14 -0500

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Michal Židek
On 02/05/2016 05:13 PM, Lukas Slebodnik wrote: On (05/02/16 16:56), Pavel Reichl wrote: Hopefully the last one. From 58b06b8fee18c4242e301ecf71f92a77f6ba6e7b Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 22 Jan 2016 08:34:14 -0500 Subject: [PATCH] IDMAP: Add test to validate off by

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Lukas Slebodnik
On (05/02/16 16:56), Pavel Reichl wrote: >Hopefully the last one. >From 58b06b8fee18c4242e301ecf71f92a77f6ba6e7b Mon Sep 17 00:00:00 2001 >From: Pavel Reichl >Date: Fri, 22 Jan 2016 08:34:14 -0500 >Subject: [PATCH] IDMAP: Add test to validate off by one bug > >Resolves: >https://fedorahosted.org/

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Pavel Reichl
Hopefully the last one. >From 58b06b8fee18c4242e301ecf71f92a77f6ba6e7b Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 22 Jan 2016 08:34:14 -0500 Subject: [PATCH] IDMAP: Add test to validate off by one bug Resolves: https://fedorahosted.org/sssd/ticket/2922 --- src/tests/cmocka/test_sss_

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Pavel Reichl
Michal told me off list about asserts I missed. >From 8a5264f944dbe110b4d72a876cdc5ba2c112a73d Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 22 Jan 2016 08:34:14 -0500 Subject: [PATCH] IDMAP: Add test to validate off by one bug Resolves: https://fedorahosted.org/sssd/ticket/2922 ---

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Pavel Reichl
And now with correct patch. :-) >From 549433ddba79916c54dd2d06342a34d67727c0be Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 22 Jan 2016 08:34:14 -0500 Subject: [PATCH] IDMAP: Add test to validate off by one bug Resolves: https://fedorahosted.org/sssd/ticket/2922 --- src/tests/cmocka/t

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Pavel Reichl
On 02/05/2016 03:22 PM, Michal Židek wrote: On 01/22/2016 02:55 PM, Pavel Reichl wrote: Hello, please see simple test adding test for https://fedorahosted.org/sssd/ticket/2922. Sumit proposed to test if mapping of UNIX MAX_ID + 1 fails to be mapped to SID. Without patch for #2922 test fails

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Dan Lavu
https://technet.microsoft.com/en-us/library/cc526636.aspx https://support.microsoft.com/en-us/kb/218185 ? On 02/05/2016 09:31 AM, Jakub Hrozek wrote: On Fri, Feb 05, 2016 at 03:16:18PM +0100, Lukas Slebodnik wrote: On (05/02/16 15:10), Jakub Hrozek wrote: On Fri, Feb 05, 2016 at 02:54:53PM +0

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Dan Lavu
Pavel, I found the wording to be strange, this is shorter and more concise description of the parameter. I also took the liberty of editing the description of 'pam_account_expired_message' as well. I don't think the comment about ssh keys is necessary, since it applies to all pam auth phase n

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Jakub Hrozek
On Fri, Feb 05, 2016 at 03:16:18PM +0100, Lukas Slebodnik wrote: > On (05/02/16 15:10), Jakub Hrozek wrote: > >On Fri, Feb 05, 2016 at 02:54:53PM +0100, Lukas Slebodnik wrote: > >> On (05/02/16 13:55), Pavel Reichl wrote: > >> > > >> > > >> >On 02/05/2016 11:01 AM, Jakub Hrozek wrote: > >> >>On Tue

[SSSD] Re: [PATCH] IDMAP: Add test to validate off by one bug

2016-02-05 Thread Michal Židek
On 01/22/2016 02:55 PM, Pavel Reichl wrote: Hello, please see simple test adding test for https://fedorahosted.org/sssd/ticket/2922. Sumit proposed to test if mapping of UNIX MAX_ID + 1 fails to be mapped to SID. Without patch for #2922 test fails otherwise test passes. Thanks. Hi, Please

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Lukas Slebodnik
On (05/02/16 15:10), Jakub Hrozek wrote: >On Fri, Feb 05, 2016 at 02:54:53PM +0100, Lukas Slebodnik wrote: >> On (05/02/16 13:55), Pavel Reichl wrote: >> > >> > >> >On 02/05/2016 11:01 AM, Jakub Hrozek wrote: >> >>On Tue, Feb 02, 2016 at 08:48:43PM +0100, Pavel Reichl wrote: >> >... >> >> >> >>I wo

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Jakub Hrozek
On Fri, Feb 05, 2016 at 02:54:53PM +0100, Lukas Slebodnik wrote: > On (05/02/16 13:55), Pavel Reichl wrote: > > > > > >On 02/05/2016 11:01 AM, Jakub Hrozek wrote: > >>On Tue, Feb 02, 2016 at 08:48:43PM +0100, Pavel Reichl wrote: > >... > >> > >>I would prefer to split this patch into two, one that

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Lukas Slebodnik
On (05/02/16 13:55), Pavel Reichl wrote: > > >On 02/05/2016 11:01 AM, Jakub Hrozek wrote: >>On Tue, Feb 02, 2016 at 08:48:43PM +0100, Pavel Reichl wrote: >... >> >>I would prefer to split this patch into two, one that patches the LDAP >>code to return ERR_ACCOUNT_LOCKED and one that passes on and d

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Pavel Reichl
On 02/05/2016 11:01 AM, Jakub Hrozek wrote: On Tue, Feb 02, 2016 at 08:48:43PM +0100, Pavel Reichl wrote: ... I would prefer to split this patch into two, one that patches the LDAP code to return ERR_ACCOUNT_LOCKED and one that passes on and displays the message. Done. From 511ef599902

[SSSD] Re: [PATCH] PAM: Notify user of denial due to AD account lockout

2016-02-05 Thread Jakub Hrozek
On Tue, Feb 02, 2016 at 08:48:43PM +0100, Pavel Reichl wrote: > Hello, > > please see attached patch. > > To test connect to AD using ldap provider (for both id and auth). Lock > account of AD user by entering invalid password repeatedly. In pam section > of sssd.conf set pam_account_locked_messa