[SSSD] Re: [PATCH] LDAP: Use the common get_uppercase_realm to uppercase the realm

2016-02-26 Thread Pavel Březina
On 02/25/2016 02:04 PM, Jakub Hrozek wrote: Hi, attached is a simple clan-up patch. Hi, make_realm_upper_case also contains a check that returns the original string if delimiter is not found. Are we sure it is safe to remove this test? Can you also rename get_uppercase_realm to something m

[SSSD] Re: [PATCH] tests: Extend test_child_common.c to include tests for the only_extra_args functionality

2016-02-26 Thread Pavel Březina
On 02/24/2016 04:26 PM, Jakub Hrozek wrote: Hi, the attached patch was already acked by Sumit as part of the adcli thread, so I'd like to push it now. Ack. Go ahead. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedoraho

[SSSD] Re: [PATCH] memberof: Don't allocate on a NULL context

2016-02-26 Thread Pavel Březina
On 02/24/2016 03:19 PM, Jakub Hrozek wrote: Hi, the attached patch fixes: https://fedorahosted.org/sssd/ticket/2959 It was confirmed by the original reporter. The bug was there since 2009, by the way, I'm really suprised we only caught it now.. Good job finding this. I'm inclined to ack

[SSSD] Re: Tlog integration and packages

2016-02-26 Thread Jakub Hrozek
On Thu, Feb 25, 2016 at 03:09:25PM +0200, Nikolai Kondrashov wrote: > Hi everyone, > > I'd like to continue the discussion of tlog integration, and also present you > the first release of tlog - a development preview, which has the configuration > interface necessary to implement the integration:

[SSSD] Re: [PATCH]: test ldap provider with TLS or SSL

2016-02-26 Thread Jakub Hrozek
On Thu, Feb 25, 2016 at 05:18:09PM -0500, Dan Lavu wrote: > Here is a patch for https://fedorahosted.org/sssd/ticket/2820 > > First real patch... criticisms to for what I need to improve on are welcome, > including concepts that I should learn, thanks. Thanks a lot for the patch! See my comments

[SSSD] Re: [PATCH]: test ldap provider with TLS or SSL

2016-02-26 Thread Lukas Slebodnik
On (26/02/16 11:53), Jakub Hrozek wrote: >On Thu, Feb 25, 2016 at 05:18:09PM -0500, Dan Lavu wrote: >> Here is a patch for https://fedorahosted.org/sssd/ticket/2820 >> >> First real patch... criticisms to for what I need to improve on are welcome, >> including concepts that I should learn, thanks.

[SSSD] Re: [PATCH] IPA: lookup idview name even if there is no master domain

2016-02-26 Thread Jakub Hrozek
On Thu, Feb 25, 2016 at 11:26:13AM +0100, Jakub Hrozek wrote: > On Tue, Feb 23, 2016 at 03:26:57PM +0100, Jakub Hrozek wrote: > > On Mon, Feb 22, 2016 at 06:40:44PM +0100, Sumit Bose wrote: > > > Hi, > > > > > > these two patches fixes and issue which was reported on > > > https://www.redhat.com/a

[SSSD] Re: [PATCH] tests: Extend test_child_common.c to include tests for the only_extra_args functionality

2016-02-26 Thread Jakub Hrozek
On Fri, Feb 26, 2016 at 10:58:16AM +0100, Pavel Březina wrote: > On 02/24/2016 04:26 PM, Jakub Hrozek wrote: > >Hi, > > > >the attached patch was already acked by Sumit as part of the adcli > >thread, so I'd like to push it now. > > Ack. Go ahead. * master: b5797517abb117cff7330acc894b71deda74be3

[SSSD] URI in HBAC rules - patch - request for feedback

2016-02-26 Thread Lukáš Hellebrandt
Hi, FreeIPA and SSSD communities! I am working on adding URI to HBAC as my thesis [1]. The goal is to control access not only based on (user, host, service), but on (user, host, service, resource's URI). I created a patch for FreeIPA [2] so it is capable of storing URI as part of HBAC rule. I cre

[SSSD] Re: URI in HBAC rules - patch - request for feedback

2016-02-26 Thread Jakub Hrozek
On Fri, Feb 26, 2016 at 01:15:59PM +0100, Lukáš Hellebrandt wrote: > Hi, FreeIPA and SSSD communities! > > I am working on adding URI to HBAC as my thesis [1]. The goal is to > control access not only based on (user, host, service), but on (user, > host, service, resource's URI). > > I created a

[SSSD] Re: [PATCH] cache_req improvements

2016-02-26 Thread Jakub Hrozek
On Wed, Feb 24, 2016 at 12:41:24PM +0100, Pavel Březina wrote: > >> From f61d0192b8254247802167ea385b52f65d4e175d Mon Sep 17 00:00:00 2001 > >>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= > >>Date: Thu, 18 Feb 2016 14:25:18 +0100 > >>Subject: [PATCH 07/12] sysdb: reset ldb errors > >> > >>After ldb conn

[SSSD] Re: [PATCH] LDAP: Use the common get_uppercase_realm to uppercase the realm

2016-02-26 Thread Jakub Hrozek
On Fri, Feb 26, 2016 at 10:47:13AM +0100, Pavel Březina wrote: > On 02/25/2016 02:04 PM, Jakub Hrozek wrote: > >Hi, > > > >attached is a simple clan-up patch. > > Hi, > make_realm_upper_case also contains a check that returns the original string > if delimiter is not found. Are we sure it is safe

[SSSD] Re: [PATCH] memberof: Don't allocate on a NULL context

2016-02-26 Thread Jakub Hrozek
On Fri, Feb 26, 2016 at 11:08:45AM +0100, Pavel Březina wrote: > On 02/24/2016 03:19 PM, Jakub Hrozek wrote: > >Hi, > > > >the attached patch fixes: > > https://fedorahosted.org/sssd/ticket/2959 > > > >It was confirmed by the original reporter. The bug was there since 2009, > >by the way, I'm r

[SSSD] Re: URI in HBAC rules - patch - request for feedback

2016-02-26 Thread Lukáš Hellebrandt
> First question I have is that the URLs only match on complete string > match. From past conversations I thought we wanted to add a more > granular evaluation..? I am planning to interpret URI as a prefix. However, there might be problem getting enough granularity because FreeIPA has dropped DENY

[SSSD] Re: URI in HBAC rules - patch - request for feedback

2016-02-26 Thread Lukáš Hellebrandt
>> >> Btw, is there some better place to share patches than a pasting tool? >> Maybe some form of pull request? > > You can clone SSSD on github and publish a branch in your clone > https://github.com/SSSD/sssd > https://github.com/lhellebr/sssd/commits/url_in_hbac

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-02-26 Thread Justin Stephenson
Thanks a lot for the feedback, I am new to the cmocka framework so I will take some time to learn it and respond after amending the patch. -Justin On 02/25/2016 05:00 AM, Jakub Hrozek wrote: On Thu, Feb 25, 2016 at 10:53:43AM +0100, Sumit Bose wrote: On Wed, Feb 24, 2016 at 05:19:50PM -0500,

[SSSD] Re: [PATCH] CLIENT: Retry request after EPIPE

2016-02-26 Thread Lukas Slebodnik
On (23/02/16 14:28), Lukas Slebodnik wrote: >On (23/02/16 13:37), Jakub Hrozek wrote: >>On Thu, Feb 18, 2016 at 02:04:54PM +0100, Lukas Slebodnik wrote: >>> ehlo, >>> >>> It took me some time to reproduce issue with cron. >>> It occured very rarely in my case (twice in a week). >>> >>> Therefore

[SSSD] Re: libini - config file validity checks

2016-02-26 Thread Michal Židek
Hi, we had a discussion with Lukas about this feature and came up with some modifications to the design. I will explain the change in the typo detection mechanism. The format in the schema/constraints file will be following. [rule/domain_options] validator = allowed_options section = domain/.*

[SSSD] Re: libini - config file validity checks

2016-02-26 Thread Jakub Hrozek
On Fri, Feb 26, 2016 at 04:41:49PM +0100, Michal Židek wrote: > Hi, > > we had a discussion with Lukas about this feature > and came up with some modifications to the design. > > I will explain the change in the typo detection mechanism. > > The format in the schema/constraints file will be foll

[SSSD] [PATCHES] Add new default PAM services for AD GPOs

2016-02-26 Thread Stephen Gallagher
[PATCH 1/2] GPO: Add Cockpit to the Remote Interactive defaults The Cockpit Project is an administrative console that is gaining in popularity and is a default component on some operating systems (such as Fedora Server). Since it is becoming more common, we should ensure that it is part of the sta

[SSSD] Re: [PATCH] CLIENT: Retry request after EPIPE

2016-02-26 Thread Lukas Slebodnik
On (26/02/16 16:22), Lukas Slebodnik wrote: >On (23/02/16 14:28), Lukas Slebodnik wrote: >>On (23/02/16 13:37), Jakub Hrozek wrote: >>>On Thu, Feb 18, 2016 at 02:04:54PM +0100, Lukas Slebodnik wrote: ehlo, It took me some time to reproduce issue with cron. It occured very rarel