[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Simo Sorce
On Tue, 2016-03-01 at 18:22 -0500, Simo Sorce wrote: > On Tue, 2016-03-01 at 22:34 +0100, Lukas Slebodnik wrote: > > On (01/03/16 12:05), Simo Sorce wrote: > > >On Tue, 2016-03-01 at 17:51 +0100, Lukas Slebodnik wrote: > > >> On (01/03/16 17:45), Lukas Slebodnik wrote: > > >> >On (31/01/16 11:53),

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Simo Sorce
On Tue, 2016-03-01 at 22:34 +0100, Lukas Slebodnik wrote: > On (01/03/16 12:05), Simo Sorce wrote: > >On Tue, 2016-03-01 at 17:51 +0100, Lukas Slebodnik wrote: > >> On (01/03/16 17:45), Lukas Slebodnik wrote: > >> >On (31/01/16 11:53), Simo Sorce wrote: > >> >>Expired != Disabled > >> >>this change

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 12:05), Simo Sorce wrote: >On Tue, 2016-03-01 at 17:51 +0100, Lukas Slebodnik wrote: >> On (01/03/16 17:45), Lukas Slebodnik wrote: >> >On (31/01/16 11:53), Simo Sorce wrote: >> >>Expired != Disabled >> >>this change is intentional. >> >> >> >Yes, but explain it to Active directory :-)

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Simo Sorce
On Tue, 2016-03-01 at 17:51 +0100, Lukas Slebodnik wrote: > On (01/03/16 17:45), Lukas Slebodnik wrote: > >On (31/01/16 11:53), Simo Sorce wrote: > >>Expired != Disabled > >>this change is intentional. > >> > >Yes, but explain it to Active directory :-) > > > >Attached is patch with workaround/hack

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 17:45), Lukas Slebodnik wrote: >On (31/01/16 11:53), Simo Sorce wrote: >>Expired != Disabled >>this change is intentional. >> >Yes, but explain it to Active directory :-) > >Attached is patch with workaround/hack >regression with expired AD users. > ENOPATCH LS >From a2feac9bb5f6fde16

[SSSD] [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Lukas Slebodnik
On (31/01/16 11:53), Simo Sorce wrote: >Expired != Disabled >this change is intentional. > Yes, but explain it to Active directory :-) Attached is patch with workaround/hack regression with expired AD users. LS ___ sssd-devel mailing list sssd-devel@lis

[SSSD] Re: [PATCH] sdap: improve filtering of multiple results in GC lookups

2016-03-01 Thread Jakub Hrozek
On Mon, Feb 29, 2016 at 11:17:14AM +0100, Jakub Hrozek wrote: > ACK. > > There were some downstream tests failing, but the same tests kept > failing even with a vanilla RHEL-7.2 package, so I think it's a fluke in > the test and not a regression. * master: 5ff7a765434ed0b4d37564ade26d7761d06f81c3

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-01 Thread Pavel Reichl
On 03/01/2016 04:54 PM, Lukas Slebodnik wrote: On (01/03/16 15:54), Pavel Reichl wrote: I added one more similar patch. sss_idmap_calculate_range can accept domain SID or range identifier on its input. Previous parameter name was misleading. Could you explain why it need to be in two separa

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 15:54), Pavel Reichl wrote: >I added one more similar patch. > >sss_idmap_calculate_range can accept domain SID or range identifier on its >input. Previous parameter name was misleading. Could you explain why it need to be in two separate patches? LS _

[SSSD] Re: [PATCH] remove user certificate if not found on the server

2016-03-01 Thread Jakub Hrozek
On Mon, Feb 29, 2016 at 02:05:37PM +0100, Sumit Bose wrote: > On Thu, Feb 25, 2016 at 11:36:43AM +0100, Pavel Březina wrote: > > On 02/25/2016 11:07 AM, Sumit Bose wrote: > > >On Thu, Feb 25, 2016 at 10:53:03AM +0100, Pavel Březina wrote: > > >>On 02/24/2016 02:34 PM, Sumit Bose wrote: > > >>>On We

[SSSD] Re: [PATCH] IDMAP: Add minor performance improvements

2016-03-01 Thread Jakub Hrozek
On Mon, Feb 29, 2016 at 03:10:05PM +0100, Sumit Bose wrote: > On Wed, Feb 17, 2016 at 10:47:26AM +0100, Pavel Reichl wrote: > > On 02/15/2016 06:19 PM, Sumit Bose wrote: > > >On Tue, Jan 26, 2016 at 05:35:06PM +0100, Pavel Reichl wrote: > > >>>Hello, > > >>> > > >>>please see simple patch attached.

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 08:48), Dan Lavu wrote: >Thanks Nikolai and Lukas, > >Related to the run script, what version of Debian should we be testing >against? Seems like Wheezy is missing libnss-wrapper package in it's default >repos. > Wheezy is old stable and does not have all required dependencies. In read

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-01 Thread Pavel Reichl
I added one more similar patch. sss_idmap_calculate_range can accept domain SID or range identifier on its input. Previous parameter name was misleading. >From c17976f5c9053e09ea2033284dc3545d02ba0644 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Tue, 1 Mar 2016 08:41:24 -0500 Subject: [PAT

[SSSD] [PATCH] IDMAP: Make parameter name more descriptive

2016-03-01 Thread Pavel Reichl
Hello, Please see trivial patch attached, thanks Bye. >From 96e6f5cfe6d134748a4db248266fba774b32628b Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Tue, 1 Mar 2016 08:41:24 -0500 Subject: [PATCH] IDMAP: Make parameter name more descriptive Domain SID (not name) is used for computaion of see

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Dan Lavu
Thanks Nikolai and Lukas, Related to the run script, what version of Debian should we be testing against? Seems like Wheezy is missing libnss-wrapper package in it's default repos. + sudo -p 'Need root permissions to install packages. Enter sudo password for root: ' apt-get --yes install -- l

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 15:07), Nikolai Kondrashov wrote: >On 03/01/2016 02:56 PM, Lukas Slebodnik wrote: >>On (01/03/16 13:30), Nikolai Kondrashov wrote: >>>On 03/01/2016 10:46 AM, Lukas Slebodnik wrote: On (29/02/16 20:30), Nikolai Kondrashov wrote: >On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: >>

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Nikolai Kondrashov
On 03/01/2016 02:56 PM, Lukas Slebodnik wrote: On (01/03/16 13:30), Nikolai Kondrashov wrote: On 03/01/2016 10:46 AM, Lukas Slebodnik wrote: On (29/02/16 20:30), Nikolai Kondrashov wrote: On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: On (29/02/16 18:54), Nikolai Kondrashov wrote: keeping th

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 13:30), Nikolai Kondrashov wrote: >On 03/01/2016 10:46 AM, Lukas Slebodnik wrote: >>On (29/02/16 20:30), Nikolai Kondrashov wrote: >>>On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: On (29/02/16 18:54), Nikolai Kondrashov wrote: >keeping the "if" branches consistent and somewhat

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-03-01 Thread Pavel Březina
On 02/25/2016 02:08 PM, Jakub Hrozek wrote: On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: First of the responders is converted -) Sorry for the first delay in review. Before reading the code, I submitted the patches to automated tests, so far I found: Error: COMPILER_WARNING:

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Nikolai Kondrashov
On 03/01/2016 10:46 AM, Lukas Slebodnik wrote: On (29/02/16 20:30), Nikolai Kondrashov wrote: On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: On (29/02/16 18:54), Nikolai Kondrashov wrote: keeping the "if" branches consistent and somewhat easier to interpret. However, if you and others are more

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (29/02/16 20:30), Nikolai Kondrashov wrote: >On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: >>On (29/02/16 18:54), Nikolai Kondrashov wrote: >>>On 02/29/2016 06:31 PM, Lukas Slebodnik wrote: The rest of the required packages CI will attempt to install itself, using -the distribution's