[SSSD] Re: [PATCH] REFACTOR: global_talloc_context push/pop remove

2016-04-11 Thread Petr Cech
On 04/11/2016 08:51 AM, Lukas Slebodnik wrote: On (11/04/16 06:34), Petr Cech wrote: Hello list, push/pop global_talloc_context into check_leaks is redudant. It is done in leak_check_setup() and leak_check_teardown() functions in src/tests/check_leaks. Thanks Pavel Brezina, that showed me it.

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-11 Thread Sumit Bose
On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: > On 04/06/2016 02:06 PM, Sumit Bose wrote: > >On Wed, Apr 06, 2016 at 12:59:32PM +0300, Nikolai Kondrashov wrote: > >>On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: > >>>The attached patch adds exporting of the original (non-ov

[SSSD] Re: [PATCH] IPA: Check RDN in ipa_add_ad_memberships_get_next

2016-04-11 Thread Lukas Slebodnik
On (11/04/16 15:01), Lukas Slebodnik wrote: >ehlo, > >attached patch fix crash in #2980 > >LS >From 422abe6e6263c3c907611a8611fa3f28d6e93ae0 Mon Sep 17 00:00:00 2001 >From: Lukas Slebodnik >Date: Mon, 11 Apr 2016 14:46:47 +0200 >Subject: [PATCH] IPA: Check RDN in ipa_add_ad_memberships_get_next >

[SSSD] Re: [PATCH] LDAP: Print port in sdap_print_server

2016-04-11 Thread Jakub Hrozek
On Mon, Apr 11, 2016 at 02:58:06PM +0200, Lukas Slebodnik wrote: > On (11/04/16 13:39), Jakub Hrozek wrote: > >On Mon, Apr 11, 2016 at 01:12:51PM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> following patch help me to find out issues with GPO. > >> I think it might be useful also in other ca

[SSSD] [PATCH] IPA: Check RDN in ipa_add_ad_memberships_get_next

2016-04-11 Thread Lukas Slebodnik
ehlo, attached patch fix crash in #2980 LS >From 422abe6e6263c3c907611a8611fa3f28d6e93ae0 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 11 Apr 2016 14:46:47 +0200 Subject: [PATCH] IPA: Check RDN in ipa_add_ad_memberships_get_next LDB functions ldb_dn_get_component_val and ldb_dn_get

[SSSD] Re: [PATCH] LDAP: Print port in sdap_print_server

2016-04-11 Thread Lukas Slebodnik
On (11/04/16 13:39), Jakub Hrozek wrote: >On Mon, Apr 11, 2016 at 01:12:51PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> following patch help me to find out issues with GPO. >> I think it might be useful also in other cases. >> >> But ideal would be if fail-over code would print port as well. >>

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-11 Thread Nikolai Kondrashov
On 04/11/2016 11:43 AM, Jakub Hrozek wrote: On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: On 04/06/2016 02:06 PM, Sumit Bose wrote: sorry for the delay. The patch looks good in general and is working as expected. Currently the environment variable is set unconditionally wh

[SSSD] Re: [PATCH] LDAP: Print port in sdap_print_server

2016-04-11 Thread Jakub Hrozek
On Mon, Apr 11, 2016 at 01:12:51PM +0200, Lukas Slebodnik wrote: > ehlo, > > following patch help me to find out issues with GPO. > I think it might be useful also in other cases. > > But ideal would be if fail-over code would print port as well. > ATM "0" is logged as a port with AD. That's bec

[SSSD] [PATCH] LDAP: Print port in sdap_print_server

2016-04-11 Thread Lukas Slebodnik
ehlo, following patch help me to find out issues with GPO. I think it might be useful also in other cases. But ideal would be if fail-over code would print port as well. ATM "0" is logged as a port with AD. LS >From b37b66996eb9d809c6d6eda3834cea82c64a76b3 Mon Sep 17 00:00:00 2001 From: root Da

[SSSD] [PATCH] GPO: Process GPOS in offline mode if ldap search failed

2016-04-11 Thread Lukas Slebodnik
ehlo, attached patch should fix #2964. BTW it worked previously because there was a bug in marking domain as offline. So this bug was revealed with fix of another bug :-) 0561d532cf76b035b73cfed929a6896071dac407 LS >From c88f07a4375dd7a6960b0f909d4a9431bad5bd15 Mon Sep 17 00:00:00 2001 From: Luk

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-11 Thread Jakub Hrozek
On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: > On 04/06/2016 02:06 PM, Sumit Bose wrote: > >On Wed, Apr 06, 2016 at 12:59:32PM +0300, Nikolai Kondrashov wrote: > >>On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: > >>>The attached patch adds exporting of the original (non-ov