[SSSD] Re: [PATCHES] Data provider refactoring

2016-06-16 Thread Pavel Březina
On 06/15/2016 09:57 PM, Lukas Slebodnik wrote: On (15/06/16 21:54), Lukas Slebodnik wrote: On (15/06/16 21:08), Lukas Slebodnik wrote: On (15/06/16 19:08), Lukas Slebodnik wrote: On (15/06/16 14:08), Pavel Březina wrote: On 06/15/2016 08:44 AM, Lukas Slebodnik wrote: On (14/06/16 15:30), Pav

[SSSD] Re: [PATCHES] Data provider refactoring

2016-06-16 Thread Jakub Hrozek
On Wed, Jun 15, 2016 at 09:57:45PM +0200, Lukas Slebodnik wrote: > On (15/06/16 21:54), Lukas Slebodnik wrote: > >On (15/06/16 21:08), Lukas Slebodnik wrote: > >>On (15/06/16 19:08), Lukas Slebodnik wrote: > >>>On (15/06/16 14:08), Pavel Březina wrote: > On 06/15/2016 08:44 AM, Lukas Slebodnik

[SSSD] Re: [PATCH] ssh: skip invalid certificates

2016-06-16 Thread Jakub Hrozek
On Tue, Jun 07, 2016 at 03:58:31PM +0200, Sumit Bose wrote: > > You need to free tmp_ctx in this function. > > ah. sorry, I added it to the caller and forgot to add it to the new > function. New version attached. > > bye, > Sumit Thank you, ACK CI: http://sssd-ci.duckdns.org/logs/job/45/27/summ

[SSSD] Re: [PATCH] Add underlying diagnostic message for SSL errors.

2016-06-16 Thread Jakub Hrozek
On Tue, Jun 14, 2016 at 03:25:19PM +0200, Pavel Březina wrote: > On 06/09/2016 04:04 PM, Jakub Hrozek wrote: > > Hi, > > > > the reporter of https://fedorahosted.org/sssd/ticket/3005 kindly > > submitted a patch. I'm resending it here for review (looks good to me > > btw) > > Ack. * master: 2bd4

[SSSD] Re: [PATCH] ssh: skip invalid certificates

2016-06-16 Thread Jakub Hrozek
On Thu, Jun 16, 2016 at 01:33:47PM +0200, Jakub Hrozek wrote: > On Tue, Jun 07, 2016 at 03:58:31PM +0200, Sumit Bose wrote: > > > You need to free tmp_ctx in this function. > > > > ah. sorry, I added it to the caller and forgot to add it to the new > > function. New version attached. > > > > bye,

[SSSD] Re: [PATCHES] Data provider refactoring

2016-06-16 Thread Lukas Slebodnik
On (16/06/16 11:13), Jakub Hrozek wrote: >On Wed, Jun 15, 2016 at 09:57:45PM +0200, Lukas Slebodnik wrote: >> On (15/06/16 21:54), Lukas Slebodnik wrote: >> >On (15/06/16 21:08), Lukas Slebodnik wrote: >> >>On (15/06/16 19:08), Lukas Slebodnik wrote: >> >>>On (15/06/16 14:08), Pavel Březina wrote:

[SSSD] Re: [PATCHES] Data provider refactoring

2016-06-16 Thread Lukas Slebodnik
On (16/06/16 10:32), Pavel Březina wrote: >On 06/15/2016 09:57 PM, Lukas Slebodnik wrote: >> On (15/06/16 21:54), Lukas Slebodnik wrote: >> > On (15/06/16 21:08), Lukas Slebodnik wrote: >> > > On (15/06/16 19:08), Lukas Slebodnik wrote: >> > > > On (15/06/16 14:08), Pavel Březina wrote: >> > > > >

[SSSD] Re: [PATCH] DEBUG: Add `debug` alias for debug_level

2016-06-16 Thread Jakub Hrozek
On Wed, Jun 08, 2016 at 09:23:39AM +0200, Pavel Březina wrote: > Ack from me as well. master: 131684b9107a3fc07906013d16b35975531f2864 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@li

[SSSD] Re: [PATCHES] Data provider refactoring

2016-06-16 Thread Pavel Březina
On 06/16/2016 03:32 PM, Lukas Slebodnik wrote: On (16/06/16 10:32), Pavel Březina wrote: On 06/15/2016 09:57 PM, Lukas Slebodnik wrote: On (15/06/16 21:54), Lukas Slebodnik wrote: On (15/06/16 21:08), Lukas Slebodnik wrote: On (15/06/16 19:08), Lukas Slebodnik wrote: On (15/06/16 14:08), Pav

[SSSD] Re: [PATCHES] Data provider refactoring

2016-06-16 Thread Jakub Hrozek
On Thu, Jun 16, 2016 at 04:40:15PM +0200, Pavel Březina wrote: > On 06/16/2016 03:32 PM, Lukas Slebodnik wrote: > > On (16/06/16 10:32), Pavel Březina wrote: > > > On 06/15/2016 09:57 PM, Lukas Slebodnik wrote: > > > > On (15/06/16 21:54), Lukas Slebodnik wrote: > > > > > On (15/06/16 21:08), Lukas

[SSSD] [PATCH] UTIL: Use errno_t in TEVENT_REQ_RETURN_ON_ERROR

2016-06-16 Thread Lukas Slebodnik
ehlo, attached is a patch for TEVENT_REQ_RETURN_ON_ERROR which was discussed in dp_provider related thread. It "fixes" 6 clang warnings and 150 UNINIT from coverity (visible only in --agresive mode) BTW feel fre to prose different error code for result of down casting == 0. It should not happen

[SSSD] [PATCH] pam-srv-tests: Fix warning unused-function

2016-06-16 Thread Lukas Slebodnik
ehlo, attached small patch fix tiny complier warning when building with openssl instead of nss. LS >From 8f0038d89a4739d4a1848cb492be2a072be64687 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 10 Jun 2016 19:20:21 +0200 Subject: [PATCH 3/3] pam-srv-tests: Fix warning unused-function

[SSSD] [PATCH] SPEC: Run sssd as privileged user

2016-06-16 Thread Lukas Slebodnik
ehlo, attached patch makes my life easier. I needn't patch spec file before building sssd for downstream tests. SSSD still has some issues with non-root mode and complicated providers. I would appreciate review. LS >From 3e0a400bdcfdd0de263b63014576401a125cd7f8 Mon Sep 17 00:00:00 2001 From: Luk

[SSSD] Re: [PATCH] SPEC: Run sssd as privileged user

2016-06-16 Thread Jakub Hrozek
On Thu, Jun 16, 2016 at 08:04:36PM +0200, Lukas Slebodnik wrote: > ehlo, > > attached patch makes my life easier. > I needn't patch spec file before building > sssd for downstream tests. SSSD still has some > issues with non-root mode and complicated providers. > > I would appreciate review. I t

[SSSD] Re: [PATCH] SPEC: Run sssd as privileged user

2016-06-16 Thread Lukas Slebodnik
On (16/06/16 22:11), Jakub Hrozek wrote: >On Thu, Jun 16, 2016 at 08:04:36PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> attached patch makes my life easier. >> I needn't patch spec file before building >> sssd for downstream tests. SSSD still has some >> issues with non-root mode and complicated

[SSSD] Re: [PATCH] SPEC: Run sssd as privileged user

2016-06-16 Thread Jakub Hrozek
On Thu, Jun 16, 2016 at 10:17:26PM +0200, Lukas Slebodnik wrote: > On (16/06/16 22:11), Jakub Hrozek wrote: > >On Thu, Jun 16, 2016 at 08:04:36PM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> attached patch makes my life easier. > >> I needn't patch spec file before building > >> sssd for dow

[SSSD] Re: [PATCH] pam-srv-tests: Fix warning unused-function

2016-06-16 Thread Jakub Hrozek
On Thu, Jun 16, 2016 at 07:31:46PM +0200, Lukas Slebodnik wrote: > ehlo, > > attached small patch fix tiny complier warning when building with openssl > instead of nss. > > LS ack CI: http://sssd-ci.duckdns.org/logs/job/45/33/summary.html ___ sssd-dev