[SSSD] Re: [PATCH] sssctl: manual page

2016-07-08 Thread Dan Lavu
So I didn't need to review this? Here are some edits, if you would like to merge them (again, I was unable to apply the match, so I did the edits inline of Pavel's patch). On Thu, Jul 7, 2016 at 1:23 PM, Jakub Hrozek wrote: > On Thu, Jul 07, 2016 at 07:18:55PM +0200, Michal Židek wrote: > > On

[SSSD] Re: [PATCH] PAM: Allow to configure pam services for smartcards

2016-07-08 Thread Sumit Bose
On Wed, Jul 06, 2016 at 11:10:38AM +0200, Jakub Hrozek wrote: > On Wed, Jul 06, 2016 at 11:04:56AM +0200, Lukas Slebodnik wrote: > > Updated patch is attached. > > it is not :-) (for whatever reasons Lukas' reply with the patch was not delivered to my inbox, so I picked it from the archive) The

[SSSD] [PATCH] sssctl: Fix warning maybe-uninitialized

2016-07-08 Thread Lukas Slebodnik
ehlo, I can see warning maybe-uninitialized in mock build. I had a plan to initialize it to NULL. But this version fixed if as well. It looks like some special gcc optimalisation and special case may cause to have unitialized output argument _dom when return code is EOK LS >From f30325ade75a3571

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-07-08 Thread Michal Židek
On 07/08/2016 12:56 PM, Lukas Slebodnik wrote: On (08/07/16 12:17), Michal Židek wrote: From 66419775a94768efe8c98ce6e8bbfa4743107eae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Fri, 8 Jul 2016 11:32:50 +0200 Subject: [PATCH] config: Some fixes to schema Fixes: https:/

[SSSD] [PATCH] ipa_hbac: Fix documentation for hbac_enable_debug

2016-07-08 Thread Lukas Slebodnik
ehlo, You will need to apply patch "[PATCH] doxygen: Fix path to header file ipa_hbac.h" if you want to see this warning. LS >From 99e7d743b87769098b735a54a20cbb6ed5b32c86 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 8 Jul 2016 14:39:43 +0200 Subject: [PATCH] ipa_hbac: Fix documenta

[SSSD] Re: [PATCH] LDAP: Fix storing initgroups for users with no supplementary

2016-07-08 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 02:03:16PM +0200, Lukas Slebodnik wrote: > On (08/07/16 13:55), Jakub Hrozek wrote: > >Hi, > > > >I was looking into the remaining downstream test failures and found this > >bug caused by the FQDN patchset.. > > Would it be complicated to write an integration test? I guess

[SSSD] Re: [PATCH] LDAP: Fix storing initgroups for users with no supplementary

2016-07-08 Thread Lukas Slebodnik
On (08/07/16 13:55), Jakub Hrozek wrote: >Hi, > >I was looking into the remaining downstream test failures and found this >bug caused by the FQDN patchset.. Would it be complicated to write an integration test? LS ___ sssd-devel mailing list sssd-devel@

[SSSD] [PATCH] LDAP: Fix storing initgroups for users with no supplementary

2016-07-08 Thread Jakub Hrozek
Hi, I was looking into the remaining downstream test failures and found this bug caused by the FQDN patchset.. >From df82480e68ac31f97e504c56917e1dbe083950cb Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 8 Jul 2016 13:19:31 +0200 Subject: [PATCH] LDAP: Fix storing initgroups for users wi

[SSSD] [PATCH] doxygen: Fix path to header file ipa_hbac.h

2016-07-08 Thread Lukas Slebodnik
ehlo, Small issue after moving libiba_hbac to new location. Warning: tag INPUT: input source `src/providers/ipa/ipa_hbac.h' does not exist warning: source src/providers/ipa/ipa_hbac.h is not a readable file or directory... skipping. LS >From 5d589294760cef9a362fc076cb0c127bfcaaf922 Mon

[SSSD] Announce - SSSD 1.13 is the new LTM branch

2016-07-08 Thread Jakub Hrozek
Hi, the SSSD upstream supports some selected branches for a longer time, to make life easier for long-term supported distributions such as Red Hat Enterprise Linux, Ubuntu LTM or Suse Enterprise Linux. Since the sssd-1.13 branch is quite stable and already used in several long-term supported dist

[SSSD] [PATCH] sssctl: Fix format string for size_t

2016-07-08 Thread Lukas Slebodnik
ehlo, We review some patches in hurry yesterday and therefore I misse some issues. I noticed after packaging 1.14.0 in rawhide and copr LS >From 2285cb4773cf0b2a62a24280bc13408a415b862e Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 8 Jul 2016 13:04:10 +0200 Subject: [PATCH 2/2] sssct

[SSSD] Re: [PATCH] sssctl: Fix error handling after memory allocation failure

2016-07-08 Thread Pavel Březina
On 07/08/2016 01:13 PM, Lukas Slebodnik wrote: ehlo, U saw some warning s in rawhide after packagein 1.14.0 I tried to fix it but I found anouther issue. LS Obvious ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fed

[SSSD] [PATCH] sssctl: Fix error handling after memory allocation failure

2016-07-08 Thread Lukas Slebodnik
ehlo, U saw some warning s in rawhide after packagein 1.14.0 I tried to fix it but I found anouther issue. LS >From f39b8a34b600deb3f87affeba7fc532c41a7266b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 8 Jul 2016 12:16:47 +0200 Subject: [PATCH 1/2] sssctl: Fix error handling after m

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-07-08 Thread Lukas Slebodnik
On (08/07/16 12:17), Michal Židek wrote: >From 66419775a94768efe8c98ce6e8bbfa4743107eae Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Michal=20=C5=BDidek?= >Date: Fri, 8 Jul 2016 11:32:50 +0200 >Subject: [PATCH] config: Some fixes to schema > >Fixes: >https://fedorahosted.org/sssd/ticket/3068 > >Optio

[SSSD] Re: [PATCH] sssctl: config-check access check report

2016-07-08 Thread Pavel Březina
On 07/08/2016 09:04 AM, Michal Židek wrote: On 07/07/2016 04:03 PM, Michal Židek wrote: Hi, Pavel requested this small change to sssctl config-check command. Michal This email got lost yesterday. Sending again. Michal Ack one more time. ___ sss

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-07-08 Thread Michal Židek
On 07/08/2016 12:07 PM, Lukas Slebodnik wrote: On (08/07/16 12:03), Michal Židek wrote: Hi, attached is patch for ticket https://fedorahosted.org/sssd/ticket/3068 The ticket also talks about allowing options for negative cache timeouts in all responders, but I did not do that. We do indeed in

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-07-08 Thread Lukas Slebodnik
On (08/07/16 12:03), Michal Židek wrote: >Hi, > >attached is patch for ticket >https://fedorahosted.org/sssd/ticket/3068 > >The ticket also talks about allowing options >for negative cache timeouts in all responders, >but I did not do that. > >We do indeed initialize negative cache in all >responde

[SSSD] [PATCH] config: Some fixes to schema

2016-07-08 Thread Michal Židek
Hi, attached is patch for ticket https://fedorahosted.org/sssd/ticket/3068 The ticket also talks about allowing options for negative cache timeouts in all responders, but I did not do that. We do indeed initialize negative cache in all responders, but we always read the timeouts from NSS sectio

[SSSD] Re: RFC - 1.13 should be our upstream LTM

2016-07-08 Thread Howard Guo
Good morining Jakub. Thanks very much for the info, 1.13 has been performing extremely well in my tests, it is a very good release. Have a lovely weekend. Kind regards, Howard On Fri, 8 Jul 2016, Jakub Hrozek wrote: Hi, our upstream front page still lists 1.9 as LTM, which is maybe true te

[SSSD] Re: [PATCH] FO: Set port to NOT_WORKING when trying a next server

2016-07-08 Thread Pavel Březina
On 05/10/2016 04:33 PM, Jakub Hrozek wrote: Hi, attached is a patch that I think is correct and it did solve a bug I was seeing, but I'm not sure if it's the right thing to do since the code was stable since 2009.. What I was seeing was a scenario where an LDAP server was listening on port 389,

[SSSD] Re: RFC - 1.13 should be our upstream LTM

2016-07-08 Thread Timo Aaltonen
On 08.07.2016 11:33, Jakub Hrozek wrote: > Hi, > > our upstream front page still lists 1.9 as LTM, which is maybe true > technically, because we haven't proclaimed any other release as LTM, but > 1.9 is also very old and upstream we really just tell users to upgrade to > 1.13. > > So I think we s

[SSSD] Re: [PATCH] sssctl: config-check access check report

2016-07-08 Thread Michal Židek
On 07/07/2016 04:03 PM, Michal Židek wrote: Hi, Pavel requested this small change to sssctl config-check command. Michal This email got lost yesterday. Sending again. Michal >From 07bb03731ef425fecf01cbaefc533c28d4875151 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: