[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-05 Thread Justin Stephenson
Hi Lukas, I sent a response on July 6th but perhaps there was an issue with the mailing list or some reason it did not go through. Updated patch attached. I moved the resolv_is_address() function declaration into the async_resolv.h file(so that it could be included in the cmocka/t

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-05 Thread Lukas Slebodnik
On (26/02/16 09:47), Justin Stephenson wrote: >Thanks a lot for the feedback, I am new to the cmocka framework so I will >take some time to learn it and respond after amending the patch. > Justin, do you plan to update the patch? LS ___ sssd-devel mailin

[SSSD] Re: [PATCH] sss_override: improve --debug description

2016-08-05 Thread Lukas Slebodnik
On (15/03/16 12:40), Pavel Březina wrote: >On 12/09/2015 01:16 PM, Jakub Hrozek wrote: >> On Wed, Dec 09, 2015 at 01:07:10PM +0100, Pavel Březina wrote: >> > https://fedorahosted.org/sssd/ticket/2813 >> > >> > I wanted to split include/debug_levels.xml into more files so we don't >> > duplicate in

[SSSD] Re: SDAP: Don't log an op failure when no users are found

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 12:01), Pavel Březina wrote: >On 08/02/2016 12:40 PM, Fabiano Fidêncio wrote: >> Please, see the attached patch. >> >> It passed CI: http://sssd-ci.duckdns.org/logs/job/50/66/summary.html >> >> Best Regards, > >Ack. master: * 835965da366e468c12015ac35979a8ded0824c66 LS _

[SSSD] Re: [PATCH] Fix typo

2016-08-05 Thread Lukas Slebodnik
On (04/08/16 14:11), Pavel Březina wrote: >Simple one liner attached. >From 6c3d8d6dba969960590d88bdd9a4ec2e9b4a1bb2 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Pavel=20B=C5=99ezina?= >Date: Thu, 4 Aug 2016 14:10:09 +0200 >Subject: [PATCH] Fix typo in debug message > >--- > src/providers/ipa/ipa_in

[SSSD] Re: [PATCH] tools: Add missing gettext macro

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 13:50), Petr Cech wrote: >On 08/05/2016 01:05 PM, Michal Židek wrote: >> Hi, >> >> see the attached simple patch. I sent it >> as part of the commands renaming patchset, >> but forgot to include it in the last >> iteration. >> >> Michal > >ACK > master: * 1472e41692cfc47bf2be14756ce6

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-08-05 Thread Lukas Slebodnik
On (29/07/16 10:46), Petr Cech wrote: >On 07/29/2016 10:17 AM, Lukas Slebodnik wrote: >> On (29/07/16 10:05), Petr Cech wrote: >> > On 07/29/2016 09:52 AM, Lukas Slebodnik wrote: >> > > On (29/07/16 09:41), Petr Cech wrote: >> > > > On 07/29/2016 09:23 AM, Lukas Slebodnik wrote: >> > > > > What is

[SSSD] Re: [PATCH] sssctl: print a message when managing sssd

2016-08-05 Thread Lukas Slebodnik
On (20/07/16 10:44), Pavel Březina wrote: >On 07/18/2016 01:28 PM, Lukas Slebodnik wrote: >> On (07/07/16 12:59), Pavel Březina wrote: >> > On 07/05/2016 07:49 AM, Jakub Hrozek wrote: >> > > On Fri, Jul 01, 2016 at 01:24:35PM +0200, Pavel Březina wrote: >> > > >> > > > From 8b877579f3d1a9bbfa728

[SSSD] Re: [PATCH] sudo man page: say that we support IPA schema

2016-08-05 Thread Lukas Slebodnik
On (13/06/16 10:08), Pavel Březina wrote: >On 06/03/2016 05:42 PM, Jakub Hrozek wrote: >> On Wed, Jun 01, 2016 at 11:58:45AM +0200, Pavel Březina wrote: >> > SSIA >> >> > From 2101e03fa59fec3f834b48256a287f456662d7c2 Mon Sep 17 00:00:00 2001 >> > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= >> > Date:

[SSSD] Re: [PATCH] PROVIDER: Conversion empty string from D-Bus to NULL

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 11:56), Pavel Březina wrote: >On 07/27/2016 11:17 AM, Petr Cech wrote: >> On 07/27/2016 10:57 AM, Pavel Březina wrote: >> > On 07/27/2016 10:26 AM, Petr Cech wrote: >> > > Hi list, >> > > >> > > there is patch for [1] attached. >> > > >> > > [1] https://fedorahosted.org/sssd/ticket/3

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-05 Thread Petr Cech
On 08/04/2016 11:06 AM, Jakub Hrozek wrote: On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech wrote: Hello list, attached patch fixes duplication of pid file declaration. I hope that the util/util.h is the right place for it. Another

[SSSD] Re: [PATCH] tools: Add missing gettext macro

2016-08-05 Thread Petr Cech
On 08/05/2016 01:05 PM, Michal Židek wrote: Hi, see the attached simple patch. I sent it as part of the commands renaming patchset, but forgot to include it in the last iteration. Michal ACK -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lis

[SSSD] Re: [PATCH] sssctl: use internal API to remove files

2016-08-05 Thread Petr Cech
On 07/13/2016 01:47 PM, Pavel Březina wrote: 0001-utils-add-remove_subtree.patch From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree Remove all entrie

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-05 Thread Lukas Slebodnik
On (04/08/16 12:59), Lukas Slebodnik wrote: >On (04/08/16 11:38), Jakub Hrozek wrote: >>On Thu, Aug 04, 2016 at 11:26:41AM +0200, Jakub Hrozek wrote: >>> On Thu, Aug 04, 2016 at 11:19:36AM +0200, Lukas Slebodnik wrote: >>> > On (04/08/16 11:15), Jakub Hrozek wrote: >>> > >On Thu, Aug 04, 2016 at 08

[SSSD] Re: [PATCH] IPA: Removing of confusing debug message

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 11:59), Pavel Březina wrote: >On 07/26/2016 10:17 AM, Petr Cech wrote: >> On 07/12/2016 12:01 PM, Pavel Březina wrote: >> > On 07/12/2016 11:54 AM, Jakub Hrozek wrote: >> > > On Tue, Jul 12, 2016 at 11:52:05AM +0200, Pavel Březina wrote: >> > > > On 07/12/2016 10:20 AM, Petr Cech wrote

[SSSD] [PATCH] tools: Add missing gettext macro

2016-08-05 Thread Michal Židek
Hi, see the attached simple patch. I sent it as part of the commands renaming patchset, but forgot to include it in the last iteration. Michal >From 3dbbe08b50ca1ffeae4945cb3ea4b263d1d91305 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Fri, 5 Aug 2016 12:55:00 +0200 Subje

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-05 Thread Petr Cech
On 08/05/2016 12:19 PM, Petr Cech wrote: On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. CI: http://sssd-ci.duckdns.org/logs/job/50/88/summary.html It failed on F24 on dyndns: http://sssd-ci.duckdns.org/logs/job/50/8

[SSSD] Re: [PATCH] SYSDB: Fix setting dataExpireTimestamp if sysdb is supposed to set the current time

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 11:58), Pavel Březina wrote: >On 08/03/2016 05:30 PM, Jakub Hrozek wrote: >> Hi, >> >> please see the attached patch and the test. They should fix >> https://fedorahosted.org/sssd/ticket/3064. I don't think more >> explanation than what is in the ticket and in the commit message is >>

[SSSD] Re: [PATCH] SYSDB: Sanitize dn in sysdb_get_user_members_recursively

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 11:54), Pavel Březina wrote: >On 08/04/2016 08:52 AM, Lukas Slebodnik wrote: >> On (02/08/16 18:40), Lukas Slebodnik wrote: >> > On (02/08/16 15:54), Lukas Slebodnik wrote: >> > > ehlo, >> > > >> > > attached two patches fix a crash in nss responder, >> > > which was caused by recent

[SSSD] Re: [PATCH] sssctl: Generic help for cache-upgrade and config-check

2016-08-05 Thread Michal Židek
On 08/05/2016 12:01 PM, Pavel Březina wrote: On 07/26/2016 04:43 PM, Michal Židek wrote: Hi! Attached is patch for ticket: https://fedorahosted.org/sssd/ticket/3086 This patch applies on top of the patches from thread: [SSSD] [PATCH] sssctl: Consistent commands naming Michal Hi, I believe y

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-05 Thread Michal Židek
On 08/05/2016 12:30 PM, Lukas Slebodnik wrote: On (04/08/16 16:21), Michal Židek wrote: Hi, As was requested on devel meeting, I removed the compatibility with old commands. New patch attached. Michal From 0c18c75e2b6a2e29f95b0e477369b5db766afbdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mi

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-05 Thread Lukas Slebodnik
On (04/08/16 16:21), Michal Židek wrote: >Hi, > >As was requested on devel meeting, I removed the >compatibility with old commands. > >New patch attached. > >Michal >From 0c18c75e2b6a2e29f95b0e477369b5db766afbdb Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Michal=20=C5=BDidek?= >Date: Mon, 25 Jul 20

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-05 Thread Lukas Slebodnik
On (05/08/16 11:51), Pavel Březina wrote: >On 08/04/2016 04:21 PM, Michal Židek wrote: >> Hi, >> >> As was requested on devel meeting, I removed the >> compatibility with old commands. >> >> New patch attached. >> >> Michal > >Ack. master: * 488b455f6b7881ec108a127840b1c1f1523d937f LS _

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-05 Thread Petr Cech
On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. Regards -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/list

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-05 Thread Pavel Březina
On 08/05/2016 12:05 PM, Petr Cech wrote: On 08/05/2016 11:48 AM, Pavel Březina wrote: On 08/02/2016 10:19 AM, Petr Cech wrote: Hello list, the attached patch fixes: https://fedorahosted.org/sssd/ticket/3109 There was missing condition for offline state of sssd at ldap code for password changi

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-05 Thread Petr Cech
On 08/05/2016 11:48 AM, Pavel Březina wrote: On 08/02/2016 10:19 AM, Petr Cech wrote: Hello list, the attached patch fixes: https://fedorahosted.org/sssd/ticket/3109 There was missing condition for offline state of sssd at ldap code for password changing. If sssd is offline it returns PAM_AUTH

[SSSD] Re: [PATCH] sssctl: use internal API to remove files

2016-08-05 Thread Pavel Březina
Bump. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-08-05 Thread Pavel Březina
On 07/25/2016 12:55 PM, Pavel Březina wrote: On 07/20/2016 03:03 PM, Jakub Hrozek wrote: On Wed, Jul 20, 2016 at 03:00:14PM +0200, Jakub Hrozek wrote: On Tue, Jul 19, 2016 at 12:20:16PM +0200, Pavel Březina wrote: On 07/18/2016 03:23 PM, Jakub Hrozek wrote: On Thu, Jul 14, 2016 at 11:39:40AM

[SSSD] Re: [PATCH] sssctl: Generic help for cache-upgrade and config-check

2016-08-05 Thread Pavel Březina
On 07/26/2016 04:43 PM, Michal Židek wrote: Hi! Attached is patch for ticket: https://fedorahosted.org/sssd/ticket/3086 This patch applies on top of the patches from thread: [SSSD] [PATCH] sssctl: Consistent commands naming Michal Hi, I believe you can use NULL instead of options. __

[SSSD] Re: SDAP: Don't log an op failure when no users are found

2016-08-05 Thread Pavel Březina
On 08/02/2016 12:40 PM, Fabiano Fidêncio wrote: Please, see the attached patch. It passed CI: http://sssd-ci.duckdns.org/logs/job/50/66/summary.html Best Regards, Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedor

[SSSD] Re: [PATCH] IPA: Removing of confusing debug message

2016-08-05 Thread Pavel Březina
On 07/26/2016 10:17 AM, Petr Cech wrote: On 07/12/2016 12:01 PM, Pavel Březina wrote: On 07/12/2016 11:54 AM, Jakub Hrozek wrote: On Tue, Jul 12, 2016 at 11:52:05AM +0200, Pavel Březina wrote: On 07/12/2016 10:20 AM, Petr Cech wrote: Hello list, there is simple patch for [1]. I prepared two

[SSSD] Re: [PATCH] SYSDB: Fix setting dataExpireTimestamp if sysdb is supposed to set the current time

2016-08-05 Thread Pavel Březina
On 08/03/2016 05:30 PM, Jakub Hrozek wrote: Hi, please see the attached patch and the test. They should fix https://fedorahosted.org/sssd/ticket/3064. I don't think more explanation than what is in the ticket and in the commit message is needed :) Ack. _

[SSSD] Re: [PATCH] PROVIDER: Conversion empty string from D-Bus to NULL

2016-08-05 Thread Pavel Březina
On 07/27/2016 11:17 AM, Petr Cech wrote: On 07/27/2016 10:57 AM, Pavel Březina wrote: On 07/27/2016 10:26 AM, Petr Cech wrote: Hi list, there is patch for [1] attached. [1] https://fedorahosted.org/sssd/ticket/3084 If you prefer two commits--one for reverting and second with the patch--don't

[SSSD] Re: [PATCH] SYSDB: Sanitize dn in sysdb_get_user_members_recursively

2016-08-05 Thread Pavel Březina
On 08/04/2016 08:52 AM, Lukas Slebodnik wrote: On (02/08/16 18:40), Lukas Slebodnik wrote: On (02/08/16 15:54), Lukas Slebodnik wrote: ehlo, attached two patches fix a crash in nss responder, which was caused by recent Sumit's patches. The 1st patch cannot be applied to master because I plan

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-05 Thread Pavel Březina
On 08/04/2016 04:21 PM, Michal Židek wrote: Hi, As was requested on devel meeting, I removed the compatibility with old commands. New patch attached. Michal Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahost

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-05 Thread Pavel Březina
On 08/02/2016 10:19 AM, Petr Cech wrote: Hello list, the attached patch fixes: https://fedorahosted.org/sssd/ticket/3109 There was missing condition for offline state of sssd at ldap code for password changing. If sssd is offline it returns PAM_AUTHINFO_UNAVAIL now and not PAM_PERM_DENIED. Reg

[SSSD] [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-05 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/3111 From 09b4b655d7a151bac165ace05b0f3262f5e32201 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Fri, 5 Aug 2016 11:32:43 +0200 Subject: [PATCH] DP: Initialize D-Bus as soon as possible Resolves: https://fedorahosted.org/sssd/ticket/31

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-05 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org