[SSSD] Re: [PATCH] Unit tests for pam_sss using pam_wrapper (need help with CI..)

2016-08-08 Thread Lukas Slebodnik
On (09/05/16 10:07), Jakub Hrozek wrote: >On Wed, May 04, 2016 at 11:36:57PM +0200, Lukas Slebodnik wrote: >> On (27/04/16 10:51), Jakub Hrozek wrote: >> >Hi, >> > >> >the attached patches implement unit tests for the pam_sss module using >> >pam_wrapper and libpamtest. In my testing, the coverage

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 04:20 PM, Petr Cech wrote: On 08/08/2016 04:09 PM, Lukas Slebodnik wrote: On (08/08/16 15:36), Petr Cech wrote: On 08/08/2016 03:14 PM, Petr Cech wrote: On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing en

[SSSD] [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-08 Thread Lukas Slebodnik
ehlo, yet another patch which fixes issues caused by sysdb refactoring. reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups. I am looking forward to the pam_wrapper So we can test it in upstream. LS >From e501f7

[SSSD] Re: [PATCH] Two code-hardening patches

2016-08-08 Thread Lukas Slebodnik
On (08/08/16 16:35), Lukas Slebodnik wrote: >On (04/08/16 11:03), Jakub Hrozek wrote: >>On Wed, Aug 03, 2016 at 06:08:44PM +0200, Lukas Slebodnik wrote: >>> On (03/08/16 18:05), Jakub Hrozek wrote: >>> >Hi, >>> > >>> >these two patches add error handling to the code. The first prevents >>> >operati

[SSSD] Re: [PATCH] Two code-hardening patches

2016-08-08 Thread Lukas Slebodnik
On (04/08/16 11:03), Jakub Hrozek wrote: >On Wed, Aug 03, 2016 at 06:08:44PM +0200, Lukas Slebodnik wrote: >> On (03/08/16 18:05), Jakub Hrozek wrote: >> >Hi, >> > >> >these two patches add error handling to the code. The first prevents >> >operating on ldb_message if retrieving the message fails.

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 04:09 PM, Lukas Slebodnik wrote: On (08/08/16 15:36), Petr Cech wrote: On 08/08/2016 03:14 PM, Petr Cech wrote: On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Lukas Slebodnik
On (08/08/16 15:36), Petr Cech wrote: >On 08/08/2016 03:14 PM, Petr Cech wrote: >> On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: >> > ehlo, >> > >> > The simple reproducer is to use getent passwd,group with non-existing >> > entry. >> > Without the patch you will see that "/var/lib/sss/mc/passwd"

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 03:14 PM, Petr Cech wrote: On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "/var/lib/sss/mc/passwd" is opened twice. Onece with mode "rw" opened by sssd_nss and th

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "/var/lib/sss/mc/passwd" is opened twice. Onece with mode "rw" opened by sssd_nss and the 2nd time with "r-" opened by sssd-client

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-08 Thread Lukas Slebodnik
On (05/08/16 12:07), Pavel Březina wrote: >On 08/05/2016 12:05 PM, Petr Cech wrote: >> On 08/05/2016 11:48 AM, Pavel Březina wrote: >> > On 08/02/2016 10:19 AM, Petr Cech wrote: >> > > Hello list, >> > > >> > > the attached patch fixes: >> > > https://fedorahosted.org/sssd/ticket/3109 >> > > >> >

[SSSD] [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Lukas Slebodnik
ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "/var/lib/sss/mc/passwd" is opened twice. Onece with mode "rw" opened by sssd_nss and the 2nd time with "r-" opened by sssd-client (getpwnam, getpwuid, getgrnam, getgrgid) LS >Fr

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-08-08 Thread Petr Cech
On 08/05/2016 03:58 PM, Lukas Slebodnik wrote: On (29/07/16 10:46), Petr Cech wrote: On 07/29/2016 10:17 AM, Lukas Slebodnik wrote: On (29/07/16 10:05), Petr Cech wrote: On 07/29/2016 09:52 AM, Lukas Slebodnik wrote: On (29/07/16 09:41), Petr Cech wrote: On 07/29/2016 09:23 AM, Lukas Slebodn

[SSSD] Re: [PATCH] sssctl: Generic help for cache-upgrade and config-check

2016-08-08 Thread Pavel Březina
On 08/05/2016 12:47 PM, Michal Židek wrote: On 08/05/2016 12:01 PM, Pavel Březina wrote: On 07/26/2016 04:43 PM, Michal Židek wrote: Hi! Attached is patch for ticket: https://fedorahosted.org/sssd/ticket/3086 This patch applies on top of the patches from thread: [SSSD] [PATCH] sssctl: Consist

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-08 Thread Petr Cech
On 08/08/2016 10:26 AM, Pavel Březina wrote: On 08/05/2016 01:02 PM, Petr Cech wrote: On 08/05/2016 12:19 PM, Petr Cech wrote: On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. CI: http://sssd-ci.duckdns.org/logs/jo

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-08 Thread Pavel Březina
On 08/05/2016 01:02 PM, Petr Cech wrote: On 08/05/2016 12:19 PM, Petr Cech wrote: On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. CI: http://sssd-ci.duckdns.org/logs/job/50/88/summary.html It failed on F24 on dyndns

[SSSD] Re: [PATCH] LDAP: Fix Dereference after NULL check

2016-08-08 Thread Lukas Slebodnik
On (08/08/16 09:56), Petr Cech wrote: >On 08/08/2016 09:13 AM, Petr Cech wrote: >> On 08/08/2016 09:09 AM, Lukas Slebodnik wrote: >> > ehlo, >> > >> > attached is a oneliner for bug introduced in >> > dc30c60f166ad9adc63a47a1013508a71624ac87 >> > >> > I would push the patch with oneliner rule >>

[SSSD] Re: [PATCH] LDAP: Fix Dereference after NULL check

2016-08-08 Thread Petr Cech
On 08/08/2016 09:13 AM, Petr Cech wrote: On 08/08/2016 09:09 AM, Lukas Slebodnik wrote: ehlo, attached is a oneliner for bug introduced in dc30c60f166ad9adc63a47a1013508a71624ac87 I would push the patch with oneliner rule but there were objection in past for such behaviour. It was recommended

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-08 Thread Petr Cech
On 08/04/2016 05:01 PM, Petr Cech wrote: On 08/04/2016 04:35 PM, Petr Cech wrote: Hi list, there is the first version of patch for [1]. I need to investigate if we have the same issue in other *_childs. I tested it with sleep() added into ldap_child code. [1] https://fedorahosted.org/sssd/tic

[SSSD] Re: [PATCH] LDAP: Fix Dereference after NULL check

2016-08-08 Thread Petr Cech
On 08/08/2016 09:09 AM, Lukas Slebodnik wrote: ehlo, attached is a oneliner for bug introduced in dc30c60f166ad9adc63a47a1013508a71624ac87 I would push the patch with oneliner rule but there were objection in past for such behaviour. It was recommended to to use only in "critical" situation bef

[SSSD] [PATCH] LDAP: Fix Dereference after NULL check

2016-08-08 Thread Lukas Slebodnik
ehlo, attached is a oneliner for bug introduced in dc30c60f166ad9adc63a47a1013508a71624ac87 I would push the patch with oneliner rule but there were objection in past for such behaviour. It was recommended to to use only in "critical" situation before release. LS >From 48b71bb0b1012f5e1830b8ec35