[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (synchronize)

2016-09-01 Thread fidencio
fidencio's pull request #11: "SECRETS: Don't remove a container when it has children" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/11 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/11/head:pr11 git check

[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (edited)

2016-09-01 Thread fidencio
fidencio's pull request #11: "SECRETS: Don't remove a container when it has children" was edited See the full pull-request at https://github.com/SSSD/sssd/pull/11 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/11/head:pr11 git checkout p

[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (edited)

2016-09-01 Thread fidencio
fidencio's pull request #11: "SECRETS: Don't remove a container when it has children" was edited See the full pull-request at https://github.com/SSSD/sssd/pull/11 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/11/head:pr11 git checkout p

[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (synchronize)

2016-09-01 Thread fidencio
fidencio's pull request #11: "SECRETS: Don't remove a container when it has children" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/11 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/11/head:pr11 git check

[SSSD] Re: [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

2016-09-01 Thread Fabiano Fidêncio
On Thu, Sep 1, 2016 at 6:02 PM, Lukas Slebodnik wrote: > On (01/09/16 17:22), Fabiano Fidêncio wrote: >>On Thu, Sep 1, 2016 at 5:12 PM, Lukas Slebodnik wrote: >>> On (30/08/16 17:07), Lukas Slebodnik wrote: On (30/08/16 16:59), Fabiano Fidêncio wrote: >Lukaš, > >On Tue, Aug 30, 20

[SSSD] Re: [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 17:22), Fabiano Fidêncio wrote: >On Thu, Sep 1, 2016 at 5:12 PM, Lukas Slebodnik wrote: >> On (30/08/16 17:07), Lukas Slebodnik wrote: >>>On (30/08/16 16:59), Fabiano Fidêncio wrote: Lukaš, On Tue, Aug 30, 2016 at 4:54 PM, Lukas Slebodnik wrote: > ehlo, > >>

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

2016-09-01 Thread lslebodn
lslebodn commented on a pull request """ On (01/09/16 08:35), fidencio wrote: >On Thu, Sep 1, 2016 at 2:10 PM, lslebodn wrote: > >> On (01/09/16 04:32), Jakub Hrozek wrote: >> >On Thu, Sep 01, 2016 at 03:21:06AM -0700, fidencio wrote: >> >> On Thu, Sep 1, 2016 at 11:54 AM, lslebodn >> wrote: >>

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Michal Židek
On 09/01/2016 05:26 PM, Dmitri Pal wrote: Hello, I do not like either of the versions of the patch. It is OK to use path_concat instead of snprintf. The whole point of not using it was to simplify the code and not have to check yet another error clause. But using path_concat is fine. The thing t

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Dmitri Pal
Hello, I do not like either of the versions of the patch. It is OK to use path_concat instead of snprintf. The whole point of not using it was to simplify the code and not have to check yet another error clause. But using path_concat is fine. The thing that I do not like is that in the current cod

[SSSD] Re: [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

2016-09-01 Thread Fabiano Fidêncio
On Thu, Sep 1, 2016 at 5:12 PM, Lukas Slebodnik wrote: > On (30/08/16 17:07), Lukas Slebodnik wrote: >>On (30/08/16 16:59), Fabiano Fidêncio wrote: >>>Lukaš, >>> >>>On Tue, Aug 30, 2016 at 4:54 PM, Lukas Slebodnik wrote: ehlo, Clang static analyzer assume that ldb_search can found

[SSSD] Re: [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

2016-09-01 Thread Lukas Slebodnik
On (30/08/16 17:07), Lukas Slebodnik wrote: >On (30/08/16 16:59), Fabiano Fidêncio wrote: >>Lukaš, >> >>On Tue, Aug 30, 2016 at 4:54 PM, Lukas Slebodnik wrote: >>> ehlo, >>> >>> Clang static analyzer assume that ldb_search can found >>> 0 entries in the tree "cn=sysdb". Thenvariable version >>> co

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Michal Židek
On 09/01/2016 02:32 PM, Lukas Slebodnik wrote: On (01/09/16 14:28), Michal Židek wrote: On 09/01/2016 02:13 PM, Lukas Slebodnik wrote: On (01/09/16 13:15), Michal Židek wrote: Hi, see the attached ding-libs patch for ticket #3166. This is how sssctl config-check prints the merging issues wit

[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (synchronize)

2016-09-01 Thread fidencio
fidencio's pull request #11: "SECRETS: Don't remove a container when it has children" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/11 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/11/head:pr11 git check

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-01 Thread Justin Stephenson
On 08/30/2016 03:54 AM, Jakub Hrozek wrote: On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote: Hello, The attached patches resolve https://fedorahosted.org/sssd/ticket/3142 However, I am having difficult with the man page addition to 'src/man/sssd.conf.5.xml' for this new optio

[SSSD] Re: [RFC] Cleaning up the IFP responder (mainly) and socket-activatable responders

2016-09-01 Thread Stephen Gallagher
On 08/31/2016 01:40 PM, Fabiano Fidêncio wrote: > Howdy! > > Taking a look on https://fedorahosted.org/sssd/ticket/2395 seems that > there are a few ways to achieve what's proposed by Simo and I'd like > to discuss one of those before start implementing it. > > As far as I understand the bug, SSS

[SSSD] Re: [PATCH] Create pidfile after responders have started

2016-09-01 Thread Lukas Slebodnik
On (26/08/16 13:16), Victor Tapia wrote: >Hi, > >Sorry for the late response, I've been out for nearly two weeks. I'm >attaching a new version of the patch to review. > >> Does upstart/init script need to be updated as well? >> We have some generic in src/sysv/sssd.in > >Upstart does need to keep t

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 14:28), Michal Židek wrote: >On 09/01/2016 02:13 PM, Lukas Slebodnik wrote: >> On (01/09/16 13:15), Michal Židek wrote: >> > Hi, >> > >> > see the attached ding-libs patch for ticket #3166. >> > >> > This is how sssctl config-check prints the merging >> > issues without this patch: >

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Michal Židek
On 09/01/2016 02:13 PM, Lukas Slebodnik wrote: On (01/09/16 13:15), Michal Židek wrote: Hi, see the attached ding-libs patch for ticket #3166. This is how sssctl config-check prints the merging issues without this patch: Messages generated during configuration merging: 2 File blaa did not mat

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 13:15), Michal Židek wrote: >Hi, > >see the attached ding-libs patch for ticket #3166. > >This is how sssctl config-check prints the merging >issues without this patch: > >Messages generated during configuration merging: 2 >File blaa did not match provided patterns. Skipping. >File /et

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ * master: 0d1d9d8001232f74eca63cbba6c400d507b33823 """ See the full comment at https://github.com/SSSD/sssd/pull/9#issuecomment-244058945 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://list

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (closed)

2016-09-01 Thread jhrozek
celestian's pull request #9: "SYSDB: Removing of unused parametr" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/9 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/9/head:pr9 git checkout pr9 _

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (+pushed)

2016-09-01 Thread jhrozek
celestian's pull request #9: "SYSDB: Removing of unused parametr" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/9 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org

[SSSD] [sssd PR#7] Fix initgroups with nested groups (+pushed)

2016-09-01 Thread jhrozek
sumit-bose's pull request #7: "Fix initgroups with nested groups" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/7 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (+pushed)

2016-09-01 Thread jhrozek
jhrozek's pull request #8: "MAN: Document the ldap_user_gid_number option" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/8 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorah

[SSSD] [sssd PR#7] Fix initgroups with nested groups (closed)

2016-09-01 Thread jhrozek
sumit-bose's pull request #7: "Fix initgroups with nested groups" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/7 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/7/head:pr7 git checkout pr7 _

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ * master: 5bd3bef4a655fdfacd2f5df8a2343fe7bc68a771 """ See the full comment at https://github.com/SSSD/sssd/pull/7#issuecomment-244058146 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://list

[SSSD] [PATCH] failover: proceed normally when no new server is found

2016-09-01 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/3131 I couldn't reproduce manually so I used the second patch as a by-code reproducer. If you apply the patch then sssd will try to resolve meta server twice simultaneously and triggering the problematic code path. You can search for RESOLV SRV DONE in logs

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ * master: 6f59bb822d1e54e178207be45e382f4ee173c434 """ See the full comment at https://github.com/SSSD/sssd/pull/8#issuecomment-244054299 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://list

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (closed)

2016-09-01 Thread jhrozek
jhrozek's pull request #8: "MAN: Document the ldap_user_gid_number option" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/8 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/8/head:pr8 git checkout pr8 ___

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ On Wed, Aug 31, 2016 at 07:15:10AM -0700, lslebodn wrote: > On (31/08/16 01:47), sumit-bose wrote: > >On Wed, Aug 31, 2016 at 01:30:12AM -0700, Jakub Hrozek wrote: > >> On Wed, Aug 31, 2016 at 12:36:37AM -0700, sumit-bose wrote: > >> > On Tue, Aug 30, 2016 a

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ CI: http://sssd-ci.duckdns.org/logs/job/52/87/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/8#issuecomment-244052362 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org http

[SSSD] [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Michal Židek
Hi, see the attached ding-libs patch for ticket #3166. This is how sssctl config-check prints the merging issues without this patch: Messages generated during configuration merging: 2 File blaa did not match provided patterns. Skipping. File /etc/sssd/conf.d/blaa.conf did not pass access check.

[SSSD] Re: RFC: github PR workflow

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 12:29), Jakub Hrozek wrote: >On Thu, Sep 01, 2016 at 12:10:15PM +0200, Lukas Slebodnik wrote: >> On (01/09/16 10:30), Jakub Hrozek wrote: >> >On Thu, Sep 01, 2016 at 09:49:50AM +0200, Petr Cech wrote: >> >> On 08/31/2016 10:28 AM, Jakub Hrozek wrote: >> >> > Hi, >> >> > >> >> > I docu

[SSSD] Re: [PATCH] DEBUG: Apend line feed to messages from libsemanage

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 08:23), Fabiano Fidêncio wrote: >On Thu, Sep 1, 2016 at 8:16 AM, Lukas Slebodnik wrote: >> ehlo, >> >> @see >> (Wed Aug 31 14:12:18 2016) [[sssd[selinux_child[7088 [libsemanage] >> (0x0020): could not query record value(Wed Aug 31 14:12:18 2016) >> [[sssd[selinux_child[7088

[SSSD] Re: RFC: github PR workflow

2016-09-01 Thread Jakub Hrozek
On Thu, Sep 01, 2016 at 12:10:15PM +0200, Lukas Slebodnik wrote: > On (01/09/16 10:30), Jakub Hrozek wrote: > >On Thu, Sep 01, 2016 at 09:49:50AM +0200, Petr Cech wrote: > >> On 08/31/2016 10:28 AM, Jakub Hrozek wrote: > >> > Hi, > >> > > >> > I documented workflow that we could use for submitting

[SSSD] Re: RFC: github PR workflow

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 10:30), Jakub Hrozek wrote: >On Thu, Sep 01, 2016 at 09:49:50AM +0200, Petr Cech wrote: >> On 08/31/2016 10:28 AM, Jakub Hrozek wrote: >> > Hi, >> > >> > I documented workflow that we could use for submitting PRs: >> > https://fedorahosted.org/sssd/wiki/GithubWorkflow >> > >> > I

[SSSD] Re: [RFC] Cleaning up the IFP responder (mainly) and socket-activatable responders

2016-09-01 Thread Pavel Březina
On 08/31/2016 10:16 PM, Jakub Hrozek wrote: On Wed, Aug 31, 2016 at 07:40:32PM +0200, Fabiano Fidêncio wrote: Howdy! Taking a look on https://fedorahosted.org/sssd/ticket/2395 seems that there are a few ways to achieve what's proposed by Simo and I'd like to discuss one of those before start im

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (edited)

2016-09-01 Thread fidencio
fidencio's pull request #10: "UTIL: Remove support to libini older than 1.0.0" was edited See the full pull-request at https://github.com/SSSD/sssd/pull/10 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/10/head:pr10 git checkout pr10 ___

[SSSD] Re: [PATCH] GPO: Cat vals with same key from different GPOs

2016-09-01 Thread Alexander Bokovoy
On Thu, 01 Sep 2016, Michal Židek wrote: On 09/01/2016 10:31 AM, Jakub Hrozek wrote: On Thu, Sep 01, 2016 at 09:56:33AM +0200, Michal Židek wrote: On 08/31/2016 07:49 PM, Stephen Gallagher wrote: On 08/31/2016 01:24 PM, Simo Sorce wrote: On Wed, 2016-08-31 at 17:41 +0200, Michal Židek wrote:

[SSSD] Re: [PATCH] GPO: Cat vals with same key from different GPOs

2016-09-01 Thread Michal Židek
On 09/01/2016 10:31 AM, Jakub Hrozek wrote: On Thu, Sep 01, 2016 at 09:56:33AM +0200, Michal Židek wrote: On 08/31/2016 07:49 PM, Stephen Gallagher wrote: On 08/31/2016 01:24 PM, Simo Sorce wrote: On Wed, 2016-08-31 at 17:41 +0200, Michal Židek wrote: Hi, here is patch for ticket #3161. See

[SSSD] Re: [PATCH] GPO: Cat vals with same key from different GPOs

2016-09-01 Thread Jakub Hrozek
On Thu, Sep 01, 2016 at 09:56:33AM +0200, Michal Židek wrote: > On 08/31/2016 07:49 PM, Stephen Gallagher wrote: > > On 08/31/2016 01:24 PM, Simo Sorce wrote: > > > On Wed, 2016-08-31 at 17:41 +0200, Michal Židek wrote: > > > > Hi, > > > > > > > > here is patch for ticket #3161. > > > > > > > > S

[SSSD] Re: RFC: github PR workflow

2016-09-01 Thread Jakub Hrozek
On Thu, Sep 01, 2016 at 09:49:50AM +0200, Petr Cech wrote: > On 08/31/2016 10:28 AM, Jakub Hrozek wrote: > > Hi, > > > > I documented workflow that we could use for submitting PRs: > > https://fedorahosted.org/sssd/wiki/GithubWorkflow > > > > It's quite similar to what the FreeIPA team uses (

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (synchronize)

2016-09-01 Thread fidencio
fidencio's pull request #10: "UTIL: Remove support to libini older than 1.0.0" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/10 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/10/head:pr10 git checkout pr1

[SSSD] Re: [PATCH] GPO: Cat vals with same key from different GPOs

2016-09-01 Thread Michal Židek
On 08/31/2016 07:49 PM, Stephen Gallagher wrote: On 08/31/2016 01:24 PM, Simo Sorce wrote: On Wed, 2016-08-31 at 17:41 +0200, Michal Židek wrote: Hi, here is patch for ticket #3161. See more in the ticket description. I was thinking why we originally replaced the lists and I think it comes f

[SSSD] Re: RFC: github PR workflow

2016-09-01 Thread Petr Cech
On 08/31/2016 10:28 AM, Jakub Hrozek wrote: Hi, I documented workflow that we could use for submitting PRs: https://fedorahosted.org/sssd/wiki/GithubWorkflow It's quite similar to what the FreeIPA team uses (although I don't think they publicly document it yet). Comments or edits welcome.