[SSSD] Re: [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

On Wed, Sep 7, 2016 at 8:34 AM, Lukas Slebodnik wrote: > On (06/09/16 21:38), Fabiano Fidêncio wrote: >>On Tue, Sep 6, 2016 at 8:49 PM, lslebodn >> wrote: >>> lslebodn commented on a pull request >>> >>> """ >>> IMHO, it might be better to close this PR. >>> If we decide to dor support for libini_

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

On (05/09/16 15:35), Petr Cech wrote: >On 09/05/2016 03:32 PM, Lukas Slebodnik wrote: >> On (05/09/16 15:24), Jakub Hrozek wrote: >> > On Mon, Sep 05, 2016 at 02:31:31PM +0200, Fabiano Fidêncio wrote: >> > > On Mon, Sep 5, 2016 at 11:59 AM, Fabiano Fidêncio >> > > wrote: >> > > > Petr, >> > > >

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

On (05/09/16 16:07), Jakub Hrozek wrote: >On Mon, Sep 05, 2016 at 03:32:48PM +0200, Lukas Slebodnik wrote: >> On (05/09/16 15:24), Jakub Hrozek wrote: >> >On Mon, Sep 05, 2016 at 02:31:31PM +0200, Fabiano Fidêncio wrote: >> >> On Mon, Sep 5, 2016 at 11:59 AM, Fabiano Fidêncio >> >> wrote: >> >> >

[SSSD] Re: [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

On (06/09/16 21:38), Fabiano Fidêncio wrote: >On Tue, Sep 6, 2016 at 8:49 PM, lslebodn > wrote: >> lslebodn commented on a pull request >> >> """ >> IMHO, it might be better to close this PR. >> If we decide to dor support for libini_config < 1.1 or 1.2 >> then it will be a different patch anyway.

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

On 09/06/2016 01:18 PM, Petr Cech wrote: On 09/06/2016 01:15 PM, Petr Cech wrote: On 09/05/2016 02:31 PM, Fabiano Fidêncio wrote: On Mon, Sep 5, 2016 at 11:59 AM, Fabiano Fidêncio wrote: Petr, I went through your patches and in general they look good to me. However, I haven't done any test

[SSSD] Re: [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

On Tue, Sep 6, 2016 at 8:49 PM, lslebodn wrote: > lslebodn commented on a pull request > > """ > IMHO, it might be better to close this PR. > If we decide to dor support for libini_config < 1.1 or 1.2 > then it will be a different patch anyway. @see my previous comment > """ Please, take a look o

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

lslebodn commented on a pull request """ IMHO, it might be better to close this PR. If we decide to dor support for libini_config < 1.1 or 1.2 then it will be a different patch anyway. @see my previous comment """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-24505079

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (comment)

lslebodn commented on a pull request """ On (06/09/16 10:25), mzidek-rh wrote: >This PR includes some fixes for local provider. Namely jhrozek's patch for >sss_groupadd and fix for sss_groupshow. I will add more fixes (sss_usermod >etc.) in another PR tomorrow. > Try to run pep8 src/tests/intg/t

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (comment)

mzidek-rh commented on a pull request """ This PR includes some fixes for local provider. Namely jhrozek's patch for sss_groupadd and fix for sss_groupshow. I will add more fixes (sss_usermod etc.) in another PR tomorrow. """ See the full comment at https://github.com/SSSD/sssd/pull/16#issueco

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (synchronize)

mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/16 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/16/head:pr16 git checkout pr16 From 0bcb9c

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 09/06/2016 05:11 PM, Justin Stephenson wrote: On 09/06/2016 10:57 AM, Petr Cech wrote: On 09/06/2016 04:17 PM, Justin Stephenson wrote: On 09/05/2016 10:20 AM, Petr Cech wrote: On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote: Petr, On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech wrote: On 09

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 09/06/2016 10:57 AM, Petr Cech wrote: On 09/06/2016 04:17 PM, Justin Stephenson wrote: On 09/05/2016 10:20 AM, Petr Cech wrote: On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote: Petr, On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech wrote: On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote: Petr,

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 09/06/2016 04:17 PM, Justin Stephenson wrote: On 09/05/2016 10:20 AM, Petr Cech wrote: On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote: Petr, On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech wrote: On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote: Petr, I see you have updated the OPT_MAX_CHILD

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 09/05/2016 10:20 AM, Petr Cech wrote: On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote: Petr, On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech wrote: On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote: Petr, I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of 50. However, you have

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

On 09/05/2016 10:23 AM, Lukas Slebodnik wrote: On (05/09/16 15:54), Petr Cech wrote: On 09/05/2016 09:45 AM, Lukas Slebodnik wrote: On (02/09/16 15:34), Petr Cech wrote: On 09/02/2016 03:31 PM, Justin Stephenson wrote: On 09/02/2016 05:23 AM, Petr Cech wrote: On 09/01/2016 03:36 PM, Just

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (+deferred)

fidencio's pull request #10: "UTIL: Remove support to libini older than 1.0.0" label *deferred* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/10 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

jhrozek commented on a pull request """ good idea """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-244944667 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-deve

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (-ack)

jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *ack* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahos

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (+nack)

mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" label *nack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/16 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (+nack)

jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *nack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahost

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

sumit-bose commented on a pull request """ On Tue, Sep 06, 2016 at 04:51:26AM -0700, Jakub Hrozek wrote: > Thanks for the ack, I would also like to ask @sumit-bose if he agrees with > the change. Since we already handle other clock skew related error codes the same way I think it is ok. But I wo

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

sumit-bose commented on a pull request """ On Tue, Sep 06, 2016 at 05:37:14AM -0700, Pavel Březina wrote: > On 09/06/2016 02:21 PM, Jakub Hrozek wrote: > > On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > > > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > > > Thanks for the ack,

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (comment)

lslebodn commented on a pull request """ On (06/09/16 05:40), mzidek-rh wrote: >sss_groupshow used shortname to search >in sysdb database. We have to u e sysdb_fqname >(aka internal_fqname) format for all sysdb >oprations. > >Resolves: >https://fedorahosted.org/sssd/ticket/3175 I miss an integrati

[SSSD] Re: [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

On Tue, Sep 6, 2016 at 2:30 PM, jhrozek wrote: > jhrozek commented on a pull request > > """ > On Tue, Sep 06, 2016 at 05:16:00AM -0700, fidencio wrote: >> The distributions that would break with this patch are: >> - RHEL/CentOS 5 and older > > I don't think we care about RHEL-5 with master and I'

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (opened)

mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was opened PR body: """ sss_groupshow used shortname to search in sysdb database. We have to u e sysdb_fqname (aka internal_fqname) format for all sysdb oprations. Resolves: https://fedorahosted.org/sssd/ticket/3175 """ See the fu

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

lslebodn commented on a pull request """ On (06/09/16 05:16), fidencio wrote: >The distributions that would break with this patch are: >- RHEL/CentOS 5 and older >- Debian Wheezy (from 2013) and older >- Ubuntu 12.04 LTS and older > >I was not able to find what's the version of the package on SLES

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

pbrezina commented on a pull request """ On 09/06/2016 02:21 PM, Jakub Hrozek wrote: > On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > > Thanks for the ack, I would also like to ask @sumit-bose > > >

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 05:16:00AM -0700, fidencio wrote: > The distributions that would break with this patch are: > - RHEL/CentOS 5 and older I don't think we care about RHEL-5 with master and I'm not sure sssd master even builds there. > - Debian Wheezy

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > Thanks for the ack, I would also like to ask @sumit-bose > > if he agrees with the change. > > Btw since clock s

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

fidencio commented on a pull request """ The distributions that would break with this patch are: - RHEL/CentOS 5 and older - Debian Wheezy (from 2013) and older - Ubuntu 12.04 LTS and older I was not able to find what's the version of the package on SLES """ See the full comment at https://gith

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

pbrezina commented on a pull request """ On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > Thanks for the ack, I would also like to ask @sumit-bose > if he agrees with the change. Btw since clock skew is not fatal anymore, is it possible for us to actually perform onl

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

jhrozek commented on a pull request """ On Fri, Sep 02, 2016 at 08:37:07AM -0700, celestian wrote: > I wrote the conditions in fully way for clarity. Yes, it is possible to write > it in condensed way. > > My question in note is about which type of our CI I can use. It is in > memberof plugin.

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (+nack)

celestian's pull request #13: "MEMBEROF: Don't resolve members if they are removed" label *nack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/13 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

jhrozek commented on a pull request """ On Thu, Sep 01, 2016 at 09:01:54AM -0700, lslebodn wrote: > On (01/09/16 08:35), fidencio wrote: > >On Thu, Sep 1, 2016 at 2:10 PM, lslebodn wrote: > > > >> On (01/09/16 04:32), Jakub Hrozek wrote: > >> >On Thu, Sep 01, 2016 at 03:21:06AM -0700, fidencio wr

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

lslebodn commented on a pull request """ On (06/09/16 04:57), Jakub Hrozek wrote: >On Tue, Sep 06, 2016 at 04:54:29AM -0700, lslebodn wrote: >> On (06/09/16 03:14), Jakub Hrozek wrote: >> >The log said: >> >(Tue Sep 6 15:18:31:935105 2016) [sss_groupadd] >> >[sysdb_timestamp_cache_connect] (0x04

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 04:54:29AM -0700, lslebodn wrote: > On (06/09/16 03:14), Jakub Hrozek wrote: > >The log said: > >(Tue Sep 6 15:18:31:935105 2016) [sss_groupadd] > >[sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL > >(Tue Sep

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (+nack)

jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *nack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list sssd-devel@lists.fedorah

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

lslebodn commented on a pull request """ On (06/09/16 03:14), Jakub Hrozek wrote: >The log said: >(Tue Sep 6 15:18:31:935105 2016) [sss_groupadd] >[sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL >(Tue Sep 6 15:18:31:935255 2016) [sss_groupadd] [sss_names_init_from_args]

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

jhrozek commented on a pull request """ Thanks for the ack, I would also like to ask @sumit-bose if he agrees with the change. """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-244927163 ___ sssd-devel mailing list sssd-dev

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (+ack)

jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *ack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahoste

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

On 09/06/2016 01:15 PM, Petr Cech wrote: On 09/05/2016 02:31 PM, Fabiano Fidêncio wrote: On Mon, Sep 5, 2016 at 11:59 AM, Fabiano Fidêncio wrote: Petr, I went through your patches and in general they look good to me. However, I haven't done any tests yet with your patches (and I'll do it af

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

mzidek-rh commented on a pull request """ I see the error with the sss_groupshow. Will send patch in another PR. """ See the full comment at https://github.com/SSSD/sssd/pull/14#issuecomment-244920668 ___ sssd-devel mailing list sssd-devel@lists.fedora

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

On 09/05/2016 02:31 PM, Fabiano Fidêncio wrote: On Mon, Sep 5, 2016 at 11:59 AM, Fabiano Fidêncio wrote: Petr, I went through your patches and in general they look good to me. However, I haven't done any tests yet with your patches (and I'll do it after lunch). I've done some tests and I've

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

mzidek-rh commented on a pull request """ The patch works. I pushed it to CI, waiting for results. As I tested the local provider now, I found that the sss_groupshow does not seem to work. Will check why. But it is not related to this patch. """ See the full comment at https://github.com/SSSD/

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (+ack)

jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *ack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list sssd-devel@lists.fedoraho

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

fidencio commented on a pull request """ Patch works as expected but I wasn't able to run CI tests on it* due to some connection issue to the CI machine. *: Well, I ran it locally and it passed. Please, if possible, run the CI as feel free to push as soon as it passes. """ See the full commen

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (opened)

jhrozek's pull request #15: "Avoid returning System Error on clock skew" was opened PR body: """ Rather return ERR_NETWORK_IO and at least let the user authenticate offline. """ See the full pull-request at https://github.com/SSSD/sssd/pull/15 ... or pull the PR as Git branch: git remote add ghs

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (synchronize)

jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/14 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (opened)

jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" was opened PR body: """ The log said: (Tue Sep 6 15:18:31:935105 2016) [sss_groupadd] [sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL (Tue Sep 6 15:18:31:935255 201