URL: https://github.com/SSSD/sssd/pull/78
Title: #78: ipa: Nested netgroups do not work
celestian commented:
"""
Code LGTM.
CI passed: http://sssd-ci.duckdns.org/logs/job/56/99/summary.html
And I tested it manually:
```
Setup FreeIPA server and do the following:
1. create two netgroups - ng1, n
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
sumit-bose commented:
"""
Sorry, this issue was introduced by a assume simple last minute change which I
didn't test properly. I couldn't decide if I want to keep the options i
URL: https://github.com/SSSD/sssd/pull/69
Author: sumit-bose
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/69/head:pr69
git checkout pr69
F
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented:
"""
Change done. Here is the fix up patch that in order to help the reviewer:
```
[ffidenci@cat sssd]$ git diff HEAD
diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh
index 9a7098c..387
URL: https://github.com/SSSD/sssd/pull/79
Author: fidencio
Title: #79: LIBSSS_CONFIG: Drop libsss_config
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/79/head:pr79
git checkout pr79
From 78b6c96d1766d136dc5f56d5a39fe
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
lslebodn commented:
"""
On (10/11/16 13:38), Jakub Hrozek wrote:
>Since there is no ticket, I only pushed the patches to master:
>682c9c3467055c2149af28826f7458b857b0f8c4
>da8801c363716533f
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
lslebodn commented:
"""
You forgot to rebuve build dependencies from spec file
and from ci.deps
contrib/ci/deps.sh:libaugeas-dev
contrib/sssd.spec.in:BuildRequires: augeas-devel
LS
"""
See the ful
URL: https://github.com/SSSD/sssd/pull/78
Title: #78: ipa: Nested netgroups do not work
jhrozek commented:
"""
btw just to help with the review, I also fired up a test job using our
downstream tests with a 7.3 package and this test. I'll let you know how the
test went.
"""
See the full commen
