URL: https://github.com/SSSD/sssd/pull/75
Title: #75: Add configuirable max payload size limit of a secret
jhrozek commented:
"""
ACK, I'll push when CI finishes
"""
See the full comment at
https://github.com/SSSD/sssd/pull/75#issuecomment-262710494
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
jhrozek commented:
"""
(CI pending)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/39#issuecomment-262709772
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
jhrozek commented:
"""
ack, this version works for me
"""
See the full comment at
https://github.com/SSSD/sssd/pull/39#issuecomment-262709744
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
celestian commented:
"""
Squashed version pushed.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/39#issuecomment-262694326
URL: https://github.com/SSSD/sssd/pull/39
Author: celestian
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/39/head:pr39
git checkout pr39
From
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
lslebodn commented:
"""
On (23/11/16 08:07), celestian wrote:
>I pushed new version. The patch is the same plus I added back-ported patch
>from #80 (with cerry-pick tag).
>
NACK to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
celestian commented:
"""
I pushed new version. The patch is the same plus I added back-ported patch from
#80 (with cerry-pick tag).
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/39
Author: celestian
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/39/head:pr39
git checkout pr39
From
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
Testing went fine, but there is a "declared 'static' but never defined" issue.
If this patch can be push with
diff --git
URL: https://github.com/SSSD/sssd/pull/75
Author: fidencio
Title: #75: Add configuirable max payload size limit of a secret
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/75/head:pr75
git checkout pr75
From
URL: https://github.com/SSSD/sssd/pull/75
Title: #75: Add configuirable max payload size limit of a secret
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/75
Title: #75: Add configuirable max payload size limit of a secret
fidencio commented:
"""
New version pushed.
```
[ffidenci@cat x86_64]$ git diff
diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c
index a9cf74d..ed70193 100644
URL: https://github.com/SSSD/sssd/pull/75
Author: fidencio
Title: #75: Add configuirable max payload size limit of a secret
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/75/head:pr75
git checkout pr75
From
URL: https://github.com/SSSD/sssd/pull/75
Title: #75: Add configuirable max payload size limit of a secret
jhrozek commented:
"""
Apart from the nitpick, I don't have any other comments. Unless someone else
has, I can even squash the nitpick and just push the patches, -- just let me
know.
"""
URL: https://github.com/SSSD/sssd/pull/75
Title: #75: Add configuirable max payload size limit of a secret
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/85
Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn()
celestian commented:
"""
Reproducer:
We need AD domain and it's AD subdomain.
If we type in SSSD box connected to AD domain:
```
id Administrator@
```
it resolves between Administrator@ and
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
jhrozek commented:
"""
regardless of what we choose, the patch for PR #80 does not apply atop this
patch, can we have a version that applies to the 1.13 branch, please?
"""
See the
URL: https://github.com/SSSD/sssd/pull/85
Author: celestian
Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn()
Action: opened
PR body:
"""
Currently in order to match multiple LDAP search results we
use two different functions - we have sysdb_try_to_find_expected_dn()
but also
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
lslebodn commented:
"""
On (23/11/16 06:19), celestian wrote:
>Thanks for CR.
>After pushing it is important to cherry pick #80 as well.
>
I do not agree. The ticket #3241 was a
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
jhrozek commented:
"""
For some reason the downstream tests are stuck and time out, even with
known-good packages. I will keep trying but for downstream's sake I'm going to
push the
URL: https://github.com/SSSD/sssd/pull/79
Author: fidencio
Title: #79: BUILD: Drop libsss_config
Action: edited
Changed field: title
Original value:
"""
LIBSSS_CONFIG: Drop libsss_config
"""
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented:
"""
Suggestion taken and changes done, thanks for the review!
I've just pushed a new version of the patch.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/79
Author: fidencio
Title: #79: LIBSSS_CONFIG: Drop libsss_config
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/79/head:pr79
git checkout pr79
From
URL: https://github.com/SSSD/sssd/pull/66
Title: #66: Minor Dynamic DNS fixes
jhrozek commented:
"""
On Wed, Nov 23, 2016 at 06:05:10AM -0800, lslebodn wrote:
> @jhrozek Do you pan to review the patch?
Feel free to take over the review, I'm currently busy with other work.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
I'm fine with the patch as well. Shall I re-run the test with the original
reproducer or did you already run it?
"""
See the full
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13)
celestian commented:
"""
Thanks for CR.
After pushing it is important to cherry pick #80 as well.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/66
Title: #66: Minor Dynamic DNS fixes
lslebodn commented:
"""
@jhrozek Do you pan to review the patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/66#issuecomment-262520613
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
lslebodn commented:
"""
I asked Florian on IRC and he is fine with the last version.
@sumit-bose do you have other comments; can we push it?
"""
See the full
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
lslebodn commented:
"""
There is a tiny conflict due to change in `src/external/configlib.m4`
There is also typo in commit message `lib_config` and IMHO it might be
better to use "BUILD"
as a component
On Thu, Nov 17, 2016 at 12:23:24PM +0100, Jakub Hrozek wrote:
> Hi,
>
> as we're planning what exactly are we going to work on in the next release
> and also preparing to move away from fedorahosted, I think it makes sense
> to clean up our Trac. The intent is to make our trac better searchable
>
URL: https://github.com/SSSD/sssd/pull/83
Title: #83: TESTS: Check new line at end of file
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/83
Author: lslebodn
Title: #83: TESTS: Check new line at end of file
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/83/head:pr83
git checkout pr83
URL: https://github.com/SSSD/sssd/pull/83
Title: #83: TESTS: Check new line at end of file
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/83
Title: #83: TESTS: Check new line at end of file
lslebodn commented:
"""
On (22/11/16 08:16), Nikolai Kondrashov wrote:
>Looks good to me!
>
* 900778b5afd0143005cfd40cc67ad5086481f7ee
LS
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/80
Title: #80: SYSDB: Fixing of sudorule without a sudoUser
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/80
Title: #80: SYSDB: Fixing of sudorule without a sudoUser
lslebodn commented:
"""
master:
* 7e23edbaa7a6bbd0b461d5792535896b6a77928b
sssd-1-14:
* 54f176066dafafdc12f6e0dd112ff6339308aa7c
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/80
Author: celestian
Title: #80: SYSDB: Fixing of sudorule without a sudoUser
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/80/head:pr80
git checkout pr80
45 matches
Mail list logo
