[SSSD] Re: Design document - SSSD's files provider

2016-11-28 Thread Pavel Březina
On 11/21/2016 04:17 PM, Jakub Hrozek wrote: Hi, I realized I never sent a design document about the files provider to the sssd-devel list - I'm sorry about that. Nonetheless, I discussed the design with Stephen quite some time ago, so hopefully it's not completely wrong. LGTM _

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2016-11-28 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ So, I will rewrite tests for sysdb_try_to_find_expected_dn() to suitable form for sdap_object_in_domain(). """ See the full comment at https://github.com/SSSD/sssd

[SSSD] [sssd PR#85][+Changes requested] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2016-11-28 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] Re: Design document - Socket-activatable responders

2016-11-28 Thread Jakub Hrozek
On Thu, Nov 24, 2016 at 02:33:04PM +0100, Fabiano Fidêncio wrote: > The design page is done [0] and it's based on this discussion [1] we > had on this very same mailing list. A pull-request with the > implementation is already opened [2]. > > [0]: https://fedorahosted.org/sssd/wiki/DesignDocs/Sock

[SSSD] Re: Design document - Socket-activatable responders

2016-11-28 Thread Pavel Březina
On 11/28/2016 10:47 AM, Jakub Hrozek wrote: On Thu, Nov 24, 2016 at 02:33:04PM +0100, Fabiano Fidêncio wrote: The design page is done [0] and it's based on this discussion [1] we had on this very same mailing list. A pull-request with the implementation is already opened [2]. [0]: https://fedor

[SSSD] Re: Design document - Socket-activatable responders

2016-11-28 Thread Jakub Hrozek
On Mon, Nov 28, 2016 at 10:57:44AM +0100, Pavel Březina wrote: > On 11/28/2016 10:47 AM, Jakub Hrozek wrote: > > On Thu, Nov 24, 2016 at 02:33:04PM +0100, Fabiano Fidêncio wrote: > > > The design page is done [0] and it's based on this discussion [1] we > > > had on this very same mailing list. A p

[SSSD] [sssd PR#69][synchronized] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/69 Author: sumit-bose Title: #69: krb5: Use command line arguments instead env vars for krb5_child Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/69/head:pr69 git checkout pr69 F

[SSSD] [sssd PR#69][-Changes requested] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] Re: Design discussion: Fleet Commander integration

2016-11-28 Thread Oliver Gutiérrez
Hi everybody, As I started to design nd develop the changes needed in Fleet Commander, and after a meeting with Alberto Ruiz about the things we need, in the FreeIPA side of the things it is all Ok. The only thing that should be added is the ability to select what is the priority in the deskto

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child sumit-bose commented: """ Hi Lukas, thank you for the review, I added my replies to your comments. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/6

[SSSD] [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys

2016-11-28 Thread celestian
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys celestian commented: """ Code LGTM. CI: http://sssd-ci.duckdns.org/logs/job/57/87/summary.html There is a failure on test ```test_sanity_rfc2307``` -- I think it is not connected to

[SSSD] [sssd PR#93][+Accepted] SSH: Use default_domain_suffix for users' authorized keys

2016-11-28 Thread celestian
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-11-28 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders pbrezina commented: """ Ok, I read those commits and I so far have none code issues. Haven't tried it yet. """ See the full comment at https://github.com/SSSD/sssd/pull/94#issuecomment-2632653

[SSSD] [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys

2016-11-28 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys pbrezina commented: """ On 11/24/2016 06:10 PM, Jakub Hrozek wrote: > > > > You can view, comment on, o

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child lslebodn commented: """ On (28/11/16 03:07), sumit-bose wrote: >Hi Lukas, > >thank you for the review, I added my replies to your comments. > ACK LS """ See the full comment

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child lslebodn commented: """ I fixed few coding style issues. I hope you don't mind. master: * 167b05b28d6b969230973646bee2f1c1f49205d2 * f78b2dd73d26988068306cc22a504fd0e069d6cc *

[SSSD] [sssd PR#69][+Pushed] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@list

[SSSD] [sssd PR#69][closed] krb5: Use command line arguments instead env vars for krb5_child

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Author: sumit-bose Title: #69: krb5: Use command line arguments instead env vars for krb5_child Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/69/head:pr69 git checkout pr69 ___

[SSSD] [sssd PR#96][opened] CONFDB: Supress clang false passitive warnings

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/96 Author: lslebodn Title: #96: CONFDB: Supress clang false passitive warnings Action: opened PR body: """ The errno is macro expandee into '(*__errno_location ())'. The reason is that errno is private in glibc and and the function __errno_location return

[SSSD] [sssd PR#96][comment] CONFDB: Supress clang false passitive warnings

2016-11-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/96 Title: #96: CONFDB: Supress clang false passitive warnings fidencio commented: """ Once you're already touching this part of the code, would you mind to use a explicit check? "(ret != 0)" instead of just "(ret)" ... """ See the full comment at https:/

[SSSD] [sssd PR#96][synchronized] CONFDB: Supress clang false passitive warnings

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/96 Author: lslebodn Title: #96: CONFDB: Supress clang false passitive warnings Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/96/head:pr96 git checkout pr96 From f1b15071018099b1

[SSSD] [sssd PR#96][comment] CONFDB: Supress clang false passitive warnings

2016-11-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/96 Title: #96: CONFDB: Supress clang false passitive warnings lslebodn commented: """ On (28/11/16 06:42), fidencio wrote: >Once you're already touching this part of the code, would you mind to use a >explicit check? "(ret != 0)" instead of just "(ret)" ..

[SSSD] [sssd PR#94][synchronized] Enable {socket,dbus}-activation for responders

2016-11-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Author: fidencio Title: #94: Enable {socket,dbus}-activation for responders Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/94/head:pr94 git checkout pr94 From c596fdd46471b161

[SSSD] [sssd PR#96][comment] CONFDB: Supress clang false passitive warnings

2016-11-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/96 Title: #96: CONFDB: Supress clang false passitive warnings fidencio commented: """ Acked-by: Fabiano Fidêncio """ See the full comment at https://github.com/SSSD/sssd/pull/96#issuecomment-263411367 ___ sssd-

[SSSD] [sssd PR#96][+Accepted] CONFDB: Supress clang false passitive warnings

2016-11-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/96 Title: #96: CONFDB: Supress clang false passitive warnings Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o